Great, glad to hear it.

This was caused by a change of the default tasklist driver from kolab to database, which I have now reverted. Package build is still pending.

I believe this is resolved with the roundcubemail update from today, please reopen if you can still reproduce the issue.

Just seen your comment, let's just try no cache then.

I don't have any data, but I suspect generating the timezone information every time is relatively costly (looks like a lot of stuff is happening), so no caching at all might be problematic.
Caching the potentially changing information, and making sure we pick the right version of timezoneinformation without making caching useless (by caching each dtstart version) seems relatively involved.
Perhaps we can just not provide timezone information with non-recurring events though (outlook seems to do that when creating new events).

another lint issue

lint and trans changes

Addressed comments

Looks reasonable, with some comments on the comments.

Some more input validation

Addressed comments

Only check the required dependencies for now

lint

After trying various approaches I've settled on using the cache to propagate the values.
I suppose the javascript approach would also be doable, but it seems more complex to me.

Moved to api/v4/fs/

Updated commented test with comment why we can't currently test this.

Changing the config in browser tests doesn't work because we're testing code served via octane...
Soo, not sure how to test this.

Removed the toast check because this passes now

As discussed. I fail to test disabling the support form currently (no idea why), but it seems to work fine in practice.

In D4229#50861, @machniak wrote:

I fixed SignupTest in master, WalletTest works for me. Mollie payment tests fail because of https://github.com/mollie/mollie-api-php/issues/649 and I'm not sure what to do about it.

As for the diff... How about we make the support page to look like https://kolabnow.com/support, but hide the right-side box if app.support_email is not set? If you're a company that installs Kolab for your employees only, you still might find this support channel useful. That means that we'd have to set this option to something (like john@kolab.org for config.dev) to keep the test.

I could extract the original test and put it into the kolabnow deployment config if we wanted that.

Fixup

Don't change the string we send to the client
Log to syslog

Only print the status code and reason

Fixup

Deduplication during upload for files, fixed updating parents

Reopen if this still is a problem please.

Rebased on master

Addressed comments

FWIW: Not using auto-increment on the pivot table fs_relations (I think that's the name in laravel?) IMO makes no sense. The only reason there is an id it all is because laravel needs it. Logically it should be a composite primary key from the two foreign keys.

Updated description

The api will require a bit of a cleanup in that I'm currently using /items/ but some existing code still uses /files/. I thought about using /fs/ instead.
Should I standardize everything on /fs/ ?

Cleanup

Throwing an exception now to be a bit more explicit than then crash when trying to access null

Fixed tests that we broke.

With support page

A bit less in your face

In D4169#50126, @machniak wrote:

Modification of the default theme.json will break some browser tests. We e.g. assert that /support page and faq entries work.

Addressed comments

In D4151#49970, @machniak wrote:

Makes sense, but please note that it will require some configuration when we deploy this change (as the default is 'local').

Fixed lint issues (the remaining ones only appear in arc lint)

I'll look into the lint problems.

I suppose some of this is just required because of php8.

Not entirely sure if there is a valid case where we end up passing a domain package, but not a domain to assignPlan. I ran into this at some point, but maybe I'll have to reproduce first.

The tests require some adjustment, that's currently in a separate commit (I can fix that before pushing).

Looks good to me, with some minor comments