Made uri's configurable, some cleanup, centralized test account setup and cleanup.

I have pushed iRony 0.4.7 to Kolab:16. Don't know about the shortlogins, the code seems to still work in my tests, but I don't have an actual system that supports shortlogins that I could test against thunderbird.

Is this still a thing? Because I can't reproduce the issue.

more fixes

Test cleanup to work with test users.

Include the roundcube test and fixed some lint issues

Requires https://git.kolab.org/D3986

In T7097#99230, @machniak wrote:

I think the username canonification is done by kolab_auth plugin. So, maybe some problem with loading plugins/configuration.

The iRony patch is now available in https://obs.kolabsys.com/package/show/Kolab:16:Testing/iRony

I haven't really looked into the shortlogin issue yet, but at least for individual requests authenticated requests worked for me.
AFAIR the feature uses the username_domain roundcube config option to complete the login name if there is no domain part.

Thanks for the info.

According to tcpdump -s 0 -A 'tcp dst port 80' I'm indeed getting unauthenticated PROPFIND requests, but that can't work IMO, so I'm not sure what's going on.
If anybody could confirm that they also see unauthenticated requests, and confirm what they are seeing with the old iRony, that could help.

I'm trying to reproduce the thunderbird issue:

In T7097#98258, @sicherha wrote:

(Sorry about my tone in yesterday's last-night comment; I was a tad frustrated. I'd like to do what I can to help fix this as quickly as possible.)

In T7097#98246, @sicherha wrote:

It looks like the workaround (logging into iRony with the full email address) works fine with DAVx5 (on Android) but doesn't work with Kontact or Thunderbird.

Sigh... I was originally hoping to use my holiday to get Debian 11 support up & running, but there are too many fires to put out right now.

This is really not good and will break things. Please always raise the version number.

Indeed. Rule #1 for packagers: whenever the contents of a package change, bump its release number.
In my day job we use aptly, which refuses to accept an identically named .deb file with different contents, but I'm not aware that OBS supports that kind of check.

It's possible that we face additional incompatibilities, we have unfortunately rather poor test-coverage on these components.
But we do need the update to get to php8 support eventually.

I have now included the vobject compatibility fix and I'm not planning on downgrading the sabre dependencies again.
The updated iRony package is currently in Kolab:16:Testing, but I'm still fighting an obs issue that seems to somehow pull in the libkolabxml 1.3.0 update into Debian_10...

Just for clarification:

• On Debian 10 and Ubuntu 18.04 the php-kolabformat 1.3.0 update should indeed not be available
• With the 1.3.0 update the kolabformat.php file is expected to no longer exist, as it is not required by php and no longer generated in more recent swig variants.
• Kolab is not currently php 8 compatible (though we are working towards it).

I was now able to verify that that this work.

Hide the table entry and legend

String based uuid, fixed test

Fixed unittest

Fixed lint issues

deduplicate sql queries, router reload

Cleanup of a bunch of accidentally added changes

Addressed the comments

Now with tests.

Cleanup

Fixed linting issues

Cleaned up .env files & follow symbolic links in configure.sh

Stripping all the secrets will require some additional setup-procedure to generate them, so I'm not going to do that in this patch. The situation has not actually gotten worse because I just concatenated src/env.example and ansible/env.local into ansible/env.

In D3902#47162, @mollekopf wrote:

In D3902#47042, @machniak wrote:

Specifically the problem might be with src/database/migrations/2022_05_13_090000_permissions_and_room_subscriptions.php. It probably should check if the SKUs already exist and not try to add them again if so. There's another problem with this migration file. It is not self-contained, i.e. it does not remove 'meet' SKU in up(), but does add it in down().

In D3902#47042, @machniak wrote:

This migration thing is a mess and will be problematic in the future. I however have no better idea. We'll have to be very careful in the future. And this makes managing Kolab4 installation (and updates), if you are not Apheleia IT, very difficult.

fwiw, the same could be done for the admin/reseller domain if we wanted to.

This should resolve the following modification:

line length

Backwards compatibility

Adjusted tests to pass again

Call IMAP::verifyAccount from the create job

Addressed 2 out of 3 comments

Deployment configs as a filesystem overlay

Optional IMAP backend, pass tests with imap backend disabled, fixed IMAP::verifyAccount.

I suppose Handler::created could be used to spawn a job, not sure if it is a good solution or not.

The abuse check now lives externally. As a generic mechanism vanmeeuwen suggested that we may be able to install an app/Handler/Abuse.php just like we do for app/Handler/Mailbox.php, and that this might provide a suitable generic hook to run an abuse-check background job.

Cleanup

Removed production seeder

Fixed production seeder