Page MenuHomekolab.org

mollekopf (Christian Mollekopf)
User

User Details

User Since
Apr 12 2015, 12:47 PM (301 w, 6 d)

Recent Activity

Yesterday

mollekopf updated the diff for D2143: Remove folder typedata in-memory cache.

Removed the in-memory cache instead.

Fri, Jan 22, 3:08 PM · Roundcube Kolab Plugins
mollekopf updated the diff for D2155: Allow clearing the in-memory typedata cache.

New name

Fri, Jan 22, 1:44 PM
mollekopf added a comment to D2143: Remove folder typedata in-memory cache.

How about we call self::folders_typedata($prefix); to populate the cache, but then user folder_type() anyways to fetch missing entries (it still uses the cache if available)?

I don't like it for performance reasons, because if we know the folder has no type then why would you bother with a METADATA request? This would create many redundant requests when listing mail folders. And I'm not sure it would solve your issue.

Fri, Jan 22, 1:33 PM · Roundcube Kolab Plugins
mollekopf added reviewers for D2155: Allow clearing the in-memory typedata cache: Roundcube Kolab Plugins Developers, machniak.
Fri, Jan 22, 1:31 PM
mollekopf requested review of D2155: Allow clearing the in-memory typedata cache.
Fri, Jan 22, 1:19 PM

Thu, Jan 21

mollekopf added a comment to D2143: Remove folder typedata in-memory cache.

With this change METADATA for every folder will be asked separately. This definitely will have performance implications. Maybe a better approach would be to add a method to reset kolab_storage::$typedata (and other cache-like data if needed). And call that method from syncroton's kolab_sync::sleep() or kolab_sync_backend_folder::hasHierarchyChanges().

Thu, Jan 21, 11:46 AM · Roundcube Kolab Plugins
mollekopf added a reviewer for D2143: Remove folder typedata in-memory cache: Roundcube Kolab Plugins Developers.
Thu, Jan 21, 11:00 AM · Roundcube Kolab Plugins
mollekopf added a project to D2143: Remove folder typedata in-memory cache: Roundcube Kolab Plugins .
Thu, Jan 21, 11:00 AM · Roundcube Kolab Plugins
mollekopf added a comment to D2143: Remove folder typedata in-memory cache.

See https://bifrost.kolabsystems.com/T408794 for context. I verified that the RC UI continues to function (especially activesync and folder config),
so it doesn't brake anything, and that the Ping works better for https://bifrost.kolabsystems.com/T408794

Thu, Jan 21, 10:58 AM · Roundcube Kolab Plugins
mollekopf added a reviewer for D2143: Remove folder typedata in-memory cache: machniak.
Thu, Jan 21, 10:50 AM · Roundcube Kolab Plugins
mollekopf requested review of D2143: Remove folder typedata in-memory cache.
Thu, Jan 21, 10:48 AM · Roundcube Kolab Plugins

Tue, Jan 19

mollekopf committed rS62590b9d0dc8: Fixed warning (authored by mollekopf).
Fixed warning
Tue, Jan 19, 5:41 PM
mollekopf planned changes to D2131: Avoid Sync unnecessary FolderSync interaction.
Tue, Jan 19, 4:20 PM
mollekopf updated the diff for D2131: Avoid Sync unnecessary FolderSync interaction.

Removed comment that no longer applies

Tue, Jan 19, 3:11 PM
mollekopf updated the diff for D2131: Avoid Sync unnecessary FolderSync interaction.

The previous patch was inclomplete as it built on another one, this is the full version.

Tue, Jan 19, 3:08 PM
mollekopf committed rSfde06e11c535: Compress pendingdata (authored by mollekopf).
Compress pendingdata
Tue, Jan 19, 1:41 PM
mollekopf closed D2062: Compress pendingdata.
Tue, Jan 19, 1:41 PM
mollekopf committed rS5463154459b9: Bump collectionChanges even if we failed to retrieve the entry. (authored by mollekopf).
Bump collectionChanges even if we failed to retrieve the entry.
Tue, Jan 19, 1:41 PM
mollekopf closed D2056: Bump collectionChanges even if we failed to retrieve the entry..
Tue, Jan 19, 1:41 PM
mollekopf abandoned D2128: A synckey that is not matching the server sync key is invalid..
Tue, Jan 19, 1:36 PM
mollekopf committed rRPKd4c00a9555d0: Do not ignore INBOX for the displayed folder hierarchy (authored by mollekopf).
Do not ignore INBOX for the displayed folder hierarchy
Tue, Jan 19, 12:29 PM
mollekopf closed D2092: Do not ignore INBOX for the displayed folder hierarchy.
Tue, Jan 19, 12:29 PM
mollekopf added reviewers for D2131: Avoid Sync unnecessary FolderSync interaction: Syncroton Developers, machniak.
Tue, Jan 19, 10:21 AM
mollekopf added reviewers for D2128: A synckey that is not matching the server sync key is invalid.: Syncroton Developers, machniak.
Tue, Jan 19, 10:20 AM
mollekopf requested review of D2131: Avoid Sync unnecessary FolderSync interaction.
Tue, Jan 19, 10:19 AM
mollekopf requested review of D2128: A synckey that is not matching the server sync key is invalid..
Tue, Jan 19, 10:18 AM

Mon, Jan 18

mollekopf added a comment to D2092: Do not ignore INBOX for the displayed folder hierarchy.

FWIW, I assume the original code meant to make the case prettier where all folders are below inbox. I think for the affected UI's it shouldn't be a big deal, and avoids the confusing situation we can have right now.

Mon, Jan 18, 2:30 PM
mollekopf updated the diff for D2092: Do not ignore INBOX for the displayed folder hierarchy.

Instead of not showing a tree at all, show it for INBOX as well.

Mon, Jan 18, 2:28 PM
mollekopf committed rCaacc7c613626: Pass on a language identifier even if we couldn't find a translation file (authored by mollekopf).
Pass on a language identifier even if we couldn't find a translation file
Mon, Jan 18, 1:59 PM
mollekopf closed D2122: Pass on a language identifier even if we couldn't find a translation file.
Mon, Jan 18, 1:59 PM
mollekopf committed rC527d914fac6d: log_error doesn't exist, use raise_error (authored by mollekopf).
log_error doesn't exist, use raise_error
Mon, Jan 18, 1:59 PM
mollekopf closed D955: log_error doesn't exist, use raise_error.
Mon, Jan 18, 1:59 PM
mollekopf updated the diff for D2122: Pass on a language identifier even if we couldn't find a translation file.

Addressed comments

Mon, Jan 18, 1:28 PM
mollekopf added reviewers for D2122: Pass on a language identifier even if we couldn't find a translation file: Chwala Developers, machniak.
Mon, Jan 18, 1:08 PM
mollekopf requested review of D2122: Pass on a language identifier even if we couldn't find a translation file.
Mon, Jan 18, 1:07 PM

Thu, Jan 14

mollekopf committed rKd756114692cb: OPENVIDU_PUBLICURL doesn't seem to do anything (authored by mollekopf).
OPENVIDU_PUBLICURL doesn't seem to do anything
Thu, Jan 14, 1:03 PM

Wed, Jan 13

mollekopf added reviewers for D2092: Do not ignore INBOX for the displayed folder hierarchy: Roundcube, machniak.

FWIW, this code was just like this from the beginning, so I don't know if there ever was a valid usecase for it.
Can't think of one though.

Wed, Jan 13, 7:08 PM
mollekopf requested review of D2092: Do not ignore INBOX for the displayed folder hierarchy.
Wed, Jan 13, 7:05 PM
mollekopf committed rKf3c31df4fc5c: Set MIX_ASSET_PATH (authored by mollekopf).
Set MIX_ASSET_PATH
Wed, Jan 13, 4:07 PM
mollekopf committed rKa10c2102a1e2: Renamed the override file to not build the development container by default (authored by mollekopf).
Renamed the override file to not build the development container by default
Wed, Jan 13, 3:00 PM
mollekopf committed rK2a8c5669d091: Only write .env if it doesn't already exist (authored by mollekopf).
Only write .env if it doesn't already exist
Wed, Jan 13, 1:47 PM
mollekopf committed rK47bd99e43742: Use a docker-compose.override.yml instead (authored by mollekopf).
Use a docker-compose.override.yml instead
Wed, Jan 13, 1:47 PM
mollekopf committed rK876bdfaa68ca: Set the server port (authored by mollekopf).
Set the server port
Wed, Jan 13, 1:47 PM
mollekopf committed rK4135c5c1ff9f: Configure a second KMS instance (authored by mollekopf).
Configure a second KMS instance
Wed, Jan 13, 1:47 PM
mollekopf committed rK8384a4584f9e: Assign beta and meet skus during init (authored by mollekopf).
Assign beta and meet skus during init
Wed, Jan 13, 1:47 PM
mollekopf committed rK890c051b9360: Build openvidu from source on the host (authored by mollekopf).
Build openvidu from source on the host
Wed, Jan 13, 1:47 PM
mollekopf committed rKb529ae9e6c6d: Docker compose setup enhancements: (authored by mollekopf).
Docker compose setup enhancements:
Wed, Jan 13, 1:47 PM
mollekopf committed rK5e99fe406be3: Use a docker-compose.override.yml instead (authored by mollekopf).
Use a docker-compose.override.yml instead
Wed, Jan 13, 12:06 PM
mollekopf committed rK33e9e209aa91: Set the server port (authored by mollekopf).
Set the server port
Wed, Jan 13, 12:06 PM
mollekopf updated the diff for D2080: Support for multiple KMS instances with selection by current load.

Fixed build

Wed, Jan 13, 11:47 AM
mollekopf committed rK28844fbdc748: Configure a second KMS instance (authored by mollekopf).
Configure a second KMS instance
Wed, Jan 13, 10:38 AM
mollekopf committed rK377475292e71: Assign beta and meet skus during init (authored by mollekopf).
Assign beta and meet skus during init
Wed, Jan 13, 10:38 AM
mollekopf committed rKac1b892d0874: Build openvidu from source on the host (authored by mollekopf).
Build openvidu from source on the host
Wed, Jan 13, 10:38 AM
mollekopf committed rK641fa7fd639a: Docker compose setup enhancements: (authored by mollekopf).
Docker compose setup enhancements:
Wed, Jan 13, 10:38 AM
mollekopf committed rK59515e8bee82: Reconfigure stun server (authored by Jeroen van Meeuwen <vanmeeuwen@apheleia-it.ch>).
Reconfigure stun server
Wed, Jan 13, 10:37 AM
mollekopf committed rK2b535ad7a797: Allow IP address substitution (authored by Jeroen van Meeuwen <vanmeeuwen@apheleia-it.ch>).
Allow IP address substitution
Wed, Jan 13, 10:37 AM
mollekopf committed rK6c58f5ea730e: Try to seed Kurento with the configured public ip address (authored by vanmeeuwen).
Try to seed Kurento with the configured public ip address
Wed, Jan 13, 10:37 AM
mollekopf committed rKd695e7c1cb52: Add a STUN server (authored by vanmeeuwen).
Add a STUN server
Wed, Jan 13, 10:37 AM
mollekopf committed rKb754f7534586: Exclude libsoup from the cleaning action (authored by Jeroen van Meeuwen <vanmeeuwen@apheleia-it.ch>).
Exclude libsoup from the cleaning action
Wed, Jan 13, 10:37 AM
mollekopf committed rK9ff4fe2ccce6: Update docker-compose.yml (authored by Jeroen van Meeuwen <vanmeeuwen@apheleia-it.ch>).
Update docker-compose.yml
Wed, Jan 13, 10:37 AM
mollekopf committed rK80a3a1cbd337: Another iteration (authored by Jeroen van Meeuwen <vanmeeuwen@apheleia-it.ch>).
Another iteration
Wed, Jan 13, 10:37 AM
mollekopf committed rK5b1082dbd5ec: Correct install dir (authored by Jeroen van Meeuwen <vanmeeuwen@apheleia-it.ch>).
Correct install dir
Wed, Jan 13, 10:37 AM
mollekopf committed rK7ae1239bb47b: Change install directory for web rtc kms core gst plugins (authored by Jeroen van Meeuwen <vanmeeuwen@apheleia-it.ch>).
Change install directory for web rtc kms core gst plugins
Wed, Jan 13, 10:37 AM
mollekopf committed rKa1478b1fcd33: Include libnice (authored by Jeroen van Meeuwen <vanmeeuwen@apheleia-it.ch>).
Include libnice
Wed, Jan 13, 10:37 AM
mollekopf committed rKa67607fdcb0b: From our own repository (authored by vanmeeuwen).
From our own repository
Wed, Jan 13, 10:37 AM
mollekopf committed rK39f964a970c5: Re-enable shell and recompiling (authored by vanmeeuwen).
Re-enable shell and recompiling
Wed, Jan 13, 10:37 AM
mollekopf committed rKff7a03c04c47: Clean out after building (authored by Jeroen van Meeuwen <vanmeeuwen@apheleia-it.ch>).
Clean out after building
Wed, Jan 13, 10:37 AM
mollekopf committed rK2f59d236bf57: With dtls (authored by Jeroen van Meeuwen <vanmeeuwen@apheleia-it.ch>).
With dtls
Wed, Jan 13, 10:37 AM
mollekopf committed rKdeb5b988868a: Fix submodules again (authored by vanmeeuwen).
Fix submodules again
Wed, Jan 13, 10:37 AM
mollekopf committed rK4ebb0f316df3: Edit git modules (authored by vanmeeuwen).
Edit git modules
Wed, Jan 13, 10:37 AM
mollekopf committed rKc45ab2674630: This actually builds locally with the kurento version of base gstreamer (authored by vanmeeuwen).
This actually builds locally with the kurento version of base gstreamer
Wed, Jan 13, 10:37 AM
mollekopf committed rKf2d5f954f37d: openni is not available on ppc64le? (authored by vanmeeuwen).
openni is not available on ppc64le?
Wed, Jan 13, 10:37 AM
mollekopf committed rK9de73d9da006: Try this! (authored by vanmeeuwen).
Try this!
Wed, Jan 13, 10:37 AM
mollekopf committed rK6452d532c6e2: Another tweak and run it without the removing of tooling (authored by vanmeeuwen).
Another tweak and run it without the removing of tooling
Wed, Jan 13, 10:37 AM
mollekopf committed rK1e1019bfda46: Another attempt (authored by vanmeeuwen).
Another attempt
Wed, Jan 13, 10:37 AM
mollekopf committed rK81aa6f0bcf29: Install redis (authored by vanmeeuwen).
Install redis
Wed, Jan 13, 10:37 AM
mollekopf added a comment to D2080: Support for multiple KMS instances with selection by current load.

For the branch I would propose we base ourselves on the v2.16.0 tag

Wed, Jan 13, 9:54 AM
mollekopf added reviewers for D2080: Support for multiple KMS instances with selection by current load: vanmeeuwen, machniak.
  • no longer fails if some kms is initially unreachable
  • allowMoreElements is now taken into account
Wed, Jan 13, 9:52 AM
mollekopf updated the diff for D2080: Support for multiple KMS instances with selection by current load.

Added copyright

Wed, Jan 13, 9:50 AM

Tue, Jan 12

mollekopf requested review of D2080: Support for multiple KMS instances with selection by current load.
Tue, Jan 12, 8:28 PM
mollekopf added a comment to D2056: Bump collectionChanges even if we failed to retrieve the entry..

Also, maybe we should tackle this from a different angle. If the folder has been disabled why do we even attempt to sync anything from that folder. We should tell the client that a hierarchy changed. So, maybe the problem is somewhere else, and could be fixed in a better way. We of course can still keep this solution as it prevents from timeout issues caused by other factors.

Tue, Jan 12, 9:33 AM

Mon, Jan 11

mollekopf requested review of D2074: Ignore notfound folders..
Mon, Jan 11, 6:00 PM
mollekopf added inline comments to D2056: Bump collectionChanges even if we failed to retrieve the entry..
Mon, Jan 11, 3:18 PM
mollekopf updated the diff for D2056: Bump collectionChanges even if we failed to retrieve the entry..

Addressed comment

Mon, Jan 11, 3:17 PM
mollekopf added a comment to D2062: Compress pendingdata.

Good points.

Mon, Jan 11, 2:53 PM

Thu, Jan 7

mollekopf added a comment to D2062: Compress pendingdata.

Tested with up to 200k messages (it failed with 50k before).

Thu, Jan 7, 4:28 PM
mollekopf added reviewers for D2062: Compress pendingdata: Syncroton Developers, machniak.
Thu, Jan 7, 4:26 PM
mollekopf requested review of D2062: Compress pendingdata.
Thu, Jan 7, 4:21 PM
mollekopf added reviewers for D2056: Bump collectionChanges even if we failed to retrieve the entry.: Syncroton Developers, machniak.
Thu, Jan 7, 3:26 PM
mollekopf requested review of D2056: Bump collectionChanges even if we failed to retrieve the entry..
Thu, Jan 7, 3:23 PM

Wed, Jan 6

mollekopf committed rS9d0d281ba230: Symlinks necessary to run this in a live environment (authored by mollekopf).
Symlinks necessary to run this in a live environment
Wed, Jan 6, 2:41 PM

Wed, Dec 30

mollekopf updated the diff for D2026: Check if swoole is installed in quickstart.sh.

Only check if the module is available so we don't depend on pecl

Wed, Dec 30, 3:40 PM
mollekopf updated subscribers of D2026: Check if swoole is installed in quickstart.sh.
Wed, Dec 30, 10:43 AM
mollekopf added a reviewer for D2026: Check if swoole is installed in quickstart.sh: Restricted Project.
Wed, Dec 30, 10:42 AM
mollekopf requested review of D2026: Check if swoole is installed in quickstart.sh.
Wed, Dec 30, 10:41 AM

Dec 21 2020

mollekopf requested review of D1978: Allow unauthenticated OPTIONS requests.
Dec 21 2020, 2:33 PM
mollekopf committed rS30426cadf1d2: Bumped version to 2.3.18 (authored by mollekopf).
Bumped version to 2.3.18
Dec 21 2020, 2:01 PM
mollekopf committed rS2cebe30e3acc: Added a warning if we detect a folder hierarchy change. (authored by mollekopf).
Added a warning if we detect a folder hierarchy change.
Dec 21 2020, 2:01 PM

Dec 15 2020

mollekopf committed rP6788cb9f9489: Bump version number to 0.8.19 (authored by mollekopf).
Bump version number to 0.8.19
Dec 15 2020, 10:37 AM
mollekopf committed rP32deba147137: An initial version of the Plesk auth driver (authored by vanmeeuwen).
An initial version of the Plesk auth driver
Dec 15 2020, 10:37 AM