Page MenuHomekolab.org

machniak (Aleksander Machniak)
Kolab Systems, Developer

Projects (30)

User Details

User Since
Apr 12 2015, 12:47 PM (322 w, 3 d)

Recent Activity

Today

machniak requested review of D2605: Add slow requests log.
Wed, Jun 16, 2:55 PM
machniak requested review of D2599: Improve themes, add some scss vars, add missing localization for the default theme.
Wed, Jun 16, 1:19 PM

Yesterday

machniak updated the diff for D2554: Add PGP keys generator.
  • Generate a keypair for new alias
  • Unregister keys on alias delete
Tue, Jun 15, 1:52 PM

Sat, Jun 12

machniak updated the diff for D2593: Update to Openvidu-browser 2.18.
  • Disable jsnlog's error handlers added in OpenVidu 2.18
Sat, Jun 12, 8:19 AM

Fri, Jun 11

machniak requested review of D2593: Update to Openvidu-browser 2.18.
Fri, Jun 11, 2:12 PM

Thu, Jun 10

machniak requested review of D2587: Improve wallet() methods accuracy.
Thu, Jun 10, 3:04 PM
machniak updated the diff for D2581: UI localization.
  • Add test for localization in getWalletNotice()
Thu, Jun 10, 10:54 AM

Wed, Jun 9

machniak requested review of D2581: UI localization.
Wed, Jun 9, 2:34 PM

Tue, Jun 8

machniak committed rRPK5a94fd8bc6e6: 2FA: Add missing login_lc config handling (authored by machniak).
2FA: Add missing login_lc config handling
Tue, Jun 8, 10:38 AM

Fri, Jun 4

machniak requested review of D2572: Resellers - all changes.
Fri, Jun 4, 3:03 PM
machniak committed rKfad0f675055c: Fix phpstan errors (authored by machniak).
Fix phpstan errors
Fri, Jun 4, 2:08 PM
machniak committed rK5925612aafcb: Fix tests regressions (authored by machniak).
Fix tests regressions
Fri, Jun 4, 1:55 PM
machniak committed rKf336df8e9d45: Merge branch 'master' into dev/reseller (authored by machniak).
Merge branch 'master' into dev/reseller
Fri, Jun 4, 1:55 PM
machniak closed D2452: Tenant scope for CLI commands.

Merged into dev/reseller.

Fri, Jun 4, 12:32 PM
machniak committed rK6aa312a4a5db: Tenant scope for CLI commands (authored by machniak).
Tenant scope for CLI commands
Fri, Jun 4, 12:31 PM
machniak committed rK5d98fbe82027: Require PHP>=7.3 and Guzzle Http Client (authored by machniak).
Require PHP>=7.3 and Guzzle Http Client
Fri, Jun 4, 12:26 PM

Tue, Jun 1

machniak retitled D2452: Tenant scope for CLI commands from [WIP] Tenant scope for CLI commands to Tenant scope for CLI commands.
Tue, Jun 1, 3:26 PM
machniak updated the diff for D2452: Tenant scope for CLI commands.
  • Simplify again
Tue, Jun 1, 3:26 PM
machniak updated the diff for D2452: Tenant scope for CLI commands.
  • Simplify/Unify
Tue, Jun 1, 2:06 PM
machniak updated the diff for D2452: Tenant scope for CLI commands.
  • Couple of fixes, tenant-condition for wallets
Tue, Jun 1, 12:41 PM
machniak committed rK021a0daf6855: Merge branch 'master' into dev/reseller (authored by machniak).
Merge branch 'master' into dev/reseller
Tue, Jun 1, 12:06 PM
machniak committed rKacf48440adde: UI localization (partial) (authored by machniak).
UI localization (partial)
Tue, Jun 1, 12:01 PM
machniak closed D2518: UI localization (partial).
Tue, Jun 1, 12:01 PM
machniak committed rKa0069a7d5489: Introduce a unified mechanism for permissions checking in the UI (authored by machniak).
Introduce a unified mechanism for permissions checking in the UI
Tue, Jun 1, 12:01 PM
machniak closed D2524: Introduce a unified mechanism for permissions checking in the UI.
Tue, Jun 1, 12:01 PM
machniak committed rKb6cc7fc764ca: [Reseller] Wallet page (authored by machniak).
[Reseller] Wallet page
Tue, Jun 1, 11:58 AM
machniak committed rK788c62c51e82: Add tenant() method to Domain, Group and Discount (authored by machniak).
Add tenant() method to Domain, Group and Discount
Tue, Jun 1, 11:02 AM

Thu, May 27

machniak committed rK35036d332a8f: Fix memory issue in wallet:charge command (authored by machniak).
Fix memory issue in wallet:charge command
Thu, May 27, 10:13 AM
machniak closed D2560: Fix memory issue in wallet:charge command.
Thu, May 27, 10:13 AM
machniak committed rKeaac9aa08b9b: Per-tenant domains visibility (authored by machniak).
Per-tenant domains visibility
Thu, May 27, 9:35 AM
machniak added a comment to D2494: Laravel Passport support.

To sum up the current state:

  1. All tests pass!
  2. Tokens refresh request is fast now, but /auth/login is still 0.3-0.4 sec. I didn't investigate how much of that is passport.
  3. We should probably add some code to Kernel as in https://laravel.com/docs/6.x/passport#purging-tokens
  4. @vanmeeuwen, should take a look at this regarding deployment of the oauth keys and client secret (and ./artisan passport:keys --force) - we need the same keys on every Kolab4 host.
Thu, May 27, 9:26 AM
machniak added a comment to D2566: Log sql query execution time.

On the other hand, maybe %dms format would be better for query time.

Thu, May 27, 9:05 AM
machniak accepted D2566: Log sql query execution time.
Thu, May 27, 7:55 AM

Wed, May 26

machniak updated the diff for D2554: Add PGP keys generator.
  • Add exportPublicKey() use
Wed, May 26, 4:13 PM
machniak updated the diff for D2554: Add PGP keys generator.
  • Use Laravel's Storage functionality
Wed, May 26, 3:01 PM

Tue, May 25

machniak updated the diff for D2554: Add PGP keys generator.
  • Switch new keypair algorithms to RSA
Tue, May 25, 1:11 PM
machniak requested review of D2560: Fix memory issue in wallet:charge command.
Tue, May 25, 10:02 AM
machniak requested review of D2554: Add PGP keys generator.
Tue, May 25, 9:26 AM

Fri, May 21

machniak added a comment to D2494: Laravel Passport support.

I did another run of tests and got the same result as above. I.e. I run vendor/bin/phpunit tests/Browser/Admin twice on master and all is green. Then I run the same on this diff and I got three tests failing. Looks like the problem is with refreshing the token. I see this in console dump:

https:\/\/admin.alec.dev.kolab.io\/api\/auth\/info?refresh=1 - Failed to load resource: the server responded with a status of 401 ()

I see C: POST https://admin.alec.dev.kolab.io/api/auth/info?refresh=1 [5M]: 0.0055 sec in the log and this is strange because it's too fast and there are no sql queries for this request logged.

Fri, May 21, 11:19 AM

Thu, May 20

machniak committed rSd734f252b37d: Fix fatal error introduced in the last commit (authored by machniak).
Fix fatal error introduced in the last commit
Thu, May 20, 2:24 PM
machniak committed rS15b11cf6a2df: Fix so Bcc header is not removed from mail stored in Sent folder (authored by machniak).
Fix so Bcc header is not removed from mail stored in Sent folder
Thu, May 20, 2:19 PM
machniak requested changes to D2494: Laravel Passport support.

phpstan errors:

Line   app/Http/Controllers/API/AuthController.php                  
------ ------------------------------------------------------------- 
 157    Access to an undefined property object::$error_description.  
------ -------------------------------------------------------------
Thu, May 20, 12:45 PM
machniak requested review of D2536: [Reseller] Wallet page.
Thu, May 20, 9:48 AM

Wed, May 19

machniak committed rKcf684339a3ca: Merge branch 'master' into dev/reseller (authored by machniak).
Merge branch 'master' into dev/reseller
Wed, May 19, 12:13 PM
machniak requested changes to D2494: Laravel Passport support.
There was 1 error:
Wed, May 19, 10:39 AM

Tue, May 18

machniak abandoned D2377: [WIP] Resellers: Signup with approval.
Tue, May 18, 4:12 PM
machniak abandoned D1453: small layout ui polish for user profile, user info, user list and dashboard.
Tue, May 18, 4:08 PM
machniak closed D2446: Reseller comissioning system.

Merged into dev/reseller

Tue, May 18, 4:06 PM
machniak committed rK2de8edd9f18b: Reseller comissioning system (authored by machniak).
Reseller comissioning system
Tue, May 18, 4:05 PM
machniak requested review of D2530: Per-tenant domains visibility.
Tue, May 18, 1:11 PM

May 14 2021

machniak requested review of D2524: Introduce a unified mechanism for permissions checking in the UI.
May 14 2021, 1:36 PM

May 13 2021

machniak retitled D2446: Reseller comissioning system from [WIP] Reseller comissioning system to Reseller comissioning system.
May 13 2021, 3:33 PM
machniak updated the diff for D2446: Reseller comissioning system.
  • Add tests
  • Debit reseller's wallet on user deletion (for the negative balance value)
  • Credit/debit reseller's wallet on Penalize/Award action
May 13 2021, 3:29 PM

May 12 2021

machniak updated the diff for D2446: Reseller comissioning system.
  • Migration fixes, tests fixes, added some simple tests
May 12 2021, 2:39 PM
machniak retitled D2446: Reseller comissioning system from Reseller comissioning system to [WIP] Reseller comissioning system.
May 12 2021, 11:37 AM

May 11 2021

machniak updated the diff for D2446: Reseller comissioning system.

Rebase

May 11 2021, 3:20 PM
machniak updated the diff for D2446: Reseller comissioning system.

Rebase

May 11 2021, 3:19 PM
machniak requested review of D2518: UI localization (partial).
May 11 2021, 1:31 PM

May 8 2021

machniak committed rK6dfd438618a0: Use @babel/eslint-parser, update eslint, fix some linting issues (authored by machniak).
Use @babel/eslint-parser, update eslint, fix some linting issues
May 8 2021, 11:39 AM

May 7 2021

machniak committed rKf7fb3606a43e: Ignore phpstan error (authored by machniak).
Ignore phpstan error
May 7 2021, 3:39 PM
machniak committed rK36b8497b2f4b: Distlists/Groups vs Resellers (authored by machniak).
Distlists/Groups vs Resellers
May 7 2021, 3:39 PM
machniak committed rK6d58303ab1ac: Fix phpstan errors (authored by machniak).
Fix phpstan errors
May 7 2021, 3:39 PM
machniak committed rK8e4d64aeb1d3: Merge branch 'master' into dev/reseller (authored by machniak).
Merge branch 'master' into dev/reseller
May 7 2021, 3:39 PM
machniak committed rK1f18551de62a: Cleanup phpstan config (authored by machniak).
Cleanup phpstan config
May 7 2021, 1:00 PM
machniak committed rKaddb347dac2a: Move some code from webpack config to the before.php script (authored by machniak).
Move some code from webpack config to the before.php script
May 7 2021, 1:00 PM
machniak committed rKb28c33417f00: Fix test regressions (authored by machniak).
Fix test regressions
May 7 2021, 12:13 PM
machniak committed rK18a7cd7dbd77: Localization with vue-i18n (authored by machniak).
Localization with vue-i18n
May 7 2021, 12:13 PM
machniak closed D2395: Localization with vue-i18n.
May 7 2021, 12:13 PM
machniak committed rKe11caabd056a: [Admin] Distribution lists UI (authored by machniak).
[Admin] Distribution lists UI
May 7 2021, 10:57 AM
machniak closed D2506: [Admin] Distribution lists UI.
May 7 2021, 10:57 AM
machniak committed rK365f9e9602b9: [User] Distribution lists UI (authored by machniak).
[User] Distribution lists UI
May 7 2021, 10:57 AM
machniak closed D2500: [User] Distribution lists UI.
May 7 2021, 10:57 AM
machniak committed rK757939464319: Display existing entitlement cost instead of the SKU cost where appropriate (authored by machniak).
Display existing entitlement cost instead of the SKU cost where appropriate
May 7 2021, 9:53 AM
machniak closed D2512: Display existing entitlement cost instead of the SKU cost where appropriate.
May 7 2021, 9:52 AM
machniak updated subscribers of D2506: [Admin] Distribution lists UI.
May 7 2021, 8:55 AM

May 5 2021

machniak abandoned D2458: Reseller Stats UI.

Merged into dev/reseller.

May 5 2021, 2:24 PM
machniak committed rK5fa8cd3e7be0: Merge branch 'master' into dev/reseller (authored by machniak).
Merge branch 'master' into dev/reseller
May 5 2021, 2:11 PM
machniak committed rK2a5209079916: Reseller Stats UI (authored by machniak).
Reseller Stats UI
May 5 2021, 1:37 PM

May 4 2021

machniak requested changes to D2494: Laravel Passport support.
  1. See inline comments
  2. When logging into the user UI I see this in the log:
[2021-05-04 09:27:08] local.DEBUG: [SQL] select * from `oauth_clients` where `id` = ? limit 1 [array (
  0 => '1',
)]
[2021-05-04 09:27:08] local.DEBUG: [SQL] select * from `oauth_clients` where `id` = ? limit 1 [array (
  0 => '1',
)]

I.e. a duplicated query. Would be good to investigate why it is done twice.

  1. Token refresh does not work. A scenario:
    • set token_expiry_minutes = 1 minute,
    • log in to the UI, and wait a minute,
    • you'll see that the refresh request returns 401 Unauthorized.
    • in log: The resource owner or authorization server denied the request. {"exception":"[object] (League\\OAuth2\\Server\\Exception\\OAuthServerException(code: 9): The resource owner or authorization server denied the request. at /home/alec/repos/kolab/src/vendor/league/oauth2-server/src/Exception/OAuthServerException.php:243).
    • I guess you just have to add refresh_token to the request in line 166 of app.js.
  2. When runing Feature suite tests I got 3 errors:
1) Tests\Feature\Controller\PasswordResetTest::testPasswordResetValidInput
ErrorException: Undefined property: stdClass::$access_token
2) Tests\Feature\Controller\SignupTest::testSignupValidInput
ErrorException: Undefined property: stdClass::$access_token
3) Tests\Feature\Controller\SignupTest::testSignupGroupAccount
ErrorException: Undefined property: stdClass::$access_token
  1. Look like a few browser test failures are also related to Undefined property: stdClass::$access_token.
  2. We should think how deploy encryption keys across multiple hosts.
  3. Could https://github.com/laravel/passport/issues/379 be a problem for us in any way considering our future use of Passport?
May 4 2021, 11:50 AM
machniak requested review of D2512: Display existing entitlement cost instead of the SKU cost where appropriate.
May 4 2021, 10:18 AM

May 3 2021

machniak accepted D2410: rcube_imap_generic.php fixes.
May 3 2021, 10:08 AM

Apr 30 2021

machniak closed D2428: Signup Invitations.

Merged into dev/reseller.

Apr 30 2021, 11:21 AM
machniak committed rKe7a47d5d39d1: Signup Invitations (authored by machniak).
Signup Invitations
Apr 30 2021, 11:20 AM
machniak requested review of D2506: [Admin] Distribution lists UI.
Apr 30 2021, 11:10 AM

Apr 28 2021

machniak added inline comments to D2428: Signup Invitations.
Apr 28 2021, 11:28 AM

Apr 27 2021

machniak added a comment to D2428: Signup Invitations.

@mollekopf Ready for the final review.

Apr 27 2021, 12:45 PM
machniak updated the diff for D2428: Signup Invitations.
  • Add wording for the invitation email
Apr 27 2021, 12:44 PM
machniak planned changes to D2428: Signup Invitations.
Apr 27 2021, 12:35 PM
machniak updated the diff for D2428: Signup Invitations.

Fix

Apr 27 2021, 12:25 PM
machniak updated the diff for D2428: Signup Invitations.
  • Don't process csv if any email address is invalid
  • Cleanup
Apr 27 2021, 12:24 PM
machniak requested changes to D2494: Laravel Passport support.
Apr 27 2021, 10:55 AM
machniak retitled D2395: Localization with vue-i18n from [WIP] Localization with vue-i18n to Localization with vue-i18n.
Apr 27 2021, 9:41 AM

Apr 26 2021

machniak updated the diff for D2395: Localization with vue-i18n.
  • Small css improvements to the page menu
Apr 26 2021, 3:13 PM
machniak updated the diff for D2395: Localization with vue-i18n.
  • Store user language in a cookie, always load English
  • Small code cleanup
  • Update tests
  • Small linting fixes
  • Browser test for the language selector
Apr 26 2021, 2:22 PM
machniak committed rACf559eeb51d71: Fix regression in LDAP authentication (authored by machniak).
Fix regression in LDAP authentication
Apr 26 2021, 10:10 AM

Apr 23 2021

machniak updated the diff for D2395: Localization with vue-i18n.
  • Rebase
  • Improve language selector
  • Store UI localization in php file
  • Remove unused Laravel localization files
Apr 23 2021, 2:46 PM
machniak updated the diff for D2500: [User] Distribution lists UI.

Rebase

Apr 23 2021, 12:30 PM
machniak requested review of D2500: [User] Distribution lists UI.
Apr 23 2021, 12:29 PM
machniak requested changes to D2494: Laravel Passport support.

Just code review. I didn't look closer to this yet.

Apr 23 2021, 9:02 AM

Apr 21 2021

machniak added a comment to D2488: Implode doesn't work for DateTime objects.

I don't like that output format. How did you get to the problem? Maybe you should use Carbon objects instead.

Apr 21 2021, 7:08 PM