Page MenuHomekolab.org

machniak (Aleksander Machniak)
Kolab Systems, Developer

Projects (31)

User Details

User Since
Apr 12 2015, 12:47 PM (273 w, 2 d)

Recent Activity

Thu, Jul 2

machniak committed rK7554fffa9edc: Fix flaky tests and bitwise operator use (authored by machniak).
Fix flaky tests and bitwise operator use
Thu, Jul 2, 12:58 PM

Mon, Jun 29

machniak committed rKc5b4123bf4d9: Update js dependencies (authored by machniak).
Update js dependencies
Mon, Jun 29, 2:33 PM
machniak requested review of D1423: Multiple-themes support.
Mon, Jun 29, 1:35 PM

Fri, Jun 26

machniak committed rKadf3f7419175: Update phpstan/larastan, add tests/Browser/ to phpstan analyze (authored by machniak).
Update phpstan/larastan, add tests/Browser/ to phpstan analyze
Fri, Jun 26, 10:20 AM
machniak committed rK8d1452ae72bb: improve mail notificaions (authored by bohlender).
improve mail notificaions
Fri, Jun 26, 8:38 AM
machniak closed D1414: improve mail notificaions.
Fri, Jun 26, 8:38 AM

Thu, Jun 25

machniak accepted D1414: improve mail notificaions.
Thu, Jun 25, 2:57 PM
machniak requested changes to D1414: improve mail notificaions.
Thu, Jun 25, 10:01 AM
machniak requested changes to D1414: improve mail notificaions.
Thu, Jun 25, 9:38 AM

Wed, Jun 24

machniak committed rK09591aff30dc: Set NOT NULL DEFAULT current_timestamp() on created_at/updated_at columns (authored by machniak).
Set NOT NULL DEFAULT current_timestamp() on created_at/updated_at columns
Wed, Jun 24, 12:15 PM
machniak closed D1408: Set NOT NULL DEFAULT current_timestamp() on created_at/updated_at columns.
Wed, Jun 24, 12:15 PM
machniak committed rKf25d4dfb516b: Aliases sharing (authored by machniak).
Aliases sharing
Wed, Jun 24, 12:15 PM
machniak closed D1402: Aliases sharing.
Wed, Jun 24, 12:15 PM
machniak committed rKc72e9ef38ad9: Added production seeders (authored by machniak).
Added production seeders
Wed, Jun 24, 12:15 PM
machniak closed D1390: Added production seeders.
Wed, Jun 24, 12:14 PM

Mon, Jun 22

machniak updated the diff for D1390: Added production seeders.
  • Update storage cost for production
Mon, Jun 22, 11:02 AM

Fri, Jun 19

machniak committed rK89d61e51f5bc: Fix flaky tests (authored by machniak).
Fix flaky tests
Fri, Jun 19, 1:32 PM
machniak abandoned D1396: Fix created_at/updated_at on user settings added by UserObserver.

Abandoned in favour of https://git.kolab.org/D1408.

Fri, Jun 19, 1:04 PM
machniak requested review of D1408: Set NOT NULL DEFAULT current_timestamp() on created_at/updated_at columns.
Fri, Jun 19, 1:04 PM
machniak updated the diff for D1402: Aliases sharing.
  • Limit alias duplicates to private domains
Fri, Jun 19, 12:14 PM
machniak updated the diff for D1402: Aliases sharing.
  • Additional findByEmail() test
Fri, Jun 19, 11:08 AM
machniak requested review of D1402: Aliases sharing.
Fri, Jun 19, 10:22 AM

Wed, Jun 17

machniak requested review of D1396: Fix created_at/updated_at on user settings added by UserObserver.
Wed, Jun 17, 12:36 PM
machniak requested review of D1390: Added production seeders.
Wed, Jun 17, 11:31 AM

Mon, Jun 15

machniak committed rK01f9fcea44ce: Mobile UI fixes (authored by machniak).
Mobile UI fixes
Mon, Jun 15, 3:19 PM
machniak closed D1384: Mobile UI fixes.
Mon, Jun 15, 3:19 PM
machniak committed rK61b980f766d8: Display a notice about the wallet state (Bifrost#T348752) (authored by machniak).
Display a notice about the wallet state (Bifrost#T348752)
Mon, Jun 15, 3:19 PM
machniak closed D1372: Display a notice about the wallet state (Bifrost#T348752).
Mon, Jun 15, 3:19 PM
machniak committed rKb6a778523891: Add copyright and company details in the page footer (authored by machniak).
Add copyright and company details in the page footer
Mon, Jun 15, 3:19 PM
machniak closed D1378: Add copyright and company details in the page footer.
Mon, Jun 15, 3:19 PM
machniak committed rK037514191beb: Fix transaction description for domain entitlements (authored by machniak).
Fix transaction description for domain entitlements
Mon, Jun 15, 3:19 PM
machniak closed D1366: Fix transaction description for domain entitlements.
Mon, Jun 15, 3:19 PM
machniak committed rKfbf3f75e27ea: Make sure we bill for entitlements that are deleted (authored by machniak).
Make sure we bill for entitlements that are deleted
Mon, Jun 15, 3:19 PM
machniak closed D1297: Make sure we bill for entitlements that are deleted.
Mon, Jun 15, 3:19 PM
machniak updated the diff for D1378: Add copyright and company details in the page footer.
  • Hardcode copyright in the footer
Mon, Jun 15, 3:09 PM
machniak updated the diff for D1384: Mobile UI fixes.
  • Add real favicon.ico
Mon, Jun 15, 2:12 PM
machniak requested review of D1384: Mobile UI fixes.
Mon, Jun 15, 1:03 PM

Sun, Jun 14

machniak committed rK1e03ad3917a9: Bump js dependencies, fix linting issues (authored by machniak).
Bump js dependencies, fix linting issues
Sun, Jun 14, 8:34 AM

Fri, Jun 12

machniak requested review of D1378: Add copyright and company details in the page footer.
Fri, Jun 12, 12:19 PM
machniak updated the diff for D1297: Make sure we bill for entitlements that are deleted.
  • Rollback transactions on exceptions
  • Performance optimization
Fri, Jun 12, 11:01 AM
machniak added a comment to D1051: improve wallet layout.

Partially implemented in https://git.kolab.org/D1372 and we decided to not implement the costs overview table. So, I think this differential could be abandoned.

Fri, Jun 12, 8:59 AM
machniak requested review of D1372: Display a notice about the wallet state (Bifrost#T348752).
Fri, Jun 12, 8:55 AM

Thu, Jun 11

machniak updated the summary of D1366: Fix transaction description for domain entitlements.
Thu, Jun 11, 9:20 AM
machniak requested review of D1366: Fix transaction description for domain entitlements.
Thu, Jun 11, 9:16 AM

Wed, Jun 10

machniak committed rKc4818aadb932: Small css fix (authored by machniak).
Small css fix
Wed, Jun 10, 3:10 PM
machniak committed rK5b736c1c9b50: Fix font-size on small elements (authored by machniak).
Fix font-size on small elements
Wed, Jun 10, 3:10 PM
machniak committed rK5819373d54ff: Improve error handling on signup welcome page (authored by machniak).
Improve error handling on signup welcome page
Wed, Jun 10, 3:10 PM
machniak committed rK98d3e8702b7e: Fix linting issues and a regression in browser tests (authored by machniak).
Fix linting issues and a regression in browser tests
Wed, Jun 10, 12:31 PM
machniak committed rKf4537ed38a96: VAT on Receipts (authored by machniak).
VAT on Receipts
Wed, Jun 10, 11:56 AM
machniak closed D1327: VAT on Receipts.
Wed, Jun 10, 11:56 AM
machniak committed rK92c7f9f21811: Receipts UI (authored by machniak).
Receipts UI
Wed, Jun 10, 11:56 AM
machniak closed D1348: Receipts UI.
Wed, Jun 10, 11:56 AM
machniak updated the diff for D1348: Receipts UI.
  • Fix History tab after rabease
Wed, Jun 10, 11:54 AM
machniak updated the diff for D1348: Receipts UI.
  • Use YYYY-MM format in receipt filename
  • Rebase
Wed, Jun 10, 11:45 AM
machniak committed rK90da82738276: Transaction log in admin UI (authored by machniak).
Transaction log in admin UI
Wed, Jun 10, 11:41 AM
machniak closed D1360: Transaction log in admin UI.
Wed, Jun 10, 11:41 AM
machniak committed rKda13578ce560: Wallet magic (authored by machniak).
Wallet magic
Wed, Jun 10, 11:41 AM
machniak closed D1150: Wallet magic.
Wed, Jun 10, 11:41 AM
machniak committed rK534d00000831: Cherry-picked contents from hkccp-import (authored by vanmeeuwen).
Cherry-picked contents from hkccp-import
Wed, Jun 10, 11:41 AM
machniak closed D1291: Cherry-picked contents from hkccp-import.
Wed, Jun 10, 11:41 AM
machniak committed rK0481c595510a: Add plain text parts to email (authored by machniak).
Add plain text parts to email
Wed, Jun 10, 11:41 AM
machniak closed D1354: Add plain text parts to email.
Wed, Jun 10, 11:41 AM
machniak added inline comments to D1360: Transaction log in admin UI.
Wed, Jun 10, 10:58 AM
machniak updated the diff for D1360: Transaction log in admin UI.
  • Small code improvements
Wed, Jun 10, 8:59 AM
machniak requested review of D1360: Transaction log in admin UI.
Wed, Jun 10, 8:14 AM

Tue, Jun 9

machniak committed rK7dc1e3fa2ee8: Limit number of records the test works with, code improvements (authored by machniak).
Limit number of records the test works with, code improvements
Tue, Jun 9, 11:12 AM
machniak requested review of D1354: Add plain text parts to email.
Tue, Jun 9, 10:47 AM

Mon, Jun 8

machniak updated the diff for D1348: Receipts UI.
  • Use YYYY-MM format in receipt filename
Mon, Jun 8, 12:03 PM
machniak requested review of D1348: Receipts UI.
Mon, Jun 8, 8:49 AM

Jun 5 2020

machniak requested changes to D1150: Wallet magic.

@vanmeeuwen, I rebased, fixed obvious bugs and refactored the code so now we have Wallet::balanceLastsUntil() that we need tests for in tests/Feature/WalletTest::testBalanceLastsUntil().

Jun 5 2020, 1:47 PM
machniak updated the diff for D1150: Wallet magic.
  • Fix error due to missing use statements
  • Create Wallet::balanceLastsUntil()
Jun 5 2020, 1:44 PM
machniak added inline comments to D1297: Make sure we bill for entitlements that are deleted.
Jun 5 2020, 1:09 PM
machniak requested changes to D1297: Make sure we bill for entitlements that are deleted.

This learned us that an exception does not rollback uncommitted transactions. Here's a general fix for this issue:

--- a/src/app/Exceptions/Handler.php
+++ b/src/app/Exceptions/Handler.php
@@ -5,6 +5,7 @@ namespace App\Exceptions;
 use Exception;
 use Illuminate\Auth\AuthenticationException;
 use Illuminate\Foundation\Exceptions\Handler as ExceptionHandler;
+use Illuminate\Support\Facades\DB;
Jun 5 2020, 12:50 PM
machniak committed rK35814db70a9c: Fix test failing when executed more than once (authored by machniak).
Fix test failing when executed more than once
Jun 5 2020, 9:34 AM
machniak accepted D1291: Cherry-picked contents from hkccp-import.

My comments to src/app/Domain.php were not addressed, but it's not critical.

Jun 5 2020, 9:01 AM
machniak updated the diff for D1327: VAT on Receipts.
  • Render fake receipt with VAT
Jun 5 2020, 8:26 AM

Jun 4 2020

machniak committed rK279da5dfbdc1: Fix regression, improve button labels (authored by machniak).
Fix regression, improve button labels
Jun 4 2020, 4:22 PM
machniak requested review of D1327: VAT on Receipts.
Jun 4 2020, 3:07 PM
machniak committed rK10f2840186b8: Wallet history (authored by machniak).
Wallet history
Jun 4 2020, 1:59 PM
machniak closed D1321: Wallet history.
Jun 4 2020, 1:59 PM
machniak updated the diff for D1321: Wallet history.
  • Top-up -> Payment
Jun 4 2020, 1:58 PM
machniak committed rK9b606244c719: Support: Awarding a bonus or penalty (Bifrost#T315896) (authored by machniak).
Support: Awarding a bonus or penalty (Bifrost#T315896)
Jun 4 2020, 12:53 PM
machniak closed D1267: Support: Awarding a bonus or penalty (Bifrost#T315896).
Jun 4 2020, 12:53 PM
machniak requested review of D1321: Wallet history.
Jun 4 2020, 12:47 PM
machniak committed rK5df6db72a947: Receipt document (html and pdf) (authored by machniak).
Receipt document (html and pdf)
Jun 4 2020, 10:34 AM
machniak closed D1309: Receipt document (html and pdf).
Jun 4 2020, 10:33 AM
machniak added a comment to D1315: Return an empty body element for empty descriptions.

The spec. says Body is optional. https://docs.microsoft.com/en-us/openspecs/exchange_server_protocols/ms-ascal/70161e94-3b50-4d20-8c4d-e3ca608f9dc8

Jun 4 2020, 9:37 AM

Jun 3 2020

machniak committed rKc4f6f1b8b280: Wallet charge: top-ups and notifications (authored by machniak).
Wallet charge: top-ups and notifications
Jun 3 2020, 12:27 PM
machniak closed D1249: Wallet charge: top-ups and notifications.
Jun 3 2020, 12:26 PM
machniak updated the diff for D1249: Wallet charge: top-ups and notifications.
  • Fix typo
Jun 3 2020, 12:14 PM
machniak added inline comments to D1249: Wallet charge: top-ups and notifications.
Jun 3 2020, 9:41 AM
machniak updated the diff for D1249: Wallet charge: top-ups and notifications.
  • Fix Stripe auto-payment charge
  • Fix Mollie auto-payment
  • Add more tests
Jun 3 2020, 9:37 AM

Jun 1 2020

machniak updated the test plan for D1309: Receipt document (html and pdf).
Jun 1 2020, 10:43 AM
machniak requested review of D1309: Receipt document (html and pdf).
Jun 1 2020, 10:33 AM

May 29 2020

machniak retitled D1249: Wallet charge: top-ups and notifications from WIP: Wallet charge: top-ups and notifications to Wallet charge: top-ups and notifications.
May 29 2020, 4:30 PM
machniak updated the summary of D1249: Wallet charge: top-ups and notifications.
May 29 2020, 4:30 PM
machniak updated the diff for D1249: Wallet charge: top-ups and notifications.
  • Update transaction log with payment description
  • Add wallet:mandate command to view/enable/disable auto-payment
  • Disabled mandate handling, test and fixed some flaky tests
May 29 2020, 4:29 PM
machniak updated the summary of D1267: Support: Awarding a bonus or penalty (Bifrost#T315896).
May 29 2020, 8:18 AM
machniak updated the diff for D1267: Support: Awarding a bonus or penalty (Bifrost#T315896).
  • Use transaction log
May 29 2020, 8:17 AM

May 28 2020

machniak planned changes to D1249: Wallet charge: top-ups and notifications.
May 28 2020, 12:58 PM