Page MenuHomePhorge

machniak (Aleksander Machniak)
Kolab Systems, Developer

Projects (32)

User Details

User Since
Apr 12 2015, 12:47 PM (519 w, 20 h)

Recent Activity

Fri, Mar 21

machniak committed rRPKf72d48940ebe: Fix adjusting timezone on events from free-busy source.
Fri, Mar 21, 2:05 PM

Thu, Mar 20

machniak closed D5142: DataMigrator: Fix handling of "spread event blocks" in the Takeout's ics parser.
Thu, Mar 20, 9:44 AM
machniak committed rK581f743db956: DataMigrator: Fix handling of "spread event blocks" in the Takeout's ics parser.
Thu, Mar 20, 9:44 AM
machniak updated the diff for D5142: DataMigrator: Fix handling of "spread event blocks" in the Takeout's ics parser.
  • Small code improvement, more assertions
Thu, Mar 20, 9:43 AM
machniak accepted D5145: Don't abort the migration on some expected errors.
Thu, Mar 20, 8:38 AM
machniak accepted D5148: Progress reporting.
Thu, Mar 20, 8:38 AM

Wed, Mar 19

machniak accepted D5133: Continue with migration on 400 error code.

I don't like \n in a log message. It's fine otherwise.

Wed, Mar 19, 6:43 PM
machniak requested changes to D5145: Don't abort the migration on some expected errors.
Wed, Mar 19, 6:40 PM
machniak requested changes to D5148: Progress reporting.
Wed, Mar 19, 6:33 PM
machniak accepted D5151: Skip the zip extraction if already available.
Wed, Mar 19, 6:21 PM
machniak updated the diff for D5142: DataMigrator: Fix handling of "spread event blocks" in the Takeout's ics parser.
  • Fix test description
  • DataMigrator: Make sure \r\n is used in mbox parser output
Wed, Mar 19, 3:37 PM
machniak requested review of D5142: DataMigrator: Fix handling of "spread event blocks" in the Takeout's ics parser.
Wed, Mar 19, 2:40 PM

Tue, Mar 18

machniak updated the diff for D5136: Proper use of request parameters in Guzzle client.
  • Small fix
Tue, Mar 18, 3:54 PM
machniak closed D5128: Use an Enum for a list of queues.
Tue, Mar 18, 2:53 PM
machniak committed rKd95a559ac49a: Use an Enum for a list of queues.
Tue, Mar 18, 2:53 PM
machniak updated the diff for D5128: Use an Enum for a list of queues.
  • Remove redundant code
Tue, Mar 18, 2:53 PM
machniak updated the diff for D5128: Use an Enum for a list of queues.
  • Merge branch 'master' into dev/queue-enum
  • Assert job's queue
Tue, Mar 18, 2:49 PM
machniak committed rK642a135ecc37: Remove unnneded @phpstan-ignore comment.
Tue, Mar 18, 2:20 PM
machniak closed D5132: Laravel v11.
Tue, Mar 18, 2:18 PM
machniak committed rK1b9742079aa1: Laravel v11.
Tue, Mar 18, 2:18 PM
machniak updated the diff for D5132: Laravel v11.
  • Use Swoole v6.0.1
Tue, Mar 18, 2:15 PM
machniak committed rRPKaf90c641dc54: Improve input handling - makes it more safe and fixes some PHP warnings.
Tue, Mar 18, 2:05 PM
machniak committed rRPKe2559a7f7b52: CS fixes.
Tue, Mar 18, 2:05 PM
machniak committed rRPK9dda9d113bf3: Fix PHP Fatal error: Uncaught Error: Class "libkolab" not found.
Tue, Mar 18, 2:05 PM
machniak committed rRPK106931e76ced: Bump phpunit version(s).
Tue, Mar 18, 2:05 PM
machniak requested review of D5139: Files: Fix token refresh (when using SSO and Kolab4 files API).
Tue, Mar 18, 2:05 PM
machniak requested review of D5136: Proper use of request parameters in Guzzle client.
Tue, Mar 18, 2:05 PM

Fri, Mar 14

machniak requested review of D5132: Laravel v11.
Fri, Mar 14, 3:27 PM
machniak committed R113:08248d99f803: Improve installer to fix confusion about disabling SMTP authentication (#9801).
Fri, Mar 14, 1:53 PM
machniak committed R113:8ec39907b5bd: Add rcmail_oauth::is_token_valid() method.
Fri, Mar 14, 1:53 PM
machniak committed R113:0fd28406f755: Fix PHP warning (#9775).
Fri, Mar 14, 1:53 PM
machniak committed R113:ea41ae4b9640: Fix match-type selector (remove unsupported options) in delete header action….
Fri, Mar 14, 1:53 PM
machniak committed R113:4a9516b2c98e: Fix decoding of attachment names encoded using both RFC2231 and RFC2047….
Fri, Mar 14, 1:53 PM
machniak committed R113:96903289b760: Fix phpdoc issue.
Fri, Mar 14, 1:53 PM
machniak committed R113:f3b58b2f83b8: Update changelog.
Fri, Mar 14, 1:53 PM
machniak committed R113:478ca05753f0: Fix merge conflict.
Fri, Mar 14, 1:53 PM
machniak committed R113:cd42de335a0c: Update links in comments and config to https where available (#9759) (authored by Philip Weir <88682+johndoh@users.noreply.github.com>).
Fri, Mar 14, 1:53 PM
machniak committed R113:8f34bf9e6493: Fix decodeContent() call with the by-reference argument.
Fri, Mar 14, 1:53 PM
machniak committed R113:3e579599766e: Fix handling of binary mail parts (e.g. PDF) encoded with quoted-printable….
Fri, Mar 14, 1:53 PM
machniak committed R113:71d2b673d9db: Fix link style inside .tagedit-list element.
Fri, Mar 14, 1:53 PM
machniak committed R113:b206cbc87a2f: IMAP: Partial support for ANNOTATE-EXPERIMENT-1 extension (RFC 5257).
Fri, Mar 14, 1:53 PM
machniak committed R113:a34f7160511e: Reset internal cache in appropriate places to be on a safe side.
Fri, Mar 14, 1:53 PM
machniak accepted D5130: Clear the kolab_files_token on oauth token refresh.

The is_token_valid() call should probably be done in the plugin's startup() method.

Fri, Mar 14, 12:08 PM

Wed, Mar 12

machniak added a comment to D5128: Use an Enum for a list of queues.

I don't understand why we no longer need $this->onQueue(self::QUEUE); ? Clearly seems to work in the tests, so there's apparently something making it work.

Wed, Mar 12, 1:03 PM
machniak requested review of D5128: Use an Enum for a list of queues.
Wed, Mar 12, 11:56 AM
machniak committed rAC4ea6e769315d: Fix 'Undefined array key "PHP_AUTH_USER"' warning.
Wed, Mar 12, 11:02 AM
machniak closed D5126: Add generic job:execute command (remove existing job:* commands).
Wed, Mar 12, 9:40 AM
machniak committed rKa16c73ab4ec3: Add generic job:execute command (remove existing job:* commands).
Wed, Mar 12, 9:40 AM
machniak closed D5124: Improve jobs resistence to temporary storage failures.
Wed, Mar 12, 9:40 AM
machniak committed rK1577b1e7cc81: Improve jobs resistence to temporary storage failures.
Wed, Mar 12, 9:39 AM

Tue, Mar 11

machniak requested review of D5126: Add generic job:execute command (remove existing job:* commands).
Tue, Mar 11, 3:58 PM
machniak requested review of D5124: Improve jobs resistence to temporary storage failures.
Tue, Mar 11, 3:20 PM
machniak closed D5122: Signup: Hide plan selection step if there's only one plan.
Tue, Mar 11, 11:13 AM
machniak committed rK43275900b87e: Signup: Hide plan selection step if there's only one plan.
Tue, Mar 11, 11:13 AM

Fri, Mar 7

machniak updated the diff for D5122: Signup: Hide plan selection step if there's only one plan.
  • Cleanup
Fri, Mar 7, 3:32 PM
machniak updated the diff for D5122: Signup: Hide plan selection step if there's only one plan.
  • Dashboard elements visibility for a group account without a custom domain
  • Get rid of default plan
  • CS fix
Fri, Mar 7, 3:15 PM

Wed, Mar 5

machniak added inline comments to D5122: Signup: Hide plan selection step if there's only one plan.
Wed, Mar 5, 10:44 AM
machniak updated the diff for D5122: Signup: Hide plan selection step if there's only one plan.
  • Introduce DEFAULT_PLAN config option
Wed, Mar 5, 9:05 AM

Tue, Mar 4

machniak updated the diff for D5122: Signup: Hide plan selection step if there's only one plan.
  • Cleanup and lint error fix
Tue, Mar 4, 3:47 PM
machniak requested review of D5122: Signup: Hide plan selection step if there's only one plan.
Tue, Mar 4, 3:35 PM

Thu, Feb 27

machniak closed D5100: Bump version numbers, cleanup composer.json files.
Thu, Feb 27, 3:45 PM
machniak closed D5118: 2FA: Use 32-char (160bit) long secrets.
Thu, Feb 27, 3:45 PM
machniak committed rRPK0d455af28061: 2FA: Use 32-char (160bit) long secrets.
Thu, Feb 27, 3:45 PM
machniak committed rRPK1072c6303f20: Bump version numbers, cleanup composer.json files.
Thu, Feb 27, 3:45 PM
machniak closed D5114: Footer: Don't skip parts with Content-Disposition:inline.
Thu, Feb 27, 3:42 PM
machniak committed rPf63cb8a3841b: Footer: Don't skip parts with Content-Disposition:inline.
Thu, Feb 27, 3:42 PM
machniak closed D5098: DataMigrator: Support user impersonation on Kolab4 account.
Thu, Feb 27, 3:41 PM
machniak committed rK5c4a230feeef: DataMigrator: Support user impersonation on Kolab4 account.
Thu, Feb 27, 3:41 PM

Tue, Feb 25

machniak accepted D5116: Move wallet processing to a background queue.
Tue, Feb 25, 6:11 PM
machniak closed D5112: Meet: Remember selected audio/video device.
Tue, Feb 25, 1:57 PM
machniak committed rK2cc2b7a2dd56: Meet: Remember selected audio/video device.
Tue, Feb 25, 1:57 PM
machniak retitled D5118: 2FA: Use 32-char (160bit) long secrets from 2FA: Make secret's length configurable
Tue, Feb 25, 1:15 PM
machniak updated the diff for D5118: 2FA: Use 32-char (160bit) long secrets.
  • Remove the config option, hardcode length=32
Tue, Feb 25, 1:14 PM
machniak requested review of D5118: 2FA: Use 32-char (160bit) long secrets.
Tue, Feb 25, 12:12 PM
machniak added a comment to D5116: Move wallet processing to a background queue.

That assertion would be $this->assertSame(WalletCheck::QUEUE, $job->queue);.

Tue, Feb 25, 9:46 AM
machniak requested changes to D5116: Move wallet processing to a background queue.

We can assert the queue in tests. Maybe add one assertion in tests/Feature/Jobs/WalletCheckTest.php

Tue, Feb 25, 9:28 AM

Mon, Feb 24

machniak closed D4650: Set Content-Length:0 for an empty Sync response.
Mon, Feb 24, 1:57 PM
machniak committed rSf82155a990ad: Set Content-Length:0 for an empty Sync response.
Mon, Feb 24, 1:57 PM
machniak updated the diff for D4650: Set Content-Length:0 for an empty Sync response.
  • Merge branch 'master' into dev/empty-sync-fix
  • Cleanup
  • Fix compatibility with Roundcube 1.7
Mon, Feb 24, 1:56 PM
machniak requested review of D5114: Footer: Don't skip parts with Content-Disposition:inline.
Mon, Feb 24, 11:25 AM

Feb 21 2025

machniak added a reviewer for D5112: Meet: Remember selected audio/video device: Restricted Project.
Feb 21 2025, 12:15 PM
machniak updated the diff for D5112: Meet: Remember selected audio/video device.
  • Cleanup
Feb 21 2025, 12:15 PM
machniak planned changes to D5112: Meet: Remember selected audio/video device.
Feb 21 2025, 11:54 AM
machniak updated the summary of D5112: Meet: Remember selected audio/video device.
Feb 21 2025, 11:54 AM
machniak requested review of D5112: Meet: Remember selected audio/video device.
Feb 21 2025, 11:53 AM
machniak accepted D5110: Turn Domain Configuration into a more generic DNS configuration.
Feb 21 2025, 10:52 AM
machniak requested changes to D5110: Turn Domain Configuration into a more generic DNS configuration.

Oh, whenever we change localization text we should update other languages, i.e. remove the entries from the French language.

Feb 21 2025, 8:54 AM
machniak accepted D5110: Turn Domain Configuration into a more generic DNS configuration.

FYI, on the screenshot you miss some dots after domain names.

Feb 21 2025, 8:50 AM

Feb 20 2025

machniak committed rKfd9c553b0250: Fix flaky test.
Feb 20 2025, 2:57 PM
machniak committed rKc7c31e698f41: Fix merge regression.
Feb 20 2025, 2:26 PM
machniak closed D5108: Use incrementing retry interval (backoff) in all jobs.
Feb 20 2025, 2:26 PM
machniak committed rK12e27a123022: Use incrementing retry interval (backoff) in all jobs.
Feb 20 2025, 2:26 PM
machniak closed D5106: Use a separate queue for mailing jobs, de-duplicate code.
Feb 20 2025, 2:26 PM
machniak committed rK734ef93c24f6: Use a separate queue for mailing jobs, de-duplicate code.
Feb 20 2025, 2:26 PM
machniak closed D5102: Make "postmaster" and "webmaster" a forbidden local part of an email address in public domain.
Feb 20 2025, 2:26 PM
machniak closed D5104: Move wallet top-up code into Wallet.
Feb 20 2025, 2:26 PM
machniak committed rK74f08a1648a6: Move wallet top-up code into Wallet.
Feb 20 2025, 2:26 PM
machniak committed rK7cd52cdf93f8: Make "postmaster" and "webmaster" a forbidden local part of an email address in….
Feb 20 2025, 2:26 PM

Feb 19 2025

machniak committed rK77fcef932fae: Move some unit tests into appropriate place.
Feb 19 2025, 2:37 PM
machniak committed rKa080da49c12d: Fix flaky user delete test.
Feb 19 2025, 2:22 PM