Page MenuHomekolab.org

machniak (Aleksander Machniak)
Kolab Systems, Developer

Projects (31)

User Details

User Since
Apr 12 2015, 12:47 PM (259 w, 1 d)

Recent Activity

Yesterday

machniak updated the diff for D1063: Add a discount column to the Wallet model, and commands to control such a discount.
  • Wallet discounts (by a separate table)
Mon, Mar 30, 4:12 PM
machniak committed rK3696bb7ebae8: 2FA - initial, non-working code (authored by machniak).
2FA - initial, non-working code
Mon, Mar 30, 1:36 PM
machniak closed D1075: 2FA - initial, non-working code.
Mon, Mar 30, 1:36 PM
machniak updated the diff for D1075: 2FA - initial, non-working code.
  • Improve logon form, fix tests, remove dummy method
Mon, Mar 30, 1:28 PM
machniak accepted D1096: Use ->addMonthsWithoutOverflow() and ->subMonthsWithoutOverflow().

I'd re-check on 1st of month.

Mon, Mar 30, 11:04 AM

Sat, Mar 28

machniak accepted D1081: Instead of converting the values from zlib:deflate to binary by hand we can use the iolist_to_binary() function from erlang; this allows us to convert also nested iolists..

Looks like a nice simple change.

Sat, Mar 28, 8:16 AM
machniak added a comment to rK16b688d80237: Working 2FA.

in addition, the 2FA checkbox could use an explicit (as in not hidden behind the info button) hint

that this only works when the users also sets it up in roundcube,
as well as a hint that this will disable the usage of external clients for now
Sat, Mar 28, 8:07 AM

Fri, Mar 27

machniak updated the diff for D1075: 2FA - initial, non-working code.
  • Remove unused lang entries
  • Fix phpstan errors
Fri, Mar 27, 4:11 PM
machniak committed rK1a7f57412289: Fix phpstan errors (authored by machniak).
Fix phpstan errors
Fri, Mar 27, 4:10 PM
machniak committed rK69895764d1a0: Remove unused lang entries (authored by machniak).
Remove unused lang entries
Fri, Mar 27, 4:10 PM
machniak updated the diff for D1075: 2FA - initial, non-working code.
  • Remove configured factors on entitlement delete, added tests
Fri, Mar 27, 3:51 PM
machniak committed rK2e18f6f897ef: Remove configured factors on entitlement delete, added tests (authored by machniak).
Remove configured factors on entitlement delete, added tests
Fri, Mar 27, 3:34 PM
machniak added inline comments to D1069: Progress changes on to LDAP.
Fri, Mar 27, 11:01 AM
machniak added a reviewer for D1075: 2FA - initial, non-working code: Restricted Project.
Fri, Mar 27, 9:52 AM
machniak committed rK16b688d80237: Working 2FA (authored by machniak).
Working 2FA
Fri, Mar 27, 9:49 AM
machniak requested review of D1075: 2FA - initial, non-working code.
Fri, Mar 27, 9:49 AM

Thu, Mar 26

machniak committed rK62557f6f2cfa: 2FA - initial, non-working code (authored by machniak).
2FA - initial, non-working code
Thu, Mar 26, 12:15 PM
machniak committed rKa02286ec40a6: Add 2FA and Activesync SKUs (authored by machniak).
Add 2FA and Activesync SKUs
Thu, Mar 26, 12:07 PM
machniak closed D1057: Add 2FA and Activesync SKUs.
Thu, Mar 26, 12:07 PM
machniak commandeered D1063: Add a discount column to the Wallet model, and commands to control such a discount.

We'll move forward with a new table: discounts { id, discount, description, code (for vouchers), active } and wallets.discount_id.

Thu, Mar 26, 11:41 AM

Wed, Mar 25

machniak added a comment to D1051: improve wallet layout.

I would do all these calculations on the server side. Probably returned with extended domains/users api requests, or maybe better via /api/v4/wallet/{wallet-id} (which does not exist yet).

Wed, Mar 25, 4:52 PM
machniak requested review of D1057: Add 2FA and Activesync SKUs.
Wed, Mar 25, 12:31 PM

Tue, Mar 24

machniak committed rK100dff478aac: Display user/domain status in UI, add Active status (authored by machniak).
Display user/domain status in UI, add Active status
Tue, Mar 24, 4:44 PM
machniak closed D1045: Display user/domain status in UI, add Active status.
Tue, Mar 24, 4:44 PM
machniak committed rK36185b19cb07: Remove "empty" and unused job file (authored by machniak).
Remove "empty" and unused job file
Tue, Mar 24, 4:44 PM
machniak updated the diff for D1045: Display user/domain status in UI, add Active status.
  • Add console script to set/get user status
  • Add console command to set/get domain status
  • Browser tests for status indicators
  • Make user:status and domain:status commands available in non-production mode only
  • CS and typos fixes
Tue, Mar 24, 12:49 PM
machniak added a comment to D1045: Display user/domain status in UI, add Active status.

Reopen

Tue, Mar 24, 12:43 PM
machniak committed rKfe4ff9750886: CS and typos fixes (authored by machniak).
CS and typos fixes
Tue, Mar 24, 12:41 PM
machniak closed D1045: Display user/domain status in UI, add Active status.
Tue, Mar 24, 12:41 PM
machniak updated the diff for D1045: Display user/domain status in UI, add Active status.

Fix

Tue, Mar 24, 12:26 PM
machniak updated the diff for D1045: Display user/domain status in UI, add Active status.

CS fixes

Tue, Mar 24, 12:19 PM
machniak added inline comments to D1045: Display user/domain status in UI, add Active status.
Tue, Mar 24, 11:36 AM
machniak reopened D1045: Display user/domain status in UI, add Active status.
Tue, Mar 24, 8:38 AM

Mon, Mar 23

machniak committed rK3d22edbfa0fd: Make user:status and domain:status commands available in non-production mode… (authored by machniak).
Make user:status and domain:status commands available in non-production mode…
Mon, Mar 23, 4:41 PM
machniak added a comment to D1045: Display user/domain status in UI, add Active status.

@bohlender, there are two helper commands you can use to test the functionality.

$ php artisan user:status --del=imapReady
$ php artisan user:status --add=imapReady
$ php artisan domain:status --del=verified
$ php artisan domain:status --add=verified
Mon, Mar 23, 4:17 PM
machniak committed rK798e6538c15c: Browser tests for status indicators (authored by machniak).
Browser tests for status indicators
Mon, Mar 23, 4:10 PM
machniak committed rK572a2251a19c: Add console command to set/get domain status (authored by machniak).
Add console command to set/get domain status
Mon, Mar 23, 4:10 PM
machniak committed rK6fa017115887: Add console script to set/get user status (authored by machniak).
Add console script to set/get user status
Mon, Mar 23, 4:10 PM
machniak committed rK843876cd82c0: Display user/domain status in UI, add Active status (authored by machniak).
Display user/domain status in UI, add Active status
Mon, Mar 23, 4:10 PM
machniak closed D1045: Display user/domain status in UI, add Active status.
Mon, Mar 23, 4:10 PM
machniak updated the summary of D1045: Display user/domain status in UI, add Active status.
Mon, Mar 23, 3:53 PM
machniak added reviewers for D1045: Display user/domain status in UI, add Active status: vanmeeuwen, bohlender.
Mon, Mar 23, 3:53 PM
machniak updated the diff for D1045: Display user/domain status in UI, add Active status.
  • Add console script to set/get user status
  • Add console command to set/get domain status
  • Browser tests for status indicators
Mon, Mar 23, 3:52 PM

Fri, Mar 20

machniak requested review of D1045: Display user/domain status in UI, add Active status.
Fri, Mar 20, 2:51 PM
machniak updated the diff for D1030: Mollie payments.
  • RedirectUrl don't have to public
Fri, Mar 20, 2:41 PM
machniak updated the diff for D1030: Mollie payments.
  • Change webhook location to fix auth issue
Fri, Mar 20, 2:25 PM
machniak updated the diff for D1030: Mollie payments.
  • The proxy on 127.0.0.1 can be trusted
  • Added APP_PUBLIC_URL setting
Fri, Mar 20, 1:23 PM
machniak updated the diff for D1030: Mollie payments.
  • Reset mollie_id when testing payment
Fri, Mar 20, 10:45 AM
machniak updated the diff for D1030: Mollie payments.
  • Set locale for Mollie to fix browser test
Fri, Mar 20, 10:25 AM
machniak updated the diff for D1030: Mollie payments.
  • Tests for payments controller
  • Browser test for payment with Mollie
Fri, Mar 20, 9:19 AM

Tue, Mar 17

machniak requested review of D1030: Mollie payments.
Tue, Mar 17, 11:27 AM
machniak committed rK7f609d4d86c4: Wallet page and wallet balance badge in Dashboard (authored by machniak).
Wallet page and wallet balance badge in Dashboard
Tue, Mar 17, 11:26 AM
machniak closed D1024: Wallet page and wallet balance badge in Dashboard.
Tue, Mar 17, 11:25 AM

Mon, Mar 16

machniak requested review of D1024: Wallet page and wallet balance badge in Dashboard.
Mon, Mar 16, 10:08 AM

Fri, Mar 13

machniak committed rKcf98610f79ce: Small UI and browser tests improvements (authored by machniak).
Small UI and browser tests improvements
Fri, Mar 13, 8:40 PM
machniak committed rK8ca5c29a3cc4: Get rid of owner_id (authored by machniak).
Get rid of owner_id
Fri, Mar 13, 3:26 PM
machniak closed D1018: Get rid of owner_id.
Fri, Mar 13, 3:25 PM
machniak added inline comments to D1018: Get rid of owner_id.
Fri, Mar 13, 2:15 PM
machniak requested review of D1018: Get rid of owner_id.
Fri, Mar 13, 1:28 PM
machniak committed rK8d8f186c3b5a: Unlock dusk version (authored by machniak).
Unlock dusk version
Fri, Mar 13, 11:52 AM
machniak committed rKc2d1a4e5d859: User entitlements management (authored by machniak).
User entitlements management
Fri, Mar 13, 11:52 AM
machniak closed D1012: User entitlements management.
Fri, Mar 13, 11:52 AM
machniak updated the diff for D1012: User entitlements management.
  • Add browser tests, fix small issues
Fri, Mar 13, 11:14 AM

Thu, Mar 12

machniak updated the diff for D1012: User entitlements management.
  • Use Queue:: syntax, phpstan is now happy
Thu, Mar 12, 4:04 PM
machniak requested review of D1012: User entitlements management.
Thu, Mar 12, 3:45 PM

Tue, Mar 10

machniak committed rKf8fa8af34755: De-duplicate code of TestCase and DuskTestCase with a trait (authored by machniak).
De-duplicate code of TestCase and DuskTestCase with a trait
Tue, Mar 10, 12:41 PM
machniak committed rKa722f7af5a36: Fix linting path (authored by machniak).
Fix linting path
Tue, Mar 10, 12:10 PM
machniak committed rKe055ff07ad51: Refactor resources tree (authored by machniak).
Refactor resources tree
Tue, Mar 10, 12:09 PM
machniak committed rK1a2e8fbe7234: Fix js/css linting issues (authored by machniak).
Fix js/css linting issues
Tue, Mar 10, 12:09 PM
machniak updated the diff for D1000: Deleting users/accounts.
  • Make UserVerifyTest less fragile - wait up to 10 seconds
Tue, Mar 10, 11:01 AM
machniak updated the diff for D1000: Deleting users/accounts.
  • Fix tests regressions
Tue, Mar 10, 10:49 AM
machniak updated the diff for D1000: Deleting users/accounts.
  • Rebase
  • Small refactoring regarding wallets/accounts
  • Remove redundant code
Tue, Mar 10, 10:01 AM

Mon, Mar 9

machniak abandoned D1006: Use property_exists instead of array_key_exists on object.

Done in bdfb95825b525 [syncroton master].

Mon, Mar 9, 12:17 PM
machniak committed rSbdfb95825b52: Update Syncroton (authored by machniak).
Update Syncroton
Mon, Mar 9, 12:16 PM
machniak added a comment to D1006: Use property_exists instead of array_key_exists on object.

Looks like the mentioned bug has been fixed in PHP 5.2.2, so I'm guessing we can remove the whole method. Oh, actually upstream did it here https://github.com/tine20/syncroton/commit/e847e680ba19d65aa5305d73313a5ea7af2387a7. So, I'm going to update Syncroton version we're using.

Mon, Mar 9, 12:08 PM
machniak updated the diff for D1000: Deleting users/accounts.
  • Fix dispatching DomainDelete job - use ID instead of the Model object
Mon, Mar 9, 11:55 AM
machniak updated the diff for D1000: Deleting users/accounts.
  • Use wallets to control access to UI elements
Mon, Mar 9, 11:02 AM

Fri, Mar 6

machniak updated the diff for D1000: Deleting users/accounts.
  • Fixes regarding wallets
Fri, Mar 6, 3:40 PM
machniak updated the diff for D1000: Deleting users/accounts.
  • Set domain/user STATUS_DELETED after removing from ldap
  • Added more browser tests (that are failing at the moment)
Fri, Mar 6, 1:34 PM
machniak accepted D964: Implement a changelog to further the debiting of wallet balances.

I reviewed it again, I guess it's ready to be merged.

Fri, Mar 6, 9:52 AM

Thu, Mar 5

machniak added inline comments to D1000: Deleting users/accounts.
Thu, Mar 5, 6:46 PM
machniak retitled D1000: Deleting users/accounts from Implement proper users listing, added tests for it to Deleting users/accounts.
Thu, Mar 5, 2:01 PM
machniak requested review of D1000: Deleting users/accounts.
Thu, Mar 5, 1:59 PM
machniak accepted D994: Upgrade to Laravel 6.x.
Thu, Mar 5, 11:36 AM

Tue, Mar 3

machniak committed rK634614cb0e66: Dusk browser extensions (authored by machniak).
Dusk browser extensions
Tue, Mar 3, 8:32 AM
machniak closed D988: Dusk browser extensions.
Tue, Mar 3, 8:32 AM
machniak added a comment to D988: Dusk browser extensions.

Yes, I just copied some code I already have had in Roundcube for future use. The main point was to have possibility to extend the browser object with some helper code, to simplify tests writing.

Tue, Mar 3, 8:09 AM

Mon, Mar 2

machniak requested review of D988: Dusk browser extensions.
Mon, Mar 2, 8:48 PM
machniak updated the diff for D982: Add some fontawesome images.
  • Move fontawesome icons selection to a separate file
Mon, Mar 2, 4:19 PM
machniak added a comment to D964: Implement a changelog to further the debiting of wallet balances.

Looks good for now.

Mon, Mar 2, 1:05 PM
machniak requested review of D982: Add some fontawesome images.
Mon, Mar 2, 11:37 AM
machniak committed rKbd67f73b11e8: Group: Additional user (Bifrost#T249344) (authored by machniak).
Group: Additional user (Bifrost#T249344)
Mon, Mar 2, 11:34 AM
machniak closed D976: Group: Additional user (Bifrost#T249344).
Mon, Mar 2, 11:34 AM
machniak updated the diff for D976: Group: Additional user (Bifrost#T249344).
  • Eliminate aliases sorting issue
Mon, Mar 2, 10:53 AM
machniak updated the diff for D976: Group: Additional user (Bifrost#T249344).
  • Add orderBy() so aliases list is sorted
Mon, Mar 2, 10:46 AM

Feb 29 2020

machniak updated the diff for D976: Group: Additional user (Bifrost#T249344).
  • Adding new users
Feb 29 2020, 8:44 AM

Feb 28 2020

machniak updated the diff for D976: Group: Additional user (Bifrost#T249344).
  • Aliases UI
Feb 28 2020, 1:10 PM

Feb 27 2020

machniak added inline comments to D964: Implement a changelog to further the debiting of wallet balances.
Feb 27 2020, 9:07 PM
machniak added inline comments to D964: Implement a changelog to further the debiting of wallet balances.
Feb 27 2020, 9:05 PM
machniak updated the diff for D976: Group: Additional user (Bifrost#T249344).
  • Aliases validation
Feb 27 2020, 3:48 PM