Page MenuHomePhorge

machniak (Aleksander Machniak)
Kolab Systems, Developer

Projects (32)

User Details

User Since
Apr 12 2015, 12:47 PM (504 w, 5 d)

Recent Activity

Today

machniak updated the diff for D5062: Kolab4 tags support.
  • Performance: Use lighter rcube_message_header instead of rcube_message
Fri, Dec 13, 3:19 PM
machniak requested changes to D5044: Warning on FolderSync synckey reuse, but then don't try to create in the backend.

Adding methods to backend interface implementation requires some more code. Phpstan says:

Line   lib/ext/Syncroton/Command/FolderSync.php                          
------ ------------------------------------------------------------------ 
 295    Call to an undefined method Syncroton_Backend_IFolder::exists().
Fri, Dec 13, 11:27 AM
machniak requested review of D5062: Kolab4 tags support.
Fri, Dec 13, 11:07 AM
machniak closed D5060: Tests: Various fixes.
Fri, Dec 13, 11:00 AM
machniak committed rS3c23e5ae0414: Tests: Various fixes (authored by machniak).
Tests: Various fixes
Fri, Dec 13, 11:00 AM
machniak requested review of D5060: Tests: Various fixes.
Fri, Dec 13, 10:49 AM

Yesterday

machniak updated the summary of D5032: Kolab Tags SQL and ANNOTATE drivers.
Thu, Dec 12, 1:50 PM
machniak updated the diff for D5032: Kolab Tags SQL and ANNOTATE drivers.
  • Fixes regarding syncroton API for tags
Thu, Dec 12, 1:44 PM

Wed, Dec 11

machniak updated the diff for D5032: Kolab Tags SQL and ANNOTATE drivers.
  • Small doc fix
Wed, Dec 11, 3:20 PM
machniak retitled D5032: Kolab Tags SQL and ANNOTATE drivers from Kolab Tags SQL Database Driver
Wed, Dec 11, 3:13 PM
machniak updated the diff for D5032: Kolab Tags SQL and ANNOTATE drivers.
  • CS fixes
  • ANNOTATE driver
  • Improvements
  • SQL driver fixes
Wed, Dec 11, 3:12 PM
machniak committed rK16f50556c653: Fix localization for chargeback transactions description (authored by machniak).
Fix localization for chargeback transactions description
Wed, Dec 11, 9:05 AM

Tue, Dec 10

machniak requested changes to D5058: Always run the seeder when horizon starts.
Tue, Dec 10, 3:43 PM
machniak requested review of D5056: WalletCheck cleanup.
Tue, Dec 10, 10:48 AM

Mon, Dec 9

machniak accepted D5054: Error handling when querying sync-states.
Mon, Dec 9, 6:40 PM
machniak accepted D5048: User::SERVICE_ROLE for service accounts.
Mon, Dec 9, 2:35 PM
machniak accepted D5050: Explicitly mention that this is an automatically suspected spammer.
Mon, Dec 9, 2:06 PM
machniak requested changes to D5052: Test the sasl auth hook.
Mon, Dec 9, 1:17 PM
machniak requested changes to D5048: User::SERVICE_ROLE for service accounts.
Mon, Dec 9, 1:10 PM
machniak added a comment to D5046: Create a client for webmail sso via migration.

BTW, none of the other registered passport clients are added via the migration. Maybe they should too. However, as all of them depend on existing-in-config client secrets and Ids, I'm still not sure migration is the correct place. Maybe we should have something like a "global seeder".

Mon, Dec 9, 12:05 PM

Thu, Dec 5

machniak requested changes to D5046: Create a client for webmail sso via migration.

We call the seeder after migration, so the seeder will fail because the record already exists.

Thu, Dec 5, 3:03 PM

Wed, Dec 4

machniak committed R113:df02322d6a38: Fix Oauth issues with use_secure_urls=true (#9722) (authored by machniak).
Fix Oauth issues with use_secure_urls=true (#9722)
Wed, Dec 4, 10:14 AM
machniak committed R113:726f9c5d3cb5: Update changelog (authored by machniak).
Update changelog
Wed, Dec 4, 10:14 AM
machniak committed R113:3b1258b78550: Fix preg_match()'s $flags type (#9686) (authored by Paul J. Dorn <pajod@users.noreply.github.com>).
Fix preg_match()'s $flags type (#9686)
Wed, Dec 4, 10:14 AM
machniak committed R113:2f4748bb9d01: BUG: get_variable for postgres never returns a value (#9710) (authored by Vitaly Lavrov <vel21ripn@gmail.com>).
BUG: get_variable for postgres never returns a value (#9710)
Wed, Dec 4, 10:14 AM
machniak committed R113:6baf9aeff0dd: Added German translation for "Keep Formatting" (#9701) (authored by Jan <56178675+JE4GLE@users.noreply.github.com>).
Added German translation for "Keep Formatting" (#9701)
Wed, Dec 4, 10:14 AM
machniak committed R113:5c38c6728709: Fix PHP fatal error when parsing some malformed BODYSTRUCTURE responses (#9689) (authored by machniak).
Fix PHP fatal error when parsing some malformed BODYSTRUCTURE responses (#9689)
Wed, Dec 4, 10:14 AM
machniak committed R113:a68ef058aefe: Password: Remove reference to non-existing 'password_zxcvbn_min_score' option… (authored by machniak).
Password: Remove reference to non-existing 'password_zxcvbn_min_score' option…
Wed, Dec 4, 10:14 AM

Tue, Dec 3

machniak added a comment to R113:f74f30240dd1: Support configuring the oauth redirect uri.

Proper fix https://github.com/roundcube/roundcubemail/commit/df02322d6a38e6691ec066d83ee7e6ca34a1054d

Tue, Dec 3, 12:46 PM

Thu, Nov 28

machniak accepted D5042: Single kolab_users_count metric with state label.
Thu, Nov 28, 10:31 AM

Wed, Nov 27

machniak accepted D5040: user:resync: efficient resync for created/deleted users.
Wed, Nov 27, 10:12 AM
machniak requested changes to D5040: user:resync: efficient resync for created/deleted users.
Wed, Nov 27, 9:09 AM
machniak accepted D5028: Disable the mandate if we retrieve a valid one.

This warning message is not that useful without a wallet ID, I suppose.

Wed, Nov 27, 8:26 AM

Tue, Nov 26

machniak requested changes to D5040: user:resync: efficient resync for created/deleted users.
Tue, Nov 26, 2:10 PM
machniak committed rS14ca1160815e: Fix CS and phpstan issues (authored by machniak).
Fix CS and phpstan issues
Tue, Nov 26, 1:45 PM

Mon, Nov 25

machniak requested review of D5038: UI: Prefer to display suspended over degraded status.
Mon, Nov 25, 11:36 AM

Fri, Nov 22

machniak accepted D5026: Always try to top-up the wallet on charge.
Fri, Nov 22, 2:15 PM
machniak committed rKa2bc81339bdd: Fix test regression (authored by machniak).
Fix test regression
Fri, Nov 22, 2:08 PM
machniak committed rKa63260da6f96: Fix test regressions (authored by machniak).
Fix test regressions
Fri, Nov 22, 2:08 PM
machniak requested review of D5036: Don't allow Delete jobs on non-deleted objects.
Fri, Nov 22, 2:03 PM
machniak committed rK001d05e4c3c4: Fix an obvious code issue (authored by machniak).
Fix an obvious code issue
Fri, Nov 22, 1:26 PM
machniak closed D5034: Unrestrict users on signup with a 100% discount.
Fri, Nov 22, 1:26 PM
machniak committed rK1115ebfb7470: Unrestrict users on signup with a 100% discount (authored by machniak).
Unrestrict users on signup with a 100% discount
Fri, Nov 22, 1:26 PM
machniak requested review of D5034: Unrestrict users on signup with a 100% discount.
Fri, Nov 22, 12:57 PM
machniak committed rRPK687ab45110b0: CS fixes (authored by machniak).
CS fixes
Fri, Nov 22, 10:57 AM
machniak requested review of D5032: Kolab Tags SQL and ANNOTATE drivers.
Fri, Nov 22, 10:45 AM
machniak requested changes to D5028: Disable the mandate if we retrieve a valid one.
Fri, Nov 22, 8:42 AM
machniak requested changes to D5030: user:purge command to delete inactive users.
Fri, Nov 22, 8:28 AM
machniak added a comment to D5026: Always try to top-up the wallet on charge.

I was thinking about removing the try/catch. If we make a top-up attempt on every WalletCheck job run there's really no need for dispatching a separate job. The only danger will be that if topUpWallet() always throws the rest of the code will never execute, but how big of a danger is that I'm not sure.

Fri, Nov 22, 7:57 AM

Thu, Nov 21

machniak accepted D5024: Collect horizon metrics.
Thu, Nov 21, 10:47 AM

Tue, Nov 19

machniak closed D5022: Don't dispatch update jobs on deleted objects.
Tue, Nov 19, 11:41 AM
machniak committed rK65e919c6d350: Don't dispatch update jobs on deleted objects (authored by machniak).
Don't dispatch update jobs on deleted objects
Tue, Nov 19, 11:41 AM
machniak committed rK79b02e7ca6e2: Fix regression (authored by machniak).
Fix regression
Tue, Nov 19, 10:40 AM
machniak requested review of D5022: Don't dispatch update jobs on deleted objects.
Tue, Nov 19, 10:28 AM
machniak accepted D5018: Metric for users with failed init.
Tue, Nov 19, 8:06 AM
machniak accepted D5020: Set a timeout on the imap backend.
Tue, Nov 19, 8:04 AM

Mon, Nov 18

machniak closed D5012: Referral programs.
Mon, Nov 18, 2:37 PM
machniak committed rKb16089d854cd: Referral programs (authored by machniak).
Referral programs
Mon, Nov 18, 2:37 PM
machniak added a comment to D5014: Metric to detect users that need a cleanup.

Take a look at App\Jobs\User\DeleteJob, it will add STATUS_DELETED after all code before passes (does not throw an exception). So, checking for missing STATUS_DELETED should be included, and probably should be enough to check just this one.

Mon, Nov 18, 2:16 PM
machniak accepted D5016: Some means to partition a user:resync into smaller batches.
Mon, Nov 18, 2:11 PM
machniak added a comment to D5014: Metric to detect users that need a cleanup.

Also, whereNot('status', '&', User::STATUS_DELETED) would probably do the same. This status is set after user deletion from LDAP/IMAP was successful.

Mon, Nov 18, 12:32 PM
machniak accepted D5014: Metric to detect users that need a cleanup.

Maybe where deleted_at < "5 seconds ago" would be better to give some slack to users deleted "right now".

Mon, Nov 18, 12:31 PM

Fri, Nov 15

machniak closed D5010: External sender module.
Fri, Nov 15, 12:15 PM
machniak committed rKe3a8f0ac4ba0: External sender module (authored by machniak).
External sender module
Fri, Nov 15, 12:15 PM

Thu, Nov 14

machniak updated the diff for D5012: Referral programs.
  • Add QR code
Thu, Nov 14, 10:01 AM

Nov 13 2024

machniak updated the diff for D5012: Referral programs.
  • CS fixes
Nov 13 2024, 2:57 PM
machniak requested review of D5012: Referral programs.
Nov 13 2024, 2:37 PM

Nov 12 2024

machniak committed rK55712f9241fe: Fix phpstan errors (authored by machniak).
Fix phpstan errors
Nov 12 2024, 11:16 AM
machniak committed rK3fba3205c0db: Add daily `wallet:charge --topup` command execution (authored by machniak).
Add daily `wallet:charge --topup` command execution
Nov 12 2024, 11:16 AM
machniak closed D5001: Log job start (partial).
Nov 12 2024, 10:51 AM
machniak committed rKfde824a7ea96: Log job start (partial) (authored by machniak).
Log job start (partial)
Nov 12 2024, 10:51 AM

Nov 6 2024

machniak committed R113:c008d6272414: Update changelog (authored by machniak).
Update changelog
Nov 6 2024, 3:30 PM
machniak committed R113:dc9ace7526b2: Fix regression causing inline SVG images to be missing in mail preview (#9644) (authored by machniak).
Fix regression causing inline SVG images to be missing in mail preview (#9644)
Nov 6 2024, 3:30 PM
machniak committed R113:8cc559a6f057: Fix getting IMAP vendor name (#9654) (authored by Pablo Zmdl <57864086+pabzm@users.noreply.github.com>).
Fix getting IMAP vendor name (#9654)
Nov 6 2024, 3:30 PM
machniak committed R113:84e0bafa5bbb: Managesieve: Fix current script state after initial scripts creation in… (authored by machniak).
Managesieve: Fix current script state after initial scripts creation in…
Nov 6 2024, 3:30 PM
machniak committed R113:602a989697c1: Fix PHP warning (#9611) (authored by machniak).
Fix PHP warning (#9611)
Nov 6 2024, 3:30 PM
machniak committed R113:f3c526e6d1ad: Fix PHP deprecation warnings (#9616) (authored by machniak).
Fix PHP deprecation warnings (#9616)
Nov 6 2024, 3:30 PM
machniak committed R113:62a8a37ac869: Update changelog (authored by machniak).
Update changelog
Nov 6 2024, 3:30 PM
machniak committed R113:ffb2cf7929b7: vcard: Fix whitespace handling in line cont's (#9637) (authored by respiranto <github023@respiranto.de>).
vcard: Fix whitespace handling in line cont's (#9637)
Nov 6 2024, 3:30 PM
machniak committed R113:83f56f1758aa: OAuth: Support standard authentication with short-living password received with… (authored by machniak).
OAuth: Support standard authentication with short-living password received with…
Nov 6 2024, 3:30 PM
machniak committed R113:f343ecea09f8: Fix regression where HTML messages were displayed unstyled (#9586) (authored by machniak).
Fix regression where HTML messages were displayed unstyled (#9586)
Nov 6 2024, 3:30 PM
machniak committed R113:32fed15346e5: Fix regression where printing/scaling/rotating image attachments was broken… (authored by machniak).
Fix regression where printing/scaling/rotating image attachments was broken…
Nov 6 2024, 3:30 PM
machniak committed R113:44ed0d6fb0ce: Makefile: Fix error: setting require-dev does not exist or is not supported by… (authored by machniak).
Makefile: Fix error: setting require-dev does not exist or is not supported by…
Nov 6 2024, 3:30 PM
machniak committed R113:89c8fe9ae931: - Fix XSS vulnerability in serving of attachments other than HTML or SVG [CVE… (authored by machniak).
- Fix XSS vulnerability in serving of attachments other than HTML or SVG [CVE…
Nov 6 2024, 3:30 PM
machniak committed R113:602d0f566eb3: Fix information leak (access to remote content) via insufficient CSS filtering… (authored by machniak).
Fix information leak (access to remote content) via insufficient CSS filtering…
Nov 6 2024, 3:30 PM
machniak committed R113:b5ed0e49464e: Fix bug where imap_conn_option's 'socket' was ignored (#9566) (authored by machniak).
Fix bug where imap_conn_option's 'socket' was ignored (#9566)
Nov 6 2024, 3:30 PM
machniak committed R113:68af7c864a36: Fix XSS vulnerability in post-processing of sanitized HTML content [CVE-2024… (authored by machniak).
Fix XSS vulnerability in post-processing of sanitized HTML content [CVE-2024…
Nov 6 2024, 3:30 PM
machniak committed R113:3567090a997e: Fix infinite loop when parsing malformed Sieve script (#9562) (authored by machniak).
Fix infinite loop when parsing malformed Sieve script (#9562)
Nov 6 2024, 3:30 PM
machniak committed R113:c9702be84cdc: Fix merge conflict (authored by machniak).
Fix merge conflict
Nov 6 2024, 3:30 PM
machniak committed R113:c96ff0e811e2: Managesieve: Protect special scripts in managesieve_kolab_master mode (authored by machniak).
Managesieve: Protect special scripts in managesieve_kolab_master mode
Nov 6 2024, 3:30 PM
machniak committed R113:9d9f4d6926e1: Fix bug where an unhandled exception was caused by an invalid image attachment… (authored by machniak).
Fix bug where an unhandled exception was caused by an invalid image attachment…
Nov 6 2024, 3:30 PM
machniak committed R113:f6c92ebafe09: Fix bug where a long subject title could not be displayed in some cases (#9416) (authored by machniak).
Fix bug where a long subject title could not be displayed in some cases (#9416)
Nov 6 2024, 3:30 PM
machniak committed R113:8eb583b499bc: Fix bug where "with attachment" filter could fail on some fts engines (#9514) (authored by machniak).
Fix bug where "with attachment" filter could fail on some fts engines (#9514)
Nov 6 2024, 3:30 PM
machniak committed R113:71804a8c5389: Fix bug where some messages could get malformed in an import from a MBOX file… (authored by machniak).
Fix bug where some messages could get malformed in an import from a MBOX file…
Nov 6 2024, 3:30 PM
machniak committed R113:55447653c5fd: Fix invalid line break characters in multi-line text in Sieve scripts (#9543) (authored by machniak).
Fix invalid line break characters in multi-line text in Sieve scripts (#9543)
Nov 6 2024, 3:30 PM
machniak committed R113:6139544f1b92: Missing polish translation for "keep formatting" (#9493) (authored by KrzysztofWWW <23614799+KrzysztofWWW@users.noreply.github.com>).
Missing polish translation for "keep formatting" (#9493)
Nov 6 2024, 3:30 PM
machniak committed R113:e8e0c6836910: Fix decoding mail parts with multiple base64-encoded text blocks (#9290) (authored by machniak).
Fix decoding mail parts with multiple base64-encoded text blocks (#9290)
Nov 6 2024, 3:30 PM
machniak committed R113:ccf3d8e43fe9: Update changelog (authored by machniak).
Update changelog
Nov 6 2024, 3:30 PM
machniak committed R113:f6a5e758df79: Fix double scrollbar in compose window with big body (#9484, #7760) (authored by Pablo Zmdl <57864086+pabzm@users.noreply.github.com>).
Fix double scrollbar in compose window with big body (#9484, #7760)
Nov 6 2024, 3:30 PM
machniak committed R113:f6bc11f611fd: Update changelog (authored by machniak).
Update changelog
Nov 6 2024, 3:30 PM