Page MenuHomekolab.org

machniak (Aleksander Machniak)
Kolab Systems, Developer

Projects (30)

User Details

User Since
Apr 12 2015, 12:47 PM (370 w, 1 d)

Recent Activity

Thu, May 12

machniak updated the diff for D3563: Shared folders' subfolders support and LMTP address aliases.
  • Fix phpcs error
Thu, May 12, 4:09 PM
machniak requested review of D3563: Shared folders' subfolders support and LMTP address aliases.
Thu, May 12, 4:03 PM

Tue, May 10

machniak updated the diff for D3544: Lists code de-duplication.
  • Fix linting errors
Tue, May 10, 2:59 PM
machniak requested review of D3557: Tabs widget.
Tue, May 10, 2:34 PM

Fri, May 6

machniak updated the diff for D3551: Modal dialog component.
  • Fix regexp again
Fri, May 6, 3:36 PM
machniak updated the diff for D3551: Modal dialog component.
  • Fix regexp
Fri, May 6, 3:19 PM
machniak requested review of D3551: Modal dialog component.
Fri, May 6, 3:16 PM

Wed, May 4

machniak updated the diff for D3544: Lists code de-duplication.
  • More code de-duplication
  • More code de-duplication
  • cols -> columns
Wed, May 4, 9:21 AM

Tue, May 3

machniak requested review of D3544: Lists code de-duplication.
Tue, May 3, 12:52 PM

Mon, May 2

machniak requested review of D3538: Unify resources/domains/shared folders/distlists listing API with the rest.
Mon, May 2, 2:59 PM
machniak updated the diff for D3532: Unify/automate loader element.
  • Move some utility functions to utils.js
Mon, May 2, 1:18 PM
machniak requested review of D3532: Unify/automate loader element.
Mon, May 2, 11:44 AM
machniak committed rK468d1abd3062: Update tests to detect missing payment method icons (authored by machniak).
Update tests to detect missing payment method icons
Mon, May 2, 10:48 AM
machniak committed rK2ba105dd314d: Fix missing icon for the bank transfer method (authored by machniak).
Fix missing icon for the bank transfer method
Mon, May 2, 10:36 AM

Fri, Apr 29

machniak committed rKa870e163c5e0: Lock cash-dom to version 8.1.0 (authored by machniak).
Lock cash-dom to version 8.1.0
Fri, Apr 29, 3:40 PM
machniak committed rKe8dbee9f7cf9: Fix undefined array key error (authored by machniak).
Fix undefined array key error
Fri, Apr 29, 1:03 PM
machniak committed rKcad26b3d41a7: Fix flaky test (authored by machniak).
Fix flaky test
Fri, Apr 29, 1:03 PM
machniak closed D3502: BelongsToUser Trait.
Fri, Apr 29, 12:21 PM
machniak closed D3514: Get rid of vuex.
Fri, Apr 29, 12:21 PM
machniak closed D3520: Meet: Fix releasing media streams, CS fixes.
Fri, Apr 29, 12:21 PM
machniak closed D3526: FontAwesome v6 and refactor the way we include icons.
Fri, Apr 29, 12:21 PM
machniak committed rK5b438a0ea845: Merge branch 'master' into beta-release (authored by machniak).
Merge branch 'master' into beta-release
Fri, Apr 29, 12:20 PM
machniak committed rK352a3753e6bc: FontAwesome v6 and refactor the way we include icons (authored by machniak).
FontAwesome v6 and refactor the way we include icons
Fri, Apr 29, 12:20 PM
machniak committed rK0eac12aabdb2: Meet: Fix releasing media streams, CS fixes (authored by machniak).
Meet: Fix releasing media streams, CS fixes
Fri, Apr 29, 12:20 PM
machniak committed rK4e1f683def10: Get rid of vuex (authored by machniak).
Get rid of vuex
Fri, Apr 29, 12:20 PM
machniak committed rKd708c1341d91: BelongsToUser Trait (authored by machniak).
BelongsToUser Trait
Fri, Apr 29, 12:20 PM
machniak committed rK56a36a1676c3: Meet: Fix releasing media streams, CS fixes (authored by machniak).
Meet: Fix releasing media streams, CS fixes
Fri, Apr 29, 12:20 PM
machniak committed rK962913f9ffc8: Replace anchorme with stringifyjs (authored by machniak).
Replace anchorme with stringifyjs
Fri, Apr 29, 12:05 PM

Thu, Apr 28

machniak updated the diff for D3526: FontAwesome v6 and refactor the way we include icons.
  • Merge branch 'master' into dev/fontawesome-refactor
Thu, Apr 28, 2:39 PM
machniak committed rK088039231454: Axios update (authored by machniak).
Axios update
Thu, Apr 28, 2:19 PM
machniak committed rKf572a193ad70: Fix handling of incomplete files (authored by machniak).
Fix handling of incomplete files
Thu, Apr 28, 2:03 PM
machniak requested review of D3526: FontAwesome v6 and refactor the way we include icons.
Thu, Apr 28, 11:33 AM

Wed, Apr 27

machniak committed rK63cfc93e5c5c: Various client code improvements (authored by machniak).
Various client code improvements
Wed, Apr 27, 3:49 PM
machniak committed rKd3f88442f646: Bump vue-fontawesome version up (authored by machniak).
Bump vue-fontawesome version up
Wed, Apr 27, 12:56 PM
machniak committed rKcfa95a6626a7: Improve companion app icon (authored by machniak).
Improve companion app icon
Wed, Apr 27, 11:14 AM

Tue, Apr 26

machniak committed rKdd7e86d262b4: Improve volume indicator (authored by machniak).
Improve volume indicator
Tue, Apr 26, 2:42 PM
machniak committed rRPK5ef2f4fb67cd: Small css improvement (authored by machniak).
Small css improvement
Tue, Apr 26, 12:05 PM
machniak committed rRPKc28d62df9178: Fix adding resources to new events (authored by machniak).
Fix adding resources to new events
Tue, Apr 26, 12:05 PM
machniak requested review of D3520: Meet: Fix releasing media streams, CS fixes.
Tue, Apr 26, 8:45 AM
machniak requested review of D3514: Get rid of vuex.
Tue, Apr 26, 8:28 AM

Mon, Apr 25

machniak committed rK1860eb38316c: Fix regression in 2FA logon (authored by machniak).
Fix regression in 2FA logon
Mon, Apr 25, 4:46 PM
machniak committed rK7458e77ef8f9: Fix broken submit button label in domain settings form (authored by machniak).
Fix broken submit button label in domain settings form
Mon, Apr 25, 2:35 PM
machniak committed rK15c426efd61c: Meet: Fix releasing media streams, CS fixes (authored by machniak).
Meet: Fix releasing media streams, CS fixes
Mon, Apr 25, 12:19 PM

Fri, Apr 22

machniak requested review of D3502: BelongsToUser Trait.
Fri, Apr 22, 12:33 PM

Thu, Apr 21

machniak committed rK5fa15c94d17d: Don't display "Unauthenticated" when token refresh fails (authored by machniak).
Don't display "Unauthenticated" when token refresh fails
Thu, Apr 21, 3:21 PM
machniak committed rKdf33bf420f7c: Workaround strange bootstrap+cash-dom error (authored by machniak).
Workaround strange bootstrap+cash-dom error
Thu, Apr 21, 2:58 PM
machniak committed rK8a62ff5ce853: Password expiration notification (authored by machniak).
Password expiration notification
Thu, Apr 21, 2:09 PM
machniak closed D3379: Password expiration notification.
Thu, Apr 21, 2:09 PM
machniak updated the diff for D3379: Password expiration notification.
  • Fix test
Thu, Apr 21, 1:55 PM
machniak updated the diff for D3379: Password expiration notification.
  • Merge branch 'master' into dev/password-retention
Thu, Apr 21, 1:44 PM
machniak committed rKc42ea2ecba17: Fix phpstan error (authored by machniak).
Fix phpstan error
Thu, Apr 21, 1:41 PM
machniak committed rK6c7db399d671: Fix error if a file has no 'size' property (authored by machniak).
Fix error if a file has no 'size' property
Thu, Apr 21, 12:40 PM
machniak committed rK80277465afda: Merge branch 'beta-release' of ssh://git.kolab.org/source/kolab into beta… (authored by machniak).
Merge branch 'beta-release' of ssh://git.kolab.org/source/kolab into beta…
Thu, Apr 21, 12:40 PM
machniak committed rK50389d90f3c0: Fix error if a file has no 'size' property (authored by machniak).
Fix error if a file has no 'size' property
Thu, Apr 21, 12:27 PM
machniak updated the diff for D3379: Password expiration notification.
  • Suggested changes
Thu, Apr 21, 10:42 AM
machniak committed rKf81b66d5d752: Create Roundcube user default identity (when creating the user) (authored by machniak).
Create Roundcube user default identity (when creating the user)
Thu, Apr 21, 10:28 AM
machniak closed D3415: Create Roundcube user default identity (when creating the user).
Thu, Apr 21, 10:28 AM
machniak closed D3490: fs:expunge command.

Merged into the beta-release branch.

Thu, Apr 21, 10:27 AM
machniak closed D3496: Update npm dependencies (for beta-release).

Merged into the beta-release branch.

Thu, Apr 21, 10:22 AM
machniak committed rK8e0bd91a7219: Update npm dependencies (for beta-release) (authored by machniak).
Update npm dependencies (for beta-release)
Thu, Apr 21, 10:01 AM

Wed, Apr 20

machniak committed rK1dd9b9c44117: Fix file type detection, don't require it to be working in the existsing tests (authored by machniak).
Fix file type detection, don't require it to be working in the existsing tests
Wed, Apr 20, 3:21 PM
machniak committed rKd3eb188ae136: Fix js/css linting issues (authored by machniak).
Fix js/css linting issues
Wed, Apr 20, 2:16 PM
machniak updated the diff for D3496: Update npm dependencies (for beta-release).
  • Fix Bootstrap's regression - unwanted bold border on tables
Wed, Apr 20, 2:10 PM
machniak committed rKec86a23ebcbd: Use of wss:// vs. ws:// protocol should depend on config.tls, not "local host" (authored by machniak).
Use of wss:// vs. ws:// protocol should depend on config.tls, not "local host"
Wed, Apr 20, 1:33 PM
machniak committed rK28b3a7bb51bb: Fix more test regressions (authored by machniak).
Fix more test regressions
Wed, Apr 20, 1:19 PM
machniak committed rKc71168f23b71: Fix various test regressions (authored by machniak).
Fix various test regressions
Wed, Apr 20, 12:27 PM
machniak requested review of D3496: Update npm dependencies (for beta-release).
Wed, Apr 20, 11:43 AM
machniak committed rK4716c805faf7: Fix phpstan errors (authored by machniak).
Fix phpstan errors
Wed, Apr 20, 10:58 AM
machniak committed rK7804304c25bd: fs:expunge command (authored by machniak).
fs:expunge command
Wed, Apr 20, 10:58 AM

Tue, Apr 19

machniak committed rK29dccc0fe697: Don't use a static variable (authored by machniak).
Don't use a static variable
Tue, Apr 19, 2:40 PM
machniak committed rKf70156095ff1: Merge branch 'beta-release' of ssh://git.kolab.org/source/kolab into beta… (authored by machniak).
Merge branch 'beta-release' of ssh://git.kolab.org/source/kolab into beta…
Tue, Apr 19, 2:27 PM
machniak retitled D3490: fs:expunge command from Remove use of unset mimetype property on files list to fs:expunge command.
Tue, Apr 19, 12:33 PM
machniak requested review of D3490: fs:expunge command.
Tue, Apr 19, 12:25 PM

Apr 15 2022

machniak updated the diff for D3463: [WIP] Files API.
  • Files API schema refactoring
Apr 15 2022, 1:15 PM

Apr 14 2022

machniak added a comment to D3463: [WIP] Files API.
item_id, key = 'share_<share-link-id1>', value = '{"john@kolab.org":"r"}' -- for a regular file

So, how do you search fast by the key if you don't know item_id (which is the index here)? Should we just add an index on the key column alone?

Apr 14 2022, 1:52 PM
machniak added a comment to D3463: [WIP] Files API.
  • If we move file name, size, mimetype to a separate table whenever we want to list/sort/search we have to make join(s) which will make it slow, and I'd say listing/searching by these three attributes is essential. A simplest listing needs to return at least the file size, name and mimetype, this makes this basic query much complicated/slower.

The assumption is that most if not all "lists" of "files" do not contain a column for the attributes such as size, mtime nor mimetype, let alone allow for "sorting by".

Apr 14 2022, 10:27 AM
machniak added a comment to D3463: [WIP] Files API.
  • If we move file name, size, mimetype to a separate table whenever we want to list/sort/search we have to make join(s) which will make it slow, and I'd say listing/searching by these three attributes is essential. A simplest listing needs to return at least the file size, name and mimetype, this makes this basic query much complicated/slower.
  • If we wanted to re-use the existing SettingsTrait the table name would have to be fs_file_settings, or you insist on "attributes"?
  • If we move permissions to settings/attributes then a "search by share id" query will be very slow, as it will be a non-indexed query on a big table. Therefore I'd keep the fs_permissions table as is.
  • App\Handlers\Beta\Files is there for a reason, it extends App\Handlers\Beta\Base class, but I guess I can move it to App\Handlers\Files. Note: that we still have Distlists, Resources, SharedFolders under \Beta, so it would not be consistent.
  • I understand fs_chunks needs a sequence column, but what's wrong with the incremented id? Ok, I guess with a generated id we can make it more performant, because we don't need to make an INSERT first. I.e. we'd generate chunk-id, save the chunk-file, then insert. Do you want to make the chunk id unique/primary key?
  • @mollekopf, the file_id + sequence is not unique enough, there might be more than one deleted record with the same file_id + sequence combination. Especially considering file updates and partial uploads. SO, I see a reason to have an extra id for the chunk filename.
Apr 14 2022, 9:09 AM

Apr 12 2022

machniak updated the diff for D3463: [WIP] Files API.
  • Make max chunk size depend on SWOOLE_PACKAGE_MAX_LENGTH option
Apr 12 2022, 10:15 AM

Apr 11 2022

machniak updated the diff for D3463: [WIP] Files API.
  • Store files in chunks (don't concatenate), some refactorings
Apr 11 2022, 3:53 PM

Apr 8 2022

machniak updated the diff for D3463: [WIP] Files API.
  • Storage error handling
Apr 8 2022, 3:30 PM
machniak updated the diff for D3463: [WIP] Files API.
  • File upload/download via unauth API location
  • File update API
  • Files API schema/implementation refactor (slim-down)
Apr 8 2022, 1:57 PM

Mar 30 2022

machniak added a comment to D3463: [WIP] Files API.

Ok, so the current schema does not cover folders and sharing of folders. I have a simple solution for that:

--- a/src/database/migrations/2022_03_02_100000_create_filesystem_tables.php
+++ b/src/database/migrations/2022_03_02_100000_create_filesystem_tables.php
@@ -30,6 +30,7 @@ function (Blueprint $table) {
             function (Blueprint $table) {
                 $table->string('id', 36)->primary();
                 $table->string('library_id', 36);
+                $table->string('parent_id', 36)->nullable()->index(); // parent folder identifier
                 $table->string('name', 512);
                 $table->bigInteger('size')->unsigned()->default(0);
                 $table->string('mimetype');
Mar 30 2022, 12:04 PM

Mar 21 2022

machniak added a comment to D3463: [WIP] Files API.

@mollekopf I just added the sharing feature. What do you think about this now?

Mar 21 2022, 2:09 PM
machniak updated the diff for D3463: [WIP] Files API.
  • Add missing FilePermission model
Mar 21 2022, 2:08 PM
machniak updated the diff for D3463: [WIP] Files API.
  • Fix sharing
Mar 21 2022, 2:06 PM

Mar 15 2022

machniak requested review of D3463: [WIP] Files API.
Mar 15 2022, 12:12 PM

Mar 11 2022

machniak updated the diff for D3409: Laravel v9.
  • The daemonize option does not work
  • Min processes must be >0
  • Fixed swoole container
Mar 11 2022, 3:12 PM
machniak requested review of D3415: Create Roundcube user default identity (when creating the user).
Mar 11 2022, 2:33 PM

Mar 10 2022

machniak updated the diff for D3409: Laravel v9.
  • Fix swoole configuration
Mar 10 2022, 11:46 AM
machniak updated the diff for D3409: Laravel v9.
  • Update swoole container with php8/fedora35/swoole 4.8
  • Update the nginx containers to fedora 35 while we're at it
  • Daemonize octane, .env.local -> .env.local.example
  • Explicit octane config
Mar 10 2022, 10:20 AM

Mar 3 2022

machniak committed rKc31d0ffbc453: Use "your logo here" logos in the default theme (authored by machniak).
Use "your logo here" logos in the default theme
Mar 3 2022, 12:11 PM

Feb 28 2022

machniak committed rKd99b8fa47e03: Add Swoole config section to config/octane.php (authored by machniak).
Add Swoole config section to config/octane.php
Feb 28 2022, 12:15 PM
machniak updated the diff for D3409: Laravel v9.
  • Add Swoole config section to config/octane.php
Feb 28 2022, 11:59 AM

Feb 24 2022

machniak committed rK34bf24df4449: Update spomky-labs/otphp package for better PHP 8.1 support (authored by machniak).
Update spomky-labs/otphp package for better PHP 8.1 support
Feb 24 2022, 2:47 PM
machniak committed rK3e39addd4b91: Fix typo in phpdoc (authored by machniak).
Fix typo in phpdoc
Feb 24 2022, 2:47 PM
machniak committed rKf48a28151395: Cleanup and use of new Eloquent features (authored by machniak).
Cleanup and use of new Eloquent features
Feb 24 2022, 2:47 PM
machniak updated the diff for D3409: Laravel v9.
  • Update spomky-labs/otphp package for better PHP 8.1 support
Feb 24 2022, 2:46 PM
machniak abandoned D3397: Laravel v9.

Close in favour of D3409

Feb 24 2022, 11:51 AM
machniak updated the diff for D3409: Laravel v9.
  • Fix typo in phpdoc
Feb 24 2022, 11:51 AM
machniak requested review of D3409: Laravel v9.
Feb 24 2022, 11:47 AM