• Generate a keypair for new alias
• Unregister keys on alias delete

• Disable jsnlog's error handlers added in OpenVidu 2.18

• Add test for localization in getWalletNotice()

Merged into dev/reseller.

• Simplify again

• Simplify/Unify

• Couple of fixes, tenant-condition for wallets

To sum up the current state:

1. All tests pass!
2. Tokens refresh request is fast now, but /auth/login is still 0.3-0.4 sec. I didn't investigate how much of that is passport.
3. We should probably add some code to Kernel as in https://laravel.com/docs/6.x/passport#purging-tokens
4. @vanmeeuwen, should take a look at this regarding deployment of the oauth keys and client secret (and ./artisan passport:keys --force) - we need the same keys on every Kolab4 host.

On the other hand, maybe %dms format would be better for query time.

• Add exportPublicKey() use

• Use Laravel's Storage functionality

• Switch new keypair algorithms to RSA

I did another run of tests and got the same result as above. I.e. I run vendor/bin/phpunit tests/Browser/Admin twice on master and all is green. Then I run the same on this diff and I got three tests failing. Looks like the problem is with refreshing the token. I see this in console dump:

https:\/\/admin.alec.dev.kolab.io\/api\/auth\/info?refresh=1 - Failed to load resource: the server responded with a status of 401 ()

I see C: POST https://admin.alec.dev.kolab.io/api/auth/info?refresh=1 [5M]: 0.0055 sec in the log and this is strange because it's too fast and there are no sql queries for this request logged.

phpstan errors:

Line   app/Http/Controllers/API/AuthController.php                  
------ ------------------------------------------------------------- 
 157    Access to an undefined property object::$error_description.  
------ -------------------------------------------------------------

Merged into dev/reseller

• Add tests
• Debit reseller's wallet on user deletion (for the negative balance value)
• Credit/debit reseller's wallet on Penalize/Award action

• Migration fixes, tests fixes, added some simple tests

Rebase

Rebase

Merged into dev/reseller.

1. See inline comments
2. When logging into the user UI I see this in the log:

[2021-05-04 09:27:08] local.DEBUG: [SQL] select * from `oauth_clients` where `id` = ? limit 1 [array (
  0 => '1',
)]
[2021-05-04 09:27:08] local.DEBUG: [SQL] select * from `oauth_clients` where `id` = ? limit 1 [array (
  0 => '1',
)]

I.e. a duplicated query. Would be good to investigate why it is done twice.

3. Token refresh does not work. A scenario:
   • set token_expiry_minutes = 1 minute,
   • log in to the UI, and wait a minute,
   • you'll see that the refresh request returns 401 Unauthorized.
   • in log: The resource owner or authorization server denied the request. {"exception":"[object] (League\\OAuth2\\Server\\Exception\\OAuthServerException(code: 9): The resource owner or authorization server denied the request. at /home/alec/repos/kolab/src/vendor/league/oauth2-server/src/Exception/OAuthServerException.php:243).
   • I guess you just have to add refresh_token to the request in line 166 of app.js.
4. When runing Feature suite tests I got 3 errors:

1) Tests\Feature\Controller\PasswordResetTest::testPasswordResetValidInput
ErrorException: Undefined property: stdClass::$access_token
2) Tests\Feature\Controller\SignupTest::testSignupValidInput
ErrorException: Undefined property: stdClass::$access_token
3) Tests\Feature\Controller\SignupTest::testSignupGroupAccount
ErrorException: Undefined property: stdClass::$access_token

5. Look like a few browser test failures are also related to Undefined property: stdClass::$access_token.
6. We should think how deploy encryption keys across multiple hosts.
7. Could https://github.com/laravel/passport/issues/379 be a problem for us in any way considering our future use of Passport?

Merged into dev/reseller.

@mollekopf Ready for the final review.

• Add wording for the invitation email

Fix

• Don't process csv if any email address is invalid
• Cleanup

• Small css improvements to the page menu

• Store user language in a cookie, always load English
• Small code cleanup
• Update tests
• Small linting fixes
• Browser test for the language selector

• Rebase
• Improve language selector
• Store UI localization in php file
• Remove unused Laravel localization files

Rebase

Just code review. I didn't look closer to this yet.

I don't like that output format. How did you get to the problem? Maybe you should use Carbon objects instead.