Page MenuHomePhorge

machniak (Aleksander Machniak)
Kolab Systems, Developer

Projects (32)

User Details

User Since
Apr 12 2015, 12:47 PM (484 w, 5 d)

Recent Activity

Thu, Jul 25

machniak added a comment to D4854: First attempt to get oauth going.

BTW, I noted that some of your differentials cannot be easily used. arc patch returns "Base commit is not in local repository". Then I get:

Checking patch docker/synapse/rootfs/opt/app-root/src/init.sh...
error: docker/synapse/rootfs/opt/app-root/src/init.sh: does not exist in index
Checking patch docker/synapse/rootfs/opt/app-root/src/homeserver.yaml...
error: docker/synapse/rootfs/opt/app-root/src/homeserver.yaml: does not exist in index
Checking patch docker/synapse/Dockerfile...
error: docker/synapse/Dockerfile: does not exist in index
Checking patch config.prod/src/database/seeds/PassportSeeder.php...
Checking patch config.demo/src/database/seeds/PassportSeeder.php...
Checking patch ci/testctl...
Hunk #1 succeeded at 111 (offset -1 lines).
Checking patch ci/env...
error: while searching for:
MEET_SERVER_TOKEN=simple123
PASSPORT_PROXY_OAUTH_CLIENT_ID=5909ca4f-df7e-45fe-b355-e7c195aef117
PASSPORT_PROXY_OAUTH_CLIENT_SECRET=3URb+3JGJM9wPuDnlUSTPOw2mqmHsoOV8NXanx9xwQM=
DES_KEY=kBxUM/53N9p9abusAoT0ZEAxwI2pxFz/
Thu, Jul 25, 10:09 AM · Restricted Project
machniak added a comment to D4854: First attempt to get oauth going.

I'm going to write tests.

Thu, Jul 25, 9:09 AM · Restricted Project

Wed, Jul 24

machniak committed rKda8e4454bfca: Data Migrator: Close IMAP connections cleanly (authored by machniak).
Data Migrator: Close IMAP connections cleanly
Wed, Jul 24, 1:56 PM
machniak requested review of D4863: Fix and unify checks for SoftDeletes capability on a model.
Wed, Jul 24, 1:56 PM

Tue, Jul 23

machniak committed rIacf0426c4739: Fix size=0 for uploaded files (authored by machniak).
Fix size=0 for uploaded files
Tue, Jul 23, 12:00 PM
machniak committed rI61e111c478ca: Fix PHP8 warning (authored by machniak).
Fix PHP8 warning
Tue, Jul 23, 12:00 PM
machniak committed rCa1b82ce077f6: Fix PHP8 warnings (authored by machniak).
Fix PHP8 warnings
Tue, Jul 23, 11:53 AM
machniak committed rRPK102847604da5: Fix PHP8 warnings (authored by machniak).
Fix PHP8 warnings
Tue, Jul 23, 11:25 AM

Mon, Jul 22

machniak requested review of D4860: MariaDB compatibility fix.
Mon, Jul 22, 3:16 PM
machniak committed rS8bae1357be24: Small CS fixes (authored by machniak).
Small CS fixes
Mon, Jul 22, 2:50 PM
machniak committed rKfed7b8267e6d: Data Migrator: Cleanup jobs code (authored by machniak).
Data Migrator: Cleanup jobs code
Mon, Jul 22, 1:21 PM
machniak closed D4857: Data Migrator: Improvements and tests.
Mon, Jul 22, 11:50 AM
machniak committed rKa1f0d888441d: Data Migrator: Improvements and tests (authored by machniak).
Data Migrator: Improvements and tests
Mon, Jul 22, 11:50 AM
machniak updated the diff for D4857: Data Migrator: Improvements and tests.
  • Better const name
Mon, Jul 22, 11:48 AM
machniak requested review of D4857: Data Migrator: Improvements and tests.
Mon, Jul 22, 11:46 AM

Wed, Jul 17

machniak committed rKd3f874dd159b: EWS: Put X-MS-ID in the main VEVENT block (authored by machniak).
EWS: Put X-MS-ID in the main VEVENT block
Wed, Jul 17, 2:41 PM
machniak committed rK5ce1c2d1b78a: Fix test regression (authored by machniak).
Fix test regression
Wed, Jul 17, 1:24 PM
machniak committed rK76d38b70c9c8: Fix flaky test (authored by machniak).
Fix flaky test
Wed, Jul 17, 1:04 PM
machniak committed rK3b14529b0c25: Fix code style and small regression (authored by machniak).
Fix code style and small regression
Wed, Jul 17, 12:11 PM
machniak closed D4848: IMAP/DAV/EWS migrator improvements and tests.
Wed, Jul 17, 11:42 AM
machniak committed rK50f6240db029: Cleanup (authored by machniak).
Cleanup
Wed, Jul 17, 11:42 AM
machniak committed rKfdb35bdfc18c: EWS: Improve distlist members handling (authored by machniak).
EWS: Improve distlist members handling
Wed, Jul 17, 11:42 AM
machniak committed rK642b4d497828: IMAP/DAV/EWS migrator improvements and tests (authored by machniak).
IMAP/DAV/EWS migrator improvements and tests
Wed, Jul 17, 11:42 AM

Tue, Jul 16

machniak updated the diff for D4848: IMAP/DAV/EWS migrator improvements and tests.
  • EWS: Fix some contact properties in exported vCard
  • EWS: Fix lists handling
  • EWS: Improved tasks handling
Tue, Jul 16, 4:26 PM

Mon, Jul 15

machniak added a comment to D4851: Attempted to support bcc via eas 16.0.

Nope. If you do this the header will be send to every recipient. Note that we're unsetting the header in $smtp_headers only here. The copy of the message saved to Sent folder should contain Bcc header intact.

Mon, Jul 15, 3:38 PM
machniak closed T8382: Debian12: warning in kolab-webadmin as Resolved.

Thanks. Fixed.

Mon, Jul 15, 1:06 PM · Bug Reports
machniak committed rWAP0bbdc61c53b3: Fix PHP deprecation warning (T8382) (authored by machniak).
Fix PHP deprecation warning (T8382)
Mon, Jul 15, 1:06 PM
machniak requested review of D4848: IMAP/DAV/EWS migrator improvements and tests.
Mon, Jul 15, 12:48 PM

Mon, Jul 8

machniak closed D4842: Sync Calendars first.
Mon, Jul 8, 3:35 PM
machniak committed rS75a0b664346f: Sync Calendars first (authored by machniak).
Sync Calendars first
Mon, Jul 8, 3:35 PM
machniak closed D4845: IMAP data migrator and other improvements.
Mon, Jul 8, 8:12 AM
machniak committed rK21d3bcab8719: IMAP data migrator and other improvements (authored by machniak).
IMAP data migrator and other improvements
Mon, Jul 8, 8:12 AM

Sun, Jul 7

machniak added a comment to D4827: IMAP and DAV migration.

In D4845: IMAP data migrator and other improvements I took this differential of yours, but I re-implemented some things differently. I think it's cleaner. Still a lot of TODO lines there. So, we might improve while writing tests. I have also an idea to try to do mail streaming for best performance.

Sun, Jul 7, 10:18 AM
machniak requested review of D4845: IMAP data migrator and other improvements.
Sun, Jul 7, 10:11 AM

Fri, Jul 5

machniak added a comment to D4839: Ignore iTip parsing errors when synchronizing mail.

Throwable catches that fatal error. Now looking at this I found that we could change the catch in https://git.kolab.org/diffusion/RPK/browse/master/plugins/libcalendaring/lib/libcalendaring_vcalendar.php$158

Fri, Jul 5, 12:00 PM
machniak updated the diff for D4842: Sync Calendars first.
  • It's a debug not a warning
Fri, Jul 5, 11:48 AM
machniak updated the diff for D4842: Sync Calendars first.
  • Move sorting to later place
Fri, Jul 5, 11:47 AM
machniak updated the diff for D4842: Sync Calendars first.
  • Fix sorting callback
Fri, Jul 5, 11:03 AM
machniak updated the diff for D4842: Sync Calendars first.
  • Fix sign
Fri, Jul 5, 10:25 AM
machniak requested review of D4842: Sync Calendars first.
Fri, Jul 5, 10:15 AM

Thu, Jul 4

machniak closed D4836: Incremental migration EWS -> DAV.
Thu, Jul 4, 3:07 PM
machniak committed rK4de395e830c9: Incremental migration EWS -> DAV (authored by machniak).
Incremental migration EWS -> DAV
Thu, Jul 4, 3:07 PM
machniak added a comment to D4839: Ignore iTip parsing errors when synchronizing mail.

Indeed. I just noticed that the actual error wasn't an exception. It was `PHP Fatal error: Uncaught Error: __clone method called on non-object in /usr/share/roundcubemail/plugins/libcalendaring/lib
/libcalendaring_vcalendar.php:633`, so to catch it we'd have to catch Throwable, I suppose, I'm not sure.

Thu, Jul 4, 1:51 PM
machniak closed D4818: Send QR-code content also plain text.
Thu, Jul 4, 12:28 PM
machniak closed D4821: Use Laravel HTTP client in CompanionApp.
Thu, Jul 4, 12:28 PM
machniak committed rK3407cd0a8367: Use Laravel HTTP client in CompanionApp (authored by machniak).
Use Laravel HTTP client in CompanionApp
Thu, Jul 4, 12:28 PM
machniak committed rK356c7abbf687: Send QR-code content also plain text (authored by machniak).
Send QR-code content also plain text
Thu, Jul 4, 12:28 PM
machniak updated the diff for D4839: Ignore iTip parsing errors when synchronizing mail.
  • phpdoc
Thu, Jul 4, 12:27 PM
machniak requested review of D4839: Ignore iTip parsing errors when synchronizing mail.
Thu, Jul 4, 12:19 PM
machniak closed D4830: Add --tenant option where needed.
Thu, Jul 4, 11:59 AM
machniak closed D4833: Use Laravel HTTP client for Meet connections.
Thu, Jul 4, 11:59 AM
machniak committed rKf774cc5f8fb9: Use Laravel HTTP client for Meet connections (authored by machniak).
Use Laravel HTTP client for Meet connections
Thu, Jul 4, 11:59 AM
machniak committed rK870e7b0d2ebf: Add --tenant option where needed (authored by machniak).
Add --tenant option where needed
Thu, Jul 4, 11:59 AM
machniak updated the diff for D4836: Incremental migration EWS -> DAV.
  • Missing DAV/Search
Thu, Jul 4, 11:52 AM
machniak requested review of D4836: Incremental migration EWS -> DAV.
Thu, Jul 4, 11:51 AM

Wed, Jul 3

machniak added a comment to D4827: IMAP and DAV migration.

Good progress, but I was about to work on DAV, and I already have some conflicting code. Please, don't work on DAV at this moment.

Wed, Jul 3, 6:25 PM
machniak added a comment to T8376: Debian 11: warning in /usr/share/php/HTTP/Request2.php.

Short term, we should update the php-http-request2 package. 2.6.0 supports PHP >= 5.6 still, so there's no issue with that.

Wed, Jul 3, 9:59 AM · Bug Reports
machniak requested review of D4833: Use Laravel HTTP client for Meet connections.
Wed, Jul 3, 9:28 AM

Tue, Jul 2

machniak committed rRPK398c3120e83d: Add missing test file (authored by machniak).
Add missing test file
Tue, Jul 2, 12:25 PM
machniak committed rRPK8f88b4b12086: Fix fatal error when parsing VEVENT without DTSTART (authored by machniak).
Fix fatal error when parsing VEVENT without DTSTART
Tue, Jul 2, 12:22 PM
machniak committed rRPK1345402bb9ec: Fix tests using Roundcube master (authored by machniak).
Fix tests using Roundcube master
Tue, Jul 2, 11:56 AM
machniak closed D4824: Data migration tool.
Tue, Jul 2, 11:20 AM
machniak committed rKfd6cc6b72094: Data migration tool (authored by machniak).
Data migration tool
Tue, Jul 2, 11:20 AM
machniak requested review of D4830: Add --tenant option where needed.
Tue, Jul 2, 11:14 AM

Mon, Jul 1

machniak added inline comments to D4827: IMAP and DAV migration.
Mon, Jul 1, 6:03 PM
machniak added inline comments to D4824: Data migration tool.
Mon, Jul 1, 1:05 PM
machniak committed rK7fddf799e548: Fix a couple of PHPCS issues (authored by machniak).
Fix a couple of PHPCS issues
Mon, Jul 1, 12:08 PM
machniak requested review of D4824: Data migration tool.
Mon, Jul 1, 11:31 AM

Fri, Jun 28

machniak updated the diff for D4659: [WIP] Init default DAV folders.
  • Merge branch 'master' into dev/dav-folders-init
Fri, Jun 28, 8:21 AM
machniak committed rKfd9c8076be1c: Add folder management methods to the DAV client (authored by machniak).
Add folder management methods to the DAV client
Fri, Jun 28, 8:13 AM
machniak updated the diff for D4821: Use Laravel HTTP client in CompanionApp.
  • Small improvements
Fri, Jun 28, 8:05 AM
machniak updated the diff for D4821: Use Laravel HTTP client in CompanionApp.
  • Fix case
Fri, Jun 28, 8:02 AM
machniak updated the diff for D4821: Use Laravel HTTP client in CompanionApp.
  • Remove unused $response variable
Fri, Jun 28, 8:00 AM
machniak requested review of D4821: Use Laravel HTTP client in CompanionApp.
Fri, Jun 28, 7:59 AM

Thu, Jun 27

machniak requested review of D4818: Send QR-code content also plain text.
Thu, Jun 27, 6:24 PM
machniak requested changes to D4815: Add the list to the admin panel as well.
Thu, Jun 27, 12:57 PM

Jun 26 2024

machniak committed rK702d39673002: Re-fix the test (authored by machniak).
Re-fix the test
Jun 26 2024, 2:30 PM
machniak committed rKdd670e2c881a: Fix phpstan errors (authored by machniak).
Fix phpstan errors
Jun 26 2024, 2:26 PM
machniak committed rK382264bb3fdd: Fix tenant option in data:import:signup-tokens command (authored by machniak).
Fix tenant option in data:import:signup-tokens command
Jun 26 2024, 2:26 PM
machniak added inline comments to D4812: Limit profit by wallet balance.
Jun 26 2024, 10:34 AM

Jun 25 2024

machniak added inline comments to D4812: Limit profit by wallet balance.
Jun 25 2024, 11:36 AM

Jun 24 2024

machniak closed D4701: Fix error on arabic date input.
Jun 24 2024, 5:41 PM
machniak committed rS7dd6f93097e8: Fix error on arabic date input (authored by machniak).
Fix error on arabic date input
Jun 24 2024, 5:41 PM
machniak closed D4794: Fold WalletCharge and WalletCheck into one.
Jun 24 2024, 2:54 PM
machniak committed rK9f8438a620f3: Fold WalletCharge and WalletCheck into one (authored by machniak).
Fold WalletCharge and WalletCheck into one
Jun 24 2024, 2:54 PM
machniak closed D4797: Rename/move CLI command files to unify.
Jun 24 2024, 2:50 PM
machniak committed rK10af84405e78: Rename/move CLI command files to unify (authored by machniak).
Rename/move CLI command files to unify
Jun 24 2024, 2:50 PM

Jun 21 2024

machniak requested changes to D4809: Turn the Receipt download into a ReceiptList.

Almost there. tests/Browser/WalletTest.php needs an update too.

Jun 21 2024, 1:20 PM

Jun 20 2024

machniak updated the diff for D4803: WIP: Server Side Events.
  • Workaround KTOR client bug, add development commands to send push notifications
Jun 20 2024, 6:32 PM

Jun 19 2024

machniak committed rK69685d461baf: CS fixes (authored by machniak).
CS fixes
Jun 19 2024, 3:28 PM
machniak requested review of D4803: WIP: Server Side Events.
Jun 19 2024, 3:23 PM
machniak added a comment to T8373: kolab undelete-mailbox doesn't work.

Maybe something like this:

--- a/cyruslib.py
+++ b/cyruslib.py
@@ -885,6 +885,7 @@ class CYRUS:
             annotation = annotation.strip()
             tokens = tokenize(annotation)
             folder = tokens[0]
+            mailbox = ensure_binary(mailbox)
Jun 19 2024, 2:10 PM · Bug Reports

Jun 17 2024

machniak requested review of D4797: Rename/move CLI command files to unify.
Jun 17 2024, 2:24 PM
machniak added a comment to D4725: Fold WalletCharge and WalletCheck into one.

See my take in D4794: Fold WalletCharge and WalletCheck into one

Jun 17 2024, 12:28 PM
machniak requested review of D4794: Fold WalletCharge and WalletCheck into one.
Jun 17 2024, 12:22 PM

Jun 14 2024

machniak closed D4791: Add tenant context to signup codes.
Jun 14 2024, 1:03 PM
machniak committed rK7bc96d52393c: Add tenant context to signup codes (authored by machniak).
Add tenant context to signup codes
Jun 14 2024, 1:03 PM
machniak closed D4752: Make CLI commands tenant independent.
Jun 14 2024, 1:02 PM
machniak committed rK19a6ff6ffdcf: Make CLI commands tenant independent (authored by machniak).
Make CLI commands tenant independent
Jun 14 2024, 1:02 PM
machniak closed D4716: Password tokens for user proxy authentication.
Jun 14 2024, 1:02 PM