Page MenuHomekolab.org

machniak (Aleksander Machniak)
Kolab Systems, Developer

Projects (30)

User Details

User Since
Apr 12 2015, 12:47 PM (313 w, 3 d)

Recent Activity

Yesterday

machniak added a comment to D2470: [Meet] Fix video elements sizing bug.

The main cause for the issue is the chat element that uses width: 30%, which causes the screen to be split not evenly (sometimes with 0.5px difference). offsetWidth is always rounded up to full pixels. So, when you divide that (0.5px bigger than in reality) width by the number of columns the sum of widthts of the participant boxes will be bigger than the real width of the container.

Wed, Apr 14, 6:17 PM
machniak committed rK1335d6cf57ce: Remove dead code (authored by machniak).
Remove dead code
Wed, Apr 14, 2:32 PM
machniak requested review of D2470: [Meet] Fix video elements sizing bug.
Wed, Apr 14, 2:29 PM
machniak requested review of D2464: Fix wallet notice precision.
Wed, Apr 14, 12:02 PM

Tue, Apr 13

machniak requested review of D2458: Reseller Stats UI.
Tue, Apr 13, 3:57 PM
machniak committed rRPK6204b43186e3: Fix compatibility with PHP 5.4 (authored by machniak).
Fix compatibility with PHP 5.4
Tue, Apr 13, 8:43 AM

Mon, Apr 12

machniak requested review of D2452: [WIP] Tenant scope for CLI commands.
Mon, Apr 12, 3:06 PM

Fri, Apr 9

machniak requested review of D2446: Reseller comissioning system.
Fri, Apr 9, 2:03 PM
machniak requested review of D2440: Remove "ON UPDATE" from expires_at column.
Fri, Apr 9, 9:34 AM

Thu, Apr 8

machniak committed rK0b12e0a6b939: Make doctrine/dbal a production requirement (authored by machniak).
Make doctrine/dbal a production requirement
Thu, Apr 8, 3:36 PM
machniak committed rK5935a9df4fe8: Store request headers with signup codes (authored by machniak).
Store request headers with signup codes
Thu, Apr 8, 3:13 PM
machniak requested changes to D1954: ux cleanup. move 'delete account' button to the top.

Browser tests need to be updated.

Thu, Apr 8, 12:45 PM
machniak committed rK208e09e04570: Remove unused EntitlementsController (authored by machniak).
Remove unused EntitlementsController
Thu, Apr 8, 12:41 PM
machniak committed rK8ac7ed94dad1: Reseller UI basics completed, with tests (authored by machniak).
Reseller UI basics completed, with tests
Thu, Apr 8, 12:41 PM

Wed, Apr 7

machniak committed rK607ee93e88e7: Reseller: Domains and Discounts controller (authored by machniak).
Reseller: Domains and Discounts controller
Wed, Apr 7, 10:37 AM

Tue, Apr 6

machniak updated the diff for D2422: Signup code refactoring.
  • Add reverse migration, document more SignupCode properties
Tue, Apr 6, 12:50 PM
machniak accepted D2383: Convert to foreign currencies using openexchangerates.org.

I was expecting a single whitelist. We don't really need two, do we?

Tue, Apr 6, 11:56 AM
machniak requested changes to D2137: add charge period to transactions.
Tue, Apr 6, 9:16 AM

Fri, Apr 2

machniak updated the diff for D2428: Signup Invitations.
  • Fix
Fri, Apr 2, 12:05 PM
machniak updated the diff for D2428: Signup Invitations.
  • Cleanup
Fri, Apr 2, 12:04 PM
machniak requested review of D2428: Signup Invitations.
Fri, Apr 2, 10:16 AM

Wed, Mar 31

machniak planned changes to D2422: Signup code refactoring.
Wed, Mar 31, 10:07 AM

Fri, Mar 26

machniak committed rKc4bd4ead4b10: Make User::canRead() work with resellers (authored by machniak).
Make User::canRead() work with resellers
Fri, Mar 26, 9:41 AM

Thu, Mar 25

machniak updated the diff for D2422: Signup code refactoring.
  • Simplify
Thu, Mar 25, 4:21 PM
machniak retitled D2422: Signup code refactoring from Throttling signups using an IP address to Signup code refactoring.
Thu, Mar 25, 4:15 PM
machniak updated the diff for D2422: Signup code refactoring.
  • Replace pack() with hex2bin()
  • SignupCode refactor
Thu, Mar 25, 4:15 PM
machniak requested review of D2422: Signup code refactoring.
Thu, Mar 25, 10:00 AM
machniak requested changes to D2383: Convert to foreign currencies using openexchangerates.org.
Thu, Mar 25, 9:24 AM

Wed, Mar 24

machniak committed rK9617696a57c1: Reseller: Access to users/domains in UI (authored by machniak).
Reseller: Access to users/domains in UI
Wed, Mar 24, 3:17 PM
machniak accepted D2239: New Payment dialog structure.
Wed, Mar 24, 1:43 PM
machniak committed rK6cfac91269ca: Re-add lost withEnvTenant() and withUserTenant() macros (authored by machniak).
Re-add lost withEnvTenant() and withUserTenant() macros
Wed, Mar 24, 1:07 PM
machniak committed rK4af1eef6dd8e: Merge branch 'dev/reseller' of ssh://git.kolab.org/source/kolab into… (authored by machniak).
Merge branch 'dev/reseller' of ssh://git.kolab.org/source/kolab into…
Wed, Mar 24, 12:06 PM
machniak committed rK114fa81adeeb: Fix rebase regressions (authored by machniak).
Fix rebase regressions
Wed, Mar 24, 12:06 PM
machniak committed rK6389c0784186: Remove redundant code that sets tenant_id on signup (authored by machniak).
Remove redundant code that sets tenant_id on signup
Wed, Mar 24, 12:06 PM
machniak committed rK527617296431: Fix error found by phpstan (authored by machniak).
Fix error found by phpstan
Wed, Mar 24, 12:06 PM
machniak committed rK792299bd1512: withEnvTenant and withUserTenant macros (authored by machniak).
withEnvTenant and withUserTenant macros
Wed, Mar 24, 12:06 PM
machniak committed rKd5d6073547eb: Update ObjectDelete and ObjectUpdate commands, and move the dangerous test to… (authored by vanmeeuwen).
Update ObjectDelete and ObjectUpdate commands, and move the dangerous test to…
Wed, Mar 24, 12:06 PM
machniak committed rK538aa48b53c7: These are just completely not needed, since there are no direct effects to… (authored by vanmeeuwen).
These are just completely not needed, since there are no direct effects to…
Wed, Mar 24, 12:06 PM
machniak committed rK719f30bcea4d: Transfer commit (authored by vanmeeuwen).
Transfer commit
Wed, Mar 24, 12:06 PM
machniak committed rK84c22530a67d: scalpel:discount:merge -> discount:merge (authored by vanmeeuwen).
scalpel:discount:merge -> discount:merge
Wed, Mar 24, 12:06 PM
machniak committed rK27c01203e01c: More complete commands, show-case dangerous delete command in scalpel (authored by vanmeeuwen).
More complete commands, show-case dangerous delete command in scalpel
Wed, Mar 24, 12:06 PM
machniak committed rK64d27ce00896: Some additional command logic (authored by vanmeeuwen).
Some additional command logic
Wed, Mar 24, 12:06 PM
machniak committed rK75be665b70c7: Revert "Add degraded status to user:status command" (authored by machniak).
Revert "Add degraded status to user:status command"
Wed, Mar 24, 12:06 PM
machniak added a reverting change for rKc441d3ca2090: Add degraded status to user:status command: rK75be665b70c7: Revert "Add degraded status to user:status command".
Wed, Mar 24, 12:06 PM
machniak committed rK885509af3077: Add degraded status to user:status command (authored by machniak).
Add degraded status to user:status command
Wed, Mar 24, 12:06 PM
machniak committed rKf29193ac9e00: Add some reseller tests (authored by machniak).
Add some reseller tests
Wed, Mar 24, 12:06 PM
machniak committed rK515f066c5090: Reseller app engine (authored by machniak).
Reseller app engine
Wed, Mar 24, 12:06 PM
machniak committed rKd751b400bd72: More changes for the work in progress (authored by vanmeeuwen).
More changes for the work in progress
Wed, Mar 24, 12:06 PM
machniak committed rKc39bcc2cf670: Rebase on master (authored by vanmeeuwen).
Rebase on master
Wed, Mar 24, 12:06 PM
machniak committed rKd70ff989c5fc: Make Reseller/UsersController more complete (authored by machniak).
Make Reseller/UsersController more complete
Wed, Mar 24, 12:06 PM
machniak committed rK0880a58061ee: Remove redundant code that sets tenant_id on signup (authored by machniak).
Remove redundant code that sets tenant_id on signup
Wed, Mar 24, 12:06 PM
machniak committed rKbead23e3acef: Add a domain that is for the other tenant (authored by vanmeeuwen).
Add a domain that is for the other tenant
Wed, Mar 24, 12:06 PM
machniak committed rKd1efae7b8acd: Fix error found by phpstan (authored by machniak).
Fix error found by phpstan
Wed, Mar 24, 12:06 PM
machniak committed rKd56a728c84ea: Fix discounts command test (authored by machniak).
Fix discounts command test
Wed, Mar 24, 12:06 PM
machniak committed rKa87b08b55ee6: withEnvTenant and withUserTenant macros (authored by machniak).
withEnvTenant and withUserTenant macros
Wed, Mar 24, 12:06 PM
machniak committed rKa9e9b6ace234: domain:add -> domain:create, update observer to handle restore() (authored by vanmeeuwen).
domain:add -> domain:create, update observer to handle restore()
Wed, Mar 24, 12:06 PM
machniak committed rK27720581f54f: This is in effect an abstract class (authored by vanmeeuwen).
This is in effect an abstract class
Wed, Mar 24, 12:06 PM
machniak committed rK80a0a3a80522: Update ObjectDelete and ObjectUpdate commands, and move the dangerous test to… (authored by vanmeeuwen).
Update ObjectDelete and ObjectUpdate commands, and move the dangerous test to…
Wed, Mar 24, 12:06 PM
machniak committed rK931e340f02f4: Hide the scalpel commands from the list of artisan commands (authored by vanmeeuwen).
Hide the scalpel commands from the list of artisan commands
Wed, Mar 24, 12:06 PM
machniak committed rK681cbaf95011: These are just completely not needed, since there are no direct effects to… (authored by vanmeeuwen).
These are just completely not needed, since there are no direct effects to…
Wed, Mar 24, 12:06 PM
machniak committed rK0fe02c32ead6: Transfer commit (authored by vanmeeuwen).
Transfer commit
Wed, Mar 24, 12:06 PM
machniak committed rKcb118ee92055: scalpel:discount:merge -> discount:merge (authored by vanmeeuwen).
scalpel:discount:merge -> discount:merge
Wed, Mar 24, 12:06 PM
machniak committed rKb26dd227f31d: More complete commands, show-case dangerous delete command in scalpel (authored by vanmeeuwen).
More complete commands, show-case dangerous delete command in scalpel
Wed, Mar 24, 12:06 PM
machniak committed rKec8efb4b5c22: Some additional command logic (authored by vanmeeuwen).
Some additional command logic
Wed, Mar 24, 12:06 PM
machniak added a reverting change for rKc441d3ca2090: Add degraded status to user:status command: rK1eb51b3c336f: Revert "Add degraded status to user:status command".
Wed, Mar 24, 12:06 PM
machniak committed rK1eb51b3c336f: Revert "Add degraded status to user:status command" (authored by machniak).
Revert "Add degraded status to user:status command"
Wed, Mar 24, 12:06 PM
machniak committed rK8430974814aa: Lock wallet:check to the current tenant (authored by machniak).
Lock wallet:check to the current tenant
Wed, Mar 24, 12:06 PM
machniak committed rKaca52c6d8e13: Add degraded status to user:status command (authored by machniak).
Add degraded status to user:status command
Wed, Mar 24, 12:06 PM
machniak committed rK9cc286cfbedd: Add some reseller tests (authored by machniak).
Add some reseller tests
Wed, Mar 24, 12:06 PM
machniak committed rKaf4971170e27: Reseller app engine (authored by machniak).
Reseller app engine
Wed, Mar 24, 12:06 PM
machniak committed rK06a3d8688152: More changes for the work in progress (authored by vanmeeuwen).
More changes for the work in progress
Wed, Mar 24, 12:06 PM
machniak committed rKe4022cc48826: Rebase on master (authored by vanmeeuwen).
Rebase on master
Wed, Mar 24, 12:06 PM

Tue, Mar 23

machniak updated the summary of D2395: [WIP] Localization with vue-i18n.
Tue, Mar 23, 3:46 PM
machniak updated the summary of D2395: [WIP] Localization with vue-i18n.
Tue, Mar 23, 3:43 PM
machniak updated the diff for D2395: [WIP] Localization with vue-i18n.
  • Localization engine for theme files
Tue, Mar 23, 3:40 PM
machniak updated the summary of D2395: [WIP] Localization with vue-i18n.
Tue, Mar 23, 2:26 PM
machniak updated the diff for D2395: [WIP] Localization with vue-i18n.
  • Upgrade to laravel-mix v6 (webpack v5) and other js dependencies
  • Don't preload English
Tue, Mar 23, 2:24 PM
machniak requested changes to D2239: New Payment dialog structure.

When executing some tests for Stripe:

Tue, Mar 23, 12:25 PM
machniak requested changes to D2383: Convert to foreign currencies using openexchangerates.org.

Looks good to me. Two things:

  1. Some tests would be nice.
  2. In bin/quickstart.php we should probably run the command if the api key is set somewhere. And/or maybe we should check-in some already fetched data into the repository. It will be needed for tests.
Tue, Mar 23, 11:46 AM
machniak requested review of D2401: Upgrade to laravel-mix v6 (webpack v5) and other js dependencies.
Tue, Mar 23, 11:34 AM

Mon, Mar 22

machniak requested review of D2395: [WIP] Localization with vue-i18n.
Mon, Mar 22, 1:59 PM
machniak added inline comments to D2383: Convert to foreign currencies using openexchangerates.org.
Mon, Mar 22, 11:45 AM
machniak requested changes to D2389: update copyright info.

BTW, It would be nice to use COMPANY_NAME (app.company.name) setting here. I.e. you have to modify App\Utils::uiEnv() to include it.

Mon, Mar 22, 11:15 AM
machniak requested changes to D2383: Convert to foreign currencies using openexchangerates.org.
Mon, Mar 22, 10:26 AM
machniak requested changes to D2239: New Payment dialog structure.
Mon, Mar 22, 9:58 AM
machniak committed rK6e713f8d557b: Attempt to fix all users chart (authored by machniak).
Attempt to fix all users chart
Mon, Mar 22, 9:48 AM

Sun, Mar 21

machniak committed rRPK315c6ec7a0d5: Tasklist: Fix list scrolling in Elastic on touch devices (authored by machniak).
Tasklist: Fix list scrolling in Elastic on touch devices
Sun, Mar 21, 11:34 AM
machniak committed rRPK39bf64e680c0: Fix 'complete' status of new tasks when using DB driver (authored by machniak).
Fix 'complete' status of new tasks when using DB driver
Sun, Mar 21, 11:16 AM

Fri, Mar 19

machniak committed rRPK54f34fa71e91: Fix logging XML (authored by machniak).
Fix logging XML
Fri, Mar 19, 12:30 PM
machniak committed rRPKd886a3bdfc4f: Fix fatal error introduced with 'kolab_format_error_log' (authored by machniak).
Fix fatal error introduced with 'kolab_format_error_log'
Fri, Mar 19, 9:02 AM

Thu, Mar 18

machniak added a comment to D2239: New Payment dialog structure.

@mollekopf, it looks good. Please, fix phpstan/phpcs issues and we're good to go.

Thu, Mar 18, 2:24 PM
machniak requested review of D2377: [WIP] Resellers: Signup with approval.
Thu, Mar 18, 1:40 PM
machniak committed rK83a4a4f1731b: Make Reseller/UsersController more complete (authored by machniak).
Make Reseller/UsersController more complete
Thu, Mar 18, 10:05 AM

Wed, Mar 17

machniak committed rK0cd56e7edfea: Remove redundant code that sets tenant_id on signup (authored by machniak).
Remove redundant code that sets tenant_id on signup
Wed, Mar 17, 2:47 PM
machniak updated the diff for D2371: Degraded accounts.
  • Simplify
Wed, Mar 17, 2:17 PM
machniak committed rRPK5e3b3c455a33: Add a way to log xml payload on kolab format error (authored by machniak).
Add a way to log xml payload on kolab format error
Wed, Mar 17, 1:39 PM
machniak requested changes to D2239: New Payment dialog structure.
Wed, Mar 17, 11:30 AM

Mar 15 2021

machniak updated the diff for D2371: Degraded accounts.
  • Add periodic reminder mail to degraded accounts
Mar 15 2021, 12:51 PM
machniak committed rK6c977059d6e2: Fix error found by phpstan (authored by machniak).
Fix error found by phpstan
Mar 15 2021, 7:59 AM

Mar 12 2021

machniak committed rKd9047561a2c3: Fix discounts command test (authored by machniak).
Fix discounts command test
Mar 12 2021, 2:01 PM