Page MenuHomePhorge

machniak (Aleksander Machniak)
Kolab Systems, Developer

Projects (32)

User Details

User Since
Apr 12 2015, 12:47 PM (469 w, 5 d)

Recent Activity

Fri, Apr 5

machniak accepted D4680: AllowedHosts middleware to restrict allowed hosts.
Fri, Apr 5, 12:11 PM

Thu, Apr 4

machniak committed rRPK0333d78048c5: Fix phpstan error (authored by machniak).
Fix phpstan error
Thu, Apr 4, 4:14 PM
machniak requested changes to D4680: AllowedHosts middleware to restrict allowed hosts.
Thu, Apr 4, 10:54 AM
machniak accepted D4677: event can be null if parsing failed.
Thu, Apr 4, 10:46 AM

Wed, Apr 3

machniak committed rIad473d3e75c0: Fix tests, add tests, fix PHP8 warnings, update dependencies (authored by machniak).
Fix tests, add tests, fix PHP8 warnings, update dependencies
Wed, Apr 3, 11:29 AM
machniak committed rIa8499c08b08b: Fix duplicated UID property in VCARDs (authored by machniak).
Fix duplicated UID property in VCARDs
Wed, Apr 3, 10:34 AM
machniak committed rI889f71f964ea: Fix regression where VCARD didn't include TEL if contact had no email address (authored by machniak).
Fix regression where VCARD didn't include TEL if contact had no email address
Wed, Apr 3, 10:34 AM

Tue, Apr 2

machniak closed D4668: ACL management for DAV folders.
Tue, Apr 2, 3:46 PM
machniak committed rRPK578617215494: ACL management for DAV folders (authored by machniak).
ACL management for DAV folders
Tue, Apr 2, 3:46 PM

Thu, Mar 28

machniak committed rRPK00bc00945b07: Fix bug in mail_get_itip_object() (authored by machniak).
Fix bug in mail_get_itip_object()
Thu, Mar 28, 8:36 PM
machniak updated the diff for D4668: ACL management for DAV folders.
  • Enable user autocomplete in DAV sharing
Thu, Mar 28, 3:59 PM
machniak accepted D4671: Feature flags for various components.
Thu, Mar 28, 9:46 AM

Wed, Mar 27

machniak updated the diff for D4668: ACL management for DAV folders.
  • DAV share invitations for addressbooks, calendars and tasklists
Wed, Mar 27, 1:46 PM
machniak reopened D4668: ACL management for DAV folders.
Wed, Mar 27, 1:46 PM
machniak abandoned D521: fix building documentation: amnesia.
Wed, Mar 27, 1:30 PM · Kolab Chat
machniak committed rRPKfa8090e47c6c: DAV share invitations for addressbooks, calendars and tasklists (authored by machniak).
DAV share invitations for addressbooks, calendars and tasklists
Wed, Mar 27, 1:29 PM

Tue, Mar 26

machniak added a comment to T8343: Unable to log into roundcube after update from 1:1.5.6.3-1~kolab1 to 1:1.5.6.4-1~kolab1 [Debian11]: Cannot access private property kolab_ldap::$ready.

The error was fixed in https://git.kolab.org/rRPK84c232f6dc4c603949199c46865d2cf6cd1bfd34, I'm not aware of the packaging state.

Tue, Mar 26, 9:58 AM · Bug Reports

Mon, Mar 25

machniak added inline comments to D4594: 15 messages / minute rate-limit for paying users.
Mon, Mar 25, 4:44 PM
machniak added a comment to D4665: Support for multiple admin/reseller/services domains, don't require a specific root domain.

I'm not sure I understand the issue. Instead of 3 config options can't we create a single one?

Mon, Mar 25, 3:58 PM
machniak accepted D4674: According to the logs this can be missing.
Mon, Mar 25, 3:30 PM

Mon, Mar 18

machniak closed D4668: ACL management for DAV folders.
Mon, Mar 18, 9:59 PM
machniak committed rRPKbe6eaf682407: ACL management for DAV folders (authored by machniak).
ACL management for DAV folders
Mon, Mar 18, 9:59 PM
machniak requested review of D4668: ACL management for DAV folders.
Mon, Mar 18, 5:53 PM

Thu, Mar 14

machniak committed rCdae10ffa579a: Fix double-UTF7-IMAP-encoding of folder names in Kolab driver (authored by machniak).
Fix double-UTF7-IMAP-encoding of folder names in Kolab driver
Thu, Mar 14, 2:53 PM

Mar 13 2024

machniak committed rS7cf419cd8c6b: Fix PHP warning (authored by machniak).
Fix PHP warning
Mar 13 2024, 11:09 AM

Mar 12 2024

machniak accepted D4662: Store modseq with the synckey.
Mar 12 2024, 2:34 PM
machniak added a comment to D4662: Store modseq with the synckey.

Also, there's a few print()s in tests that need to be removed.

Mar 12 2024, 2:17 PM
machniak requested changes to D4662: Store modseq with the synckey.
------ ------------------------------------------------------------------------------------------ 
  Line   lib/kolab_sync_data.php                                                                   
 ------ ------------------------------------------------------------------------------------------ 
  570    If condition is always false.                                                             
  593    If condition is always false.                                                             
  603    Method kolab_sync_data::getExtraData() should return string|null but returns array|null.  
 ------ ------------------------------------------------------------------------------------------
Mar 12 2024, 2:05 PM
machniak requested changes to D4662: Store modseq with the synckey.
Mar 12 2024, 12:23 PM

Mar 4 2024

machniak requested review of D4659: [WIP] Init default DAV folders.
Mar 4 2024, 11:09 AM

Mar 1 2024

machniak committed rK04a20f49138f: Fix phpstan errors regarding Wallet::transactions() use (authored by machniak).
Fix phpstan errors regarding Wallet::transactions() use
Mar 1 2024, 1:08 PM

Feb 29 2024

machniak committed rRPKf2547d87fe2c: tasklist: Fix various issues with DAV driver, store alarms option in folder… (authored by machniak).
tasklist: Fix various issues with DAV driver, store alarms option in folder…
Feb 29 2024, 4:25 PM
machniak requested review of D4656: DAV: Single-type calendar and tasks folders.
Feb 29 2024, 4:23 PM
machniak committed rRPKd15e515f04ad: Add missing template file for the ACL dialog (authored by machniak).
Add missing template file for the ACL dialog
Feb 29 2024, 8:30 AM
machniak committed rRPK3b548d050105: Add tests (authored by machniak).
Add tests
Feb 29 2024, 8:30 AM

Feb 28 2024

machniak committed rRPKe792ad4a8a66: DAV ACL dialog for Larry skin (authored by machniak).
DAV ACL dialog for Larry skin
Feb 28 2024, 2:35 PM
machniak committed rRPKd3c0b2819665: PHPDoc updates (authored by machniak).
PHPDoc updates
Feb 28 2024, 1:11 PM
machniak committed rRPK7d2672fba7bf: Tasklist: Fix unwanted tag creation when flagging a task (authored by machniak).
Tasklist: Fix unwanted tag creation when flagging a task
Feb 28 2024, 1:11 PM
machniak committed rRPK84c232f6dc4c: Fix PHP Fatal error: Cannot access private property kolab_ldap::$ready (authored by machniak).
Fix PHP Fatal error: Cannot access private property kolab_ldap::$ready
Feb 28 2024, 12:43 PM

Feb 26 2024

machniak committed rRPKca5888311167: Enable Sharing tab for DAV folders (authored by machniak).
Enable Sharing tab for DAV folders
Feb 26 2024, 2:15 PM
machniak committed rRPK0bd2c1bc14ca: ACL management for DAV folders (authored by machniak).
ACL management for DAV folders
Feb 26 2024, 1:57 PM

Feb 23 2024

machniak committed rI8a42f226ff2c: Fix PHP Error: count(): Argument #1 ($value) must be of type Countable|array… (authored by machniak).
Fix PHP Error: count(): Argument #1 ($value) must be of type Countable|array…
Feb 23 2024, 10:49 AM

Feb 12 2024

machniak committed rRPKb472372a8019: Fix editing addressbook folder using Kolab driver (authored by machniak).
Fix editing addressbook folder using Kolab driver
Feb 12 2024, 12:58 PM

Feb 9 2024

machniak committed rRPKe9fdf8e979f8: kolab_sso: Install firebase/php-jwt via composer (authored by machniak).
kolab_sso: Install firebase/php-jwt via composer
Feb 9 2024, 3:09 PM
machniak committed rRPK653734e8fcd5: Cleanup phpstan (authored by machniak).
Cleanup phpstan
Feb 9 2024, 2:16 PM
machniak committed rRPK5c9841e0c939: Make phpstan status green (see TODO in phpstan.neon) (authored by machniak).
Make phpstan status green (see TODO in phpstan.neon)
Feb 9 2024, 11:31 AM
machniak committed rRPK158b6c972de3: Make libkolab::html_diff() compatible with PHP8 (authored by machniak).
Make libkolab::html_diff() compatible with PHP8
Feb 9 2024, 11:24 AM

Feb 7 2024

machniak committed rKa55fccff931c: Fix phpstan error (authored by machniak).
Fix phpstan error
Feb 7 2024, 10:34 AM

Feb 6 2024

machniak accepted D4647: Remove domain based routing.
Feb 6 2024, 6:35 PM
machniak closed D4653: Fix vat report period.
Feb 6 2024, 11:06 AM
machniak committed rKc19b3d3afead: Fix vat report period (authored by machniak).
Fix vat report period
Feb 6 2024, 11:06 AM
machniak updated the diff for D4650: Set Content-Length:0 for an empty Sync response.
  • Remove Content-Type header from an empty Sync response
Feb 6 2024, 10:47 AM

Feb 5 2024

machniak requested review of D4653: Fix vat report period.
Feb 5 2024, 7:37 PM
machniak requested review of D4650: Set Content-Length:0 for an empty Sync response.
Feb 5 2024, 4:00 PM

Feb 1 2024

machniak closed T7472: wallace does not deliver 8bit encoded utf-8 mails, throws UnicodeEncodeError as Resolved.

Patch merged.

Feb 1 2024, 10:38 AM · PyKolab, Bug Reports
machniak closed D4625: T7472: Work around smtplib bailing out on UTF-8 messages.
Feb 1 2024, 10:29 AM
machniak committed rPd371922b2b38: T7472: Work around smtplib bailing out on UTF-8 messages (authored by sicherha).
T7472: Work around smtplib bailing out on UTF-8 messages
Feb 1 2024, 10:29 AM
machniak accepted D4644: Revert email search results by default so we get latest first.

Accepted, but please check if this does not break tests.

Feb 1 2024, 10:29 AM
machniak committed rP850825a393a8: Make footer_sender_exceptions case-insensitive (authored by machniak).
Make footer_sender_exceptions case-insensitive
Feb 1 2024, 9:59 AM

Jan 30 2024

machniak committed rRPK176f557ec7fd: PHPStan Level:4 fixes (authored by machniak).
PHPStan Level:4 fixes
Jan 30 2024, 2:46 PM
machniak committed rRPK198376f46c30: PHPStan Level:3 (authored by machniak).
PHPStan Level:3
Jan 30 2024, 2:46 PM

Jan 29 2024

machniak added inline comments to D4642: stdout logdriver support.
Jan 29 2024, 1:25 PM
machniak committed rS4283ef59f769: Fix regression in kolab_sync_storage::folder_data() (authored by machniak).
Fix regression in kolab_sync_storage::folder_data()
Jan 29 2024, 12:44 PM

Jan 26 2024

machniak committed rRPK2103cc317de9: PHPDoc fixes (authored by machniak).
PHPDoc fixes
Jan 26 2024, 2:39 PM
machniak accepted D4640: Make sure we always respond with the latest sync key.
Jan 26 2024, 9:32 AM

Jan 25 2024

machniak committed rRPK312b1981de42: Fix test (authored by machniak).
Fix test
Jan 25 2024, 3:58 PM
machniak committed rRPK5eb91ca74a24: PHPStan level:2 fixes (partial) (authored by machniak).
PHPStan level:2 fixes (partial)
Jan 25 2024, 1:48 PM
machniak added inline comments to D4640: Make sure we always respond with the latest sync key.
Jan 25 2024, 1:42 PM
machniak committed rS0c3fe018c642: Cleanup (authored by machniak).
Cleanup
Jan 25 2024, 1:22 PM
machniak committed rS16e73cfcdb6d: Cleanup (authored by machniak).
Cleanup
Jan 25 2024, 12:56 PM
machniak committed rS4bc38ec000c9: Describe testing (authored by machniak).
Describe testing
Jan 25 2024, 12:53 PM

Jan 24 2024

machniak committed rRPK5271b6e78772: Use consistent PHP code style (authored by machniak).
Use consistent PHP code style
Jan 24 2024, 11:25 AM
machniak committed rRPKf3319891d590: PHPStan Level:1 fixes, also fixed tests (authored by machniak).
PHPStan Level:1 fixes, also fixed tests
Jan 24 2024, 11:00 AM

Jan 22 2024

machniak committed rS07390a859930: Mass coding style fixup (authored by machniak).
Mass coding style fixup
Jan 22 2024, 12:27 PM

Jan 19 2024

machniak committed rRPK7aa7a9fe5b09: PHPDoc fixes (authored by machniak).
PHPDoc fixes
Jan 19 2024, 4:05 PM
machniak committed rSad5f97f6824d: PHPStan level 4 fixes (authored by machniak).
PHPStan level 4 fixes
Jan 19 2024, 4:04 PM
machniak committed rS7b78a79af7b3: PHPStan Level 3 fixes (authored by machniak).
PHPStan Level 3 fixes
Jan 19 2024, 3:25 PM
machniak committed rS79e1cd517d8b: Replace rtf.php with roundcube/rtf-html-php (authored by machniak).
Replace rtf.php with roundcube/rtf-html-php
Jan 19 2024, 11:37 AM
machniak committed rS2ccd9ba99308: Fix flaky test (authored by machniak).
Fix flaky test
Jan 19 2024, 11:37 AM
machniak committed rS2dbdefae4370: Add phpstan configuration files (authored by machniak).
Add phpstan configuration files
Jan 19 2024, 11:37 AM
machniak closed D4570: MeetingResponse and MeetingRequest fixes.
Jan 19 2024, 11:37 AM
machniak committed rSe6ece45d5558: MeetingResponse and MeetingRequest fixes (authored by machniak).
MeetingResponse and MeetingRequest fixes
Jan 19 2024, 11:36 AM
machniak committed rS7310e1eea543: Fix the merge and phpstan errors (authored by machniak).
Fix the merge and phpstan errors
Jan 19 2024, 11:36 AM
machniak committed rS74b2671f6b3c: DAV storage (authored by machniak).
DAV storage
Jan 19 2024, 10:46 AM
machniak closed D4631: DAV storage.
Jan 19 2024, 10:41 AM

Jan 16 2024

machniak committed rRPK28711f7e6ef1: Fix PHP8 warnings (authored by machniak).
Fix PHP8 warnings
Jan 16 2024, 12:03 PM
machniak committed rFe1f7ca236025: Fix PHP8 warning (authored by machniak).
Fix PHP8 warning
Jan 16 2024, 11:35 AM

Jan 11 2024

machniak added a comment to T8222: Kolab 16 on Debian 11 Bullseye.

Problem is with loading order of php modules. On Ubuntu the fix for me was:

mv /etc/php7.4/cli/conf.d/30-kolabformat.ini /etc/php7.4/cli/conf.d/32-kolabformat.ini
mv /etc/php7.4/apache2/conf.d/30-kolabformat.ini /etc/php7.4/apache2/conf.d/32-kolabformat.ini

We're working on a fix for packaging.

Jan 11 2024, 1:47 PM · Kolab 16, Libraries, Bug Reports
machniak updated the diff for D4631: DAV storage.
  • Fix performance of DAV access
  • Fix wording
Jan 11 2024, 10:28 AM
machniak requested review of D4637: Add test for Cyrus imap proxy bug.
Jan 11 2024, 9:56 AM
machniak committed rKd7b16d379c7d: Fix phpstan issues (authored by machniak).
Fix phpstan issues
Jan 11 2024, 9:00 AM

Jan 10 2024

machniak committed rRPKb258585da170: Improve "empty" _sync_unlock() (authored by machniak).
Improve "empty" _sync_unlock()
Jan 10 2024, 3:56 PM
machniak requested changes to D4613: A user create command.
Jan 10 2024, 3:14 PM
machniak committed rRPKf41dc94eae52: Compatibility fixes for Roundcube 1.7 (authored by machniak).
Compatibility fixes for Roundcube 1.7
Jan 10 2024, 2:44 PM
machniak committed rRPK9c69920ccb1b: Fix handling errors on FETCH in the cache synchronization, code cleanup (authored by machniak).
Fix handling errors on FETCH in the cache synchronization, code cleanup
Jan 10 2024, 2:44 PM
machniak requested changes to D4613: A user create command.
Jan 10 2024, 11:05 AM

Jan 7 2024

machniak accepted D4628: IMAP_WITH_GROUPWARE_DEFAULT_FOLDERS.
Jan 7 2024, 8:33 AM

Jan 5 2024

machniak updated the diff for D4631: DAV storage.
  • Fix possible PHP warning
Jan 5 2024, 2:34 PM
machniak updated the diff for D4631: DAV storage.
  • Add tests
Jan 5 2024, 2:15 PM
machniak updated the diff for D4631: DAV storage.
  • Cleanup
  • Re-implement MoveItems for DAV
  • Merge branch 'dev/dav' of ssh://git.kolab.org/diffusion/S into dev/dav
Jan 5 2024, 2:14 PM