Page MenuHomekolab.org

machniak (Aleksander Machniak)
Kolab Systems, Developer

Projects (30)

User Details

User Since
Apr 12 2015, 12:47 PM (329 w, 33 m)

Recent Activity

Yesterday

machniak committed rPNL9bcc57027a06: Fix PHP 8.1 compatibility where LDAP connection is not a resource, but an object (authored by machniak).
Fix PHP 8.1 compatibility where LDAP connection is not a resource, but an object
Sat, Jul 31, 5:37 PM
machniak committed rPNL8c1b36bb9fa9: Fix PHP 8.1 deprecation warnings (authored by machniak).
Fix PHP 8.1 deprecation warnings
Sat, Jul 31, 5:34 PM

Fri, Jul 30

machniak committed rKdea894c6f30b: Fix some browser tests in mobile mode (authored by machniak).
Fix some browser tests in mobile mode
Fri, Jul 30, 3:42 PM
machniak committed rK97429f370ebe: Refactored tenant:create command's code to fix strange phpstan errors (authored by machniak).
Refactored tenant:create command's code to fix strange phpstan errors
Fri, Jul 30, 2:01 PM
machniak updated the diff for D2554: Add PGP keys generator.
  • Switch new keypair algorithms to RSA
  • Use Laravel's Storage functionality
  • Add exportPublicKey() use
  • Generate a keypair for new alias
  • Unregister keys on alias delete
  • Add forgotten file
  • Fix issues found by phpstan
Fri, Jul 30, 1:26 PM
machniak committed rKcfe21edcc120: Update stylelint (authored by machniak).
Update stylelint
Fri, Jul 30, 12:22 PM
machniak committed rKcd7b7bfa791c: Update more npm deps (authored by machniak).
Update more npm deps
Fri, Jul 30, 12:16 PM
machniak committed rK1bddbe52d3c3: Update some npm deps (authored by machniak).
Update some npm deps
Fri, Jul 30, 12:16 PM
machniak committed rK14543c757732: Fix one more test (authored by machniak).
Fix one more test
Fri, Jul 30, 9:51 AM
machniak committed rK54dc4cddd144: Fix some tests dependency on APP_NAME (authored by machniak).
Fix some tests dependency on APP_NAME
Fri, Jul 30, 9:44 AM
machniak committed rK96ee1e4826b9: Set MAIL_REPLYTO_ADDRESS in .env.example (authored by machniak).
Set MAIL_REPLYTO_ADDRESS in .env.example
Fri, Jul 30, 9:24 AM
machniak committed rKb0d4d89a22a9: Fix regressions (authored by machniak).
Fix regressions
Fri, Jul 30, 9:08 AM
machniak committed rKeca49d51185b: Fix "Could not scan for classes inside "database/factories"" (authored by machniak).
Fix "Could not scan for classes inside "database/factories""
Fri, Jul 30, 8:13 AM

Thu, Jul 29

machniak committed rRPKc99ac18b8940: Use ISO week numbers in both full-calendar and date picker (authored by machniak).
Use ISO week numbers in both full-calendar and date picker
Thu, Jul 29, 2:34 PM
machniak updated the diff for D2623: Greylisting + SPF.
  • Remove redundant generatePassphrase()
  • Fix migration
  • Fix regression
  • Fix various bugs found by phpstan and test regressions
Thu, Jul 29, 2:04 PM

Wed, Jul 28

machniak updated the diff for D2659: Tenant settings.
  • Fix withObjectTenantContext macro
    • It's result should not depend on the current user role
    • It was throwing exceptions when working with an unauth user (e.g. /meet endpoints)
    • Fixed some tests
Wed, Jul 28, 2:11 PM

Thu, Jul 22

machniak committed rAC9386fe6e5fb6: Add an option to respond to mobilesync requests only (authored by machniak).
Add an option to respond to mobilesync requests only
Thu, Jul 22, 3:39 PM
machniak committed rKb584482f2d8d: Fix body padding issue after deleting a user (authored by machniak).
Fix body padding issue after deleting a user
Thu, Jul 22, 2:19 PM
machniak committed rK86b4731f2166: Fix call to undefined method App\Providers\Payment\Mollie::exchangeRate() (authored by machniak).
Fix call to undefined method App\Providers\Payment\Mollie::exchangeRate()
Thu, Jul 22, 2:00 PM
machniak requested review of D2680: Meet: Audio volume control.
Thu, Jul 22, 12:06 PM
machniak committed rK9fa729c67776: Fix missing localization label (authored by machniak).
Fix missing localization label
Thu, Jul 22, 9:46 AM
machniak added a comment to T6610: style.css and files_api.js only http not https.

The kolab_files plugin has some configuration. You can set these to an absolute URLs.

// URL of kolab-chwala installation
$config['kolab_files_url'] = '/chwala/';
Thu, Jul 22, 8:32 AM · Bug Reports
machniak added a comment to T6670: Deleted groups still appearing under Global Address Book.

The ldap group information is cached, by default for 10 minutes. Check ldap_cache and ldap_cache_ttl settings. You can disable the cache with $config['ldap_cache'] = null;.

Thu, Jul 22, 8:30 AM · Roundcube

Mon, Jul 19

machniak committed rAC2e81ac04b413: Set AutoDiscoverSMTPAddress to user login, and fallback to email, the same as… (authored by machniak).
Set AutoDiscoverSMTPAddress to user login, and fallback to email, the same as…
Mon, Jul 19, 3:43 PM
machniak committed rAC9372ec6fc7a0: Merge branch 'master' of ssh://git.kolab.org/diffusion/AC/autoconf (authored by machniak).
Merge branch 'master' of ssh://git.kolab.org/diffusion/AC/autoconf
Mon, Jul 19, 1:57 PM
machniak committed rACbade385c19e2: Return early on unsupported protocol (authored by machniak).
Return early on unsupported protocol
Mon, Jul 19, 1:57 PM
machniak committed rAC9906f5974c08: Typo: ErrorCore -> ErrorCode (authored by machniak).
Typo: ErrorCore -> ErrorCode
Mon, Jul 19, 10:26 AM
machniak committed rAC31b044adcd83: Fix JSON autodiscovery for requests with non-v1.0 syntax (authored by machniak).
Fix JSON autodiscovery for requests with non-v1.0 syntax
Mon, Jul 19, 9:24 AM

Fri, Jul 16

machniak accepted D2665: Log requests during testing.
Fri, Jul 16, 11:18 AM

Thu, Jul 15

machniak updated the diff for D2659: Tenant settings.
  • Add getSettings() method, and use it as a optimization tool
Thu, Jul 15, 10:07 AM

Tue, Jul 13

machniak requested review of D2659: Tenant settings.
Tue, Jul 13, 11:04 AM

Mon, Jul 12

machniak updated the diff for D2635: Further changes to the reseller implementation.
  • Remove unused Packages controllers for admin and reseller API
  • Fix SKU controllers
  • Fix Wallet controllers
  • Fix Users controllers
  • /api/discounts -> /api/users/{id}/discounts as we need the user context for this
Mon, Jul 12, 11:44 AM

Fri, Jul 9

machniak updated the diff for D2635: Further changes to the reseller implementation.
  • Fix Group and Domain controllers, use new helper checkTenant()
Fri, Jul 9, 8:00 PM
machniak updated the diff for D2635: Further changes to the reseller implementation.
  • Fix InvitationsController
Fri, Jul 9, 4:46 PM
machniak updated the diff for D2635: Further changes to the reseller implementation.
  • Fix reseller's GroupsController and tests for it
Fri, Jul 9, 3:16 PM
machniak updated the diff for D2635: Further changes to the reseller implementation.
  • Fix various places where tenant context wasn't applied when selecting a sku record
Fri, Jul 9, 12:39 PM
machniak updated the diff for D2635: Further changes to the reseller implementation.
  • Fix obvious test regressions and a bug in the signup controller
Fri, Jul 9, 10:33 AM

Wed, Jul 7

machniak updated the diff for D2635: Further changes to the reseller implementation.
  • Fix browser tests
Wed, Jul 7, 2:51 PM

Fri, Jul 2

machniak committed rSfb6622841a94: Add option to disable TNEF decoding (activesync_tnef_blacklist) (authored by machniak).
Add option to disable TNEF decoding (activesync_tnef_blacklist)
Fri, Jul 2, 3:02 PM
machniak committed rRPK945ac3605d4c: Fix 2FA logon with kolab_auth's "login as" feature (authored by machniak).
Fix 2FA logon with kolab_auth's "login as" feature
Fri, Jul 2, 1:56 PM

Jul 2 2021

machniak requested changes to D2653: Attempt to fix issues with acl setting when acl subject has upper case letters in LDAP..
Jul 2 2021, 11:20 AM
machniak committed rS8e98b9f2a9a8: Fix Windows to Olson timezone conversion for some timezones e.g. Asia/Tehran (authored by machniak).
Fix Windows to Olson timezone conversion for some timezones e.g. Asia/Tehran
Jul 2 2021, 10:45 AM
machniak committed rSa4204ab0f838: Made Timezone format Outlook compatible (authored by mollekopf).
Made Timezone format Outlook compatible
Jul 2 2021, 10:45 AM
machniak closed D2647: Made Timezone format Outlook compatible.
Jul 2 2021, 10:45 AM
machniak committed rSffbd6a2246af: Fix PHP8 warnings (authored by machniak).
Fix PHP8 warnings
Jul 2 2021, 8:42 AM
machniak committed rS0dbfe14ceeee: Support more recent PHPUnit versions (authored by machniak).
Support more recent PHPUnit versions
Jul 2 2021, 8:42 AM
machniak committed rSd267da5cdc08: Fix array and string offset access syntax with curly braces (authored by machniak).
Fix array and string offset access syntax with curly braces
Jul 2 2021, 8:42 AM

Jun 30 2021

machniak requested changes to D2635: Further changes to the reseller implementation.
[14:20:34] <alec> I'm getting quite a lot of failing tests: Errors: 20, Failures: 51, Skipped: 7, Incomplete: 14. just from --testsuite=Feature 
[14:20:34] <alec> I guess you might be running tests with a different APP_TENANT_ID or sth 
[14:20:54] <alec> I have APP_TENANT_ID=1 in .env 
[14:22:57] <alec> damn, and I've run it with production mollie key, there 4 new users created, can you remove them? 
[14:27:32] <alec> also APP_PASSPHRASE=simple123 is needed when seeding and running tests 
[14:41:48] <alec> for browser tests: Errors: 16, Failures: 8, Skipped: 14, Incomplete: 1. 
[14:43:14] <alec> this is what I expected, changing default set of entitlements/skus is breaking a lot of tests 
[14:46:14] <alec> also phpstan has a lot to say
Jun 30 2021, 2:47 PM
machniak committed rRPK83d7667aca7e: Add missing icon for "Login As" input in Elastic skin(s) (authored by machniak).
Add missing icon for "Login As" input in Elastic skin(s)
Jun 30 2021, 2:00 PM
machniak requested changes to D2635: Further changes to the reseller implementation.
Jun 30 2021, 12:27 PM
machniak added inline comments to D2635: Further changes to the reseller implementation.
Jun 30 2021, 11:42 AM
machniak requested changes to D2635: Further changes to the reseller implementation.
Jun 30 2021, 10:41 AM

Jun 25 2021

machniak requested review of D2629: Fix duplicate SKUs listed in the user form.
Jun 25 2021, 9:55 AM

Jun 23 2021

machniak abandoned D2434: User controls over greylisting on the individual user basis, and SPF whitelisting for domains.

This diff is obviously broken. I updated the branch and created a new diff in https://git.kolab.org/D2623, as I wasn't able to update this one (arc diff was failing).

Jun 23 2021, 12:37 PM
machniak requested review of D2623: Greylisting + SPF.
Jun 23 2021, 12:24 PM
machniak committed rK780cfcd00fc2: Add @group to some tests (authored by machniak).
Add @group to some tests
Jun 23 2021, 12:20 PM
machniak requested review of D2617: Add tenant:create command.
Jun 23 2021, 11:07 AM

Jun 22 2021

machniak committed rK897ac4cf63a8: Merge branch 'dev/D2434' of ssh://git.kolab.org/source/kolab into dev/D2434 (authored by machniak).
Merge branch 'dev/D2434' of ssh://git.kolab.org/source/kolab into dev/D2434
Jun 22 2021, 3:51 PM
machniak committed rK6141a934bdb6: Fix various bugs and regressions (SPF/Greylist related) (authored by machniak).
Fix various bugs and regressions (SPF/Greylist related)
Jun 22 2021, 3:51 PM
machniak committed rKb092e3716a6a: Bits of cleanup and further developing with rate limiting (authored by vanmeeuwen).
Bits of cleanup and further developing with rate limiting
Jun 22 2021, 3:51 PM
machniak committed rK7c3e28002fc8: Things not found yield a 200 response code as well (authored by vanmeeuwen).
Things not found yield a 200 response code as well
Jun 22 2021, 3:51 PM
machniak committed rK6b22c967553d: Trim trailing dots from the SPF whitelist entries (authored by vanmeeuwen).
Trim trailing dots from the SPF whitelist entries
Jun 22 2021, 3:51 PM
machniak committed rK94d067c05740: User controls over greylisting on the individual user basis, and SPF… (authored by vanmeeuwen).
User controls over greylisting on the individual user basis, and SPF…
Jun 22 2021, 3:51 PM
machniak committed rK0f7eddbb84a0: Greylisting/SPF UI (authored by machniak).
Greylisting/SPF UI
Jun 22 2021, 3:51 PM
machniak committed rK2cc377b6e1a6: Preliminary implementation of a greylisting database and spf service (authored by vanmeeuwen).
Preliminary implementation of a greylisting database and spf service
Jun 22 2021, 3:51 PM
machniak closed T6640: RC 1.4.11 | RC Plugins kolab calendar 3.5.7 | bday calendar with carddav contacts as Invalid.

I'd say it's the carddav plugin issue. Maybe it does not "inject" its addressbook sources on task=calendar requests or sth like that.

Jun 22 2021, 11:18 AM · Roundcube Kolab Plugins , Bug Reports
machniak committed rK99df85eb7386: Support groups in Entitlement::entitleableTitle() (authored by machniak).
Support groups in Entitlement::entitleableTitle()
Jun 22 2021, 10:26 AM

Jun 21 2021

machniak updated the diff for D2371: Degraded accounts.
  • Rebase
Jun 21 2021, 2:18 PM
machniak requested review of D2611: Upgrade to PHPUnit v9, drop unused dependencies.
Jun 21 2021, 11:01 AM
machniak requested review of D2554: Add PGP keys generator.
Jun 21 2021, 10:02 AM
machniak updated the diff for D2554: Add PGP keys generator.
  • Rebase
Jun 21 2021, 10:01 AM
machniak updated the diff for D2554: Add PGP keys generator.
  • Add forgotten file
Jun 21 2021, 10:00 AM
machniak committed rK188b09b503e7: Fix test regression and one flaky assertion (authored by machniak).
Fix test regression and one flaky assertion
Jun 21 2021, 9:59 AM
machniak committed rK8304c5a72f94: UI localization (authored by machniak).
UI localization
Jun 21 2021, 9:59 AM
machniak closed D2581: UI localization.
Jun 21 2021, 9:59 AM

Jun 17 2021

machniak updated the diff for D2593: Update to Openvidu-browser 2.18.
  • Bump Openvidu version in Dockerfile
Jun 17 2021, 9:45 AM
machniak committed rKcddd31f4d0d2: Improve wallet() methods accuracy (authored by machniak).
Improve wallet() methods accuracy
Jun 17 2021, 8:52 AM
machniak closed D2587: Improve wallet() methods accuracy.
Jun 17 2021, 8:52 AM
machniak committed rK3d33f21cfacc: Add slow requests log (authored by machniak).
Add slow requests log
Jun 17 2021, 8:52 AM
machniak closed D2605: Add slow requests log.
Jun 17 2021, 8:52 AM
machniak committed rKb5af9125bba8: Improve themes, add some scss vars, add missing localization for the default… (authored by machniak).
Improve themes, add some scss vars, add missing localization for the default…
Jun 17 2021, 8:52 AM
machniak closed D2599: Improve themes, add some scss vars, add missing localization for the default theme.
Jun 17 2021, 8:52 AM

Jun 16 2021

machniak requested review of D2605: Add slow requests log.
Jun 16 2021, 2:55 PM
machniak requested review of D2599: Improve themes, add some scss vars, add missing localization for the default theme.
Jun 16 2021, 1:19 PM

Jun 15 2021

machniak updated the diff for D2554: Add PGP keys generator.
  • Generate a keypair for new alias
  • Unregister keys on alias delete
Jun 15 2021, 1:52 PM

Jun 12 2021

machniak updated the diff for D2593: Update to Openvidu-browser 2.18.
  • Disable jsnlog's error handlers added in OpenVidu 2.18
Jun 12 2021, 8:19 AM

Jun 11 2021

machniak requested review of D2593: Update to Openvidu-browser 2.18.
Jun 11 2021, 2:12 PM

Jun 10 2021

machniak requested review of D2587: Improve wallet() methods accuracy.
Jun 10 2021, 3:04 PM
machniak updated the diff for D2581: UI localization.
  • Add test for localization in getWalletNotice()
Jun 10 2021, 10:54 AM

Jun 9 2021

machniak requested review of D2581: UI localization.
Jun 9 2021, 2:34 PM

Jun 8 2021

machniak committed rRPK5a94fd8bc6e6: 2FA: Add missing login_lc config handling (authored by machniak).
2FA: Add missing login_lc config handling
Jun 8 2021, 10:38 AM

Jun 4 2021

machniak requested review of D2572: Resellers - all changes.
Jun 4 2021, 3:03 PM
machniak committed rKfad0f675055c: Fix phpstan errors (authored by machniak).
Fix phpstan errors
Jun 4 2021, 2:08 PM
machniak committed rK5925612aafcb: Fix tests regressions (authored by machniak).
Fix tests regressions
Jun 4 2021, 1:55 PM
machniak committed rKf336df8e9d45: Merge branch 'master' into dev/reseller (authored by machniak).
Merge branch 'master' into dev/reseller
Jun 4 2021, 1:55 PM
machniak closed D2452: Tenant scope for CLI commands.

Merged into dev/reseller.

Jun 4 2021, 12:32 PM
machniak committed rK6aa312a4a5db: Tenant scope for CLI commands (authored by machniak).
Tenant scope for CLI commands
Jun 4 2021, 12:31 PM
machniak committed rK5d98fbe82027: Require PHP>=7.3 and Guzzle Http Client (authored by machniak).
Require PHP>=7.3 and Guzzle Http Client
Jun 4 2021, 12:26 PM

Jun 1 2021

machniak retitled D2452: Tenant scope for CLI commands from [WIP] Tenant scope for CLI commands to Tenant scope for CLI commands.
Jun 1 2021, 3:26 PM
machniak updated the diff for D2452: Tenant scope for CLI commands.
  • Simplify again
Jun 1 2021, 3:26 PM