User Details
User Details
- User Since
- Apr 12 2015, 12:47 PM (370 w, 1 d)
Thu, May 12
Thu, May 12
machniak updated the diff for D3563: Shared folders' subfolders support and LMTP address aliases.
- Fix phpcs error
machniak requested review of D3563: Shared folders' subfolders support and LMTP address aliases.
Tue, May 10
Tue, May 10
machniak updated the diff for D3544: Lists code de-duplication.
- Fix linting errors
machniak requested review of D3557: Tabs widget.
Fri, May 6
Fri, May 6
machniak requested review of D3551: Modal dialog component.
Wed, May 4
Wed, May 4
machniak updated the diff for D3544: Lists code de-duplication.
- More code de-duplication
- More code de-duplication
- cols -> columns
Tue, May 3
Tue, May 3
machniak requested review of D3544: Lists code de-duplication.
Mon, May 2
Mon, May 2
machniak updated the diff for D3532: Unify/automate loader element.
- Move some utility functions to utils.js
machniak requested review of D3532: Unify/automate loader element.
machniak committed rK468d1abd3062: Update tests to detect missing payment method icons (authored by machniak).
Update tests to detect missing payment method icons
machniak committed rK2ba105dd314d: Fix missing icon for the bank transfer method (authored by machniak).
Fix missing icon for the bank transfer method
Fri, Apr 29
Fri, Apr 29
Lock cash-dom to version 8.1.0
Fix undefined array key error
Fix flaky test
Merge branch 'master' into beta-release
machniak committed rK352a3753e6bc: FontAwesome v6 and refactor the way we include icons (authored by machniak).
FontAwesome v6 and refactor the way we include icons
machniak committed rK0eac12aabdb2: Meet: Fix releasing media streams, CS fixes (authored by machniak).
Meet: Fix releasing media streams, CS fixes
Get rid of vuex
BelongsToUser Trait
machniak committed rK56a36a1676c3: Meet: Fix releasing media streams, CS fixes (authored by machniak).
Meet: Fix releasing media streams, CS fixes
Replace anchorme with stringifyjs
Thu, Apr 28
Thu, Apr 28
machniak updated the diff for D3526: FontAwesome v6 and refactor the way we include icons.
- Merge branch 'master' into dev/fontawesome-refactor
Axios update
Fix handling of incomplete files
machniak requested review of D3526: FontAwesome v6 and refactor the way we include icons.
Wed, Apr 27
Wed, Apr 27
Various client code improvements
Bump vue-fontawesome version up
Improve companion app icon
Tue, Apr 26
Tue, Apr 26
Improve volume indicator
Small css improvement
Fix adding resources to new events
machniak requested review of D3520: Meet: Fix releasing media streams, CS fixes.
machniak requested review of D3514: Get rid of vuex.
Mon, Apr 25
Mon, Apr 25
Fix regression in 2FA logon
machniak committed rK7458e77ef8f9: Fix broken submit button label in domain settings form (authored by machniak).
Fix broken submit button label in domain settings form
machniak committed rK15c426efd61c: Meet: Fix releasing media streams, CS fixes (authored by machniak).
Meet: Fix releasing media streams, CS fixes
Fri, Apr 22
Fri, Apr 22
machniak requested review of D3502: BelongsToUser Trait.
Thu, Apr 21
Thu, Apr 21
machniak committed rK5fa15c94d17d: Don't display "Unauthenticated" when token refresh fails (authored by machniak).
Don't display "Unauthenticated" when token refresh fails
machniak committed rKdf33bf420f7c: Workaround strange bootstrap+cash-dom error (authored by machniak).
Workaround strange bootstrap+cash-dom error
Password expiration notification
machniak updated the diff for D3379: Password expiration notification.
- Fix test
machniak updated the diff for D3379: Password expiration notification.
- Merge branch 'master' into dev/password-retention
Fix phpstan error
machniak committed rK6c7db399d671: Fix error if a file has no 'size' property (authored by machniak).
Fix error if a file has no 'size' property
machniak committed rK80277465afda: Merge branch 'beta-release' of ssh://git.kolab.org/source/kolab into beta… (authored by machniak).
Merge branch 'beta-release' of ssh://git.kolab.org/source/kolab into beta…
machniak committed rK50389d90f3c0: Fix error if a file has no 'size' property (authored by machniak).
Fix error if a file has no 'size' property
machniak updated the diff for D3379: Password expiration notification.
- Suggested changes
machniak committed rKf81b66d5d752: Create Roundcube user default identity (when creating the user) (authored by machniak).
Create Roundcube user default identity (when creating the user)
Merged into the beta-release branch.
machniak committed rK8e0bd91a7219: Update npm dependencies (for beta-release) (authored by machniak).
Update npm dependencies (for beta-release)
Wed, Apr 20
Wed, Apr 20
machniak committed rK1dd9b9c44117: Fix file type detection, don't require it to be working in the existsing tests (authored by machniak).
Fix file type detection, don't require it to be working in the existsing tests
Fix js/css linting issues
machniak updated the diff for D3496: Update npm dependencies (for beta-release).
- Fix Bootstrap's regression - unwanted bold border on tables
machniak committed rKec86a23ebcbd: Use of wss:// vs. ws:// protocol should depend on config.tls, not "local host" (authored by machniak).
Use of wss:// vs. ws:// protocol should depend on config.tls, not "local host"
Fix more test regressions
Fix various test regressions
machniak requested review of D3496: Update npm dependencies (for beta-release).
Fix phpstan errors
fs:expunge command
Tue, Apr 19
Tue, Apr 19
Don't use a static variable
machniak committed rKf70156095ff1: Merge branch 'beta-release' of ssh://git.kolab.org/source/kolab into beta… (authored by machniak).
Merge branch 'beta-release' of ssh://git.kolab.org/source/kolab into beta…
machniak retitled D3490: fs:expunge command from Remove use of unset mimetype property on files list to fs:expunge command.
machniak requested review of D3490: fs:expunge command.
Apr 15 2022
Apr 15 2022
machniak updated the diff for D3463: [WIP] Files API.
- Files API schema refactoring
Apr 14 2022
Apr 14 2022
machniak added a comment to D3463: [WIP] Files API.
So, how do you search fast by the key if you don't know item_id (which is the index here)? Should we just add an index on the key column alone?
machniak added a comment to D3463: [WIP] Files API.
- If we move file name, size, mimetype to a separate table whenever we want to list/sort/search we have to make join(s) which will make it slow, and I'd say listing/searching by these three attributes is essential. A simplest listing needs to return at least the file size, name and mimetype, this makes this basic query much complicated/slower.
- If we wanted to re-use the existing SettingsTrait the table name would have to be fs_file_settings, or you insist on "attributes"?
- If we move permissions to settings/attributes then a "search by share id" query will be very slow, as it will be a non-indexed query on a big table. Therefore I'd keep the fs_permissions table as is.
- App\Handlers\Beta\Files is there for a reason, it extends App\Handlers\Beta\Base class, but I guess I can move it to App\Handlers\Files. Note: that we still have Distlists, Resources, SharedFolders under \Beta, so it would not be consistent.
- I understand fs_chunks needs a sequence column, but what's wrong with the incremented id? Ok, I guess with a generated id we can make it more performant, because we don't need to make an INSERT first. I.e. we'd generate chunk-id, save the chunk-file, then insert. Do you want to make the chunk id unique/primary key?
- @mollekopf, the file_id + sequence is not unique enough, there might be more than one deleted record with the same file_id + sequence combination. Especially considering file updates and partial uploads. SO, I see a reason to have an extra id for the chunk filename.
Apr 12 2022
Apr 12 2022
machniak updated the diff for D3463: [WIP] Files API.
- Make max chunk size depend on SWOOLE_PACKAGE_MAX_LENGTH option
Apr 11 2022
Apr 11 2022
machniak updated the diff for D3463: [WIP] Files API.
- Store files in chunks (don't concatenate), some refactorings
Apr 8 2022
Apr 8 2022
machniak updated the diff for D3463: [WIP] Files API.
- File upload/download via unauth API location
- File update API
- Files API schema/implementation refactor (slim-down)
Mar 30 2022
Mar 30 2022
machniak added a comment to D3463: [WIP] Files API.
Ok, so the current schema does not cover folders and sharing of folders. I have a simple solution for that:
--- a/src/database/migrations/2022_03_02_100000_create_filesystem_tables.php +++ b/src/database/migrations/2022_03_02_100000_create_filesystem_tables.php @@ -30,6 +30,7 @@ function (Blueprint $table) { function (Blueprint $table) { $table->string('id', 36)->primary(); $table->string('library_id', 36); + $table->string('parent_id', 36)->nullable()->index(); // parent folder identifier $table->string('name', 512); $table->bigInteger('size')->unsigned()->default(0); $table->string('mimetype');
Mar 21 2022
Mar 21 2022
machniak added a comment to D3463: [WIP] Files API.
@mollekopf I just added the sharing feature. What do you think about this now?
machniak updated the diff for D3463: [WIP] Files API.
- Add missing FilePermission model
Mar 15 2022
Mar 15 2022
machniak requested review of D3463: [WIP] Files API.
Mar 11 2022
Mar 11 2022
machniak updated the diff for D3409: Laravel v9.
- The daemonize option does not work
- Min processes must be >0
- Fixed swoole container
machniak requested review of D3415: Create Roundcube user default identity (when creating the user).
Mar 10 2022
Mar 10 2022
machniak updated the diff for D3409: Laravel v9.
- Update swoole container with php8/fedora35/swoole 4.8
- Update the nginx containers to fedora 35 while we're at it
- Daemonize octane, .env.local -> .env.local.example
- Explicit octane config
Mar 3 2022
Mar 3 2022
machniak committed rKc31d0ffbc453: Use "your logo here" logos in the default theme (authored by machniak).
Use "your logo here" logos in the default theme
Feb 28 2022
Feb 28 2022
machniak committed rKd99b8fa47e03: Add Swoole config section to config/octane.php (authored by machniak).
Add Swoole config section to config/octane.php
machniak updated the diff for D3409: Laravel v9.
- Add Swoole config section to config/octane.php
Feb 24 2022
Feb 24 2022
machniak committed rK34bf24df4449: Update spomky-labs/otphp package for better PHP 8.1 support (authored by machniak).
Update spomky-labs/otphp package for better PHP 8.1 support
Fix typo in phpdoc
Cleanup and use of new Eloquent features
machniak updated the diff for D3409: Laravel v9.
- Update spomky-labs/otphp package for better PHP 8.1 support
machniak requested review of D3409: Laravel v9.