Page MenuHomePhorge

Fold WalletCharge and WalletCheck into one
Changes PlannedPublic

Authored by mollekopf on Mon, Jun 3, 11:31 AM.
Referenced Files
Unknown Object (File)
Mon, Jun 17, 8:46 AM
Unknown Object (File)
Sat, Jun 15, 8:38 PM
Unknown Object (File)
Fri, Jun 14, 12:46 PM
Unknown Object (File)
Thu, Jun 13, 9:57 PM
Unknown Object (File)
Thu, Jun 13, 9:44 AM
Unknown Object (File)
Wed, Jun 12, 4:02 PM
Unknown Object (File)
Tue, Jun 11, 5:25 AM
Unknown Object (File)
Sat, Jun 8, 6:36 PM


Group Reviewers
Restricted Project

Diff Detail

rK kolab
Lint Skipped
No Test Coverage
Build Status
Buildable 47544
Build 18018: arc lint + arc unit

Event Timeline

mollekopf created this revision.
mollekopf added a reviewer: Restricted Project.Mon, Jun 3, 11:32 AM

Will require at least some more cleanup (remove WalletCharge job and command).

Maybe it makes sense, if huge number of jobs is not an issue. Also we should probably do dispatch($wallet->id) instead of dispatch($wallet) (and do find() instead of refresh()).

One more note. Currently if topUpWallet() throws exception (for any reason, e.g. Mollie connection issues) the WalletCharge job will try to top up the wallet again. Here it won't happen, so it will be more fragile to temporary issues with the payment provider. Catching the exception and invoking a separate WalletCharge job might make sense.

That means at least I wouldn't remove job:walletcharge command (and the job), it might come in handy.