Page MenuHomekolab.org

A blue default theme
ClosedPublic

Authored by mollekopf on Mar 22 2023, 10:40 AM.

Diff Detail

Repository
rK kolab
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

mollekopf requested review of this revision.Mar 22 2023, 10:40 AM
mollekopf created this revision.
mollekopf added a reviewer: Restricted Project.Mar 22 2023, 10:40 AM

Modification of the default theme.json will break some browser tests. We e.g. assert that /support page and faq entries work.

I also don't like this blue color.

Modification of the default theme.json will break some browser tests. We e.g. assert that /support page and faq entries work.

Ok, I'll look into it.

I also don't like this blue color.

It's a bit in your face I agree, but I don't think we should change the color just here. We should have one kolab.org blue and use that (on websites and application). Atm. this is the blue we have.
I could see us revert to more grey, with blue highlights though for a less overwhelming UI.

mollekopf updated this revision to Diff 11936.Mar 22 2023, 1:54 PM

A bit less in your face

mollekopf updated this revision to Diff 11948.Mar 22 2023, 3:44 PM

With support page

mollekopf updated this revision to Diff 11954.Mar 22 2023, 11:48 PM

Fixed tests that we broke.

I think it's fine to remove the items, we still test the overall mechanism.

vanmeeuwen accepted this revision.Mar 27 2023, 1:34 PM
This revision is now accepted and ready to land.Mar 27 2023, 1:34 PM
mollekopf added inline comments.Mar 27 2023, 1:35 PM
src/config/app.php
242

copyright shouldn't change.

This revision was landed with ongoing or failed builds.Mar 27 2023, 2:43 PM
Closed by commit rK99cd06f6e286: A blue default theme, and fixed the copyright (authored by Christian Mollekopf <mollekopf@apheleia-it.ch>). · Explain Why
This revision was automatically updated to reflect the committed changes.