Page MenuHomekolab.org

vanmeeuwen (Jeroen van Meeuwen)
Kolab Systems, Ninja Extra-ordinaireAdministrator

Projects (75)

User Details

User Since
Apr 12 2015, 12:45 PM (278 w, 1 d)
Roles
Administrator

Recent Activity

Today

vanmeeuwen accepted D1459: Don't create Mollie/Stripe ID until user makes a payment.
Mon, Aug 10, 3:19 PM

Tue, Jul 28

vanmeeuwen accepted D1435: Token keep-alive (refresh).
Tue, Jul 28, 11:30 AM

Jul 9 2020

vanmeeuwen committed rK877f2f7b358e: Allow multiple ldap operations in a single connection (authored by machniak).
Allow multiple ldap operations in a single connection
Jul 9 2020, 2:48 PM
vanmeeuwen closed D1429: Allow multiple ldap operations in a single connection.
Jul 9 2020, 2:48 PM
vanmeeuwen accepted D1429: Allow multiple ldap operations in a single connection.

I'll land this and rebase dev/hkccp-import on it.

Jul 9 2020, 2:48 PM

Jun 24 2020

vanmeeuwen accepted D1408: Set NOT NULL DEFAULT current_timestamp() on created_at/updated_at columns.
Jun 24 2020, 12:03 PM
vanmeeuwen accepted D1402: Aliases sharing.
Jun 24 2020, 12:02 PM
vanmeeuwen accepted D1390: Added production seeders.
Jun 24 2020, 12:00 PM

Jun 19 2020

vanmeeuwen requested changes to D1402: Aliases sharing.
Jun 19 2020, 11:49 AM
vanmeeuwen added a comment to D1402: Aliases sharing.

This would inadvertently allow john@mykolab.com to create jane@mykolab.com, and add duplicate aliases to both accounts.

Jun 19 2020, 11:49 AM
vanmeeuwen requested changes to D1396: Fix created_at/updated_at on user settings added by UserObserver.

This should not at all be necessary. Is this just something that fixes some SQLite or something?

Jun 19 2020, 11:41 AM

Jun 15 2020

vanmeeuwen accepted D1378: Add copyright and company details in the page footer.
Jun 15 2020, 3:12 PM
vanmeeuwen accepted D1384: Mobile UI fixes.
Jun 15 2020, 3:04 PM
vanmeeuwen accepted D1366: Fix transaction description for domain entitlements.
Jun 15 2020, 2:59 PM
vanmeeuwen requested changes to D1378: Add copyright and company details in the page footer.

The copyright is not subject to configuration to be honest.

Jun 15 2020, 2:58 PM
vanmeeuwen added a comment to D1366: Fix transaction description for domain entitlements.

With question ;-)

Jun 15 2020, 2:56 PM
vanmeeuwen accepted D1372: Display a notice about the wallet state (Bifrost#T348752).
Jun 15 2020, 2:56 PM
vanmeeuwen requested changes to D1366: Fix transaction description for domain entitlements.

One question for the whodunnit.

Jun 15 2020, 2:53 PM
vanmeeuwen removed a reviewer for D1297: Make sure we bill for entitlements that are deleted: machniak.
Jun 15 2020, 2:50 PM
vanmeeuwen accepted D1297: Make sure we bill for entitlements that are deleted.
Jun 15 2020, 2:49 PM

Jun 10 2020

vanmeeuwen accepted D1360: Transaction log in admin UI.
Jun 10 2020, 11:32 AM
vanmeeuwen accepted D1354: Add plain text parts to email.
Jun 10 2020, 11:31 AM
vanmeeuwen accepted D1150: Wallet magic.
Jun 10 2020, 11:30 AM
vanmeeuwen accepted D1348: Receipts UI.
Jun 10 2020, 11:29 AM
vanmeeuwen accepted D1327: VAT on Receipts.
Jun 10 2020, 11:28 AM

Jun 4 2020

vanmeeuwen accepted D1267: Support: Awarding a bonus or penalty (Bifrost#T315896).
Jun 4 2020, 12:49 PM

Jun 3 2020

vanmeeuwen accepted D1309: Receipt document (html and pdf).
Jun 3 2020, 12:54 PM
vanmeeuwen accepted D1249: Wallet charge: top-ups and notifications.
Jun 3 2020, 12:18 PM
vanmeeuwen requested changes to D1249: Wallet charge: top-ups and notifications.
Jun 3 2020, 10:54 AM

Jun 2 2020

vanmeeuwen added a comment to D1249: Wallet charge: top-ups and notifications.
[2020-06-02 09:52:50] local.DEBUG: C: POST https://kanarip.dev.kolab.io/api/v4/payments/mandate [5.8M]: 6.7196 sec.  
[2020-06-02 09:52:50] local.DEBUG: [SQL] select * from `users` where `id` = ? and `users`.`deleted_at` is null limit 1 [3502450530]  
[2020-06-02 09:52:50] local.DEBUG: [SQL] select * from `wallets` where `wallets`.`user_id` = ? and `wallets`.`user_id` is not null [3502450530]  
[2020-06-02 09:52:50] local.DEBUG: [SQL] select * from `wallet_settings` where `wallet_settings`.`wallet_id` = ? and `wallet_settings`.`wallet_id` is not null and (`key` = ?) limit 1 [a68f5ac9-1425-4691-9cf1-eb0947c0c657, mandate_amount]  
[2020-06-02 09:52:50] local.DEBUG: [SQL] select * from `wallet_settings` where `wallet_settings`.`wallet_id` = ? and `wallet_settings`.`wallet_id` is not null and (`key` = ?) limit 1 [a68f5ac9-1425-4691-9cf1-eb0947c0c657, mandate_balance]  
[2020-06-02 09:52:50] local.DEBUG: [SQL] select * from `wallet_settings` where `wallet_settings`.`wallet_id` = ? and `wallet_settings`.`wallet_id` is not null [a68f5ac9-1425-4691-9cf1-eb0947c0c657]  
[2020-06-02 09:52:51] local.DEBUG: [SQL] select * from `wallet_settings` where `wallet_settings`.`wallet_id` = ? and `wallet_settings`.`wallet_id` is not null and (`key` = ?) limit 1 [a68f5ac9-1425-4691-9cf1-eb0947c0c657, mollie_mandate_id]  
[2020-06-02 09:52:51] local.DEBUG: [SQL] update `wallet_settings` set `value` = ?, `wallet_settings`.`updated_at` = ? where `id` = ? [mdt_QHSWvmRxxF, 2020-06-02 09:52:51, 4]  
[2020-06-02 09:52:51] local.DEBUG: [SQL] select * from `wallet_settings` where `wallet_settings`.`wallet_id` = ? and `wallet_settings`.`wallet_id` is not null [a68f5ac9-1425-4691-9cf1-eb0947c0c657]  
[2020-06-02 09:52:51] local.DEBUG: C: POST https://kanarip.dev.kolab.io/api/v4/payments/mandate [5.7M]: 0.7062 sec.  
[2020-06-02 09:53:09] local.DEBUG: [SQL] select * from `payments` where `payments`.`id` = ? limit 1 [tr_nr4hDVveMc]  
[2020-06-02 09:53:09] local.DEBUG: C: POST https://kanarip.dev.kolab.io/api/webhooks/payment/mollie [5M]: 0.0141 sec.  
[2020-06-02 09:53:09] local.DEBUG: C: GET https://kanarip.dev.kolab.io/wallet [4.4M]: 0.0398 sec.  
[2020-06-02 09:53:14] local.DEBUG: [SQL] select * from `users` where `id` = ? and `users`.`deleted_at` is null limit 1 [3502450530]  
[2020-06-02 09:53:14] local.DEBUG: [SQL] select * from `user_settings` where `user_settings`.`user_id` = ? and `user_settings`.`user_id` is not null and `key` in (?, ?, ?, ?, ?, ?, ?, ?) [3502450530, billing_address, country, currency, external_email, first_name, last_name, organization, phone]  
[2020-06-02 09:53:14] local.DEBUG: [SQL] select * from `user_aliases` where `user_aliases`.`user_id` = ? and `user_aliases`.`user_id` is not null [3502450530]  
[2020-06-02 09:53:14] local.DEBUG: [SQL] select * from `domains` where `namespace` = ? and `domains`.`deleted_at` is null limit 1 [kolab.org]  
[2020-06-02 09:53:14] local.DEBUG: [SQL] select * from `wallets` where `wallets`.`user_id` = ? and `wallets`.`user_id` is not null [3502450530]  
[2020-06-02 09:53:14] local.DEBUG: [SQL] select `wallets`.*, `user_accounts`.`user_id` as `pivot_user_id`, `user_accounts`.`wallet_id` as `pivot_wallet_id` from `wallets` inner join `user_accounts` on `wallets`.`id` = `user_accounts`.`wallet_id` where `user_accounts`.`user_id` = ? [3502450530]  
[2020-06-02 09:53:14] local.DEBUG: [SQL] select * from `entitlements` where `entitlements`.`entitleable_id` = ? and `entitlements`.`entitleable_id` is not null and `entitlements`.`entitleable_type` = ? and `entitlements`.`deleted_at` is null limit 1 [3502450530, App\User]  
[2020-06-02 09:53:14] local.DEBUG: [SQL] select * from `wallets` where `wallets`.`id` = ? limit 1 [a68f5ac9-1425-4691-9cf1-eb0947c0c657]  
[2020-06-02 09:53:14] local.DEBUG: C: GET https://kanarip.dev.kolab.io/api/auth/info [5.2M]: 0.0176 sec.  
[2020-06-02 09:53:28] local.DEBUG: [SQL] select * from `wallets` []  
[2020-06-02 09:53:28] local.DEBUG: [SQL] select * from `entitlements` where `entitlements`.`wallet_id` = ? and `entitlements`.`wallet_id` is not null and `entitlements`.`deleted_at` is null [130ee29b-3be0-4765-a3c1-e3eff405fb72]  
[2020-06-02 09:53:28] local.DEBUG: [SQL] select * from `entitlements` where `entitlements`.`wallet_id` = ? and `entitlements`.`wallet_id` is not null and `entitlements`.`deleted_at` is null [2bfe7b05-a3b5-4d0b-8d0b-b6ad6ab2c2a6]  
[2020-06-02 09:53:28] local.DEBUG: [SQL] select * from `entitlements` where `entitlements`.`wallet_id` = ? and `entitlements`.`wallet_id` is not null and `entitlements`.`deleted_at` is null [58d0e908-4e97-4bd2-a560-60abebb8396c]  
[2020-06-02 09:53:28] local.DEBUG: [SQL] select * from `entitlements` where `entitlements`.`wallet_id` = ? and `entitlements`.`wallet_id` is not null and `entitlements`.`deleted_at` is null [6af7868e-d2e7-4292-b7d0-fa48daa7c8c8]  
[2020-06-02 09:53:28] local.DEBUG: [SQL] select * from `entitlements` where `entitlements`.`wallet_id` = ? and `entitlements`.`wallet_id` is not null and `entitlements`.`deleted_at` is null [6e0d02fc-ab3e-41fd-aca9-1dca549b8468]  
[2020-06-02 09:53:28] local.DEBUG: [SQL] select * from `entitlements` where `entitlements`.`wallet_id` = ? and `entitlements`.`wallet_id` is not null and `entitlements`.`deleted_at` is null [70ff3911-5969-45fa-a7d5-a135098fb74f]  
[2020-06-02 09:53:28] local.DEBUG: [SQL] select * from `entitlements` where `entitlements`.`wallet_id` = ? and `entitlements`.`wallet_id` is not null and `entitlements`.`deleted_at` is null [756d00f3-2e21-454b-ad80-c5c4124446e5]  
[2020-06-02 09:53:28] local.DEBUG: [SQL] select * from `entitlements` where `entitlements`.`wallet_id` = ? and `entitlements`.`wallet_id` is not null and `entitlements`.`deleted_at` is null [7a65bd5e-54ad-44e0-a311-8e2369778a8f]  
[2020-06-02 09:53:28] local.DEBUG: [SQL] select * from `entitlements` where `entitlements`.`wallet_id` = ? and `entitlements`.`wallet_id` is not null and `entitlements`.`deleted_at` is null [9569982c-a092-4260-ba52-29050c70f878]  
[2020-06-02 09:53:28] local.DEBUG: [SQL] select * from `entitlements` where `entitlements`.`wallet_id` = ? and `entitlements`.`wallet_id` is not null and `entitlements`.`deleted_at` is null [a68f5ac9-1425-4691-9cf1-eb0947c0c657]  
[2020-06-02 09:53:28] local.DEBUG: [SQL] select * from `entitlements` where `id` in (?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?) [04a2562c-fcdc-4e62-b31c-fa82ed2ec6bc, 1626ec3e-10d9-4c01-9ddb-511bfb937dbf, 29ee7a84-cbd3-4878-a771-9ccb36685cfb, 37658d29-1433-4b57-880b-e0ba1d6672dc, 4526d709-81ec-4795-b5a6-e3db8a7bb724, 4736d839-a797-43fb-ac07-5ba07321a439, 4827c232-75ef-4791-9b43-c42f3580a10f, 495437a4-5c1d-4b7b-ad57-93dc7bb785ca, 4f9936df-c36b-4f7d-8d2c-39b49d1f996d, 703a9067-c22a-4981-947d-1bec9fbb0e4a, 81b1741f-cd7b-4b28-a009-2e97127caada, 81bcef55-6a1d-41dc-a85b-d901e60a9f1b, 832b65d6-9cdd-4fd5-a53f-afb15dccd86b, 90fa6408-40e3-4737-9cd5-bae201b3ee7e, 927a7128-89cb-40de-875f-d116c9f6a8f8, b12c478a-594e-4da9-8757-212a86fed750, b26e1d74-e098-4696-8a2b-82ff20eabf0b, ea603f31-093a-453e-9ddf-9f5dcf9acd41]  
[2020-06-02 09:53:28] local.DEBUG: [SQL] update `entitlements` set `entitlements`.`updated_at` = ? where `id` = ? [2020-06-02 09:52:13, 37658d29-1433-4b57-880b-e0ba1d6672dc]  
[2020-06-02 09:53:28] local.DEBUG: [SQL] update `entitlements` set `entitlements`.`updated_at` = ? where `id` = ? [2020-06-02 09:52:13, 4736d839-a797-43fb-ac07-5ba07321a439]  
[2020-06-02 09:53:28] local.DEBUG: [SQL] select * from `transactions` where `transactions`.`id` = ? limit 1 [1202e276-a798-4c9a-b595-46442d94cad7]  
[2020-06-02 09:53:28] local.DEBUG: [SQL] insert into `transactions` (`user_email`, `object_id`, `object_type`, `type`, `amount`, `id`, `updated_at`, `created_at`) values (?, ?, ?, ?, ?, ?, ?, ?) [, 4736d839-a797-43fb-ac07-5ba07321a439, App\Entitlement, billed, 555, 1202e276-a798-4c9a-b595-46442d94cad7, 2020-06-02 09:53:28, 2020-06-02 09:53:28]  
[2020-06-02 09:53:28] local.DEBUG: [SQL] update `entitlements` set `entitlements`.`updated_at` = ? where `id` = ? [2020-06-02 09:52:13, 4827c232-75ef-4791-9b43-c42f3580a10f]  
[2020-06-02 09:53:28] local.DEBUG: [SQL] update `entitlements` set `entitlements`.`updated_at` = ? where `id` = ? [2020-06-02 09:52:13, 495437a4-5c1d-4b7b-ad57-93dc7bb785ca]  
[2020-06-02 09:53:28] local.DEBUG: [SQL] select * from `transactions` where `transactions`.`id` = ? limit 1 [8e8ab001-f5fd-49f9-8397-f9936daa9991]  
[2020-06-02 09:53:28] local.DEBUG: [SQL] insert into `transactions` (`user_email`, `object_id`, `object_type`, `type`, `amount`, `id`, `updated_at`, `created_at`) values (?, ?, ?, ?, ?, ?, ?, ?) [, 495437a4-5c1d-4b7b-ad57-93dc7bb785ca, App\Entitlement, billed, 444, 8e8ab001-f5fd-49f9-8397-f9936daa9991, 2020-06-02 09:53:28, 2020-06-02 09:53:28]  
[2020-06-02 09:53:28] local.DEBUG: [SQL] update `wallets` set `balance` = ? where `id` = ? [-999, a68f5ac9-1425-4691-9cf1-eb0947c0c657]  
[2020-06-02 09:53:28] local.DEBUG: [SQL] select * from `transactions` where `transactions`.`id` = ? limit 1 [734b2767-0c46-4f1d-ba80-707b92f557ff]  
[2020-06-02 09:53:28] local.DEBUG: [SQL] insert into `transactions` (`user_email`, `object_id`, `object_type`, `type`, `amount`, `id`, `updated_at`, `created_at`) values (?, ?, ?, ?, ?, ?, ?, ?) [, a68f5ac9-1425-4691-9cf1-eb0947c0c657, App\Wallet, debit, 999, 734b2767-0c46-4f1d-ba80-707b92f557ff, 2020-06-02 09:53:28, 2020-06-02 09:53:28]  
[2020-06-02 09:53:28] local.DEBUG: [SQL] update `transactions` set `transaction_id` = ?, `transactions`.`updated_at` = ? where `id` in (?, ?) [734b2767-0c46-4f1d-ba80-707b92f557ff, 2020-06-02 09:53:28, 1202e276-a798-4c9a-b595-46442d94cad7, 8e8ab001-f5fd-49f9-8397-f9936daa9991]  
[2020-06-02 09:53:28] local.DEBUG: [SQL] select * from `users` where `users`.`id` = ? and `users`.`deleted_at` is null limit 1 [3502450530]  
[2020-06-02 09:53:28] local.DEBUG: [SQL] select * from `entitlements` where `entitlements`.`wallet_id` = ? and `entitlements`.`wallet_id` is not null and `entitlements`.`deleted_at` is null [b9b92209-a329-4a40-8460-021617425287]  
[2020-06-02 09:53:28] local.DEBUG: [SQL] select * from `entitlements` where `entitlements`.`wallet_id` = ? and `entitlements`.`wallet_id` is not null and `entitlements`.`deleted_at` is null [ccc43a57-a5d8-42c3-b120-43049da9ddff]  
[2020-06-02 09:53:28] local.DEBUG: [SQL] select * from `entitlements` where `entitlements`.`wallet_id` = ? and `entitlements`.`wallet_id` is not null and `entitlements`.`deleted_at` is null [cfba5a16-934e-450b-ab75-a6748b99754a]  
[2020-06-02 09:53:28] local.DEBUG: [SQL] select * from `entitlements` where `entitlements`.`wallet_id` = ? and `entitlements`.`wallet_id` is not null and `entitlements`.`deleted_at` is null [ede1a4a0-4e18-4758-8f72-57337c23bd1d]  
[2020-06-02 09:53:28] local.DEBUG: [SQL] select * from `entitlements` where `entitlements`.`wallet_id` = ? and `entitlements`.`wallet_id` is not null and `entitlements`.`deleted_at` is null [fb248b72-bf60-4db3-9a0d-348962e3e0ac]  
[2020-06-02 09:53:39] local.DEBUG: C: GET https://kanarip.dev.kolab.io/wallet [4.4M]: 0.0905 sec.  
[2020-06-02 09:53:44] local.DEBUG: [SQL] select * from `users` where `id` = ? and `users`.`deleted_at` is null limit 1 [3502450530]  
[2020-06-02 09:53:44] local.DEBUG: [SQL] select * from `user_settings` where `user_settings`.`user_id` = ? and `user_settings`.`user_id` is not null and `key` in (?, ?, ?, ?, ?, ?, ?, ?) [3502450530, billing_address, country, currency, external_email, first_name, last_name, organization, phone]  
[2020-06-02 09:53:44] local.DEBUG: [SQL] select * from `user_aliases` where `user_aliases`.`user_id` = ? and `user_aliases`.`user_id` is not null [3502450530]  
[2020-06-02 09:53:44] local.DEBUG: [SQL] select * from `domains` where `namespace` = ? and `domains`.`deleted_at` is null limit 1 [kolab.org]  
[2020-06-02 09:53:44] local.DEBUG: [SQL] select * from `wallets` where `wallets`.`user_id` = ? and `wallets`.`user_id` is not null [3502450530]  
[2020-06-02 09:53:44] local.DEBUG: [SQL] select `wallets`.*, `user_accounts`.`user_id` as `pivot_user_id`, `user_accounts`.`wallet_id` as `pivot_wallet_id` from `wallets` inner join `user_accounts` on `wallets`.`id` = `user_accounts`.`wallet_id` where `user_accounts`.`user_id` = ? [3502450530]  
[2020-06-02 09:53:44] local.DEBUG: [SQL] select * from `entitlements` where `entitlements`.`entitleable_id` = ? and `entitlements`.`entitleable_id` is not null and `entitlements`.`entitleable_type` = ? and `entitlements`.`deleted_at` is null limit 1 [3502450530, App\User]  
[2020-06-02 09:53:44] local.DEBUG: [SQL] select * from `wallets` where `wallets`.`id` = ? limit 1 [a68f5ac9-1425-4691-9cf1-eb0947c0c657]  
[2020-06-02 09:53:44] local.DEBUG: C: GET https://kanarip.dev.kolab.io/api/auth/info [5.2M]: 0.0189 sec.
Jun 2 2020, 12:06 PM
vanmeeuwen requested changes to D1249: Wallet charge: top-ups and notifications.
Jun 2 2020, 11:44 AM
vanmeeuwen added a comment to D1249: Wallet charge: top-ups and notifications.

I set up auto-payment for CHF 50 for john@kolab.org using https://kanarip.dev.kolab.io/ and the mollie provider, clicking through the mollie interface with status 'paid', but the balance remained -9,99 after I executed a wallet:charge.

Jun 2 2020, 11:03 AM

May 28 2020

vanmeeuwen added inline comments to D1150: Wallet magic.
May 28 2020, 2:06 PM
vanmeeuwen updated the diff for D1150: Wallet magic.
  • Implement costsPerDay()
May 28 2020, 2:05 PM
vanmeeuwen updated the diff for D1150: Wallet magic.
  • Simpler version
May 28 2020, 2:03 PM
vanmeeuwen updated the diff for D1150: Wallet magic.
  • Same test for wallet function
May 28 2020, 2:01 PM
vanmeeuwen updated the diff for D1150: Wallet magic.
  • Remove superfluous commands already a part of different differentials
  • Single query
  • Some initial extras
May 28 2020, 1:57 PM
vanmeeuwen updated the diff for D1150: Wallet magic.
  • Remove superfluous commands already a part of different differentials
  • Single query
  • Some initial extras
  • A simpler version of the same thing
May 28 2020, 1:55 PM
vanmeeuwen updated the diff for D1150: Wallet magic.
  • Single query
May 28 2020, 1:26 PM
vanmeeuwen added a child revision for D1150: Wallet magic: D1291: Cherry-picked contents from hkccp-import.
May 28 2020, 12:34 PM
vanmeeuwen added a parent revision for D1291: Cherry-picked contents from hkccp-import: D1150: Wallet magic.
May 28 2020, 12:34 PM
vanmeeuwen added a reviewer for D1150: Wallet magic: Restricted Project.
May 28 2020, 12:33 PM
vanmeeuwen updated the diff for D1150: Wallet magic.
  • Remove superfluous commands already a part of different differentials
May 28 2020, 12:33 PM
vanmeeuwen updated the diff for D1297: Make sure we bill for entitlements that are deleted.
  • Additional tests
  • Correct how many SKUs to add at zero cost, beyond existing ones
  • With doc
  • Improve finding the entitleable object
  • Adjust tests
  • Avoid unintentional changes
  • Fix phpstan issues
  • Add testUpdateEntitlements
  • Feedback
  • Use counting on the sql server side
May 28 2020, 12:31 PM
vanmeeuwen committed rKad257f28b608: An initial implementation of transactions. (authored by vanmeeuwen).
An initial implementation of transactions.
May 28 2020, 12:08 PM
vanmeeuwen closed D1102: An initial implementation of transactions..
May 28 2020, 12:08 PM
vanmeeuwen updated the diff for D1102: An initial implementation of transactions..
  • Uncomment
  • Rebase on current master
May 28 2020, 12:06 PM
vanmeeuwen committed rKe177a2f419e7: Make the id for a user fillable (authored by vanmeeuwen).
Make the id for a user fillable
May 28 2020, 11:58 AM
vanmeeuwen closed D1219: Make the id for a user fillable.
May 28 2020, 11:58 AM
vanmeeuwen requested changes to D1273: Support: Unsuspending/Suspending a user (Bifrost#T315890).

Needs rebasing for resources/sass/_variables.scss, then can be accepted I think.

May 28 2020, 11:52 AM
vanmeeuwen added a child revision for D1267: Support: Awarding a bonus or penalty (Bifrost#T315896): D1102: An initial implementation of transactions..
May 28 2020, 11:46 AM
vanmeeuwen added a parent revision for D1102: An initial implementation of transactions.: D1267: Support: Awarding a bonus or penalty (Bifrost#T315896).
May 28 2020, 11:46 AM
vanmeeuwen accepted D1303: Add command to render mail templates.
May 28 2020, 11:45 AM
vanmeeuwen updated the diff for D1297: Make sure we bill for entitlements that are deleted.
  • Feedback
May 28 2020, 11:28 AM
vanmeeuwen added inline comments to D1297: Make sure we bill for entitlements that are deleted.
May 28 2020, 11:28 AM
vanmeeuwen added inline comments to D1291: Cherry-picked contents from hkccp-import.
May 28 2020, 11:23 AM
vanmeeuwen updated the diff for D1291: Cherry-picked contents from hkccp-import.
  • Simplify getting to the actual wallet
  • Simplify getting to the wallet
  • Fix test to meet expectations
May 28 2020, 11:22 AM
vanmeeuwen updated the diff for D1219: Make the id for a user fillable.
  • Set new and active outside the user id test
  • Rebase on master
May 28 2020, 11:06 AM
vanmeeuwen updated the diff for D1297: Make sure we bill for entitlements that are deleted.
  • Add testUpdateEntitlements
May 28 2020, 10:30 AM
vanmeeuwen added a comment to D1297: Make sure we bill for entitlements that are deleted.

Looking at the code in context of removing entitlements, I see we might not handle removing storage entitlements properly. We have to add some tests to tests/Feature/Controller/UsersTest::testUpdateEntitlements().

May 28 2020, 8:35 AM

May 27 2020

vanmeeuwen updated the diff for D1297: Make sure we bill for entitlements that are deleted.
  • Fix phpstan issues
May 27 2020, 2:38 PM
vanmeeuwen updated the diff for D1297: Make sure we bill for entitlements that are deleted.
  • Avoid unintentional changes
May 27 2020, 2:20 PM
vanmeeuwen updated the diff for D1297: Make sure we bill for entitlements that are deleted.
  • Additional tests
  • Correct how many SKUs to add at zero cost, beyond existing ones
  • With doc
  • Improve finding the entitleable object
  • Adjust tests
May 27 2020, 2:18 PM
vanmeeuwen committed rK86f37d40ef58: Add a command db:ping and then use it (authored by vanmeeuwen).
Add a command db:ping and then use it
May 27 2020, 12:42 PM
vanmeeuwen closed D1285: Add a command db:ping and then use it.
May 27 2020, 12:42 PM
vanmeeuwen added a comment to D1297: Make sure we bill for entitlements that are deleted.

So far so good. I have two stories to consider:

  1. User is deleting and adding the same SKU every 13 days - got it for free.
  2. (After 14 days of using his account) user raises quota, then in 14 days he lowers it - got the "rised quota period" for free.
May 27 2020, 12:26 PM
vanmeeuwen planned changes to D1297: Make sure we bill for entitlements that are deleted.

This will need to be rebased on top of an accepted D1102.

May 27 2020, 11:37 AM
vanmeeuwen added a child revision for D1297: Make sure we bill for entitlements that are deleted: D1102: An initial implementation of transactions..
May 27 2020, 11:37 AM
vanmeeuwen added a parent revision for D1102: An initial implementation of transactions.: D1297: Make sure we bill for entitlements that are deleted.
May 27 2020, 11:37 AM
vanmeeuwen requested review of D1297: Make sure we bill for entitlements that are deleted.
May 27 2020, 11:36 AM
vanmeeuwen requested review of D1291: Cherry-picked contents from hkccp-import.
May 27 2020, 9:50 AM

May 26 2020

vanmeeuwen added inline comments to D1102: An initial implementation of transactions..
May 26 2020, 2:53 PM
vanmeeuwen updated the diff for D1102: An initial implementation of transactions..
  • Use the $entitleable variable
  • Use initialized variable
May 26 2020, 2:51 PM
vanmeeuwen requested review of D1285: Add a command db:ping and then use it.
May 26 2020, 1:47 PM
vanmeeuwen updated the diff for D1102: An initial implementation of transactions..
  • The $id parameter is supposed to be a string
  • A second proposal to transactions
  • Update for D1102 review
  • Resolve some comments for D1102
  • Use constants
  • Remove unintentional commenting out
  • Add some tests
May 26 2020, 12:54 PM
vanmeeuwen committed rK2b1d422c9dd4: Ensure that these directories exist (authored by vanmeeuwen).
Ensure that these directories exist
May 26 2020, 12:44 PM
vanmeeuwen planned changes to D1102: An initial implementation of transactions..
May 26 2020, 12:43 PM
vanmeeuwen updated the diff for D1102: An initial implementation of transactions..

Rebase on current master;

May 26 2020, 12:43 PM

May 25 2020

vanmeeuwen added inline comments to D1102: An initial implementation of transactions..
May 25 2020, 11:44 PM
vanmeeuwen requested review of D1102: An initial implementation of transactions..

Let us review the one single line item for the moment.

May 25 2020, 11:06 PM
vanmeeuwen updated the diff for D1102: An initial implementation of transactions..
  • Update for D1102 review
May 25 2020, 4:29 PM
vanmeeuwen planned changes to D1102: An initial implementation of transactions..

OK, I read no objections against the principles underpinning this implementation, but there are a few things that need fixing.

May 25 2020, 10:27 AM

May 22 2020

vanmeeuwen updated the diff for D1102: An initial implementation of transactions..
  • The $id parameter is supposed to be a string
  • A second proposal to transactions
May 22 2020, 2:44 PM

May 11 2020

vanmeeuwen committed rK6170ff2e3654: Strip superfluous snippets (authored by vanmeeuwen).
Strip superfluous snippets
May 11 2020, 1:55 PM
vanmeeuwen committed rK9f31ca4f950f: Demo of not setting turn/stun (authored by vanmeeuwen).
Demo of not setting turn/stun
May 11 2020, 12:57 PM
vanmeeuwen committed rKca3a60557dfc: Remove tmpfs mounts (authored by vanmeeuwen).
Remove tmpfs mounts
May 11 2020, 12:57 PM

May 9 2020

vanmeeuwen committed rKaeea82482868: Authenticate migrated LDAP passwords correctly (authored by vanmeeuwen).
Authenticate migrated LDAP passwords correctly
May 9 2020, 1:15 PM

May 8 2020

vanmeeuwen committed rK919c1b9aa7a8: Remove ssl-dhparams.conf again (authored by vanmeeuwen).
Remove ssl-dhparams.conf again
May 8 2020, 5:00 PM
vanmeeuwen committed rK55791e1a2870: Correct linting issue (authored by vanmeeuwen).
Correct linting issue
May 8 2020, 3:42 PM
vanmeeuwen committed rK8ece08852738: A room has an owner (authored by vanmeeuwen).
A room has an owner
May 8 2020, 3:42 PM
vanmeeuwen committed rK09ec1495740f: Additional information for sessions (authored by vanmeeuwen).
Additional information for sessions
May 8 2020, 3:42 PM
vanmeeuwen committed rK4c7b564ab2d2: Provide and use a random string generator for room names (authored by vanmeeuwen).
Provide and use a random string generator for room names
May 8 2020, 1:35 PM
vanmeeuwen committed rK329233613b3d: Differentiate between the room and the session (authored by vanmeeuwen).
Differentiate between the room and the session
May 8 2020, 1:35 PM
vanmeeuwen committed rK35aa6a9922f4: Also publish APP_DOMAIN to openvidu (authored by vanmeeuwen).
Also publish APP_DOMAIN to openvidu
May 8 2020, 1:35 PM
vanmeeuwen committed rKb122e16bdeaa: Correct ssl dhparams (authored by vanmeeuwen).
Correct ssl dhparams
May 8 2020, 1:35 PM
vanmeeuwen committed rK9d7b89071570: Separate meet. from the main app (authored by vanmeeuwen).
Separate meet. from the main app
May 8 2020, 11:31 AM
vanmeeuwen committed rK253c05c6921e: Ensure that the .env file as used with docker-compose is amended before we… (authored by vanmeeuwen).
Ensure that the .env file as used with docker-compose is amended before we…
May 8 2020, 11:31 AM

May 4 2020

vanmeeuwen added a member for Syncroton Developers: mollekopf.
May 4 2020, 11:26 AM

May 1 2020

vanmeeuwen committed rKf9cdf71a417f: Adjust the default for the coturn redis database number (authored by vanmeeuwen).
Adjust the default for the coturn redis database number
May 1 2020, 12:19 PM
vanmeeuwen committed rKfbcbf99c3ec4: Docker environment enhancements (authored by vanmeeuwen).
Docker environment enhancements
May 1 2020, 12:02 PM