Page MenuHomePhorge

Payers chart
ClosedPublic

Authored by machniak on Jul 20 2022, 12:09 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Mar 25, 1:32 AM
Unknown Object (File)
Mon, Mar 25, 1:32 AM
Unknown Object (File)
Mon, Mar 25, 1:32 AM
Unknown Object (File)
Mon, Mar 25, 1:32 AM
Unknown Object (File)
Sun, Mar 24, 10:30 AM
Unknown Object (File)
Sat, Mar 23, 9:42 AM
Unknown Object (File)
Fri, Mar 22, 10:10 PM
Unknown Object (File)
Sun, Mar 17, 12:57 PM
Subscribers
Restricted Project

Details

Reviewers
mollekopf
Group Reviewers
Restricted Project
Commits
rK0cc97e891a36: Payers chart
rK67da9f8cd37c: Payers chart
Test Plan

./phpunit

Diff Detail

Repository
rK kolab
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

machniak created this revision.
mollekopf added inline comments.
src/app/Console/Commands/Data/Stats/CollectorCommand.php
75

If suspended means they also don't currently pay, let's exclude them as well. (I'm not sure what degraded vs suspended vs non-active means), but I think the goal is to get an estimate for "active" users (and we use that they are paying as a proxy for that).

76

Let's exclude them since we have the users separately.

vanmeeuwen added inline comments.
src/app/Console/Commands/Data/Stats/CollectorCommand.php
75

A suspended user is suspended because of spam nowadays. There's no way for these accounts to revive themselves, IIRC. They can simply be excluded.

A degraded user is a non-paying user, and should be included (stacked on top of active? could we?).

  • Payers chart: Exclude suspended users
This revision is now accepted and ready to land.Jul 26 2022, 2:16 PM
This revision was automatically updated to reflect the committed changes.