Page MenuHomekolab.org

Payers chart
ClosedPublic

Authored by machniak on Wed, Jul 20, 12:09 PM.

Details

Reviewers
mollekopf
Group Reviewers
Restricted Project
Commits
rK67da9f8cd37c: Payers chart
rK0cc97e891a36: Payers chart
Test Plan

./phpunit

Diff Detail

Repository
rK kolab
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

machniak requested review of this revision.Wed, Jul 20, 12:09 PM
machniak created this revision.
mollekopf added inline comments.
src/app/Console/Commands/Data/Stats/CollectorCommand.php
75

If suspended means they also don't currently pay, let's exclude them as well. (I'm not sure what degraded vs suspended vs non-active means), but I think the goal is to get an estimate for "active" users (and we use that they are paying as a proxy for that).

76

Let's exclude them since we have the users separately.

vanmeeuwen added inline comments.
src/app/Console/Commands/Data/Stats/CollectorCommand.php
75

A suspended user is suspended because of spam nowadays. There's no way for these accounts to revive themselves, IIRC. They can simply be excluded.

A degraded user is a non-paying user, and should be included (stacked on top of active? could we?).

machniak updated this revision to Diff 10661.Thu, Jul 21, 2:48 PM
  • Payers chart: Exclude suspended users
mollekopf accepted this revision.Tue, Jul 26, 2:16 PM
This revision is now accepted and ready to land.Tue, Jul 26, 2:16 PM
Closed by commit rK0cc97e891a36: Payers chart (authored by machniak, committed by Christian Mollekopf <mollekopf@apheleia-it.ch>). · Explain WhyTue, Jul 26, 2:18 PM
This revision was automatically updated to reflect the committed changes.