Paths

Table of Contentst

Differential D3728

Payers chart
ClosedPublic
Actions

Authored by machniak on Jul 20 2022, 12:09 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Wed, Apr 17, 9:32 AM

	Unknown Object (File)
	Tue, Apr 16, 3:59 AM

	Unknown Object (File)
	Sat, Apr 13, 5:50 AM

	Unknown Object (File)
	Sat, Apr 13, 3:00 AM

	Unknown Object (File)
	Fri, Apr 12, 12:32 PM

	Unknown Object (File)
	Tue, Apr 9, 11:27 AM

	Unknown Object (File)
	Mon, Apr 8, 7:00 PM

	Unknown Object (File)
	Sun, Apr 7, 10:03 AM

View All 66 Files

Subscribers

Restricted Project

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rK0cc97e891a36: Payers chart
rK67da9f8cd37c: Payers chart

Test Plan

./phpunit

Diff Detail

Repository

Branch

dev/payers-chart-cron

Lint

Lint Skipped

Unit

No Test Coverage

Build Status

Buildable 39497
Build 16091: arc lint + arc unit

Event Timeline

machniak requested review of this revision.Jul 20 2022, 12:09 PM

machniak created this revision.

Harbormaster completed remote builds in B39497: Diff 10649.Jul 20 2022, 12:09 PM

mollekopf subscribed.Jul 21 2022, 9:39 AM

mollekopf added inline comments.

src/app/Console/Commands/Data/Stats/CollectorCommand.php
74	If suspended means they also don't currently pay, let's exclude them as well. (I'm not sure what degraded vs suspended vs non-active means), but I think the goal is to get an estimate for "active" users (and we use that they are paying as a proxy for that).
75	Let's exclude them since we have the users separately.

vanmeeuwen subscribed.Jul 21 2022, 12:05 PM

vanmeeuwen added inline comments.

src/app/Console/Commands/Data/Stats/CollectorCommand.php
74	A suspended user is suspended because of spam nowadays. There's no way for these accounts to revive themselves, IIRC. They can simply be excluded. A degraded user is a non-paying user, and should be included (stacked on top of active? could we?).

Payers chart: Exclude suspended users

Harbormaster completed remote builds in B39509: Diff 10661.Jul 21 2022, 2:48 PM

mollekopf mentioned this in D3716: Payers chart.Jul 22 2022, 4:52 PM

mollekopf accepted this revision.Jul 26 2022, 2:16 PM

This revision is now accepted and ready to land.Jul 26 2022, 2:16 PM

Closed by commit rK0cc97e891a36: Payers chart (authored by machniak, committed by mollekopf). · Explain WhyJul 26 2022, 2:18 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

app/

Console/

Commands/

Data/

Stats/

CollectorCommand.php

90 lines

3 lines

Http/

Controllers/

API/

V4/

Admin/

StatsController.php

86 lines

Reseller/

StatsController.php

1 line

database/

migrations/

2022_07_19_100000_create_stats_table.php

40 lines

resources/

lang/

en/

1 line

vue/

Admin/

2 lines

Reseller/

2 lines

tests/

Browser/

Admin/

3 lines

Reseller/

3 lines

Feature/

Console/

Data/

Stats/

CollectorTest.php

77 lines

Controller/

Admin/

41 lines

Diff 10649

src/app/Console/Commands/Data/Stats/CollectorCommand.php

Loading...

src/app/Console/Kernel.php

Loading...

src/app/Http/Controllers/API/V4/Admin/StatsController.php

Loading...

src/app/Http/Controllers/API/V4/Reseller/StatsController.php

Loading...

src/database/migrations/2022_07_19_100000_create_stats_table.php

Loading...

src/resources/lang/en/app.php

Loading...

src/resources/vue/Admin/Stats.vue

Loading...

src/resources/vue/Reseller/Stats.vue

Loading...

src/tests/Browser/Admin/StatsTest.php

Loading...

src/tests/Browser/Reseller/StatsTest.php

Loading...

src/tests/Feature/Console/Data/Stats/CollectorTest.php

Loading...

src/tests/Feature/Controller/Admin/StatsTest.php

Loading...