Page MenuHomePhorge

SMTP content filter
ClosedPublic

Authored by machniak on Oct 2 2024, 12:13 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Feb 8, 1:09 AM
Unknown Object (File)
Sat, Feb 8, 1:09 AM
Unknown Object (File)
Sat, Feb 8, 1:09 AM
Unknown Object (File)
Sat, Feb 8, 1:09 AM
Unknown Object (File)
Sat, Feb 8, 1:09 AM
Unknown Object (File)
Sat, Feb 8, 1:09 AM
Unknown Object (File)
Sat, Feb 8, 1:09 AM
Unknown Object (File)
Sat, Feb 8, 1:09 AM
Subscribers
Restricted Project

Details

Reviewers
mollekopf
Group Reviewers
Restricted Project
Commits
rKf816b72a099a: SMTP content filter
Summary

The engine

Test Plan

./phpunit

Diff Detail

Repository
rK kolab
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

machniak created this revision.
  • Set back SWOOLE_PACKAGE_MAX_LENGTH to 10MB
  • Support multipart/form-data file uploads, they don't need so much memory
  • Don't require specific file name
  • Invitations policy
  • Split itip handling into per-method classes
mollekopf subscribed.

Besides the one complaint I think this can go in. I didn't investigate the rules in detail, but it's standalone enough that pushing it seems fairly risk free.

src/app/Policy/Mailfilter/RequestHandler.php
67

Still really don't like the string assembly to class approach. Just use the Class (App\Policy\Mailfilter\Modules\ItipModule::class) to fill the array.

This for instance immediately make it evident if there is a typo, or a class is deleted but still used here etc.

This revision is now accepted and ready to land.Oct 31 2024, 10:38 AM
This revision was landed with ongoing or failed builds.Oct 31 2024, 2:27 PM
Closed by commit rKf816b72a099a: SMTP content filter (authored by machniak). · Explain Why
This revision was automatically updated to reflect the committed changes.