Page MenuHomePhorge
Differential D4965

Metrics controller
AcceptedPublic
Actions

Authored by mollekopf on Tue, Oct 1, 12:59 PM.

Details

Reviewers
machniak
Group Reviewers
Restricted Project

Diff Detail

Repository
rK kolab
Lint
Lint Skipped
Unit
No Test Coverage
Build Status
Buildable 50640
Build 18432: arc lint + arc unit

Event Timeline

mollekopf requested review of this revision.Tue, Oct 1, 12:59 PM
mollekopf created this revision.
Harbormaster completed remote builds in B50640: Diff 14226.Tue, Oct 1, 12:59 PM
mollekopf added a reviewer: Restricted Project.Tue, Oct 1, 1:00 PM
machniak accepted this revision.Tue, Oct 1, 1:50 PM
machniak subscribed.

Looks good, but for consistency both queries should use tenant context and the same way of comparing user status.

This revision is now accepted and ready to land.Tue, Oct 1, 1:50 PM

Revision Contents
Changeset List

PathSize
src/
app/
Http/
Controllers/
API/
V4/
117 lines
routes/
1 line
tests/
Feature/
Controller/
40 lines

Diff 14226

View Options

src/app/Http/Controllers/API/V4/MetricsController.php

Loading...
View Options

src/routes/api.php

Loading...
View Options

src/tests/Feature/Controller/MetricsTest.php

Loading...