Page MenuHomePhorge
Differential D3149

Signup limits
ClosedPublic
Actions

Authored by vanmeeuwen on Dec 24 2021, 10:52 AM.
Tags
None
Referenced Files
F10576921: D3149.diff
Wed, Nov 29, 7:00 PM
Unknown Object (File)
Sat, Nov 25, 8:11 AM
Unknown Object (File)
Fri, Nov 24, 5:57 AM
Unknown Object (File)
Thu, Nov 23, 5:05 PM
Unknown Object (File)
Sat, Nov 18, 6:59 AM
Unknown Object (File)
Oct 18 2023, 5:07 PM
Unknown Object (File)
Oct 12 2023, 4:23 PM
Unknown Object (File)
Oct 9 2023, 9:28 AM
View All 13 Files
Subscribers
mollekopf
Restricted Project

Details

Reviewers
machniak
vanmeeuwen
Group Reviewers
Restricted Project
Commits
rKce233afa436f: Signup limits
Summary

TODO:

  • add index on signup_codes.ip_address and signup_codes.email columns
  • make sure the stored email is lowercased?
Test Plan

./phpunit

Diff Detail

Repository
rK kolab
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

machniak requested review of this revision.Dec 24 2021, 10:52 AM
machniak created this revision.
Harbormaster completed remote builds in B37463: Diff 8972.Dec 24 2021, 10:53 AM
mollekopf subscribed.Dec 24 2021, 10:58 AM
mollekopf added inline comments.
src/app/Rules/SignupExternalEmail.php
31

Add a comment that we deliberately give the "wrong" reason to not disclose information.

vanmeeuwen commandeered this revision.Dec 24 2021, 3:04 PM
vanmeeuwen added a reviewer: machniak.
vanmeeuwen updated this revision to Diff 8978.Dec 24 2021, 3:07 PM
  • Add commentary about the apparent inaccuracy of the message
Harbormaster completed remote builds in B37469: Diff 8978.Dec 24 2021, 3:07 PM
vanmeeuwen accepted this revision.Dec 24 2021, 3:09 PM
This revision is now accepted and ready to land.Dec 24 2021, 3:09 PM
Closed by commit rKce233afa436f: Signup limits (authored by vanmeeuwen). · Explain WhyDec 24 2021, 3:11 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
3 lines
app/
Http/
Controllers/
API/
4 lines
Rules/
2 lines
50 lines
config/
5 lines
tests/
Feature/
Controller/
70 lines

Diff 8984

View Options

src/.env.example

Loading...
View Options

src/app/Http/Controllers/API/SignupController.php

Loading...
View Options

src/app/Rules/ExternalEmail.php

Loading...
View Options

src/app/Rules/SignupExternalEmail.php

Loading...
View Options

src/config/app.php

Loading...
View Options

src/tests/Feature/Controller/SignupTest.php

Loading...