Page MenuHomekolab.org

Signup limits
ClosedPublic

Authored by vanmeeuwen on Dec 24 2021, 10:52 AM.

Details

Reviewers
machniak
vanmeeuwen
Group Reviewers
Restricted Project
Commits
rKce233afa436f: Signup limits
Summary

TODO:

  • add index on signup_codes.ip_address and signup_codes.email columns
  • make sure the stored email is lowercased?
Test Plan

./phpunit

Diff Detail

Repository
rK kolab
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

machniak requested review of this revision.Dec 24 2021, 10:52 AM
machniak created this revision.
mollekopf added inline comments.
src/app/Rules/SignupExternalEmail.php
31

Add a comment that we deliberately give the "wrong" reason to not disclose information.

vanmeeuwen commandeered this revision.Dec 24 2021, 3:04 PM
vanmeeuwen added a reviewer: machniak.
vanmeeuwen updated this revision to Diff 8978.Dec 24 2021, 3:07 PM
  • Add commentary about the apparent inaccuracy of the message
vanmeeuwen accepted this revision.Dec 24 2021, 3:09 PM
This revision is now accepted and ready to land.Dec 24 2021, 3:09 PM
This revision was automatically updated to reflect the committed changes.