Page MenuHomePhorge

Signup limits
ClosedPublic

Authored by vanmeeuwen on Dec 24 2021, 10:52 AM.
Tags
None
Referenced Files
F11589021: D3149.id8972.diff
Thu, Mar 28, 9:56 PM
F11588100: D3149.id8984.diff
Thu, Mar 28, 7:19 PM
Unknown Object (File)
Thu, Mar 28, 3:12 AM
Unknown Object (File)
Mon, Mar 25, 1:17 AM
Unknown Object (File)
Mon, Mar 25, 1:17 AM
Unknown Object (File)
Mon, Mar 25, 1:17 AM
Unknown Object (File)
Mon, Mar 25, 1:17 AM
Unknown Object (File)
Sun, Mar 24, 11:08 AM
Subscribers
Restricted Project

Details

Reviewers
machniak
vanmeeuwen
Group Reviewers
Restricted Project
Commits
rKce233afa436f: Signup limits
Summary

TODO:

  • add index on signup_codes.ip_address and signup_codes.email columns
  • make sure the stored email is lowercased?
Test Plan

./phpunit

Diff Detail

Repository
rK kolab
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

machniak created this revision.
mollekopf added inline comments.
src/app/Rules/SignupExternalEmail.php
31

Add a comment that we deliberately give the "wrong" reason to not disclose information.

  • Add commentary about the apparent inaccuracy of the message
This revision is now accepted and ready to land.Dec 24 2021, 3:09 PM
This revision was automatically updated to reflect the committed changes.