Details

Reviewers

vanmeeuwen
mollekopf

Group Reviewers

Restricted Project

Commits

rK566da9b3c5f9: Password reset link

Test Plan

./phpunit

Diff Detail

Repository

rK kolab

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

machniak requested review of this revision.Jan 14 2022, 2:49 PM

machniak created this revision.

Harbormaster completed remote builds in B37990: Diff 9373.Jan 14 2022, 2:49 PM

Merge branch 'master' into dev/password-link

Harbormaster completed remote builds in B38002: Diff 9382.Jan 14 2022, 2:51 PM

vanmeeuwen requested changes to this revision.Jan 14 2022, 2:58 PM

vanmeeuwen subscribed.

vanmeeuwen added inline comments.

src/app/Http/Controllers/API/PasswordResetController.php
158	password reset codes should be valid for a far shorter period, perhaps as long as 24 hours but no more.
src/app/Http/Controllers/API/V4/UsersController.php
494	`min:4` => `min:6` `max:2048` => `max:255`
src/app/Observers/VerificationCodeObserver.php
44	isn't that a database schema thing already?
src/app/VerificationCode.php
27	Here's it 8 hours, elsewhere I see 7 days.
src/tests/Browser/UsersTest.php
96–99	Can we `$john` `$user`?

This revision now requires changes to proceed.Jan 14 2022, 2:58 PM

Fixes requsted in the diff, set expiration time to 24h

Harbormaster completed remote builds in B38008: Diff 9388.Jan 14 2022, 3:28 PM

Merge branch 'master' into dev/password-link

Harbormaster completed remote builds in B38026: Diff 9394.Jan 18 2022, 12:52 PM

machniak mentioned this in D3319: Password Policy.Jan 25 2022, 11:59 AM

Fix order of codes in password reset link

Harbormaster completed remote builds in B38131: Diff 9481.Jan 26 2022, 2:19 PM

Harbormaster completed remote builds in B38131: Diff 9481.

mollekopf accepted this revision.Jan 26 2022, 2:44 PM

This revision was not accepted when it landed; it landed in state Needs Review.Jan 27 2022, 2:39 PM

Closed by commit rK566da9b3c5f9: Password reset link (authored by machniak). · Explain Why

This revision was automatically updated to reflect the committed changes.

machniak mentioned this in rK9ae41aa9253e: Password Policy.

Password reset link
ClosedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 9493

src/app/Http/Controllers/API/PasswordResetController.php

src/app/Http/Controllers/API/V4/UsersController.php

src/app/Observers/VerificationCodeObserver.php

src/app/VerificationCode.php

src/database/migrations/2022_01_13_100000_verification_code_active_column.php

src/resources/js/fontawesome.js

src/resources/lang/en/app.php

src/resources/lang/en/ui.php

src/resources/vue/User/Info.vue

src/resources/vue/User/Profile.vue

src/routes/api.php

src/tests/Browser/UserProfileTest.php

src/tests/Browser/UsersTest.php

src/tests/Feature/Controller/PasswordResetTest.php

src/tests/Feature/Controller/UsersTest.php

src/tests/Feature/VerificationCodeTest.php

Password reset linkClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 9493

src/app/Http/Controllers/API/PasswordResetController.php

src/app/Http/Controllers/API/V4/UsersController.php

src/app/Observers/VerificationCodeObserver.php

src/app/VerificationCode.php

src/database/migrations/2022_01_13_100000_verification_code_active_column.php

src/resources/js/fontawesome.js

src/resources/lang/en/app.php

src/resources/lang/en/ui.php

src/resources/vue/User/Info.vue

src/resources/vue/User/Profile.vue

src/routes/api.php

src/tests/Browser/UserProfileTest.php

src/tests/Browser/UsersTest.php

src/tests/Feature/Controller/PasswordResetTest.php

src/tests/Feature/Controller/UsersTest.php

src/tests/Feature/VerificationCodeTest.php

Password reset link
ClosedPublic
Actions

Revision Contents
Changeset List