Page MenuHomekolab.org

Password reset link
ClosedPublic

Authored by machniak on Jan 14 2022, 2:49 PM.

Details

Reviewers
vanmeeuwen
mollekopf
Group Reviewers
Restricted Project
Commits
rK566da9b3c5f9: Password reset link
Test Plan

./phpunit

Diff Detail

Repository
rK kolab
Branch
dev/password-link
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 38131
Build 15421: arc lint + arc unit

Event Timeline

machniak requested review of this revision.Jan 14 2022, 2:49 PM
machniak created this revision.
machniak updated this revision to Diff 9382.Jan 14 2022, 2:51 PM
  • Merge branch 'master' into dev/password-link
vanmeeuwen requested changes to this revision.Jan 14 2022, 2:58 PM
vanmeeuwen added a subscriber: vanmeeuwen.
vanmeeuwen added inline comments.
src/app/Http/Controllers/API/PasswordResetController.php
158

password reset codes should be valid for a far shorter period, perhaps as long as 24 hours but no more.

src/app/Http/Controllers/API/V4/UsersController.php
494

min:4 => min:6
max:2048 => max:255

src/app/Observers/VerificationCodeObserver.php
44

isn't that a database schema thing already?

src/app/VerificationCode.php
27

Here's it 8 hours, elsewhere I see 7 days.

src/tests/Browser/UsersTest.php
96–99

Can we $john $user?

This revision now requires changes to proceed.Jan 14 2022, 2:58 PM
machniak updated this revision to Diff 9388.Jan 14 2022, 3:28 PM
  • Fixes requsted in the diff, set expiration time to 24h
machniak updated this revision to Diff 9394.Jan 18 2022, 12:52 PM
  • Merge branch 'master' into dev/password-link
machniak updated this revision to Diff 9481.Jan 26 2022, 2:19 PM
  • Fix order of codes in password reset link
Harbormaster completed remote builds in B38131: Diff 9481.
mollekopf accepted this revision.Jan 26 2022, 2:44 PM
This revision was not accepted when it landed; it landed in state Needs Review.Jan 27 2022, 2:39 PM
Closed by commit rK566da9b3c5f9: Password reset link (authored by machniak). · Explain Why
This revision was automatically updated to reflect the committed changes.