Details

Reviewers

vanmeeuwen
mollekopf

Group Reviewers

Restricted Project

Commits

rK566da9b3c5f9: Password reset link

Test Plan

./phpunit

Diff Detail

Repository

rK kolab

Branch

dev/password-link

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 38131
Build 15421: arc lint + arc unit

Event Timeline

machniak requested review of this revision.Jan 14 2022, 2:49 PM

machniak created this revision.

Harbormaster completed remote builds in B37990: Diff 9373.Jan 14 2022, 2:49 PM

Merge branch 'master' into dev/password-link

Harbormaster completed remote builds in B38002: Diff 9382.Jan 14 2022, 2:51 PM

vanmeeuwen requested changes to this revision.Jan 14 2022, 2:58 PM

vanmeeuwen added a subscriber: vanmeeuwen.

vanmeeuwen added inline comments.

src/app/Http/Controllers/API/PasswordResetController.php
158	password reset codes should be valid for a far shorter period, perhaps as long as 24 hours but no more.
src/app/Http/Controllers/API/V4/UsersController.php
494	`min:4` => `min:6` `max:2048` => `max:255`
src/app/Observers/VerificationCodeObserver.php
44	isn't that a database schema thing already?
src/app/VerificationCode.php
27	Here's it 8 hours, elsewhere I see 7 days.
src/tests/Browser/UsersTest.php
96–99	Can we `$john` `$user`?

This revision now requires changes to proceed.Jan 14 2022, 2:58 PM

Fixes requsted in the diff, set expiration time to 24h

Harbormaster completed remote builds in B38008: Diff 9388.Jan 14 2022, 3:28 PM

Merge branch 'master' into dev/password-link

Harbormaster completed remote builds in B38026: Diff 9394.Jan 18 2022, 12:52 PM

machniak mentioned this in D3319: Password Policy.Jan 25 2022, 11:59 AM

Fix order of codes in password reset link

Harbormaster completed remote builds in B38131: Diff 9481.Jan 26 2022, 2:19 PM

Harbormaster completed remote builds in B38131: Diff 9481.

mollekopf accepted this revision.Jan 26 2022, 2:44 PM

This revision was not accepted when it landed; it landed in state Needs Review.Jan 27 2022, 2:39 PM

Closed by commit rK566da9b3c5f9: Password reset link (authored by machniak). · Explain Why

This revision was automatically updated to reflect the committed changes.

machniak mentioned this in rK9ae41aa9253e: Password Policy.

		Path
M		src/app/Http/Controllers/API/PasswordResetController.php (65 lines)
M		src/app/Http/Controllers/API/V4/UsersController.php (51 lines)
M		src/app/Observers/VerificationCodeObserver.php (11 lines)
M		src/app/VerificationCode.php (25 lines)
A	M	src/database/migrations/2022_01_13_100000_verification_code_active_column.php (39 lines)
M		src/resources/js/fontawesome.js (2 lines)
M		src/resources/lang/en/app.php (2 lines)
M		src/resources/lang/en/ui.php (4 lines)
M		src/resources/vue/User/Info.vue (118 lines)
M		src/resources/vue/User/Profile.vue (15 lines)
M		src/routes/api.php (3 lines)
M		src/tests/Browser/UserProfileTest.php (7 lines)
M		src/tests/Browser/UsersTest.php (112 lines)
M		src/tests/Feature/Controller/PasswordResetTest.php (78 lines)
M		src/tests/Feature/Controller/UsersTest.php (55 lines)
M		src/tests/Feature/VerificationCodeTest.php (8 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	9373	a9ad119		Jan 14 2022, 2:49 PM	★	★
Diff 2	9382	3d74399	- Merge branch 'master' into dev/password-link	Jan 14 2022, 2:51 PM	★	★
Diff 3	9388	3d74399	- Fixes requsted in the diff, set expiration time to 24h	Jan 14 2022, 3:28 PM	★	★
Diff 4	9394	6374137	- Merge branch 'master' into dev/password-link	Jan 18 2022, 12:51 PM	★	★
Diff 5	9481	6374137	- Fix order of codes in password reset link	Jan 26 2022, 2:19 PM	★	★
Diff 6	9493	0946512	rK566da9b3c5f9fd6673f1d4cd8765b52a68046716	Jan 27 2022, 2:38 PM	★	★

Commit	Tree	Parents	Author	Summary	Date
6d37f3001af5	400947a5b4cf	6e5650318c19	Aleksander Machniak	Fix order of codes in password reset link	Jan 26 2022, 2:18 PM
6e5650318c19	332393f3d276	3de482167505 63741372535a	Aleksander Machniak	Merge branch 'master' into dev/password-link	Jan 18 2022, 12:51 PM
3de482167505	edba4ef77bb2	94ed68d63647	Aleksander Machniak	Fixes requsted in the diff, set expiration time to 24h	Jan 14 2022, 3:26 PM
94ed68d63647	377e2f026e9b	6ad547707d6f 3d7439962063	Aleksander Machniak	Merge branch 'master' into dev/password-link	Jan 14 2022, 2:51 PM
6ad547707d6f	f21bbf6a603a	8e5f7931f5a9	Aleksander Machniak	Password reset link (Show More…)	Jan 14 2022, 2:48 PM
8e5f7931f5a9	1b0d4659f8f7	393acc8a0629	Aleksander Machniak	Browser tests	Jan 14 2022, 2:47 PM
393acc8a0629	a0249bc92c9c	81872a6d0a80	Aleksander Machniak	Tests and fixes	Jan 14 2022, 11:23 AM
81872a6d0a80	a1927cbbc4ce	a9ad1196af9c	Aleksander Machniak	Password reset link	Jan 13 2022, 3:40 PM

Password reset link
ClosedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 9481

src/app/Http/Controllers/API/PasswordResetController.php

src/app/Http/Controllers/API/V4/UsersController.php

src/app/Observers/VerificationCodeObserver.php

src/app/VerificationCode.php

src/database/migrations/2022_01_13_100000_verification_code_active_column.php

src/resources/js/fontawesome.js

src/resources/lang/en/app.php

src/resources/lang/en/ui.php

src/resources/vue/User/Info.vue

src/resources/vue/User/Profile.vue

src/routes/api.php

src/tests/Browser/UserProfileTest.php

src/tests/Browser/UsersTest.php

src/tests/Feature/Controller/PasswordResetTest.php

src/tests/Feature/Controller/UsersTest.php

src/tests/Feature/VerificationCodeTest.php

Password reset linkClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 9481

src/app/Http/Controllers/API/PasswordResetController.php

src/app/Http/Controllers/API/V4/UsersController.php

src/app/Observers/VerificationCodeObserver.php

src/app/VerificationCode.php

src/database/migrations/2022_01_13_100000_verification_code_active_column.php

src/resources/js/fontawesome.js

src/resources/lang/en/app.php

src/resources/lang/en/ui.php

src/resources/vue/User/Info.vue

src/resources/vue/User/Profile.vue

src/routes/api.php

src/tests/Browser/UserProfileTest.php

src/tests/Browser/UsersTest.php

src/tests/Feature/Controller/PasswordResetTest.php

src/tests/Feature/Controller/UsersTest.php

src/tests/Feature/VerificationCodeTest.php

Password reset link
ClosedPublic
Actions

Revision Contents
Changeset List