[WIP] Handle other mailrecipient objects in findObjectsByRecipientAddress()
Needs ReviewPublic
Actions

Authored by machniak on Jan 30 2023, 12:05 PM.

Details

Reviewers

mollekopf

Group Reviewers

Restricted Project

Summary

The function should return all mailrecipients not only users.

Maybe it needs an argument to return only these that implement senderPolicyFrameworkWhitelist()
on request.

Also, it probably should return all of them if e.g. there's an alias to a user and resource at the same time.

Test Plan

./phpunit

Diff Detail

Repository

rK kolab

Branch

dev/findObjectsByRecipientAddress

Lint

Lint Skipped

Unit

No Test Coverage

Build Status

Buildable 42971
Build 17270: arc lint + arc unit

Event Timeline

machniak requested review of this revision.Jan 30 2023, 12:05 PM

machniak created this revision.

Harbormaster completed remote builds in B41371: Diff 11524.Feb 2 2023, 11:39 AM

mollekopf accepted this revision.Mar 23 2023, 7:54 AM

This revision is now accepted and ready to land.Mar 23 2023, 7:54 AM

I didn't consider this diff complete. Before we merge this I'd like to know answers to my questions about the findObjectsByRecipientAddress() method:

Does it needs an argument to return only these objects that implement senderPolicyFrameworkWhitelist() method?
Should it return all objects if e.g. there's an alias to a user and resource at the same time? Right now it's the first found.

In D4033#50252, @machniak wrote:

I didn't consider this diff complete. Before we merge this I'd like to know answers to my questions about the findObjectsByRecipientAddress() method:

Does it needs an argument to return only these objects that implement senderPolicyFrameworkWhitelist() method?

Should it return all objects if e.g. there's an alias to a user and resource at the same time? Right now it's the first found.

Do shared mail folders and recipients alike have greylisting settings at all?

In D4033#50378, @vanmeeuwen wrote:

Do shared mail folders and recipients alike have greylisting settings at all?

Nope, but they could have in future. Also, the method is used not only in the greylisting context. I don't really know all implications, but just looking at the method itself I felt it's incomplete.

Right now findObjectsByRecipientAddress() method is used in:

PolicyController::senderPolicyFramework() where we check returned objects that implement 'senderPolicyFrameworkWhitelist` (i.e. right now only users).
Policy/Greylist/Request::recipientFromRequest() where we just take the first object returned.