bin/quickstart.sh enhancements
ClosedPublic
Actions

Authored by mollekopf on Nov 15 2021, 10:03 AM.

Details

Reviewers

machniak
vanmeeuwen

Group Reviewers

Restricted Project

Commits

Summary

Only build the containers we use
Fixed check for chromium
Ensure cgroupv2 is disabled on host (required for docker to work)
Ignore import errors (in case the OX api key is not set for instance)
Don't hardcode the composer binary path

Diff Detail

Repository

rK kolab

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

mollekopf requested review of this revision.Nov 15 2021, 10:03 AM

mollekopf created this revision.

Harbormaster completed remote builds in B37067: Diff 8609.Nov 15 2021, 10:03 AM

mollekopf added a reviewer: Restricted Project.Nov 17 2021, 2:02 PM

Rebased and run horizon in the background as well

Harbormaster completed remote builds in B37717: Diff 9151.Jan 7 2022, 4:50 PM

Rebased

Harbormaster completed remote builds in B37741: Diff 9178.Jan 7 2022, 4:58 PM

mollekopf added a subscriber: Restricted Project.Jan 7 2022, 5:02 PM

machniak requested changes to this revision.Jan 25 2022, 10:36 AM

machniak subscribed.

machniak added inline comments.

bin/quickstart.sh
54	There's no meet container in master.

This revision now requires changes to proceed.Jan 25 2022, 10:36 AM

vanmeeuwen requested changes to this revision.Jan 25 2022, 1:17 PM

vanmeeuwen subscribed.

vanmeeuwen added inline comments.

bin/quickstart.sh
103	nohup ./artisan please, redirect output to `>/dev/null 2>&1` not needed for swoole, that's properly daemonized

This revision was not accepted when it landed; it landed in state Needs Revision.Jan 25 2022, 3:51 PM

Closed by commit rKb2193862feda: bin/quickstart.sh enhancements (authored by mollekopf). · Explain Why

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

bin/

quickstart.sh

16 lines

Diff 9445

View Options

bin/quickstart.sh enhancementsClosedPublicActions