Page MenuHomePhorge
Differential D3023

bin/quickstart.sh enhancements
ClosedPublic
Actions

Authored by mollekopf on Nov 15 2021, 10:03 AM.
Tags
None
Referenced Files
F11877669: D3023.diff
Wed, Apr 24, 9:32 AM
Unknown Object (File)
Sun, Apr 21, 4:32 PM
Unknown Object (File)
Sun, Apr 21, 4:32 PM
Unknown Object (File)
Sun, Apr 21, 4:32 PM
Unknown Object (File)
Sun, Apr 21, 4:32 PM
Unknown Object (File)
Sun, Apr 21, 4:32 PM
Unknown Object (File)
Sat, Apr 20, 1:19 PM
Unknown Object (File)
Wed, Apr 17, 8:57 AM
View All 70 Files
Subscribers
machniak
vanmeeuwen
Restricted Project

Details

Reviewers
machniak
vanmeeuwen
Group Reviewers
Restricted Project
Commits
rKb2193862feda: bin/quickstart.sh enhancements
rKc416fc92109d: bin/quickstart.sh enhancements
rKb0fe21e23b26: bin/quickstart.sh enhancements
rKf3d34412c14a: bin/quickstart.sh enhancements
rKe42e3c3a5245: bin/quickstart.sh enhancements
rKf878676a4fc2: bin/quickstart.sh enhancements
rK656452748d99: bin/quickstart.sh enhancements
rK673a8d65521f: bin/quickstart.sh enhancements
rKfa9d1652cc41: bin/quickstart.sh enhancements
rK22bdbc0c432d: bin/quickstart.sh enhancements
rKfd0510253dfa: bin/quickstart.sh enhancements
rKae61900d9e07: bin/quickstart.sh enhancements
rKa84c2e53f484: bin/quickstart.sh enhancements
rK9570552772d2: bin/quickstart.sh enhancements
rKde1cf1385d44: bin/quickstart.sh enhancements
rK8a37039a4c75: bin/quickstart.sh enhancements
rK0d27971c5f73: bin/quickstart.sh enhancements
Summary
  • Only build the containers we use
  • Fixed check for chromium
  • Ensure cgroupv2 is disabled on host (required for docker to work)
  • Ignore import errors (in case the OX api key is not set for instance)
  • Don't hardcode the composer binary path

Diff Detail

Repository
rK kolab
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 37717
Build 15175: arc lint + arc unit

Event Timeline

mollekopf requested review of this revision.Nov 15 2021, 10:03 AM
mollekopf created this revision.
Harbormaster completed remote builds in B37067: Diff 8609.Nov 15 2021, 10:03 AM
mollekopf added a reviewer: Restricted Project.Nov 17 2021, 2:02 PM
mollekopf updated this revision to Diff 9151.Jan 7 2022, 4:50 PM
mollekopf edited the summary of this revision. (Show Details)

Rebased and run horizon in the background as well

Harbormaster completed remote builds in B37717: Diff 9151.Jan 7 2022, 4:50 PM
mollekopf updated this revision to Diff 9178.Jan 7 2022, 4:58 PM

Rebased

Harbormaster completed remote builds in B37741: Diff 9178.Jan 7 2022, 4:58 PM
mollekopf added a subscriber: Restricted Project.Jan 7 2022, 5:02 PM
machniak requested changes to this revision.Jan 25 2022, 10:36 AM
machniak subscribed.
machniak added inline comments.
bin/quickstart.sh
54

There's no meet container in master.

This revision now requires changes to proceed.Jan 25 2022, 10:36 AM
vanmeeuwen requested changes to this revision.Jan 25 2022, 1:17 PM
vanmeeuwen subscribed.
vanmeeuwen added inline comments.
bin/quickstart.sh
103

nohup ./artisan please,
redirect output to >/dev/null 2>&1

not needed for swoole, that's properly daemonized

This revision was not accepted when it landed; it landed in state Needs Revision.Jan 25 2022, 3:51 PM
Closed by commit rKb2193862feda: bin/quickstart.sh enhancements (authored by mollekopf). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
bin/
16 lines

Diff 9151

View Options

bin/quickstart.sh

Loading...