Details
Details
- Reviewers
vanmeeuwen - Group Reviewers
Restricted Project - Commits
- rK99cd06f6e286: A blue default theme, and fixed the copyright
rKf0f460b2c9dc: A blue default theme
rKd962305ecf74: A blue default theme
rK97bb402e4031: A blue default theme
Diff Detail
Diff Detail
- Repository
- rK kolab
- Lint
Lint Warnings Severity Location Code Message Warning src/resources/themes/default/lang/en/support.php:6 PHPCS.W.Generic.Files.LineLength.TooLong Generic.Files.LineLength.TooLong - Unit
No Test Coverage - Build Status
Buildable 42071 Build 16919: arc lint + arc unit
Event Timeline
Comment Actions
Modification of the default theme.json will break some browser tests. We e.g. assert that /support page and faq entries work.
I also don't like this blue color.
Comment Actions
Ok, I'll look into it.
I also don't like this blue color.
It's a bit in your face I agree, but I don't think we should change the color just here. We should have one kolab.org blue and use that (on websites and application). Atm. this is the blue we have.
I could see us revert to more grey, with blue highlights though for a less overwhelming UI.
Comment Actions
Fixed tests that we broke.
I think it's fine to remove the items, we still test the overall mechanism.
| src/config/app.php | ||
|---|---|---|
| 242 | copyright shouldn't change. | |