Page MenuHomePhorge

Do not set the Content-Length on the download response

Authored by mollekopf on Mar 23 2023, 9:00 AM.
Referenced Files
Unknown Object (File)
Tue, Dec 5, 1:33 PM
Unknown Object (File)
Fri, Dec 1, 8:50 AM
Unknown Object (File)
Wed, Nov 29, 7:28 PM
Unknown Object (File)
Sat, Nov 25, 8:46 AM
Unknown Object (File)
Fri, Nov 24, 3:16 AM
Unknown Object (File)
Sat, Nov 18, 1:07 AM
Unknown Object (File)
Tue, Nov 14, 10:06 PM
Unknown Object (File)
Sun, Nov 12, 7:13 PM



Seems related to:

Apparently swoole uses the chunked transfer encoding,
and according to the rfc we're not supposed to set Content-Length in
that case.

In any case with the Content-Length header swoole crashes, without
everything seems to work.

Diff Detail

rK kolab
Lint Not Applicable
Tests Not Applicable

Event Timeline

mollekopf created this revision.
mollekopf added a reviewer: Restricted Project.Mar 23 2023, 9:30 AM
machniak subscribed.

I was thinking that we could do a separate code path for small files that has only one chunk and send Content-Length for them, but it could be done later and I didn't really tested that.

This revision is now accepted and ready to land.Mar 23 2023, 11:51 AM
This revision was automatically updated to reflect the committed changes.