Page MenuHomePhorge

Do not set the Content-Length on the download response

Authored by mollekopf on Mar 23 2023, 9:00 AM.
Referenced Files
F10375996: D4187.diff
Tue, Oct 3, 11:47 AM
Unknown Object (File)
Thu, Sep 28, 8:54 PM
Unknown Object (File)
Tue, Sep 26, 1:39 AM



Seems related to:

Apparently swoole uses the chunked transfer encoding,
and according to the rfc we're not supposed to set Content-Length in
that case.

In any case with the Content-Length header swoole crashes, without
everything seems to work.

Diff Detail

rK kolab
Lint Passed
No Test Coverage
Build Status
Buildable 42086
Build 16934: arc lint + arc unit

Event Timeline

mollekopf created this revision.
mollekopf added a reviewer: Restricted Project.Mar 23 2023, 9:30 AM
machniak subscribed.

I was thinking that we could do a separate code path for small files that has only one chunk and send Content-Length for them, but it could be done later and I didn't really tested that.

This revision is now accepted and ready to land.Mar 23 2023, 11:51 AM
This revision was automatically updated to reflect the committed changes.