Page MenuHomekolab.org
Differential D4148

Don't try to assign a package to null
ClosedPublic
Actions

Authored by mollekopf on Sat, Mar 11, 12:50 PM.

Details

Reviewers
machniak
Group Reviewers
Restricted Project
Commits
rK51dc74706faa: Don't try to assign a package to null
rKa03daef28896: Don't try to assign a package to null
rK17de81a34e00: Don't try to assign a package to null
rK5aacd3479a6f: Don't try to assign a package to null
rK187c8fdb7d87: Don't try to assign a package to null
rK5e84bef4ead5: Don't try to assign a package to null

Diff Detail

Repository
rK kolab
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

mollekopf requested review of this revision.Sat, Mar 11, 12:50 PM
mollekopf created this revision.
mollekopf added a reviewer: Restricted Project.Sat, Mar 11, 12:54 PM

Not entirely sure if there is a valid case where we end up passing a domain package, but not a domain to assignPlan. I ran into this at some point, but maybe I'll have to reproduce first.

machniak added a subscriber: machniak.Mon, Mar 13, 12:06 PM

I'd say it should throw an exception.

mollekopf planned changes to this revision.Thu, Mar 23, 7:50 AM
mollekopf updated this revision to Diff 11960.Thu, Mar 23, 9:00 AM

Throwing an exception now to be a bit more explicit than then crash when trying to access null

machniak accepted this revision.Thu, Mar 23, 9:09 AM
This revision is now accepted and ready to land.Thu, Mar 23, 9:09 AM
This revision was landed with ongoing or failed builds.Sun, Mar 26, 11:32 PM
Closed by commit rK187c8fdb7d87: Don't try to assign a package to null (authored by Christian Mollekopf <mollekopf@apheleia-it.ch>). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/app/User.php (3 lines)

Diff 12044

View Options

src/app/User.php

Loading...