Page MenuHomePhorge

Don't try to assign a package to null

Authored by mollekopf on Mar 11 2023, 12:50 PM.
Referenced Files
Unknown Object (File)
Fri, Jul 5, 2:02 PM
Unknown Object (File)
Thu, Jul 4, 8:41 AM
Unknown Object (File)
Jun 9 2024, 10:24 PM
Unknown Object (File)
Jun 8 2024, 9:10 PM
Unknown Object (File)
Jun 8 2024, 1:57 PM
Unknown Object (File)
Jun 8 2024, 9:53 AM
Unknown Object (File)
Jun 5 2024, 2:23 PM
Unknown Object (File)
May 27 2024, 6:01 AM

Diff Detail

rK kolab
Lint Not Applicable
Tests Not Applicable

Event Timeline

mollekopf created this revision.
mollekopf added a reviewer: Restricted Project.Mar 11 2023, 12:54 PM

Not entirely sure if there is a valid case where we end up passing a domain package, but not a domain to assignPlan. I ran into this at some point, but maybe I'll have to reproduce first.

I'd say it should throw an exception.

Throwing an exception now to be a bit more explicit than then crash when trying to access null

This revision is now accepted and ready to land.Mar 23 2023, 9:09 AM
This revision was landed with ongoing or failed builds.Mar 26 2023, 11:32 PM
This revision was automatically updated to reflect the committed changes.