Page MenuHomePhorge

Don't try to assign a package to null

Authored by mollekopf on Mar 11 2023, 12:50 PM.
Referenced Files
Unknown Object (File)
Wed, Nov 29, 7:25 PM
Unknown Object (File)
Sat, Nov 25, 8:43 AM
Unknown Object (File)
Fri, Nov 24, 3:26 AM
Unknown Object (File)
Tue, Nov 21, 6:56 PM
Unknown Object (File)
Thu, Nov 16, 5:01 PM
Unknown Object (File)
Sun, Nov 12, 9:22 AM
Unknown Object (File)
Wed, Nov 8, 6:52 PM
Unknown Object (File)
Wed, Nov 8, 6:51 PM

Diff Detail

rK kolab
Lint Not Applicable
Tests Not Applicable

Event Timeline

mollekopf created this revision.
mollekopf added a reviewer: Restricted Project.Mar 11 2023, 12:54 PM

Not entirely sure if there is a valid case where we end up passing a domain package, but not a domain to assignPlan. I ran into this at some point, but maybe I'll have to reproduce first.

I'd say it should throw an exception.

Throwing an exception now to be a bit more explicit than then crash when trying to access null

This revision is now accepted and ready to land.Mar 23 2023, 9:09 AM
This revision was landed with ongoing or failed builds.Mar 26 2023, 11:32 PM
This revision was automatically updated to reflect the committed changes.