Don't try to assign a package to null
ClosedPublic
Actions

Authored by mollekopf on Mar 11 2023, 12:50 PM.

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rK187c8fdb7d87: Don't try to assign a package to null
rK17de81a34e00: Don't try to assign a package to null
rK5aacd3479a6f: Don't try to assign a package to null
rK5e84bef4ead5: Don't try to assign a package to null
rKa03daef28896: Don't try to assign a package to null
rK51dc74706faa: Don't try to assign a package to null

Diff Detail

Repository

rK kolab

Lint

Lint Errors

Severity	Location	Code	Message
Error	src/app/User.php:65	phpstan	Property App\User::$allowed_states is never read, only written.

Unit

No Test Coverage

Build Status

Buildable 42083
Build 16931: arc lint + arc unit

Event Timeline

mollekopf requested review of this revision.Mar 11 2023, 12:50 PM

mollekopf created this revision.

Harbormaster completed remote builds in B41984: Diff 11888.Mar 11 2023, 12:50 PM

Not entirely sure if there is a valid case where we end up passing a domain package, but not a domain to assignPlan. I ran into this at some point, but maybe I'll have to reproduce first.

I'd say it should throw an exception.

mollekopf planned changes to this revision.Mar 23 2023, 7:50 AM

Throwing an exception now to be a bit more explicit than then crash when trying to access null

Harbormaster completed remote builds in B42083: Diff 11960.Mar 23 2023, 9:00 AM

machniak accepted this revision.Mar 23 2023, 9:09 AM

This revision is now accepted and ready to land.Mar 23 2023, 9:09 AM

This revision was landed with ongoing or failed builds.Mar 26 2023, 11:32 PM

Closed by commit rK187c8fdb7d87: Don't try to assign a package to null (authored by mollekopf). · Explain Why

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

app/

User.php

3 lines

Diff 11960

View Options

Don't try to assign a package to nullClosedPublicActions