Don't require setting a name
ClosedPublic
Actions

Authored by mollekopf on Mar 23 2023, 12:04 PM.

Project Tags

None

Referenced Files

None

Subscribers

Details

Reviewers

machniak

Group Reviewers

Restricted Project

Commits

Summary

When creating a new device for pairing, we can just generate the name.
It will be replaced during pairing anyways with the device name.

Also, instead if there already exists a corresponding device we can just
show the existing one.

Repository

rK kolab

Lint

Lint Not Applicable

Unit

Tests Not Applicable

mollekopf requested review of this revision.Mar 23 2023, 12:04 PM

mollekopf created this revision.

mollekopf added a reviewer: Restricted Project.Mar 23 2023, 12:31 PM

machniak added inline comments.

src/resources/vue/CompanionApp/Info.vue
92–96	This request should probably be done only if the previous one was successful.
src/resources/vue/CompanionApp/List.vue
69	I think we should not use localized labels as an identifier (name). It will not work if user changes the name or UI language.

src/resources/vue/CompanionApp/Info.vue
92–96	Nothing improves by doing the second conditionally and this way we're doing them in parallel.
src/resources/vue/CompanionApp/List.vue
69	The name is not used as id, it's just a name for display. I agree that the mechanism used here to show existing instead of creating a new device by matching the name is not the prettiest approach, but it should normally work, and if it doesn't (because the language was changed) no harm is done either. The alternative would be to show the last device that was created that isn't paired, with the risk of picking the wrong one for recovery or regular. So I think we should just leave it as is, unless you have a good alternative approach.