- rK kolab
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.
I could extract the original test and put it into the kolabnow deployment config if we wanted that.
FWIW; I'm still facing failing tests in some payment tests as well as Tests\Browser\SignupTest and Tests\Browser\WalletTest. I couldn't figure those out just yet.
I fixed SignupTest in master, WalletTest works for me. Mollie payment tests fail because of https://github.com/mollie/mollie-api-php/issues/649 and I'm not sure what to do about it.
As for the diff... How about we make the support page to look like https://kolabnow.com/support, but hide the right-side box if app.support_email is not set? If you're a company that installs Kolab for your employees only, you still might find this support channel useful. That means that we'd have to set this option to something (like email@example.com for config.dev) to keep the test.
As discussed. I fail to test disabling the support form currently (no idea why), but it seems to work fine in practice.
Changing the config in browser tests doesn't work because we're testing code served via octane...
Soo, not sure how to test this.
Updated commented test with comment why we can't currently test this.
There seem to be some fairly elaborate workarounds possible in principle at least:
We already have a way to set config options:
$browser->execScript(sprintf('Object.assign(window.config, %s)', \json_encode($config)));
For payment providers we have an additional mechanism that passes the setting to the backend via headers. See https://git.kolab.org/source/kolab/browse/master/src/resources/js/app.js$371 I suppose we could make it a bit more universal mechanism. See also App\Http\Middleware\DevelConfig.
After trying various approaches I've settled on using the cache to propagate the values.