Only create the necessary minimum of skus for the

Authored by mollekopf on Sat, Mar 11, 12:49 PM.



In we just create the skus that we require, for the
domain-hosting and beta sku, we adjust the code so we enable the features if
the sku doesn't exist at all.

All sku related migrations have to be dropped from the main migrations,
as the skus are environment specific. I also dropped them from
config.demo, since we already set the appropriate values in the seeder,
so the migrations are pointless.

Original commits:

  • Enable beta entitlements if the beta sku doesn't exist
  • Drop sku related migrations
  • ImapAdminSeeder
  • Enable domain-hosting features if there is no domain-hosting sku
  • Minimal set of skus in the admin seeder

Diff Detail

rK kolab
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

mollekopf requested review of this revision.Sat, Mar 11, 12:49 PM
mollekopf created this revision.
mollekopf added a reviewer: Restricted Project.Sat, Mar 11, 12:55 PM

I'll look into the lint problems.

mollekopf updated this revision to Diff 11897.Sat, Mar 11, 7:00 PM

Fixed lint issues (the remaining ones only appear in arc lint)

machniak requested changes to this revision.Mon, Mar 13, 12:39 PM
machniak added a subscriber: machniak.

You removed some core migration files. That means that there will be references to non-existing files in the database (migrations table). I don't know whether this can cause any issues in the future. Maybe not.


This should be Sku::withObjectTenantContext($user).


This should be Sku::withObjectTenantContext($user).


I suppose, if we do such cleanup, this one could also be removed.

This revision now requires changes to proceed.Mon, Mar 13, 12:39 PM
mollekopf updated this revision to Diff 11924.Wed, Mar 22, 10:51 AM

Addressed comments

machniak accepted this revision.Wed, Mar 22, 11:11 AM
This revision is now accepted and ready to land.Wed, Mar 22, 11:11 AM
Closed by commit rK1a40fcaeb3ec: Only create the necessary minimum of skus for the (authored by Christian Mollekopf <>). · Explain WhySun, Mar 26, 11:32 PM
This revision was automatically updated to reflect the committed changes.