Page MenuHomePhorge

Only create the necessary minimum of skus for the config.prod
ClosedPublic

Authored by mollekopf on Mar 11 2023, 12:49 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Apr 13, 12:36 PM
Unknown Object (File)
Fri, Apr 5, 6:19 AM
Unknown Object (File)
Mon, Mar 18, 2:09 AM
Unknown Object (File)
Mar 17 2024, 11:37 AM
Unknown Object (File)
Feb 25 2024, 8:26 AM
Unknown Object (File)
Feb 17 2024, 7:21 PM
Unknown Object (File)
Feb 17 2024, 2:35 PM
Unknown Object (File)
Jan 28 2024, 2:05 PM
Subscribers

Details

Summary

In config.prod we just create the skus that we require, for the
domain-hosting and beta sku, we adjust the code so we enable the features if
the sku doesn't exist at all.

All sku related migrations have to be dropped from the main migrations,
as the skus are environment specific. I also dropped them from
config.demo, since we already set the appropriate values in the seeder,
so the migrations are pointless.

Original commits:

  • Enable beta entitlements if the beta sku doesn't exist
  • Drop sku related migrations
  • ImapAdminSeeder
  • Enable domain-hosting features if there is no domain-hosting sku
  • Minimal set of skus in the admin seeder

Diff Detail

Repository
rK kolab
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 42050
Build 16895: arc lint + arc unit

Event Timeline

mollekopf created this revision.
mollekopf added a reviewer: Restricted Project.Mar 11 2023, 12:55 PM

I'll look into the lint problems.

Fixed lint issues (the remaining ones only appear in arc lint)

machniak subscribed.

You removed some core migration files. That means that there will be references to non-existing files in the database (migrations table). I don't know whether this can cause any issues in the future. Maybe not.

src/app/Http/Controllers/API/V4/UsersController.php
174

This should be Sku::withObjectTenantContext($user).

186

This should be Sku::withObjectTenantContext($user).

src/database/migrations/2021_11_25_100000_create_shared_folders_table.php
49–50

I suppose, if we do such cleanup, this one could also be removed.

This revision now requires changes to proceed.Mar 13 2023, 12:39 PM
This revision is now accepted and ready to land.Mar 22 2023, 11:11 AM
This revision was automatically updated to reflect the committed changes.