Sorry, I didn't mean to imply otherwise on the 389ds issue, I knew it was upstream that was broken but also that it is required for Kolab and has been stopping an update to 20.04.

BTW, I noted that some of your differentials cannot be easily used. arc patch returns "Base commit is not in local repository". Then I get:

Checking patch docker/synapse/rootfs/opt/app-root/src/init.sh...
error: docker/synapse/rootfs/opt/app-root/src/init.sh: does not exist in index
Checking patch docker/synapse/rootfs/opt/app-root/src/homeserver.yaml...
error: docker/synapse/rootfs/opt/app-root/src/homeserver.yaml: does not exist in index
Checking patch docker/synapse/Dockerfile...
error: docker/synapse/Dockerfile: does not exist in index
Checking patch config.prod/src/database/seeds/PassportSeeder.php...
Checking patch config.demo/src/database/seeds/PassportSeeder.php...
Checking patch ci/testctl...
Hunk #1 succeeded at 111 (offset -1 lines).
Checking patch ci/env...
error: while searching for:
MEET_SERVER_TOKEN=simple123
PASSPORT_PROXY_OAUTH_CLIENT_ID=5909ca4f-df7e-45fe-b355-e7c195aef117
PASSPORT_PROXY_OAUTH_CLIENT_SECRET=3URb+3JGJM9wPuDnlUSTPOw2mqmHsoOV8NXanx9xwQM=
DES_KEY=kBxUM/53N9p9abusAoT0ZEAxwI2pxFz/

I'm going to write tests.

Great find! I'm wondering where else we have the same assumption...

389ds update issue resides on Ubuntu, it is not a Kolab issue.

• Better const name

Please do, that might help me get the 389ds update for ubuntu functioning and get me off of 18.04 finally.

Cleanup

Separate token scope

• EWS: Fix some contact properties in exported vCard
• EWS: Fix lists handling
• EWS: Improved tasks handling

I can second that. I ran into this issue as well. The dependency is not configured therefore the package is missing when doing dnf install kolab.

Hi there,
I was just able to successfully upgrade from CentOS 7 to Almalinux 9. Everything seems to be working the in place upgrade of the 389ds and the cyrus imapd were a bit of a hassle, but after testing it several times based on backups it worked ok. I can share my list of commands.

I managed to get the package updated but I still cannot send from the webmail interface, I see the same errors in roundcube/errors.log (with a new line number)

[15-Jul-2024 14:24:45 -0400]: <ka2vqi5j> PHP Error: STARTTLS failed (POST /webmail/hF3kdGo6e2kLGlvH/?_task=mail&_unlock=loading1721067885788&_framed=1&_action=send)
[15-Jul-2024 14:24:45 -0400]: <ka2vqi5j> PHP Error: Invalid response code received from server (POST /webmail/hF3kdGo6e2kLGlvH/?_task=mail&_unlock=loading1721067885788&_framed=1&_action=send)
[15-Jul-2024 14:24:45 -0400]: <ka2vqi5j> SMTP Error: Authentication failure: STARTTLS failed (Code: ) in /usr/share/roundcubemail/program/lib/Roundcube/rcube.php on line 1815 (POST /webmail/hF3kdGo6e2kLGlvH/?_task=mail&_unlock=loading1721067885788&_framed=1&_action=send)

I don't think this should be closed, the roundcube-1.5.7.4-1 package which contains the fix is not installable on Ubuntu 18.04 (it conflicts with roundcube-plugins-kolab) so this is an open issue for me.

sync bcc via eas 16.0

Nope. If you do this the header will be send to every recipient. Note that we're unsetting the header in $smtp_headers only here. The copy of the message saved to Sent folder should contain Bcc header intact.

Thanks. Fixed.

Update request: https://obs.kolabsys.com/request/show/3299

Looks good to me.

In favor of the other diff

In D4845: IMAP data migrator and other improvements I took this differential of yours, but I re-implemented some things differently. I think it's cleaner. Still a lot of TODO lines there. So, we might improve while writing tests. I have also an idea to try to do mail streaming for best performance.

This can be submitted once it is clear that it has the desired effect.

It seems to me we should:

• Adjust the catch in https://git.kolab.org/diffusion/RPK/browse/master/plugins/libcalendaring/lib/libcalendaring_vcalendar.php (to specifically just ignore a broken itip).
• Adjust all the catches in Sync.php to also catch Throwable
• Add a test that triggers this error to the syncroton testsuite
• Remove the catch in this patch again, so we don't end up with 3 layers potentially catching.

..

Throwable catches that fatal error. Now looking at this I found that we could change the catch in https://git.kolab.org/diffusion/RPK/browse/master/plugins/libcalendaring/lib/libcalendaring_vcalendar.php$158

• It's a debug not a warning

• Move sorting to later place

• Fix sorting callback

• Fix sign

In D4839#59874, @machniak wrote:

Indeed. I just noticed that the actual error wasn't an exception. It was PHP Fatal error: Uncaught Error: __clone method called on non-object in /usr/share/roundcubemail/plugins/libcalendaring/lib/libcalendaring_vcalendar.php:633, so to catch it we'd have to catch Throwable, I suppose, I'm not sure.

Still, it makes sense to not skip the entire message, but sync it as it was a normal message, ignoring the fact it has an invitation.