Page MenuHomePhorge
Feed All Stories

Fri, Feb 7

machniak updated the diff for D5092: Files migration from Kolab v3 to Kolab v4.
  • Migrate DAV folder ACL into Kolab4-style sharees
Fri, Feb 7, 3:43 PM

Wed, Feb 5

machniak updated the diff for D5096: Prevent a duplicate mail submission.
  • Add SendMail command tests
Wed, Feb 5, 3:07 PM

Tue, Feb 4

machniak updated the diff for D5096: Prevent a duplicate mail submission.
  • Cleanup
Tue, Feb 4, 1:27 PM
machniak requested review of D5096: Prevent a duplicate mail submission.
Tue, Feb 4, 1:26 PM

Mon, Feb 3

machniak requested review of D5094: Remove redundant Domain::unsuspend().
Mon, Feb 3, 11:12 AM
machniak committed rS433a2d92c7c4: Remove unused property (authored by machniak).
Remove unused property
Mon, Feb 3, 10:57 AM

Thu, Jan 30

emunson added a comment to T8379: Upgrade path from Ubuntu 18.04 or the future of kolab packages.

So the 389-ds packages are a mess in Ubuntu. The tools and scripts needed to update the on disk formats are not built and when I enable them they are broken. I am not sure if the upstream source is broken or it comes from the patches applied by Debian or Ubuntu. The only thing that I found worked was moving the contents of /var/lib/dirsrv and /etc/dirsrv to a backup, then upgrade from 18.04 to 20.04 and return the contents before rebooting. There were several other hiccups in the process as kolab packaging for Ubuntu newer than 18.04 is broken and missing packages, see: https://git.kolab.org/T8416

Thu, Jan 30, 2:19 PM · Bug Reports
emunson created T8416: Kolab Ubuntu 20.04 and newer repos are missing packages.
Thu, Jan 30, 2:19 PM · Bug Reports

Wed, Jan 29

mollekopf committed rKe82812d3c83b: postfix recipient table: Take aliases into account (authored by mollekopf).
postfix recipient table: Take aliases into account
Wed, Jan 29, 4:53 PM
mollekopf committed rKd2e63ca9eae4: Avoid unnecessary config options in the ui (authored by mollekopf).
Avoid unnecessary config options in the ui
Wed, Jan 29, 4:29 PM
mollekopf committed rKd64003bda2bc: Fixed mydestination sql query (authored by mollekopf).
Fixed mydestination sql query
Wed, Jan 29, 3:42 PM
mollekopf committed rKbd432d7ee857: Move to trash instead of flagging as deleted (authored by mollekopf).
Move to trash instead of flagging as deleted
Wed, Jan 29, 2:58 PM
mollekopf committed rK55972ced43dc: postfix: set mydestination via sql query (authored by mollekopf).
postfix: set mydestination via sql query
Wed, Jan 29, 2:35 PM

Tue, Jan 28

machniak updated the diff for D5092: Files migration from Kolab v3 to Kolab v4.
  • Support IMAP folder ACL migration
Tue, Jan 28, 3:58 PM
machniak committed rKcf4f8d6e3f0e: Remove redundant check (authored by machniak).
Remove redundant check
Tue, Jan 28, 12:15 PM
machniak updated the diff for D5092: Files migration from Kolab v3 to Kolab v4.
  • CS
Tue, Jan 28, 12:08 PM
machniak updated the diff for D5092: Files migration from Kolab v3 to Kolab v4.
  • DataMigrator: Advertise itself as a Kolab client when talking to Kolab IMAP server
  • Speed up Fs\Item::storeProperty()
  • CS fixes
Tue, Jan 28, 11:52 AM

Mon, Jan 27

machniak requested review of D5092: Files migration from Kolab v3 to Kolab v4.
Mon, Jan 27, 2:54 PM
mollekopf closed D5090: Authentication caching for passwords.
Mon, Jan 27, 10:57 AM
mollekopf committed rK31bfd99f93c4: Authentication caching for passwords (authored by mollekopf).
Authentication caching for passwords
Mon, Jan 27, 10:57 AM
mollekopf added inline comments to D5090: Authentication caching for passwords.
Mon, Jan 27, 10:52 AM
machniak accepted D5090: Authentication caching for passwords.
Mon, Jan 27, 10:52 AM
mollekopf added a comment to D5090: Authentication caching for passwords.

When $verifyMFA=true you still call hash() and store it in the cache. When using $verifyMFA=false that hash would be used. If you add to this not using $clientIP it looks to me like a potential geo-lock bypass.

Mon, Jan 27, 10:51 AM
mollekopf updated the diff for D5090: Authentication caching for passwords.

Addressed comments

Mon, Jan 27, 10:50 AM
machniak requested changes to D5090: Authentication caching for passwords.

When $verifyMFA=true you still call hash() and store it in the cache. When using $verifyMFA=false that hash would be used. If you add to this not using $clientIP it looks to me like a potential geo-lock bypass.

Mon, Jan 27, 10:27 AM
mollekopf added a reviewer for D5090: Authentication caching for passwords: Restricted Project.
Mon, Jan 27, 9:36 AM
mollekopf requested review of D5090: Authentication caching for passwords.
Mon, Jan 27, 9:35 AM
machniak committed rK8693cb4b2a7e: Fix error when authenticating with simple, but long password (authored by machniak).
Fix error when authenticating with simple, but long password
Mon, Jan 27, 9:16 AM
mollekopf committed rKd3b60de3a1f7: Remove unnecessary auth request (authored by mollekopf).
Remove unnecessary auth request
Mon, Jan 27, 9:06 AM
mollekopf committed rK70a38c6f69fb: Lower max wait from 20min to 120s (authored by mollekopf).
Lower max wait from 20min to 120s
Mon, Jan 27, 9:06 AM
mollekopf committed rK8c1eedb19a15: testctl profile function (authored by mollekopf).
testctl profile function
Mon, Jan 27, 9:06 AM
mollekopf committed rK5e8788e9c8eb: Make sure we have a working redis on start (authored by mollekopf).
Make sure we have a working redis on start
Mon, Jan 27, 9:06 AM
mollekopf committed rK2c86dd0fc77b: WITH_SYNC_TARGET for imap replication (authored by mollekopf).
WITH_SYNC_TARGET for imap replication
Mon, Jan 27, 9:06 AM

Thu, Jan 23

menge added a comment to T7502: guam 0.9.13-1 is crashing.

On our server ipv6 was disabled in the kernel. Enabling ipv6 did resolve the crash of guam

Thu, Jan 23, 1:52 PM · Guam, Kolab 16, Bug Reports

Wed, Jan 22

menge created T8414: https://docs.kolab.org/ is not available .
Wed, Jan 22, 4:33 PM · Bug Reports
menge added a comment to T7502: guam 0.9.13-1 is crashing.

I also see crashes of guam on AlmaLinux release 9.5 (Teal Serval)
I tested with I guam-0.9.13-3.61.el9.kolab_16.x86_64

Wed, Jan 22, 4:23 PM · Guam, Kolab 16, Bug Reports
machniak closed D5088: Kolab Data Migrator: Tags migration.
Wed, Jan 22, 1:32 PM
machniak committed rKc224858807cc: Kolab Data Migrator: Tags migration (authored by machniak).
Kolab Data Migrator: Tags migration
Wed, Jan 22, 1:32 PM
machniak updated the diff for D5088: Kolab Data Migrator: Tags migration.
  • Fix non-ascii folders migration, migrate folder subscription state
  • Use kolab3:// and kolab4:// schemes
Wed, Jan 22, 12:14 PM

Fri, Jan 17

machniak updated the diff for D5088: Kolab Data Migrator: Tags migration.
  • Small improvements and cleanup
Fri, Jan 17, 12:55 PM
machniak requested review of D5088: Kolab Data Migrator: Tags migration.
Fri, Jan 17, 12:41 PM

Tue, Jan 14

mollekopf closed D5086: Lookup existing clients by id, not by name.
Tue, Jan 14, 2:35 PM
mollekopf committed rK9404752c78c1: Lookup existing clients by id, not by name (authored by mollekopf).
Lookup existing clients by id, not by name
Tue, Jan 14, 2:35 PM
mollekopf closed D5082: Authentication health check.
Tue, Jan 14, 2:35 PM
mollekopf committed rK6eb7bb96d066: Authentication health check (authored by mollekopf).
Authentication health check
Tue, Jan 14, 2:35 PM
mollekopf updated the diff for D5086: Lookup existing clients by id, not by name.

Lookup by id

Tue, Jan 14, 2:07 PM
mollekopf added a reviewer for D5086: Lookup existing clients by id, not by name: Restricted Project.
Tue, Jan 14, 1:59 PM
mollekopf requested review of D5086: Lookup existing clients by id, not by name.
Tue, Jan 14, 1:58 PM
machniak closed D5080: Remove "Functional" tests.
Tue, Jan 14, 1:17 PM
machniak committed rK1f3f5ae10c0e: Remove "Functional" tests (authored by machniak).
Remove "Functional" tests
Tue, Jan 14, 1:17 PM
machniak committed rSafdb54cd4b6b: Add tests for ContentId and ContentLocation, add some comments (authored by machniak).
Add tests for ContentId and ContentLocation, add some comments
Tue, Jan 14, 12:25 PM
machniak closed D5084: Fix mail attachment duplicates, improve attachment Method and IsInline values.
Tue, Jan 14, 12:25 PM
machniak committed rSc7752217f73e: more tests (authored by machniak).
more tests
Tue, Jan 14, 12:25 PM
machniak committed rSc191aaa311e0: Fix mail attachment duplicates, improve attachment Method and IsInline values (authored by machniak).
Fix mail attachment duplicates, improve attachment Method and IsInline values
Tue, Jan 14, 12:25 PM
machniak updated the diff for D5084: Fix mail attachment duplicates, improve attachment Method and IsInline values.
  • Add tests for ContentId and ContentLocation, add some comments
Tue, Jan 14, 12:22 PM
mollekopf accepted D5084: Fix mail attachment duplicates, improve attachment Method and IsInline values.
Tue, Jan 14, 9:53 AM
mollekopf added inline comments to D5084: Fix mail attachment duplicates, improve attachment Method and IsInline values.
Tue, Jan 14, 9:49 AM
machniak updated the diff for D5084: Fix mail attachment duplicates, improve attachment Method and IsInline values.
  • more tests
Tue, Jan 14, 9:28 AM
machniak requested review of D5084: Fix mail attachment duplicates, improve attachment Method and IsInline values.
Tue, Jan 14, 9:16 AM

Jan 10 2025

machniak requested changes to D5082: Authentication health check.
Jan 10 2025, 2:34 PM
mollekopf accepted D5080: Remove "Functional" tests.
Jan 10 2025, 1:19 PM
mollekopf added a reviewer for D5082: Authentication health check: Restricted Project.
Jan 10 2025, 12:09 PM
mollekopf requested review of D5082: Authentication health check.
Jan 10 2025, 12:08 PM

Jan 9 2025

machniak closed D5078: Cleanup/de-duplicate password validation code.
Jan 9 2025, 1:35 PM
machniak committed rKcfe362d051c9: Cleanup/de-duplicate password validation code (authored by machniak).
Cleanup/de-duplicate password validation code
Jan 9 2025, 1:35 PM
machniak closed D5076: Google Takeout driver for DataMigrator.
Jan 9 2025, 1:35 PM
machniak committed rK3771b0e2172a: Google Takeout driver for DataMigrator (authored by machniak).
Google Takeout driver for DataMigrator
Jan 9 2025, 1:35 PM

Jan 8 2025

mollekopf accepted D5078: Cleanup/de-duplicate password validation code.
Jan 8 2025, 10:03 PM
machniak committed rK81407f41a8c2: Fix Undefined array key "isPending" (authored by machniak).
Fix Undefined array key "isPending"
Jan 8 2025, 3:00 PM
machniak requested review of D5080: Remove "Functional" tests.
Jan 8 2025, 2:38 PM
machniak requested review of D5078: Cleanup/de-duplicate password validation code.
Jan 8 2025, 1:30 PM

Jan 6 2025

machniak committed rS47fe3292cca0: Fix PHP warning in getFileReference() (authored by machniak).
Fix PHP warning in getFileReference()
Jan 6 2025, 2:03 PM
machniak committed rSfbf08af75fd7: Fix regressions, don't call gzinflate() on an uncompressed data (authored by machniak).
Fix regressions, don't call gzinflate() on an uncompressed data
Jan 6 2025, 1:55 PM
machniak committed rRPK12787ff4c220: Tags: Fix removing tags from messages list on tag delete from a mail preview… (authored by machniak).
Tags: Fix removing tags from messages list on tag delete from a mail preview…
Jan 6 2025, 1:00 PM
mollekopf closed D5074: Token validation when providing it as a password.
Jan 6 2025, 12:42 PM
mollekopf committed rK77ced2efb642: Token validation when providing it as a password (authored by mollekopf).
Token validation when providing it as a password
Jan 6 2025, 12:42 PM
machniak committed rRPKb3e686c00a41: Fix PHP warning (authored by machniak).
Fix PHP warning
Jan 6 2025, 12:35 PM
machniak accepted D5074: Token validation when providing it as a password.
Jan 6 2025, 12:35 PM
mollekopf updated the diff for D5074: Token validation when providing it as a password.

Moved the token validation to findAndAuthenticate, so we can skip mfa when a token has been validated.

Jan 6 2025, 12:24 PM
machniak requested changes to D5074: Token validation when providing it as a password.

After another look I think we might be doing something wrong here. A valid token should disable/skip 2FA use. Current User::findAndAuthenticate() will not skip 2FA if the password is a valid token.

Jan 6 2025, 11:34 AM
mollekopf updated the diff for D5074: Token validation when providing it as a password.

Comment style

Jan 6 2025, 11:11 AM
mollekopf updated the diff for D5074: Token validation when providing it as a password.

Now with an actual test

Jan 6 2025, 11:10 AM
machniak requested changes to D5074: Token validation when providing it as a password.
Jan 6 2025, 10:27 AM
mollekopf updated the diff for D5074: Token validation when providing it as a password.

Addressed comments

Jan 6 2025, 9:35 AM

Jan 4 2025

joe1860 created T8412: Kolab4 New deployment fails with amavis/spamassasin.
Jan 4 2025, 8:55 AM · Bug Reports

Jan 3 2025

machniak updated the diff for D5076: Google Takeout driver for DataMigrator.
  • Fix comment
  • ID generation for mail without Message-ID
Jan 3 2025, 3:22 PM
machniak updated the diff for D5076: Google Takeout driver for DataMigrator.
  • Incremental migration tests for Takeout
  • Fixes in incremental migration across drivers
Jan 3 2025, 2:42 PM
machniak planned changes to D5076: Google Takeout driver for DataMigrator.
Jan 3 2025, 11:04 AM

Jan 2 2025

machniak committed rK43bc8633f9ac: Fix regression in EWS migrator (authored by machniak).
Fix regression in EWS migrator
Jan 2 2025, 1:21 PM
machniak requested review of D5076: Google Takeout driver for DataMigrator.
Jan 2 2025, 10:49 AM
machniak closed D5072: DataMigrator drivers refactoring, (WIP) Kolab driver added.
Jan 2 2025, 10:32 AM
machniak committed rKeff9d8487cee: DataMigrator drivers refactoring, (WIP) Kolab driver added (authored by machniak).
DataMigrator drivers refactoring, (WIP) Kolab driver added
Jan 2 2025, 10:32 AM
machniak requested changes to D5074: Token validation when providing it as a password.

Placing this in User::validateCredentials() maybe is not a bad idea, but it creates some redundancy. See NGINXController::authorizeRequest() - AuthUtils::tokenValidate() now will be called twice. Also, test this new case in Unit/UserTest::testPasswordValidation().

Jan 2 2025, 8:56 AM
mollekopf added a reviewer for D5074: Token validation when providing it as a password: Restricted Project.
Jan 2 2025, 12:02 AM
mollekopf requested review of D5074: Token validation when providing it as a password.
Jan 2 2025, 12:00 AM

Jan 1 2025

mollekopf accepted D5072: DataMigrator drivers refactoring, (WIP) Kolab driver added.
Jan 1 2025, 11:02 AM

Dec 27 2024

machniak requested review of D5072: DataMigrator drivers refactoring, (WIP) Kolab driver added.
Dec 27 2024, 12:51 PM
mollekopf abandoned D5058: Always run the seeder when horizon starts.
Dec 27 2024, 11:33 AM

Dec 24 2024

mollekopf committed rK626ded3e691c: imapd.conf fixup (authored by mollekopf).
imapd.conf fixup
Dec 24 2024, 3:05 PM
mollekopf committed rK5070e51b48fe: ci/testctl reset mailbox routine (authored by mollekopf).
ci/testctl reset mailbox routine
Dec 24 2024, 1:03 PM