Page MenuHomekolab.org
Feed All Stories

Today

mollekopf updated the diff for D2143: Remove folder typedata in-memory cache.

Removed the in-memory cache instead.

Fri, Jan 22, 3:08 PM · Roundcube Kolab Plugins
machniak added a comment to D2143: Remove folder typedata in-memory cache.

If you think that this internal cache is not really needed then go this way and remove use of self::$typedata. In rare cases when we list folders for all folder types separately in a single request, we'll end up with several requests to the Roundcube imap cache, instead of one. I'm afraid that we might call folder_typedata() or folder_type() methods quite a lot, but I didn't check that, so I'm not sure.

Fri, Jan 22, 1:55 PM · Roundcube Kolab Plugins
mollekopf updated the diff for D2155: Allow clearing the in-memory typedata cache.

New name

Fri, Jan 22, 1:44 PM
mollekopf added a comment to D2143: Remove folder typedata in-memory cache.

How about we call self::folders_typedata($prefix); to populate the cache, but then user folder_type() anyways to fetch missing entries (it still uses the cache if available)?

I don't like it for performance reasons, because if we know the folder has no type then why would you bother with a METADATA request? This would create many redundant requests when listing mail folders. And I'm not sure it would solve your issue.

Fri, Jan 22, 1:33 PM · Roundcube Kolab Plugins
mollekopf added reviewers for D2155: Allow clearing the in-memory typedata cache: Roundcube Kolab Plugins Developers, machniak.
Fri, Jan 22, 1:31 PM
mollekopf requested review of D2155: Allow clearing the in-memory typedata cache.
Fri, Jan 22, 1:19 PM
machniak updated the diff for D2149: Publisher-to-subscriber and vice-versa.
  • Cleanup
  • Simplify resize() calls
  • More tests
  • Test updateConnection endpoint
Fri, Jan 22, 11:00 AM

Yesterday

machniak requested review of D2149: Publisher-to-subscriber and vice-versa.
Thu, Jan 21, 3:21 PM
indialegallive updated indialegallive.
Thu, Jan 21, 12:15 PM
machniak added a comment to D2143: Remove folder typedata in-memory cache.

How about we call self::folders_typedata($prefix); to populate the cache, but then user folder_type() anyways to fetch missing entries (it still uses the cache if available)?

Thu, Jan 21, 12:09 PM · Roundcube Kolab Plugins
mollekopf added a comment to D2143: Remove folder typedata in-memory cache.

With this change METADATA for every folder will be asked separately. This definitely will have performance implications. Maybe a better approach would be to add a method to reset kolab_storage::$typedata (and other cache-like data if needed). And call that method from syncroton's kolab_sync::sleep() or kolab_sync_backend_folder::hasHierarchyChanges().

Thu, Jan 21, 11:46 AM · Roundcube Kolab Plugins
machniak added a comment to D2143: Remove folder typedata in-memory cache.

With this change METADATA for every folder will be asked separately. This definitely will have performance implications. Maybe a better approach would be to add a method to reset kolab_storage::$typedata (and other cache-like data if needed). And call that method from syncroton's kolab_sync::sleep() or kolab_sync_backend_folder::hasHierarchyChanges().

Thu, Jan 21, 11:41 AM · Roundcube Kolab Plugins
alicemarvel21 updated alicemarvel21.
Thu, Jan 21, 11:35 AM
bohlender added a reviewer for D2137: add charge period to transactions: Restricted Project.
Thu, Jan 21, 11:01 AM
mollekopf added a reviewer for D2143: Remove folder typedata in-memory cache: Roundcube Kolab Plugins Developers.
Thu, Jan 21, 11:00 AM · Roundcube Kolab Plugins
mollekopf added a project to D2143: Remove folder typedata in-memory cache: Roundcube Kolab Plugins .
Thu, Jan 21, 11:00 AM · Roundcube Kolab Plugins
mollekopf added a comment to D2143: Remove folder typedata in-memory cache.

See https://bifrost.kolabsystems.com/T408794 for context. I verified that the RC UI continues to function (especially activesync and folder config),
so it doesn't brake anything, and that the Ping works better for https://bifrost.kolabsystems.com/T408794

Thu, Jan 21, 10:58 AM · Roundcube Kolab Plugins
mollekopf added a reviewer for D2143: Remove folder typedata in-memory cache: machniak.
Thu, Jan 21, 10:50 AM · Roundcube Kolab Plugins
mollekopf requested review of D2143: Remove folder typedata in-memory cache.
Thu, Jan 21, 10:48 AM · Roundcube Kolab Plugins
bohlender requested review of D2137: add charge period to transactions.
Thu, Jan 21, 10:30 AM

Wed, Jan 20

emmajustine72 added a comment to T6226: kolab-webadmin broken for users with kolab-admin role.

We are providing. WordTypo is a platform to offer you essentials to create exciting websites with the help of its Intelligent builder, plugins, and various tools for complete personalization. Take tips and help from our customer support and automated chatbots to create, edit, and customize your website. for more information visit our website Word Typo

Wed, Jan 20, 8:07 PM · Bug Reports

Tue, Jan 19

mollekopf committed rS62590b9d0dc8: Fixed warning (authored by mollekopf).
Fixed warning
Tue, Jan 19, 5:41 PM
mollekopf planned changes to D2131: Avoid Sync unnecessary FolderSync interaction.
Tue, Jan 19, 4:20 PM
machniak committed rK768848eaa55c: [MEET]: Generic implementation of Roles/Permissions (authored by machniak).
[MEET]: Generic implementation of Roles/Permissions
Tue, Jan 19, 4:04 PM
machniak closed D2098: [MEET]: Generic implementation of Roles/Permissions.
Tue, Jan 19, 4:04 PM
vanmeeuwen accepted D2098: [MEET]: Generic implementation of Roles/Permissions.
Tue, Jan 19, 3:29 PM
mollekopf updated the diff for D2131: Avoid Sync unnecessary FolderSync interaction.

Removed comment that no longer applies

Tue, Jan 19, 3:11 PM
mollekopf updated the diff for D2131: Avoid Sync unnecessary FolderSync interaction.

The previous patch was inclomplete as it built on another one, this is the full version.

Tue, Jan 19, 3:08 PM
johncrew updated johncrew.
Tue, Jan 19, 2:01 PM
mollekopf committed rSfde06e11c535: Compress pendingdata (authored by mollekopf).
Compress pendingdata
Tue, Jan 19, 1:41 PM
mollekopf closed D2062: Compress pendingdata.
Tue, Jan 19, 1:41 PM
mollekopf committed rS5463154459b9: Bump collectionChanges even if we failed to retrieve the entry. (authored by mollekopf).
Bump collectionChanges even if we failed to retrieve the entry.
Tue, Jan 19, 1:41 PM
mollekopf closed D2056: Bump collectionChanges even if we failed to retrieve the entry..
Tue, Jan 19, 1:41 PM
mollekopf abandoned D2128: A synckey that is not matching the server sync key is invalid..
Tue, Jan 19, 1:36 PM
machniak updated the diff for D2098: [MEET]: Generic implementation of Roles/Permissions.
  • Fix typo
Tue, Jan 19, 12:41 PM
daisyfaith updated daisyfaith.
Tue, Jan 19, 12:34 PM
mollekopf committed rRPKd4c00a9555d0: Do not ignore INBOX for the displayed folder hierarchy (authored by mollekopf).
Do not ignore INBOX for the displayed folder hierarchy
Tue, Jan 19, 12:29 PM
mollekopf closed D2092: Do not ignore INBOX for the displayed folder hierarchy.
Tue, Jan 19, 12:29 PM
machniak removed a member for Roundcube Kolab Plugins Developers: Adityab.
Tue, Jan 19, 12:05 PM
machniak added a member for Roundcube Kolab Plugins Developers: mollekopf.
Tue, Jan 19, 12:05 PM
machniak updated the diff for D2098: [MEET]: Generic implementation of Roles/Permissions.
  • Improve constants handling
  • Add unique key on openvidu_connections.session_id
  • Fix: session_id should be indexed but not unique
  • Remove redundant where clause
Tue, Jan 19, 11:26 AM
machniak committed rK14d3d27bddef: Prevent double-submission of payments form (authored by machniak).
Prevent double-submission of payments form
Tue, Jan 19, 11:12 AM
machniak closed D2104: Prevent double-submission of payments form.
Tue, Jan 19, 11:12 AM
machniak committed rKab1b623aa93c: Update npm dependencies (authored by machniak).
Update npm dependencies
Tue, Jan 19, 11:12 AM
machniak closed D2116: Update npm dependencies.
Tue, Jan 19, 11:11 AM
vanmeeuwen accepted D2104: Prevent double-submission of payments form.
Tue, Jan 19, 11:08 AM
machniak accepted D2056: Bump collectionChanges even if we failed to retrieve the entry..
Tue, Jan 19, 11:07 AM
machniak accepted D2062: Compress pendingdata.
Tue, Jan 19, 11:06 AM
machniak accepted D2092: Do not ignore INBOX for the displayed folder hierarchy.
Tue, Jan 19, 11:04 AM
vanmeeuwen requested changes to D2098: [MEET]: Generic implementation of Roles/Permissions.
Tue, Jan 19, 10:57 AM
vanmeeuwen accepted D2116: Update npm dependencies.
Tue, Jan 19, 10:54 AM
machniak added a comment to D2131: Avoid Sync unnecessary FolderSync interaction.

Wouldn't global STATUS_FOLDER_HIERARCHY_HAS_CHANGED status be more appropriate? Or this does not work with Outlook?

Tue, Jan 19, 10:44 AM
machniak added a comment to D2128: A synckey that is not matching the server sync key is invalid..

This code is not supposed to be used by Kolab backend. We're using kolab_sync_backend_state::validate().

Tue, Jan 19, 10:28 AM
mollekopf added reviewers for D2131: Avoid Sync unnecessary FolderSync interaction: Syncroton Developers, machniak.
Tue, Jan 19, 10:21 AM
mollekopf added reviewers for D2128: A synckey that is not matching the server sync key is invalid.: Syncroton Developers, machniak.
Tue, Jan 19, 10:20 AM
mollekopf requested review of D2131: Avoid Sync unnecessary FolderSync interaction.
Tue, Jan 19, 10:19 AM
mollekopf requested review of D2128: A synckey that is not matching the server sync key is invalid..
Tue, Jan 19, 10:18 AM

Mon, Jan 18

machniak committed rRPK625914a705b8: Fix PHP warnings, fix typo-regression in calendar preferences (authored by machniak).
Fix PHP warnings, fix typo-regression in calendar preferences
Mon, Jan 18, 7:46 PM
mollekopf added a comment to D2092: Do not ignore INBOX for the displayed folder hierarchy.

FWIW, I assume the original code meant to make the case prettier where all folders are below inbox. I think for the affected UI's it shouldn't be a big deal, and avoids the confusing situation we can have right now.

Mon, Jan 18, 2:30 PM
mollekopf updated the diff for D2092: Do not ignore INBOX for the displayed folder hierarchy.

Instead of not showing a tree at all, show it for INBOX as well.

Mon, Jan 18, 2:28 PM
mollekopf committed rCaacc7c613626: Pass on a language identifier even if we couldn't find a translation file (authored by mollekopf).
Pass on a language identifier even if we couldn't find a translation file
Mon, Jan 18, 1:59 PM
mollekopf closed D2122: Pass on a language identifier even if we couldn't find a translation file.
Mon, Jan 18, 1:59 PM
mollekopf committed rC527d914fac6d: log_error doesn't exist, use raise_error (authored by mollekopf).
log_error doesn't exist, use raise_error
Mon, Jan 18, 1:59 PM
mollekopf closed D955: log_error doesn't exist, use raise_error.
Mon, Jan 18, 1:59 PM
machniak added a member for Chwala Developers: mollekopf.
Mon, Jan 18, 1:56 PM
machniak accepted D2122: Pass on a language identifier even if we couldn't find a translation file.
Mon, Jan 18, 1:29 PM
mollekopf updated the diff for D2122: Pass on a language identifier even if we couldn't find a translation file.

Addressed comments

Mon, Jan 18, 1:28 PM
machniak added inline comments to D2122: Pass on a language identifier even if we couldn't find a translation file.
Mon, Jan 18, 1:21 PM
mollekopf added reviewers for D2122: Pass on a language identifier even if we couldn't find a translation file: Chwala Developers, machniak.
Mon, Jan 18, 1:08 PM
mollekopf requested review of D2122: Pass on a language identifier even if we couldn't find a translation file.
Mon, Jan 18, 1:07 PM
cleaningservice101 updated cleaningservice101.
Mon, Jan 18, 12:21 PM
cleaningservice101 updated cleaningservice101.
Mon, Jan 18, 12:21 PM
cleaningservice101 updated cleaningservice101.
Mon, Jan 18, 12:21 PM
cleaningservice101 updated cleaningservice101.
Mon, Jan 18, 12:20 PM
mywifiextsetup updated mywifiextsetup.
Mon, Jan 18, 11:46 AM
mywifiextsetup updated mywifiextsetup.
Mon, Jan 18, 11:46 AM
mywifiextsetup updated mywifiextsetup.
Mon, Jan 18, 11:44 AM
machniak updated the diff for D2098: [MEET]: Generic implementation of Roles/Permissions.
  • Fix: session_id should be indexed but not unique
Mon, Jan 18, 10:15 AM
machniak updated the diff for D2098: [MEET]: Generic implementation of Roles/Permissions.
  • Add unique key on openvidu_connections.session_id
Mon, Jan 18, 9:07 AM

Sat, Jan 16

crownpackers updated crownpackers.
Sat, Jan 16, 11:27 AM

Fri, Jan 15

sicherha-admin renamed T6232: Spam post removed from ENCHANTING KRAFT BOXES – THE BENEFITS AND STYLES to Spam post removed.
Fri, Jan 15, 10:27 PM · Autoconf, Free/Busy, PACK
sicherha-admin renamed T6238: Spam post removed from Provide A Splendid Appeal To Your Favorite Snacks With Attractive Popcorn Boxes to Spam post removed.
Fri, Jan 15, 10:27 PM
sicherha-admin renamed T6244: Spam post removed from Maintain The Excellence Of Your Brand With Durable Soap Boxes to Spam post removed.
Fri, Jan 15, 10:26 PM
sicherha-admin renamed T6253: Spam post removed from Extender.linksys.com to Spam post removed.
Fri, Jan 15, 10:25 PM
sicherha-admin renamed T6250: Spam post removed from Linksys Extender Setup to Spam post removed.
Fri, Jan 15, 10:25 PM
sicherha-admin renamed T6259: Spam post removed from Netgear Extender Setup to Spam post removed.
Fri, Jan 15, 10:24 PM
sicherha-admin renamed T6265: Spam post removed from Best Materials To Use For Vape Cartridge Boxes to Spam post removed.
Fri, Jan 15, 10:24 PM
machniak added a comment to D2092: Do not ignore INBOX for the displayed folder hierarchy.

I'm not sure I like this. While fixing the issue you also changed how the list will look like. I.e. flat list instead of a tree-like list. If we do this anyway we should do the same in kolab_delegation plugin.

Fri, Jan 15, 3:24 PM
machniak updated the diff for D2116: Update npm dependencies.
  • Fix phpstan error and flaky tests
Fri, Jan 15, 1:54 PM
machniak requested review of D2116: Update npm dependencies.
Fri, Jan 15, 12:08 PM
vanmeeuwen committed rK318fe1b86b35: Fix cache reset in scalpel commands (authored by machniak).
Fix cache reset in scalpel commands
Fri, Jan 15, 10:56 AM
vanmeeuwen closed D2110: Fix cache reset in scalpel commands.
Fri, Jan 15, 10:56 AM
vanmeeuwen accepted D2110: Fix cache reset in scalpel commands.
Fri, Jan 15, 10:55 AM
vanmeeuwen added inline comments to D2098: [MEET]: Generic implementation of Roles/Permissions.
Fri, Jan 15, 9:50 AM
machniak updated the diff for D2110: Fix cache reset in scalpel commands.
  • Add tests
Fri, Jan 15, 9:30 AM
machniak requested review of D2110: Fix cache reset in scalpel commands.
Fri, Jan 15, 9:10 AM

Thu, Jan 14

machniak requested review of D2104: Prevent double-submission of payments form.
Thu, Jan 14, 4:10 PM
machniak updated the diff for D2098: [MEET]: Generic implementation of Roles/Permissions.
  • Improve constants handling
Thu, Jan 14, 2:24 PM
machniak requested review of D2098: [MEET]: Generic implementation of Roles/Permissions.
Thu, Jan 14, 2:04 PM
mollekopf committed rKd756114692cb: OPENVIDU_PUBLICURL doesn't seem to do anything (authored by mollekopf).
OPENVIDU_PUBLICURL doesn't seem to do anything
Thu, Jan 14, 1:03 PM