Page MenuHomePhorge
Feed All Stories

All Stories
Use Results
Edit Query

Fri, Jan 10

machniak requested changes to D5082: Authentication health check.
Fri, Jan 10, 2:34 PM
mollekopf accepted D5080: Remove "Functional" tests.
Fri, Jan 10, 1:19 PM
mollekopf added a reviewer for D5082: Authentication health check: Restricted Project.
Fri, Jan 10, 12:09 PM
mollekopf requested review of D5082: Authentication health check.
Fri, Jan 10, 12:08 PM

Thu, Jan 9

machniak closed D5078: Cleanup/de-duplicate password validation code.
Thu, Jan 9, 1:35 PM
machniak committed rKcfe362d051c9: Cleanup/de-duplicate password validation code (authored by machniak).
Cleanup/de-duplicate password validation code
Thu, Jan 9, 1:35 PM
machniak closed D5076: Google Takeout driver for DataMigrator.
Thu, Jan 9, 1:35 PM
machniak committed rK3771b0e2172a: Google Takeout driver for DataMigrator (authored by machniak).
Google Takeout driver for DataMigrator
Thu, Jan 9, 1:35 PM

Wed, Jan 8

mollekopf accepted D5078: Cleanup/de-duplicate password validation code.
Wed, Jan 8, 10:03 PM
machniak committed rK81407f41a8c2: Fix Undefined array key "isPending" (authored by machniak).
Fix Undefined array key "isPending"
Wed, Jan 8, 3:00 PM
machniak requested review of D5080: Remove "Functional" tests.
Wed, Jan 8, 2:38 PM
machniak requested review of D5078: Cleanup/de-duplicate password validation code.
Wed, Jan 8, 1:30 PM

Mon, Jan 6

machniak committed rS47fe3292cca0: Fix PHP warning in getFileReference() (authored by machniak).
Fix PHP warning in getFileReference()
Mon, Jan 6, 2:03 PM
machniak committed rSfbf08af75fd7: Fix regressions, don't call gzinflate() on an uncompressed data (authored by machniak).
Fix regressions, don't call gzinflate() on an uncompressed data
Mon, Jan 6, 1:55 PM
machniak committed rRPK12787ff4c220: Tags: Fix removing tags from messages list on tag delete from a mail preview… (authored by machniak).
Tags: Fix removing tags from messages list on tag delete from a mail preview…
Mon, Jan 6, 1:00 PM
mollekopf closed D5074: Token validation when providing it as a password.
Mon, Jan 6, 12:42 PM
mollekopf committed rK77ced2efb642: Token validation when providing it as a password (authored by mollekopf).
Token validation when providing it as a password
Mon, Jan 6, 12:42 PM
machniak committed rRPKb3e686c00a41: Fix PHP warning (authored by machniak).
Fix PHP warning
Mon, Jan 6, 12:35 PM
machniak accepted D5074: Token validation when providing it as a password.
Mon, Jan 6, 12:35 PM
mollekopf updated the diff for D5074: Token validation when providing it as a password.

Moved the token validation to findAndAuthenticate, so we can skip mfa when a token has been validated.

Mon, Jan 6, 12:24 PM
machniak requested changes to D5074: Token validation when providing it as a password.

After another look I think we might be doing something wrong here. A valid token should disable/skip 2FA use. Current User::findAndAuthenticate() will not skip 2FA if the password is a valid token.

Mon, Jan 6, 11:34 AM
mollekopf updated the diff for D5074: Token validation when providing it as a password.

Comment style

Mon, Jan 6, 11:11 AM
mollekopf updated the diff for D5074: Token validation when providing it as a password.

Now with an actual test

Mon, Jan 6, 11:10 AM
machniak requested changes to D5074: Token validation when providing it as a password.
Mon, Jan 6, 10:27 AM
mollekopf updated the diff for D5074: Token validation when providing it as a password.

Addressed comments

Mon, Jan 6, 9:35 AM

Sat, Jan 4

joe1860 created T8412: Kolab4 New deployment fails with amavis/spamassasin.
Sat, Jan 4, 8:55 AM · Bug Reports

Fri, Jan 3

machniak updated the diff for D5076: Google Takeout driver for DataMigrator.
  • Fix comment
  • ID generation for mail without Message-ID
Fri, Jan 3, 3:22 PM
machniak updated the diff for D5076: Google Takeout driver for DataMigrator.
  • Incremental migration tests for Takeout
  • Fixes in incremental migration across drivers
Fri, Jan 3, 2:42 PM
machniak planned changes to D5076: Google Takeout driver for DataMigrator.
Fri, Jan 3, 11:04 AM

Thu, Jan 2

machniak committed rK43bc8633f9ac: Fix regression in EWS migrator (authored by machniak).
Fix regression in EWS migrator
Thu, Jan 2, 1:21 PM
machniak requested review of D5076: Google Takeout driver for DataMigrator.
Thu, Jan 2, 10:49 AM
machniak closed D5072: DataMigrator drivers refactoring, (WIP) Kolab driver added.
Thu, Jan 2, 10:32 AM
machniak committed rKeff9d8487cee: DataMigrator drivers refactoring, (WIP) Kolab driver added (authored by machniak).
DataMigrator drivers refactoring, (WIP) Kolab driver added
Thu, Jan 2, 10:32 AM
machniak requested changes to D5074: Token validation when providing it as a password.

Placing this in User::validateCredentials() maybe is not a bad idea, but it creates some redundancy. See NGINXController::authorizeRequest() - AuthUtils::tokenValidate() now will be called twice. Also, test this new case in Unit/UserTest::testPasswordValidation().

Thu, Jan 2, 8:56 AM
mollekopf added a reviewer for D5074: Token validation when providing it as a password: Restricted Project.
Thu, Jan 2, 12:02 AM
mollekopf requested review of D5074: Token validation when providing it as a password.
Thu, Jan 2, 12:00 AM

Wed, Jan 1

mollekopf accepted D5072: DataMigrator drivers refactoring, (WIP) Kolab driver added.
Wed, Jan 1, 11:02 AM

Fri, Dec 27

machniak requested review of D5072: DataMigrator drivers refactoring, (WIP) Kolab driver added.
Fri, Dec 27, 12:51 PM
mollekopf abandoned D5058: Always run the seeder when horizon starts.
Fri, Dec 27, 11:33 AM

Tue, Dec 24

mollekopf committed rK626ded3e691c: imapd.conf fixup (authored by mollekopf).
imapd.conf fixup
Tue, Dec 24, 3:05 PM
mollekopf committed rK5070e51b48fe: ci/testctl reset mailbox routine (authored by mollekopf).
ci/testctl reset mailbox routine
Tue, Dec 24, 1:03 PM
mollekopf committed rKd3b5df5a4a43: Disable per_user_logging for testing (authored by mollekopf).
Disable per_user_logging for testing
Tue, Dec 24, 1:03 PM
mollekopf committed rKf54029a5d1f0: Some annotation support for imapcli (authored by mollekopf).
Some annotation support for imapcli
Tue, Dec 24, 1:03 PM
mollekopf committed rKb6eb61d4b335: Disable messages_cache for roundcube (authored by mollekopf).
Disable messages_cache for roundcube
Tue, Dec 24, 1:03 PM
mollekopf committed rKdb4ffe33ee43: Fixed plugin updates from local source (authored by mollekopf).
Fixed plugin updates from local source
Tue, Dec 24, 1:03 PM
mollekopf committed rKa13127b28c13: imapcli tag option (authored by mollekopf).
imapcli tag option
Tue, Dec 24, 1:03 PM
mollekopf committed rK57a8e40e5d68: Make caldavcli usable over http (authored by mollekopf).
Make caldavcli usable over http
Tue, Dec 24, 1:03 PM
mollekopf committed rKb18d701a9cee: ci/testctl improvements (authored by mollekopf).
ci/testctl improvements
Tue, Dec 24, 1:03 PM
mollekopf committed rKedf0dedf94c6: IMAP/RC config for tags via ANNOTATE (authored by mollekopf).
IMAP/RC config for tags via ANNOTATE
Tue, Dec 24, 1:03 PM
mollekopf committed rKc4a4a8978592: Correctly filter service accounts in resync command (authored by mollekopf).
Correctly filter service accounts in resync command
Tue, Dec 24, 1:03 PM
mollekopf committed rK673c0a272fbe: IMAP: Allow tls 1.2/1.3 for now (authored by mollekopf).
IMAP: Allow tls 1.2/1.3 for now
Tue, Dec 24, 1:03 PM
mollekopf committed rKa743a7db34d0: Don't validate the username of service accounts (authored by mollekopf).
Don't validate the username of service accounts
Tue, Dec 24, 1:03 PM
mollekopf committed rK121e270afade: Only allow modern tls ciphers (authored by mollekopf).
Only allow modern tls ciphers
Tue, Dec 24, 1:03 PM
mollekopf committed rK17bb006a8fb4: Caldav search (authored by mollekopf).
Caldav search
Tue, Dec 24, 1:03 PM
mollekopf committed R113:de3d000b6f34: Reset internal cache in appropriate places to be on a safe side (authored by machniak).
Reset internal cache in appropriate places to be on a safe side
Tue, Dec 24, 11:22 AM
mollekopf committed R113:6c53df30b8d3: IMAP: Partial support for ANNOTATE-EXPERIMENT-1 extension (RFC 5257) (authored by machniak).
IMAP: Partial support for ANNOTATE-EXPERIMENT-1 extension (RFC 5257)
Tue, Dec 24, 11:22 AM
machniak closed D5032: Kolab Tags SQL and ANNOTATE drivers.
Tue, Dec 24, 11:00 AM
machniak committed rRPK21ead0149e85: Kolab Tags SQL and ANNOTATE drivers (authored by machniak).
Kolab Tags SQL and ANNOTATE drivers
Tue, Dec 24, 11:00 AM
machniak closed D5062: Kolab4 tags support.
Tue, Dec 24, 9:01 AM
machniak committed rS01e090894d0a: Kolab4 tags support (authored by machniak).
Kolab4 tags support
Tue, Dec 24, 9:01 AM
machniak updated the diff for D5032: Kolab Tags SQL and ANNOTATE drivers.
  • CS fixes
  • Revert unneded change
  • ANNOTATE base tag driver
  • Improvements
  • SQL driver fixes
  • Small doc fix
  • Fixes regarding syncroton API for tags
  • Support saving task tags as categories
  • Fix regression
  • Regressions and cleanup
Tue, Dec 24, 8:50 AM
machniak updated the diff for D5062: Kolab4 tags support.
  • Fix regression
Tue, Dec 24, 8:22 AM
mollekopf requested changes to D5032: Kolab Tags SQL and ANNOTATE drivers.
Tue, Dec 24, 8:12 AM
mollekopf reopened D5032: Kolab Tags SQL and ANNOTATE drivers.
Tue, Dec 24, 8:06 AM
mollekopf requested changes to D5062: Kolab4 tags support.

Can be shipped after that adjustments IMO.

Tue, Dec 24, 8:02 AM
mollekopf added a comment to D5062: Kolab4 tags support.

I think because of the latest change, this is now required:

Tue, Dec 24, 8:01 AM
mollekopf committed rRPK026feb6e3fdd: Fixed php8 warnings (authored by mollekopf).
Fixed php8 warnings
Tue, Dec 24, 7:58 AM
mollekopf committed rRPK8fd23ed20534: sql_where fixup (authored by mollekopf).
sql_where fixup
Tue, Dec 24, 7:58 AM
mollekopf committed rRPKbe4865053273: Kolab Tags SQL and ANNOTATE drivers (authored by machniak).
Kolab Tags SQL and ANNOTATE drivers
Tue, Dec 24, 7:58 AM
mollekopf committed rRPKd7c582bd07da: Fix search by tag (authored by mollekopf).
Fix search by tag
Tue, Dec 24, 7:58 AM
mollekopf closed D5032: Kolab Tags SQL and ANNOTATE drivers.
Tue, Dec 24, 7:58 AM
mollekopf committed rRPKabbb3921e172: Kolab Tags SQL and ANNOTATE drivers (authored by machniak).
Kolab Tags SQL and ANNOTATE drivers
Tue, Dec 24, 7:58 AM

Mon, Dec 23

mollekopf committed rC4bdc587ba9f3: Fixup for previous commit (authored by mollekopf).
Fixup for previous commit
Mon, Dec 23, 3:48 PM
machniak updated the diff for D5032: Kolab Tags SQL and ANNOTATE drivers.
  • Fix regression
Mon, Dec 23, 1:44 PM
machniak closed T8400: kolab-webadmin: Uncaught Exception: Serialization of 'LDAP\Connection' is not allowed as Resolved.

Patch merged.

Mon, Dec 23, 9:44 AM · Bug Reports
machniak committed rWAP180a93bcd7d6: Handle nicely json_encode() error (authored by machniak).
Handle nicely json_encode() error
Mon, Dec 23, 9:24 AM
machniak committed rWAP5c0dade786b7: T8400: PHP 8.2 compatibility - close LDAP connection when serializing (authored by machniak).
T8400: PHP 8.2 compatibility - close LDAP connection when serializing
Mon, Dec 23, 9:12 AM

Thu, Dec 19

machniak committed rKfaa06df38342: CS fixes (lines too long mostly) (authored by machniak).
CS fixes (lines too long mostly)
Thu, Dec 19, 3:10 PM
machniak closed D5038: UI: Prefer to display suspended over degraded status.
Thu, Dec 19, 1:28 PM
machniak committed rK7a6165f2311e: UI: Prefer to display suspended over degraded status (authored by machniak).
UI: Prefer to display suspended over degraded status
Thu, Dec 19, 1:28 PM
machniak closed D5036: Don't allow Delete jobs on non-deleted objects.
Thu, Dec 19, 1:28 PM
machniak committed rK969f657690da: Don't allow Delete jobs on non-deleted objects (authored by machniak).
Don't allow Delete jobs on non-deleted objects
Thu, Dec 19, 1:28 PM
mollekopf closed D5070: Adjust to roundcube 1.6.
Thu, Dec 19, 9:28 AM
mollekopf committed rCb25cd48b4026: Adjust to roundcube 1.6 (authored by mollekopf).
Adjust to roundcube 1.6
Thu, Dec 19, 9:28 AM
mollekopf committed rC0bf096268900: More useful error message (authored by mollekopf).
More useful error message
Thu, Dec 19, 9:28 AM
machniak accepted D5070: Adjust to roundcube 1.6.
Thu, Dec 19, 8:33 AM
mollekopf added a comment to D5070: Adjust to roundcube 1.6.

It's a bit of a mess indeed.
I think it's not needed because default_port will be ignored if the port is part of the host string.
I'm unsure how to clean this up without breaking anything, so I'll just stick to doing what we do elsewhere.

Thu, Dec 19, 7:11 AM
mollekopf updated the diff for D5070: Adjust to roundcube 1.6.

Adjust to doing the same as iRony/syncroton

Thu, Dec 19, 7:05 AM

Wed, Dec 18

machniak updated the diff for D5032: Kolab Tags SQL and ANNOTATE drivers.
  • Support saving task tags as categories
Wed, Dec 18, 2:32 PM
machniak added a comment to D5070: Adjust to roundcube 1.6.

On the other hand we use default_port everywhere, and we probably should not. I'm just wondering, why that second part of this change is not needed in Syncroton and iRony, but is in Chwala.

Wed, Dec 18, 10:34 AM
machniak added a comment to D5070: Adjust to roundcube 1.6.

Ha, I missed we use parse_host() in select_host(). So, that whole change in login() seems redundant.

Wed, Dec 18, 10:31 AM
machniak added a comment to D5070: Adjust to roundcube 1.6.

This could be simplified by use of rcube_utils::parse_host() which is what we already do in Syncroton and iRony.

Wed, Dec 18, 8:35 AM
mollekopf added a reviewer for D5070: Adjust to roundcube 1.6: Chwala Developers.
Wed, Dec 18, 8:25 AM
mollekopf requested review of D5070: Adjust to roundcube 1.6.
Wed, Dec 18, 8:25 AM

Tue, Dec 17

mollekopf committed rK98e87de2497d: We also have to pin the engine version in the package.json file (authored by mollekopf).
We also have to pin the engine version in the package.json file
Tue, Dec 17, 2:53 PM
mollekopf committed rK71fe63e9b5d2: data:init fixup (authored by mollekopf).
data:init fixup
Tue, Dec 17, 2:39 PM
mollekopf closed D5068: Init command.
Tue, Dec 17, 1:58 PM
mollekopf committed rKfeb1df494ffd: Init command (authored by mollekopf).
Init command
Tue, Dec 17, 1:58 PM
mollekopf committed rK7afcbed0adc0: Require a specific npm version (authored by mollekopf).
Require a specific npm version
Tue, Dec 17, 1:58 PM
machniak accepted D5068: Init command.

The imap user is being created from UserSeeder in the demo config. You have to remove that part. Also, maybe the command should be db:init or data:init, but just init is also fine.

Tue, Dec 17, 1:44 PM
Next