--topup mode for wallet:charge
ClosedPublic
Actions

Authored by mollekopf on Tue, Oct 1, 12:59 PM.

Details

Reviewers

machniak

Group Reviewers

Restricted Project

Commits

rK34e0a99f37a5: --topup mode for wallet:charge

Summary

This mode just finds wallets that need a topup, and triggers a
WalletCharge job for them.

Diff Detail

Repository

rK kolab

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

mollekopf requested review of this revision.Tue, Oct 1, 12:59 PM

mollekopf created this revision.

Harbormaster completed remote builds in B50646: Diff 14232.Tue, Oct 1, 12:59 PM

mollekopf added a reviewer: Restricted Project.Tue, Oct 1, 1:01 PM

machniak requested changes to this revision.Tue, Oct 1, 1:40 PM

machniak subscribed.

machniak added inline comments.

src/app/Console/Commands/Wallet/ChargeCommand.php
71	With `--dry-run` we should probably just print the wallet ID and not log anything. Also, the option is `--dry-run` not `--dry`.

This revision now requires changes to proceed.Tue, Oct 1, 1:40 PM

Addressed comments, avoid using the magic 51 status

Harbormaster completed remote builds in B50649: Diff 14235.Tue, Oct 1, 1:54 PM

machniak accepted this revision.Tue, Oct 1, 2:13 PM

This revision is now accepted and ready to land.Tue, Oct 1, 2:13 PM

Closed by commit rK34e0a99f37a5: --topup mode for wallet:charge (authored by mollekopf, committed by machniak). · Explain WhyMon, Oct 7, 9:18 AM

This revision was automatically updated to reflect the committed changes.

machniak added a commit: rK34e0a99f37a5: --topup mode for wallet:charge.

Revision Contents
Changeset List

Path

Size

src/

app/

Console/

Commands/

Wallet/

ChargeCommand.php

30 lines

Diff 14265

View Options

src/app/Console/Commands/Wallet/ChargeCommand.php

--topup mode for wallet:chargeClosedPublicActions