Page MenuHomePhorge
Differential D4971

--topup mode for wallet:charge
ClosedPublic
Actions

Authored by mollekopf on Oct 1 2024, 12:59 PM.

Details

Reviewers
machniak
Group Reviewers
Restricted Project
Commits
rK34e0a99f37a5: --topup mode for wallet:charge
Summary

This mode just finds wallets that need a topup, and triggers a
WalletCharge job for them.

Diff Detail

Repository
rK kolab
Branch
dev/mollekopf
Lint
Lint Skipped
Unit
No Test Coverage
Build Status
Buildable 50649
Build 18441: arc lint + arc unit

Event Timeline

mollekopf requested review of this revision.Oct 1 2024, 12:59 PM
mollekopf created this revision.
Harbormaster completed remote builds in B50646: Diff 14232.Oct 1 2024, 12:59 PM
mollekopf added a reviewer: Restricted Project.Oct 1 2024, 1:01 PM
machniak requested changes to this revision.Oct 1 2024, 1:40 PM
machniak subscribed.
machniak added inline comments.
src/app/Console/Commands/Wallet/ChargeCommand.php
71

With --dry-run we should probably just print the wallet ID and not log anything. Also, the option is --dry-run not --dry.

This revision now requires changes to proceed.Oct 1 2024, 1:40 PM
mollekopf updated this revision to Diff 14235.Oct 1 2024, 1:54 PM

Addressed comments, avoid using the magic 51 status

Harbormaster completed remote builds in B50649: Diff 14235.Oct 1 2024, 1:54 PM
machniak accepted this revision.Oct 1 2024, 2:13 PM
This revision is now accepted and ready to land.Oct 1 2024, 2:13 PM
Closed by commit rK34e0a99f37a5: --topup mode for wallet:charge. · Explain WhyOct 7 2024, 9:18 AM
This revision was automatically updated to reflect the committed changes.
machniak added a commit: rK34e0a99f37a5: --topup mode for wallet:charge.

Revision Contents
Changeset List

PathSize
src/
app/
Console/
Commands/
Wallet/
30 lines

Diff 14235

View Options

src/app/Console/Commands/Wallet/ChargeCommand.php

Loading...