Page MenuHomePhorge
Differential D4953

Extract the getServerModifications method
ClosedPublic
Actions

Authored by mollekopf on Fri, Sep 20, 10:46 AM.
Tags
None
Referenced Files
F15942687: D4953.id14208.diff
Wed, Oct 9, 9:00 AM
Unknown Object (File)
Sun, Oct 6, 2:29 PM
Unknown Object (File)
Thu, Oct 3, 7:41 PM
Unknown Object (File)
Mon, Sep 30, 1:38 PM
Unknown Object (File)
Mon, Sep 30, 11:29 AM
Unknown Object (File)
Mon, Sep 30, 8:25 AM
Unknown Object (File)
Mon, Sep 30, 6:54 AM
Unknown Object (File)
Sun, Sep 29, 11:37 PM
View All 27 Files
Subscribers
machniak

Details

Reviewers
machniak
Group Reviewers
Syncroton Developers
Commits
rSd977649a31ed: Extract the getServerModifications method

Diff Detail

Repository
rS syncroton
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

mollekopf requested review of this revision.Fri, Sep 20, 10:46 AM
mollekopf created this revision.
Harbormaster completed remote builds in B50388: Diff 14181.Fri, Sep 20, 10:48 AM
mollekopf added a reviewer: Syncroton Developers.Fri, Sep 20, 10:48 AM
mollekopf added a comment.Fri, Sep 20, 11:05 AM

This is just a refactoring and shouldn't change the behaviour.

machniak requested changes to this revision.Fri, Sep 20, 1:38 PM
machniak subscribed.
machniak added inline comments.
lib/ext/Syncroton/Command/Sync.php
512

Undefined variable $clientModifications.

This revision now requires changes to proceed.Fri, Sep 20, 1:38 PM
mollekopf updated this revision to Diff 14208.Sun, Sep 22, 10:34 AM

Fixed the undefined $clientModifications

Harbormaster completed remote builds in B50415: Diff 14208.Sun, Sep 22, 10:34 AM
machniak accepted this revision.Sun, Sep 22, 5:00 PM
This revision is now accepted and ready to land.Sun, Sep 22, 5:00 PM
Closed by commit rSd977649a31ed: Extract the getServerModifications method (authored by mollekopf). · Explain WhyWed, Oct 9, 9:54 AM
This revision was automatically updated to reflect the committed changes.
mollekopf added a commit: rSd977649a31ed: Extract the getServerModifications method.

Revision Contents
Changeset List

PathSize
lib/
ext/
Syncroton/
Command/
177 lines

Diff 14274

View Options

lib/ext/Syncroton/Command/Sync.php

Loading...