Page MenuHomePhorge
Differential D4953

Extract the getServerModifications method
ClosedPublic
Actions

Authored by mollekopf on Sep 20 2024, 10:46 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Nov 15, 4:53 AM
Unknown Object (File)
Wed, Nov 13, 8:24 AM
Unknown Object (File)
Tue, Nov 12, 11:33 PM
Unknown Object (File)
Thu, Oct 31, 8:30 PM
Unknown Object (File)
Sat, Oct 26, 11:20 PM
Unknown Object (File)
Thu, Oct 24, 6:02 PM
Unknown Object (File)
Thu, Oct 24, 4:39 PM
Unknown Object (File)
Thu, Oct 24, 8:30 AM
View All 46 Files
Subscribers
machniak

Details

Reviewers
machniak
Group Reviewers
Syncroton Developers
Commits
rSd977649a31ed: Extract the getServerModifications method

Diff Detail

Repository
rS syncroton
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 50415
Build 18423: arc lint + arc unit

Event Timeline

mollekopf requested review of this revision.Sep 20 2024, 10:46 AM
mollekopf created this revision.
Harbormaster completed remote builds in B50388: Diff 14181.Sep 20 2024, 10:48 AM
mollekopf added a reviewer: Syncroton Developers.Sep 20 2024, 10:48 AM
mollekopf added a comment.Sep 20 2024, 11:05 AM

This is just a refactoring and shouldn't change the behaviour.

machniak requested changes to this revision.Sep 20 2024, 1:38 PM
machniak subscribed.
machniak added inline comments.
lib/ext/Syncroton/Command/Sync.php
512

Undefined variable $clientModifications.

This revision now requires changes to proceed.Sep 20 2024, 1:38 PM
mollekopf updated this revision to Diff 14208.Sep 22 2024, 10:34 AM

Fixed the undefined $clientModifications

Harbormaster completed remote builds in B50415: Diff 14208.Sep 22 2024, 10:34 AM
machniak accepted this revision.Sep 22 2024, 5:00 PM
This revision is now accepted and ready to land.Sep 22 2024, 5:00 PM
Closed by commit rSd977649a31ed: Extract the getServerModifications method (authored by mollekopf). · Explain WhyOct 9 2024, 9:54 AM
This revision was automatically updated to reflect the committed changes.
mollekopf added a commit: rSd977649a31ed: Extract the getServerModifications method.

Revision Contents
Changeset List

PathSize
lib/
ext/
Syncroton/
Command/
177 lines

Diff 14208

View Options

lib/ext/Syncroton/Command/Sync.php

Loading...