So we can integrate the healthcheck into nagios.
Details
- Reviewers
- None
- Group Reviewers
Restricted Project - Commits
- rK3ea3de58c31b: health/status endpoint
rKa548caabd79f: health/status endpoint
rK524bbde0b7cb: health/status endpoint
rK6a9ff883485c: health/status endpoint
rKc7f7ede6135a: health/status endpoint
rK06488b2bb9f1: health/status endpoint
Diff Detail
- Repository
- rK kolab
- Lint
Lint Warnings Severity Location Code Message Warning src/app/Console/Commands/Status/Health.php:25 PHPCS.W.Generic.Files.LineLength.TooLong Generic.Files.LineLength.TooLong - Unit
No Unit Test Coverage - Build Status
Buildable 42320 Build 17093: arc lint + arc unit
Event Timeline
src/app/Http/Controllers/API/V4/HealthController.php | ||
---|---|---|
23 | I would be careful here. The output may contain errors/exceptions. While services routes might be secure, I think it would be nice to have some clean and structured response, i.e. JSON? | |
33 | 200 is the default, we're not using this argument in most of other places. |
src/app/Http/Controllers/API/V4/HealthController.php | ||
---|---|---|
23 | It's a bit of a workaround of course to simply return the command output, but the idea is to return information to what is failing exactly, and potentially why if we can. We could decide to only return what is failing and leave the why to logging (so only ok/errpr per check), but I feel like we're making our job unnecessarily difficult if we have to go dig through logs. |