Page MenuHomePhorge

Display users with no ACTIVE flag as Not Ready, code cleanup
ClosedPublic

Authored by machniak on Mar 27 2023, 1:12 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Jul 10, 7:14 AM
Unknown Object (File)
Sat, Jun 22, 4:50 AM
Unknown Object (File)
Thu, Jun 20, 3:02 PM
Unknown Object (File)
Thu, Jun 20, 2:33 PM
Unknown Object (File)
Thu, Jun 13, 1:00 AM
Unknown Object (File)
Jun 12 2024, 4:42 PM
Unknown Object (File)
Jun 10 2024, 2:02 AM
Unknown Object (File)
May 29 2024, 4:35 PM
Subscribers
Restricted Project

Details

Test Plan

./phpunit

Diff Detail

Repository
rK kolab
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

machniak created this revision.
mollekopf added inline comments.
src/app/Observers/DomainObserver.php
95

So should we perhaps just do a $domain->status = Domain::STATUS_NEW? Or what do we intend to preserve?

src/app/Observers/DomainObserver.php
95

I suppose the initial idea was to preserve CONFIRMED and VERIFIED state, but now I think every restored domain should get NEW state only. This is not a show stopper for this diff.

  • Make domain NEW (and only NEW) on restore
This revision is now accepted and ready to land.Mar 30 2023, 5:55 PM
This revision was automatically updated to reflect the committed changes.