Page MenuHomekolab.org

Display users with no ACTIVE flag as Not Ready, code cleanup
ClosedPublic

Authored by machniak on Mar 27 2023, 1:12 PM.

Details

Test Plan

./phpunit

Diff Detail

Repository
rK kolab
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

machniak requested review of this revision.Mar 27 2023, 1:12 PM
machniak created this revision.
mollekopf added inline comments.
src/app/Observers/DomainObserver.php
95

So should we perhaps just do a $domain->status = Domain::STATUS_NEW? Or what do we intend to preserve?

machniak added inline comments.Mar 30 2023, 10:07 AM
src/app/Observers/DomainObserver.php
95

I suppose the initial idea was to preserve CONFIRMED and VERIFIED state, but now I think every restored domain should get NEW state only. This is not a show stopper for this diff.

machniak updated this revision to Diff 12161.Mar 30 2023, 10:17 AM
  • Make domain NEW (and only NEW) on restore
machniak updated this revision to Diff 12164.Mar 30 2023, 10:22 AM
  • Add some assertions
mollekopf accepted this revision.Mar 30 2023, 5:55 PM
This revision is now accepted and ready to land.Mar 30 2023, 5:55 PM
This revision was automatically updated to reflect the committed changes.