Page MenuHomePhorge

Display users with no ACTIVE flag as Not Ready, code cleanup
ClosedPublic

Authored by machniak on Mar 27 2023, 1:12 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Mar 28, 1:32 AM
Unknown Object (File)
Sat, Mar 16, 7:01 PM
Unknown Object (File)
Thu, Mar 7, 2:00 AM
Unknown Object (File)
Thu, Mar 7, 2:00 AM
Unknown Object (File)
Thu, Mar 7, 1:59 AM
Unknown Object (File)
Thu, Mar 7, 1:59 AM
Unknown Object (File)
Thu, Mar 7, 1:55 AM
Unknown Object (File)
Thu, Mar 7, 12:38 AM
Subscribers
Restricted Project

Details

Test Plan

./phpunit

Diff Detail

Repository
rK kolab
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

machniak created this revision.
mollekopf added inline comments.
src/app/Observers/DomainObserver.php
95

So should we perhaps just do a $domain->status = Domain::STATUS_NEW? Or what do we intend to preserve?

src/app/Observers/DomainObserver.php
95

I suppose the initial idea was to preserve CONFIRMED and VERIFIED state, but now I think every restored domain should get NEW state only. This is not a show stopper for this diff.

  • Make domain NEW (and only NEW) on restore
This revision is now accepted and ready to land.Mar 30 2023, 5:55 PM
This revision was automatically updated to reflect the committed changes.