Page MenuHomePhorge
Feed Search

Apr 5 2018

machniak committed rRPK612fbfd02ea8: Elastic: Small fixes in Calendar.
Apr 5 2018, 2:30 PM
machniak committed rRPK2c9214621f06: Fix code indentation.
Apr 5 2018, 1:46 PM
machniak committed rRPKf422aa853fa2: Remove delegators' identities from pgp key generation form.
Apr 5 2018, 12:28 PM
machniak committed rRPKfb6029edbe07: Elastic: Save-as-event dialog using iframe.
Apr 5 2018, 11:39 AM

Apr 4 2018

machniak committed rRPK4ce8cd281a89: Elastic: Calendar searching.
Apr 4 2018, 12:26 PM
machniak committed rRPK1a8beaa8037d: Fix delegation context on RSVP action in the Calendar UI (Bifrost#T31915).
Apr 4 2018, 8:13 AM
machniak committed rRPK5d6b3ef13d83: Fix delegation context on RSVP action in the Calendar UI (Bifrost#T31915).
Apr 4 2018, 8:12 AM

Apr 3 2018

machniak committed rRPK85ba1bd127f2: Elastic: Calendar improvements.
Apr 3 2018, 11:50 AM
machniak committed rRPK0cbf82632050: Elastic: Use 'notice' messages, not 'info'.
Apr 3 2018, 11:50 AM
machniak committed rRPKbc9325b4676e: Elastic: Fix calendar folder search.
Apr 3 2018, 11:50 AM
machniak committed rRPK4dd6eb589355: Elastic: Fix calendar printing and other css issues.
Apr 3 2018, 10:25 AM

Apr 2 2018

machniak committed rRPKcbd1d83c3d4e: Elastic: Various calendar UI elements and calendar printing.
Apr 2 2018, 5:47 PM

Mar 30 2018

machniak committed rRPKabd0ea1b69b4: Elastic: Add missing folderform template.
Mar 30 2018, 3:15 PM
machniak committed rRPK8aff9a612cf1: Elastic: Calendar iTip-attend template.
Mar 30 2018, 9:46 AM
machniak committed rRPK3346ad8aa69d: Elastic: Calendar - Availability finder dialog.
Mar 30 2018, 8:49 AM

Mar 28 2018

machniak committed rRPKa444b5b801fd: Unify/de-duplicate code for folder form handling.
Mar 28 2018, 3:47 PM
machniak committed rRPK9f58502839ec: Unified addressbook folder edit/create forms with the rest of plugins.
Mar 28 2018, 1:31 PM
machniak committed rRPK42a117710942: Code de-duplication: Move folder editing form template to libkolab plugin.
Mar 28 2018, 1:31 PM

Mar 27 2018

machniak added a comment to T3475: Blue switches do not work as switches but as buttons.

@Laura Goto Settings > Folders. See checkboxes (switches) on the list? These are subscription change switches. Now imagine we add multi-selection capability to that list, which would add a normal checkbox on the left of each folder name. If we do not use the blue-switch-element we end up with two unlabelled checkboxes on each record. So, styling one of them differently would be less confusing. Though still not perfect, that's only one reason. And as I've said I don't have a strong opinion.

Mar 27 2018, 5:40 PM · UX Seminar WS17
machniak committed rRPK653a36730a2a: Elastic: Fix some regressions in Larry skin.
Mar 27 2018, 5:10 PM
machniak committed rRPKb01a3c6038f0: Elastic: Unify calendar editing forms.
Mar 27 2018, 5:10 PM
machniak committed rRPKf35d4fc14f7a: Elastic: Some improvements in Tasks.
Mar 27 2018, 3:33 PM

Mar 26 2018

machniak committed rRPK563262d11068: Elastic: Small improvements.
Mar 26 2018, 5:29 PM
machniak committed rRPK715621e3165c: Elastic: Various improvements in Tasks.
Mar 26 2018, 4:46 PM
machniak committed rRPKa1e090b1f167: Elastic: Add folder type icons (moved from the Elastic core).
Mar 26 2018, 9:19 AM
machniak committed rRPKe1fe8cb95b3d: Elastic: Change Tasks icon.
Mar 26 2018, 9:19 AM
machniak committed rRPKfcde82bb9108: Elastic: Alarms dialog.
Mar 26 2018, 9:19 AM

Mar 25 2018

machniak committed rRPK3b6c5b7bfdbf: Elastic: Mobile mode for tasks.
Mar 25 2018, 1:23 PM

Mar 23 2018

machniak committed rRPKc4a62b6658a2: Elastic: Fix navlist header text.
Mar 23 2018, 12:20 PM
machniak committed rRPK8c4e836dea9e: Elastic: Various elements of the Tasks UI.
Mar 23 2018, 11:47 AM

Mar 22 2018

machniak committed rRPK6bba054b0e3d: Merge branch 'master' into dev/elastic.
Mar 22 2018, 7:31 PM
machniak committed rRPKa7488fa70c3f: Elastic: Tasks printing and some small improvements.
Mar 22 2018, 7:31 PM
machniak committed rRPK4c59b34bbb17: Fix printing tasks.
Mar 22 2018, 4:12 PM
machniak committed rRPK11ad89c586d2: Elastic: Task (and event) edit dialog.
Mar 22 2018, 12:39 PM

Mar 19 2018

machniak committed rRPKfa9d09939c72: More attachment handling code de-duplication.
Mar 19 2018, 6:12 PM
machniak committed rS92d1b22f166d: Fix time zone conversion on systems with various non-utc time zones….
Mar 19 2018, 4:02 PM
machniak committed rRPK5b242b8e2604: Merge audittrail.js and kolabfolders.js code into libkolab.js.
Mar 19 2018, 12:54 PM
machniak committed rRPK5b57dd944922: De-duplicate attachments handling code, move it to libkolab plugin.
Mar 19 2018, 12:28 PM
machniak committed rRPK2bd656638782: Elastic: Added templates for Calendar plugin.
Mar 19 2018, 7:33 AM
machniak committed rRPK55a848087fec: Don't ignore skins.
Mar 19 2018, 7:33 AM

Mar 16 2018

machniak committed rRPK700a64b40dc8: Fix finding first occurrence for all-day events (Bifrost#T82770).
Mar 16 2018, 3:18 PM
machniak committed rRPKc7c42eabba23: Elastic: Calendar event info dialog.
Mar 16 2018, 12:40 PM
machniak committed rRPKe3f7593162c1: Elastic: Attachments tab in event edit dialog.
Mar 16 2018, 11:25 AM
machniak committed rRPKac454a59a786: Elastic: Calendar icon colors.
Mar 16 2018, 11:25 AM
machniak committed rRPKe52bc0a1582e: Merge branch 'master' into dev/elastic.
Mar 16 2018, 8:25 AM
machniak committed rRPKb96508f0211e: Calendar: Removed classic skin support.
Mar 16 2018, 8:25 AM
machniak committed rRPK21c4b6a5bb39: Elastic: Partial support for calendar plugin.
Mar 16 2018, 8:25 AM

Mar 15 2018

machniak added inline comments to D577: With this patch I'm trying to introduce a file-type object in logger, which could swallow everything thrown to stderr (and possibly stdout) and redirect to python logger. Python smtplib debug mode prints everything to stderr, but when wallace runs....
Mar 15 2018, 2:47 PM
machniak committed rRPK6f73df9bbda0: Elastic: Use pretty checkboxes on folders lists in Tasks.
Mar 15 2018, 1:44 PM
machniak committed rRPK94000956428d: Elastic: Initial (partial) support for tasklist plugin.
Mar 15 2018, 1:33 PM

Mar 13 2018

machniak added a comment to T3466: Unclear and missleading function "Tasks" in the folder menu.

We're limited by Font-Awesome iconset. And there the tasks icon is https://fontawesome.com/icons/tasks?style=solid. I also am not sure if only the icon change would fix the issue.

Mar 13 2018, 8:08 PM · UX Seminar WS17

Mar 12 2018

machniak accepted D571: In some cases kolabd fails to cleanly update IMAP mailbox after LDAP changes. That is usual when result_attribute value is in upper case. Mailbox modification seems to follow slightly different code path, by shortcutting to IMAP pykolab function....
Mar 12 2018, 1:54 PM
machniak added a comment to D571: In some cases kolabd fails to cleanly update IMAP mailbox after LDAP changes. That is usual when result_attribute value is in upper case. Mailbox modification seems to follow slightly different code path, by shortcutting to IMAP pykolab function....

Looks to me like now you'll add user/ prefix twice. See in user_mailbox_extsts() and code above your change.

Mar 12 2018, 1:05 PM

Mar 8 2018

machniak committed rRPK7ba3605df99b: Fix regression in using folder object.
Mar 8 2018, 12:45 PM
machniak committed rC15d122efae44: Fix default of fileapi_seafile_debug.
Mar 8 2018, 12:29 PM

Mar 7 2018

machniak committed rSd8b8d01b3af5: Throw exceptions when creating objects fails (proper SQL error handling).
Mar 7 2018, 4:14 PM
machniak committed rSf1dbbef2ae96: Always set an event organizer on new event (Bifrost#T75126).
Mar 7 2018, 10:42 AM
machniak committed rS651a2ad8db70: Support performance_stats option, use unified number format.
Mar 7 2018, 9:06 AM
machniak committed rS6d2a806580c3: Send DstMsgId only if it's not empty.
Mar 7 2018, 8:06 AM
machniak committed rS3052fc5ba415: Fix 'tag Moves not found' exception on MoveItems request (regression).
Mar 7 2018, 8:06 AM
machniak added a comment to T3466: Unclear and missleading function "Tasks" in the folder menu.

You can see what tasks are when you login to https://kolabnow.com/apps. Tasks are similar to calendar events, but don't have to have a date specified. In other words tasks are "todo items".

Mar 7 2018, 7:03 AM · UX Seminar WS17

Mar 6 2018

machniak closed T3757: webdav driver not working as Resolved.

Fixed in 876c956c24a4d.

Mar 6 2018, 4:39 PM · Chwala
machniak committed rC876c956c24a4: Fix handling of Content-Length in WebDAV responses (T3757).
Mar 6 2018, 4:39 PM
machniak claimed T3757: webdav driver not working.

Looks like the fix in https://git.kolab.org/rC3b776f3a10e2443c0e47d331333265f9c75d7392 wasn't correct. We need to just support both cases.

Mar 6 2018, 3:23 PM · Chwala
machniak added a comment to T3757: webdav driver not working.

So, your webdav server does not return Content-Length or the http client code is buggy? Did you try to log response headers ($response['headers'])?

Mar 6 2018, 2:48 PM · Chwala
machniak committed rRPK77aa438b51b7: Fix unstoppable "Loading..." message on events export.
Mar 6 2018, 12:19 PM
machniak added a comment to T3466: Unclear and missleading function "Tasks" in the folder menu.

When we implement the new skin for Tasks plugin, users will see a new entry on the left side menu (with the same icon). Then the entry on folders list hopefuly would be less confusing. But aside of that, I agree that together with the fact that it was the last folder on the list it could have been confusing. The use of special-type folders in Kolab is another story.

Mar 6 2018, 7:49 AM · UX Seminar WS17
machniak added a comment to T3583: missing consistency for drag and drop.

Drag-n-drop works in Settings > Folders, but not in Mail UI. I generally agree that it would be nice to have all functionality of the folder manager in Mail UI, but it's just quite a lot of work.

Mar 6 2018, 7:36 AM · UX Seminar WS17

Mar 5 2018

machniak closed T2313: kolab 16.1 roundcube webmail calendar internal server error parsing time string as Resolved.

Patch applied in 239783c3dd576.

Mar 5 2018, 11:04 AM · Roundcube Kolab Plugins , Kolab 16, Bug Reports
machniak committed rRPK239783c3dd57: T2313: Prevent from PHP fatal errors caused by double timezone spec. in….
Mar 5 2018, 11:03 AM

Mar 3 2018

machniak added a comment to T3670: [Use Test] Inconsistency in drop-down menu after right-click.

I created an upstream ticket for contextmenu plugin https://github.com/johndoh/roundcube-contextmenu/issues/104

Mar 3 2018, 7:49 AM · UX Seminar WS17

Mar 2 2018

machniak committed rS7705323832d1: Bump version to 2.3.9.
Mar 2 2018, 10:03 AM
machniak committed rS23335732da8e: Minimize false-positive cases for SEQUENCE bumps on event update.
Mar 2 2018, 9:57 AM

Mar 1 2018

machniak closed T3745: Outlook 2016 new subfolders in inbox as Invalid.

Duplicate of T2223

Mar 1 2018, 8:31 PM · Bug Reports
machniak committed rS3ee9fe809329: Correct ActiveSync command name (Moves -> MoveItems).
Mar 1 2018, 7:11 AM

Feb 28 2018

machniak committed rRPKf8692a19dc4c: Elastic: Add style for iTip invitation handling boxes.
Feb 28 2018, 5:08 PM
machniak committed rRPK9483a0b13c54: Code indentation fix.
Feb 28 2018, 12:23 PM
machniak committed rRPKc6e0395dd9ae: We accept iTip replies with older SEQUENCE but no significant changes….
Feb 28 2018, 12:23 PM

Feb 27 2018

machniak committed rRPK7b748e93e3df: Elastic: Add style for some more elements.
Feb 27 2018, 3:35 PM

Feb 26 2018

machniak committed rS0e60249d98b4: Fix possible issues in event attendees handling by more sanity checks.
Feb 26 2018, 9:19 AM

Feb 25 2018

machniak committed rRPK6b712f1a21fb: Elastic: Fix treetoggle regression.
Feb 25 2018, 10:35 AM
machniak committed rRPK0ee3194fd449: Fix reference to rcmail object.
Feb 25 2018, 10:35 AM

Feb 23 2018

machniak committed rS761e621e6b10: Fix detecting folder hierarchy changes in FolderSync (Bifrost#T42645).
Feb 23 2018, 1:17 PM

Feb 15 2018

machniak updated subscribers of T3643: [Use Test] Unclear how to add recipient from address book .

There's more than that. If we move the Options and Attachments to the right we have a (technical) problem in tablet mode. Because when switching from Options to Contacts will make them appear one on right the other on left. Which might be annoing and I can't fix that easily. You should try the tablet mode (smaller screen where only two columns are visible).

Feb 15 2018, 9:48 AM · UX Seminar WS17
machniak added a comment to T3643: [Use Test] Unclear how to add recipient from address book .

Your proposition does not make much sense to me because to add a contact you first need to select it on the list. So, while you're on the list it's better to use button in list footer than in the input, imho.

Feb 15 2018, 9:33 AM · UX Seminar WS17

Feb 14 2018

machniak added a comment to T3649: [Use Test] Confusing that window must be closed manually after having imported contacts.

You mean the one in right-bottom corner? It's not well suited for long text. Of course, we could think if list of imported contacts is really important for the user. Maybe a number would be enough. Then it could be a popup.

Feb 14 2018, 12:42 PM · UX Seminar WS17

Feb 13 2018

machniak committed rS974a07a38774: Fix folder hierarchy changes detection and response in Sync.
Feb 13 2018, 9:53 AM
machniak committed rRPKa689f3dce632: Support unicode characters in UIDs on MySQL (Bifrost#T75336).
Feb 13 2018, 7:56 AM

Feb 12 2018

machniak added a comment to T3610: Sort-E-Mails function hard to find.

The additional bar makes it too clattered. I also think that sorting order change is not something you do often.

Feb 12 2018, 2:11 PM · UX Seminar WS17
machniak added a comment to T3643: [Use Test] Unclear how to add recipient from address book .

That would make sense if the Contacts list was displayed in a popup dialog, but it's all the time on left. So, maybe we should consider removing the Contacts list box and use a dialog. However, there's a plugin that adds a button in contacts list footer which is used to attach selected contact vCard to the message. It would need to be implamented in some different way.

Feb 12 2018, 2:05 PM · UX Seminar WS17
machniak added a comment to T3595: Inconsistency in drop-down-menu design (Inbox).

This is not the same and I don't think they need to look the same. On the first screenshot you have the standard <select> element. How it looks depends on the web browser used. The other screenshot contains a custom dialog which is not a <select> and is not a single-selection list. Of course we could replace <select> lists with something custom, but I'm just not sure this is a good practice. BTW, there's another ticket about iOS Safari select lists looking completely different, but I guess browser/device developers do this for a reason.

Feb 12 2018, 1:59 PM · UX Seminar WS17
machniak added a comment to T3538: Function "Spell Check" is more likely expected among the formatting options above the text field and therefore hard to find.

An icon is one thing we have a ticket about. The other thing is button position. It is placed in the toolbar for consistency. When you don't use HTML editor, you don't have the text editor toolbar above the textarea.

Feb 12 2018, 1:54 PM · UX Seminar WS17
machniak added a comment to T3457: Hard to find folder functions: example "delete folder" (Usetest experiences).

I agree that folder management actions should be available here. It's just a lot of work. When we'll have them in the menu, they will appear also in the right-click menu.

Feb 12 2018, 12:51 PM · UX Seminar WS17
machniak added a comment to T3652: [Use Test] Searching for contacts does not work by clicking on the magnifier symbol.

In current version I slightly modified the look of the icon so it does not look like a button, making it less confusing. We could consider removing it at all.

Feb 12 2018, 12:36 PM · UX Seminar WS17
machniak added a comment to T3478: Too many steps to insert a picture in the email text.

We're here limited by the TinyMCE editor functionality. We control the Select Image dialog, so I guess we could improve it a little bit. E.g. by automatically pre-selecting newly added image and adding "Continue" or "Insert" button. We could also see if TinyMCE provides an API to replace completely its Insert/Edit image dialog.

Feb 12 2018, 12:28 PM · UX Seminar WS17
machniak added a comment to T2723: middle column in 'composing' menu on the wrong side.

So, would you propose to:

  • move the Options box to the right of the main box
  • move the Contacts box to the right of the main box
  • move both Options and Contacts to the right side?
Feb 12 2018, 12:14 PM · UX Seminar WS17
machniak added a comment to T3649: [Use Test] Confusing that window must be closed manually after having imported contacts.

We should not close automatically, because user should be able to read which contacts have been imported. We could however, replace the dialog buttons with one "Close" button, I guess.

Feb 12 2018, 12:09 PM · UX Seminar WS17
machniak added a comment to T3475: Blue switches do not work as switches but as buttons.

We still might need to use the "switch" instead of a standard checkbox on desktop. It's e.g. when you have a selectable list like the folders list, where you would use checkboxes for multi-selection and switches for subscription change. Also, I think these days users are used to know switches as everybody saw them on their mobile. Though, I don't have a strong opinion about that. Maybe we should indeed not use them on desktop.

Feb 12 2018, 12:07 PM · UX Seminar WS17
machniak added a comment to T3514: missing consistency for right click options.

I agree. Right-click functionality is provided by an external plugin. I created a ticket there https://github.com/johndoh/roundcube-contextmenu/issues/103. We'd need also such functionality for Kolab plugins that add Settings sections i.e. kolab_activesync and kolab_delegation.

Feb 12 2018, 11:55 AM · UX Seminar WS17

Jan 30 2018

machniak committed rRPK793ced3d1e30: Elastic: Small spacing fix.
Jan 30 2018, 9:38 AM