What File dialog? Could you be more precise? The notifications should be displayed in all Roundcube windows. That's how it worked.

In T224#31305, @greve wrote:

Would it display them all, or just the first/primary/top level one?

In T224#31251, @greve wrote:

Does the "only Calendar" mean it shows only the main folder, or that it only shows Calendars, incuding hierarchy for the Symantec App?

It would display only the Calendar folder, without any hierarchy in this case.

Would such folder names be possible in the ActiveSync protocol?

We can set anything as a folder name.

In T224#31227, @greve wrote:

But we're only seeing Calendar, Subcalendar2, Subcalendar4 and Subsubcalendar3 because both Subsubcalendar and Subsubcalendar2 are being hidden by the state of their parent folder and this behaviour is consistent across all devices?

Not only deleted, but indeed IMAP allows for hierarchies with deleted parents. It may also exist but be unsubscribed (in general or for activesync only), or it may be a namespace root (which is also a kind of special folder and generally not subscibeable).

@vanmeeuwen No, this is not a duplicate. The issue still persists with pykolab code from git-master. See Bifrost T16075 for the same issue.

I don't think we should imitate the editor api if any of manticore_api nor document_editor_api exists. If that happens it's an error anyway. Actually I can think only about one case, the chwala javascript file didn't load. As you can see in https://git.kolab.org/rRPK7adf82a0c6a0b272af8847dedd4b912312141f0e loading the manticore_api was never conditional.

@vanmeeuwen, The issue is fixed, but two tests fail now:

======================================================================
FAIL: test_002_check_event_conflict
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/usr/lib64/python2.7/site-packages/twisted/internet/defer.py", line 134, in maybeDeferred
    result = f(*args, **kw)
  File "/usr/lib64/python2.7/site-packages/twisted/internet/utils.py", line 191, in runWithWarningsSuppressed
    result = f(*a, **kw)
  File "/root/pykolab/tests/unit/test-011-itip.py", line 450, in test_002_check_event_conflict
    self.assertTrue(itip.check_event_conflict(event3, itip_event), "Conflict in two recurring events")
  File "/usr/lib64/python2.7/site-packages/twisted/trial/unittest.py", line 224, in failUnless
    raise self.failureException(msg)
FailTest: Conflict in two recurring events

This already has been fixed. For some reason Phabricator didn't connect my diff with the T1847.

D308 is a little bit hacky (and may not find all conflicts), but works. And the old method wasn't perfect anyway.

It is not infinite. It is just so extremally slow... For two weekly recurring events it does around 10 * 50 * 10 * 50 iterations. And every iteration calls getLastOccurrence(), getOccurenceEndDate(), etc. on EventCal (from kolab.calendaring). Looks like these are slow.

DAVBackend::folder_create() returns false on error, but it should throw an exception.

Diff created. I didn't find a nice way to avoid imap_debug issue described in my comment above. There are two sides of this issue though:

• user id/name is not set before user is authenticated. That's why some part of logs go to logs/ directory instead of logs/<username>/. I found a workaround, but a little bit hacky. In DAVLogger::_construct() add:

$_SESSION['username'] = $_SERVER['PHP_AUTH_USER'];
$_SESSION['user_id']      = -1;

this however requires to login with canonified username, if you use alias for login and canonified username for logs dir it will not catch up.
Anyway this is not a big issue, as most relevant logs are written on after auth.

• should logs/imap file (and others) be created at all if per_user_logging=true? I mean that's current behaviour, but changing this would allow as to have all debug options enabled with per_user_logging and get logs only for set up users.

Removed Kolab's nodejs and installed Node.js v6. Now it works. There's only one error now:

[error] backend port not found: :inotifywait

Ouch. Indeed. As I had problems with installing npm on Kolab:Winterfell host (see T1967) I installed npm manually, but it looks like the version I installed does not support Node.js 0.12.8 which comes with Kolab.

Probably a bug fixed here: https://git.kolab.org/rP54cb493d655bb67719572acd934994161c3751af

And related to this, enabling e.g. imap_debug together with any of above options does not really work as expected, i.e. the whole imap conversation from after login goes where expected, but everything before the user has been authenticated goes to logs/imap. Maybe it would be possible to fix this by setting $_SESSION['username'] before loging into imap.

We need more recent roundcubemail-plugins-kolab package.

According to otphp's composer.json, this change bumps PHP version requirement to at least 5.5.

I foun the broken commit rRPK1f88231db9fd0edca6e5b09c38e150216d760341. Fixed.

These "untranslated" messages come form wallace. We need to take care the solution works also for environments where invitation policy is not used at all or is used in various other modes.

I think a date is possible here if the event is full-day recurring event. In such a case to_dt() is not used on the event last occurence date in https://git.kolab.org/diffusion/P/browse/master/wallace/module_resources.py;71df0cc7b4fc8373e6d84db8e8c01e56ca99ad25$506

Thanks.

Thanks.

Well, collabora devs implemented features that allowed to implement Kolab toolbar as described in [1] (an as on the screenshot). Still, we didn't really decide that it's a better approach. It was simpler to implement.

Do I understand correctly that you use database driver?

Done in 0d32dc639b16. The event name is calendar-event-dialog.