Fix driver initialization with config properties for the right method (T1784)
ClosedPublic

Authored by bruederli on Oct 30 2016, 2:54 PM.

Details

Summary

Proposed fix for the bug reported in T1784

The method kolab_2fa::get_driver() is called with the full factor ID (<method>:<uuid>)
and therefore fails to retrieve the right properties from plugin config. This change fixes this at the right place.

Diff Detail

Repository
rRPK roundcubemail-plugins-kolab
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
bruederli retitled this revision from to Fix driver initialization with config properties for the right method (T1784) The method kolab_2fa::get_driver() is called with the full factor ID (<method>:<uuid>) and therefore fails to retrieve the right properties from plugin config. This....Oct 30 2016, 2:54 PM
bruederli updated this object.
bruederli added a reviewer: machniak.
bruederli added a subscriber: jh23453.
bruederli retitled this revision from Fix driver initialization with config properties for the right method (T1784) The method kolab_2fa::get_driver() is called with the full factor ID (<method>:<uuid>) and therefore fails to retrieve the right properties from plugin config. This... to Fix driver initialization with config properties for the right method (T1784).Oct 30 2016, 2:55 PM
bruederli updated this object.

You recommended to remove the $config definition from plugins/kolab_2fa/lib/Kolab2FA/Driver/Yubikey,php, but that hunk is missing,
Otherwise looks good to me.

bruederli updated this revision to Diff 599.Nov 2 2016, 9:06 PM
  • Remove useless Yubikey:: property re-definition
machniak accepted this revision.Nov 9 2016, 9:51 AM
This revision is now accepted and ready to land.Nov 9 2016, 9:51 AM
This revision was automatically updated to reflect the committed changes.