Page MenuHomekolab.org
Differential D242

Fix driver initialization with config properties for the right method (T1784)
ClosedPublic
Actions

Authored by bruederli on Oct 30 2016, 2:54 PM.

Details

Reviewers
machniak
Commits
rRPKdb2d3bc800fe: Fix driver initialization with config properties for the right method (T1784)
Summary

Proposed fix for the bug reported in T1784

The method kolab_2fa::get_driver() is called with the full factor ID (<method>:<uuid>)
and therefore fails to retrieve the right properties from plugin config. This change fixes this at the right place.

Diff Detail

Repository
rRPK roundcubemail-plugins-kolab
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

bruederli updated this revision to Diff 587.Oct 30 2016, 2:54 PM
bruederli retitled this revision from to Fix driver initialization with config properties for the right method (T1784) The method kolab_2fa::get_driver() is called with the full factor ID (<method>:<uuid>) and therefore fails to retrieve the right properties from plugin config. This....
bruederli updated this object.
bruederli added a reviewer: machniak.
bruederli added a subscriber: jh23453.
bruederli retitled this revision from Fix driver initialization with config properties for the right method (T1784) The method kolab_2fa::get_driver() is called with the full factor ID (<method>:<uuid>) and therefore fails to retrieve the right properties from plugin config. This... to Fix driver initialization with config properties for the right method (T1784).Oct 30 2016, 2:55 PM
bruederli updated this object.
bruederli mentioned this in T1784: kolab_2fa: yubico doesn't use config in /etc/roundcubemail/kolab_2fa.inc.php.
jh23453 added a comment.Oct 31 2016, 6:18 AM

You recommended to remove the $config definition from plugins/kolab_2fa/lib/Kolab2FA/Driver/Yubikey,php, but that hunk is missing,
Otherwise looks good to me.

bruederli updated this revision to Diff 599.Nov 2 2016, 9:06 PM
  • Remove useless Yubikey:: property re-definition
machniak accepted this revision.Nov 9 2016, 9:51 AM
machniak edited edge metadata.
This revision is now accepted and ready to land.Nov 9 2016, 9:51 AM
Closed by commit rRPKdb2d3bc800fe: Fix driver initialization with config properties for the right method (T1784) (authored by bruederli, committed by machniak). · Explain WhyNov 9 2016, 9:56 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 605

View Options

plugins/kolab_2fa/config.inc.php.dist

Loading...
View Options

plugins/kolab_2fa/kolab_2fa.php

Loading...
View Options

plugins/kolab_2fa/lib/Kolab2FA/Driver/Yubikey.php

Loading...