Differential D242

Fix driver initialization with config properties for the right method (T1784)
ClosedPublic
Actions

Authored by bruederli on Oct 30 2016, 2:54 PM.

Details

Reviewers

machniak

Commits

rRPKdb2d3bc800fe: Fix driver initialization with config properties for the right method (T1784)

Summary

Proposed fix for the bug reported in T1784

The method kolab_2fa::get_driver() is called with the full factor ID (<method>:<uuid>)
and therefore fails to retrieve the right properties from plugin config. This change fixes this at the right place.

Diff Detail

Repository

rRPK roundcubemail-plugins-kolab

Branch

master

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 5588
Build 5684: arc lint + arc unit

Event Timeline

bruederli updated this revision to Diff 587.Oct 30 2016, 2:54 PM

bruederli retitled this revision from to Fix driver initialization with config properties for the right method (T1784) The method kolab_2fa::get_driver() is called with the full factor ID (<method>:<uuid>) and therefore fails to retrieve the right properties from plugin config. This....

bruederli updated this object.

bruederli added a reviewer: machniak.

bruederli added a subscriber: jh23453.

bruederli retitled this revision from Fix driver initialization with config properties for the right method (T1784) The method kolab_2fa::get_driver() is called with the full factor ID (<method>:<uuid>) and therefore fails to retrieve the right properties from plugin config. This... to Fix driver initialization with config properties for the right method (T1784).Oct 30 2016, 2:55 PM

bruederli updated this object.

bruederli mentioned this in T1784: kolab_2fa: yubico doesn't use config in /etc/roundcubemail/kolab_2fa.inc.php.

You recommended to remove the $config definition from plugins/kolab_2fa/lib/Kolab2FA/Driver/Yubikey,php, but that hunk is missing,
Otherwise looks good to me.