Page MenuHomePhorge

Fix driver initialization with config properties for the right method (T1784)
ClosedPublic

Authored by bruederli on Oct 30 2016, 2:54 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Dec 8, 8:15 PM
Unknown Object (File)
Sun, Dec 8, 4:30 PM
Unknown Object (File)
Sun, Dec 8, 2:59 PM
Unknown Object (File)
Fri, Dec 6, 10:23 PM
Unknown Object (File)
Thu, Dec 5, 11:58 AM
Unknown Object (File)
Thu, Dec 5, 6:29 AM
Unknown Object (File)
Tue, Dec 3, 1:23 PM
Unknown Object (File)
Tue, Dec 3, 1:26 AM
Subscribers

Details

Summary

Proposed fix for the bug reported in T1784

The method kolab_2fa::get_driver() is called with the full factor ID (<method>:<uuid>)
and therefore fails to retrieve the right properties from plugin config. This change fixes this at the right place.

Diff Detail

Repository
rRPK roundcubemail-plugins-kolab
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

bruederli retitled this revision from to Fix driver initialization with config properties for the right method (T1784) The method kolab_2fa::get_driver() is called with the full factor ID (<method>:<uuid>) and therefore fails to retrieve the right properties from plugin config. This....
bruederli updated this object.
bruederli added a reviewer: machniak.
bruederli added a subscriber: jh23453.
bruederli retitled this revision from Fix driver initialization with config properties for the right method (T1784) The method kolab_2fa::get_driver() is called with the full factor ID (<method>:<uuid>) and therefore fails to retrieve the right properties from plugin config. This... to Fix driver initialization with config properties for the right method (T1784).Oct 30 2016, 2:55 PM
bruederli updated this object.

You recommended to remove the $config definition from plugins/kolab_2fa/lib/Kolab2FA/Driver/Yubikey,php, but that hunk is missing,
Otherwise looks good to me.

  • Remove useless Yubikey:: property re-definition
machniak edited edge metadata.
This revision is now accepted and ready to land.Nov 9 2016, 9:51 AM
This revision was automatically updated to reflect the committed changes.