Page MenuHomePhorge

Fix driver initialization with config properties for the right method (T1784)
ClosedPublic

Authored by bruederli on Oct 30 2016, 2:54 PM.
Tags
None
Referenced Files
F16032960: D242.diff
Sat, Oct 12, 8:36 PM
Unknown Object (File)
Tue, Oct 8, 8:50 AM
Unknown Object (File)
Sep 7 2024, 9:29 AM
Unknown Object (File)
Sep 7 2024, 6:23 AM
Unknown Object (File)
Sep 7 2024, 6:12 AM
Unknown Object (File)
Sep 3 2024, 5:52 AM
Unknown Object (File)
Aug 31 2024, 2:26 PM
Unknown Object (File)
Aug 29 2024, 2:45 PM
Subscribers

Details

Summary

Proposed fix for the bug reported in T1784

The method kolab_2fa::get_driver() is called with the full factor ID (<method>:<uuid>)
and therefore fails to retrieve the right properties from plugin config. This change fixes this at the right place.

Diff Detail

Repository
rRPK roundcubemail-plugins-kolab
Branch
master
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 5498
Build 5588: arc lint + arc unit

Event Timeline

bruederli retitled this revision from to Fix driver initialization with config properties for the right method (T1784) The method kolab_2fa::get_driver() is called with the full factor ID (<method>:<uuid>) and therefore fails to retrieve the right properties from plugin config. This....
bruederli updated this object.
bruederli added a reviewer: machniak.
bruederli added a subscriber: jh23453.
bruederli retitled this revision from Fix driver initialization with config properties for the right method (T1784) The method kolab_2fa::get_driver() is called with the full factor ID (<method>:<uuid>) and therefore fails to retrieve the right properties from plugin config. This... to Fix driver initialization with config properties for the right method (T1784).Oct 30 2016, 2:55 PM
bruederli updated this object.

You recommended to remove the $config definition from plugins/kolab_2fa/lib/Kolab2FA/Driver/Yubikey,php, but that hunk is missing,
Otherwise looks good to me.

  • Remove useless Yubikey:: property re-definition
machniak edited edge metadata.
This revision is now accepted and ready to land.Nov 9 2016, 9:51 AM
This revision was automatically updated to reflect the committed changes.