Page MenuHomePhorge
Create Task
Maniphest T969

Update Roundcube package dependencies
Closed, ResolvedPublic
Actions

Description

I saw https://obs.kolabsys.com/package/view_file/Kolab:16/roundcubemail/roundcubemail.spec?expand=1

Roundcube 1.2:

  • don't require pear's MDB2, Mail_mimeDecode, nor DB,
  • don't require php-mcrypt,
  • require php modules: pdo, openssl, session, json, pcre,
  • require pear's Crypt_GPG >= 1.4.0 (for Enigma plugin).

Also, we're using Net_Sieve package from https://github.com/roundcube/Net_Sieve.git which supports PHP7.

Roundcube 1.3:

  • now uses endroid/qrcode, we have a package already and roundcubemail should depend on it

Details

Ticket Type
Task

Event Timeline

machniak created this task.Jan 28 2016, 3:31 PM
machniak assigned this task to vanmeeuwen.
machniak raised the priority of this task from to 60.
machniak updated the task description. (Show Details)
machniak changed Ticket Type from Task to Task.
machniak subscribed.
machniak added projects: Kolab 16, Roundcube.Nov 29 2016, 9:18 AM
machniak added a comment.May 10 2017, 1:05 PM

On PHP7 (Ubuntu Xenial) we see:

[10-May-2017 12:57:43 Europe/Berlin] PHP Deprecated:  Methods with the same name as their class will not be construc
tors in a future version of PHP; Net_Sieve has a deprecated constructor in /usr/share/php/Net/Sieve.php on line 93
[10-May-2017 12:57:43 Europe/Berlin] PHP Warning:  array_merge(): Argument #1 is not an array in /usr/share/php/Net/
Sieve.php on line 312

these are fixed in the Roundcube's fork of Net_Sieve. We should provide that in packaging.

vanmeeuwen reassigned this task from vanmeeuwen to machniak.May 21 2017, 9:32 AM
vanmeeuwen subscribed.

Roundcube 1.2:

  • don't require pear's MDB2, Mail_mimeDecode, nor DB,
  • don't require php-mcrypt,

Those would be OK-ish to drop, ...

  • require php modules: pdo, openssl, session, json, pcre,

These packages do not actually exist on RHEL 7?

  • require pear's Crypt_GPG >= 1.4.0 (for Enigma plugin).

Also, we're using Net_Sieve package from https://github.com/roundcube/Net_Sieve.git which supports PHP7.

Any chance this is going upstream? We do not ship Net_Sieve at all anymore.

machniak added a comment.May 21 2017, 9:41 AM

The original Net_Sieve author abandoned the package and didn't want to fix it. That's why we forked. As for the pdo, openssl, session, json, pcre, these are php extensions, I didn't check package names for them.

machniak added a comment.May 21 2017, 10:36 AM

https://github.com/pear/Net_Sieve/pull/5 for reference. However, I'll try to take over the package and backport our fixes to it anyway.

machniak added a comment.May 21 2017, 4:50 PM

Net_Sieve taken over. So, we can keep using pear/Net_Sieve. Note that for PHP7 support version 1.4.0 is required.

machniak updated the task description. (Show Details)Aug 3 2017, 8:38 AM
pasik subscribed.Nov 25 2017, 2:42 PM
vanmeeuwen lowered the priority of this task from 60 to Normal.Mar 28 2019, 8:13 AM
mollekopf closed this task as Resolved.Aug 3 2022, 12:48 PM
mollekopf subscribed.

Fixed in roundcubemail-selfcontained