Page MenuHomekolab.org

sicherha (Christoph Erhardt)
User

User Details

User Since
Feb 4 2016, 9:02 AM (327 w, 4 d)

Recent Activity

Sun, May 8

sicherha added a comment to T6805: Port pykolab to Python 3.

Actually, cyruslib.py is not external; it is part of the pykolab package. Its source lies in the root of the pykolab repository.

Sun, May 8, 10:33 AM · Architecture & Design
sicherha committed rP63532e93c5ab: [Python 3] some more function and module names changed (authored by sicherha).
[Python 3] some more function and module names changed
Sun, May 8, 10:18 AM
sicherha closed D3481: [Python 3] some more function and module names changed.
Sun, May 8, 10:18 AM
sicherha accepted D3481: [Python 3] some more function and module names changed.
Sun, May 8, 10:17 AM
sicherha committed rPc2b69efbdd07: [Python 3] relative imports fixes (dynamic imports) Part 2 (authored by sicherha).
[Python 3] relative imports fixes (dynamic imports) Part 2
Sun, May 8, 10:12 AM
sicherha committed rP8add8bba35df: [Python 3] imap4-utf-7 codec implementation to Python 3 (authored by sicherha).
[Python 3] imap4-utf-7 codec implementation to Python 3
Sun, May 8, 10:12 AM
sicherha closed D3508: [Python 3] imap4-utf-7 codec implementation to Python 3.
Sun, May 8, 10:11 AM
sicherha accepted D3508: [Python 3] imap4-utf-7 codec implementation to Python 3.

Looks good to me.

Sun, May 8, 10:07 AM

Apr 10 2022

sicherha added a comment to D3469: [Python 3] bytes-like strings decoding for saslauthd.py.

@vanmeeuwen, how should we proceed here? This is an effort to get the PyKolab codebase into a state where it works with Python 3 without breaking existing systems that are still based on legacy Python 2. Given that background, the commit looks plausible to me.

Apr 10 2022, 3:52 PM
sicherha assigned T6220: Mailing list website inaccessible to petersen.
Apr 10 2022, 2:55 PM · Bug Reports

Mar 20 2022

sicherha added a comment to D3448: [Python 3] <= between different type error .
In D3448#41491, @ghane wrote:

pykolab.auth ERROR [11820] Authentication cache failed: TypeError("'<=' not supported between instances of 'TypeError' and 'int'")

Wait - so somewhere, someone tries to call debug() with a level argument that has the type TypeError? That doesn't sound right at all...

Mar 20 2022, 8:18 PM

Mar 16 2022

sicherha committed rP87463ed0703e: [Python 3] fork code harmonizing (authored by sicherha).
[Python 3] fork code harmonizing
Mar 16 2022, 10:29 PM
sicherha closed D3442: [Python 3] fork code harmonizing.
Mar 16 2022, 10:29 PM
sicherha accepted D3442: [Python 3] fork code harmonizing.
Mar 16 2022, 10:28 PM
sicherha committed rPb7a9a386bb97: [Python 3]rfc822 module has been removed (authored by sicherha).
[Python 3]rfc822 module has been removed
Mar 16 2022, 10:24 PM
sicherha closed D3457: [Python 3]rfc822 module has been removed.
Mar 16 2022, 10:24 PM
sicherha accepted D3457: [Python 3]rfc822 module has been removed.
Mar 16 2022, 10:22 PM

Mar 15 2022

sicherha requested changes to D3457: [Python 3]rfc822 module has been removed.

The only rfc822 function used below is rfc822.parsedate(); according to https://docs.python.org/3.10/library/email.utils.html, its email counterpart is not not email.parsedate() but email.utils.parsedate().

Mar 15 2022, 12:10 AM
sicherha committed rP6bccc291371a: [Python 3] mixed string operation on saslsocket (authored by sicherha).
[Python 3] mixed string operation on saslsocket
Mar 15 2022, 12:01 AM
sicherha closed D3451: [Python 3] mixed string operation on saslsocket.
Mar 15 2022, 12:01 AM
sicherha accepted D3451: [Python 3] mixed string operation on saslsocket.
Mar 15 2022, 12:00 AM

Mar 14 2022

sicherha added a comment to D3448: [Python 3] <= between different type error .

Do you have a backtrace of a call to debug() that triggers this type error? I wonder if it might be preferable to fix the root cause rather than the symptom.

Mar 14 2022, 11:55 PM
sicherha requested changes to D3442: [Python 3] fork code harmonizing.

Could you add to the summary of this differential a description of the concrete error that is being solved here? I presume that some part of Python (which one?) complained about one of the file descriptors for stdin/ stdout/ stderr being unavailable, but it would be great to make that explicit.

Mar 14 2022, 11:51 PM

Mar 13 2022

sicherha committed rP40cb3982dd8e: [Python 3] changed get syntax in ConfigParser module (authored by sicherha).
[Python 3] changed get syntax in ConfigParser module
Mar 13 2022, 8:57 PM
sicherha closed D3436: [Python 3] changed get syntax in ConfigParser module.
Mar 13 2022, 8:57 PM
sicherha accepted D3436: [Python 3] changed get syntax in ConfigParser module.
Mar 13 2022, 8:57 PM
sicherha committed rP4c5fc07c8211: [Python 3] dropped module anydbm (authored by sicherha).
[Python 3] dropped module anydbm
Mar 13 2022, 8:51 PM
sicherha closed D3430: [Python 3] dropped module anydbm.
Mar 13 2022, 8:51 PM
sicherha accepted D3430: [Python 3] dropped module anydbm.
Mar 13 2022, 8:50 PM
sicherha committed rP81921eb1f994: [Python 3] relative imports fixes (dynamic imports) (authored by sicherha).
[Python 3] relative imports fixes (dynamic imports)
Mar 13 2022, 8:48 PM
sicherha closed D3427: [Python 3] relative imports fixes (dynamic imports).
Mar 13 2022, 8:48 PM
sicherha accepted D3427: [Python 3] relative imports fixes (dynamic imports).
Mar 13 2022, 8:47 PM
sicherha closed D3391: [Python 3] Implicit relative imports fixes.
Mar 13 2022, 8:46 PM
sicherha committed rPe6c4153ac7de: [Python 3] Implicit relative imports fixes (authored by sicherha).
[Python 3] Implicit relative imports fixes
Mar 13 2022, 8:46 PM
sicherha committed rP1aeaee3ca41a: [Python 3]basestring to six string_types (authored by sicherha).
[Python 3]basestring to six string_types
Mar 13 2022, 8:31 PM
sicherha closed D3403: [Python 3]basestring to six string_types.
Mar 13 2022, 8:31 PM
sicherha committed rP4284cf68711b: [Python3] changed module names (authored by sicherha).
[Python3] changed module names
Mar 13 2022, 8:30 PM
sicherha committed rD9e0c64d20c0f: Added guide to use Kolab with reverse proxy (authored by lennartack).
Added guide to use Kolab with reverse proxy
Mar 13 2022, 8:26 PM

Mar 12 2022

sicherha accepted D3403: [Python 3]basestring to six string_types.

Looks good to me, thanks!

Mar 12 2022, 11:11 AM

Mar 11 2022

sicherha added a comment to T6055: docs.kolab.org not getting updated by continuous-deployment pipeline.

Thanks a lot! See D1966 for my review comments.

Mar 11 2022, 10:38 PM · Documentation, Bug Reports

Mar 6 2022

sicherha accepted D3391: [Python 3] Implicit relative imports fixes.

Thanks!

Mar 6 2022, 2:15 PM
sicherha requested changes to D3391: [Python 3] Implicit relative imports fixes.
Mar 6 2022, 10:18 AM

Feb 13 2022

sicherha closed T6817: iRony-0.4.6-2.3 RPM transaction error blocks updates as Resolved.

Hopefully fixed through the addition of a %pretrans scriptlet as described in https://docs.fedoraproject.org/en-US/packaging-guidelines/Directory_Replacement/. Please reopen if the problem persists.

Feb 13 2022, 9:08 AM · Bug Reports

Feb 7 2022

sicherha added a reviewer for D3349: Add SingleSignOn capabilitiy to kolab-saslauthd.: mollekopf.

Thanks for the diff!

Feb 7 2022, 9:54 PM

Feb 6 2022

sicherha added a comment to T6853: SSO with kolab-sasl-authd.
  1. Install Arcanist on your system.
  2. Clone the PyKolab Git repository.
  3. Create a commit from your patch.
  4. Type arc diff to submit the commit for review.
Feb 6 2022, 10:13 AM

Feb 4 2022

sicherha added a revision to T6811: Recipient access denied when inserting into the cache fails: D3343: Catch exceptions in `cache_update()`.
Feb 4 2022, 9:07 PM · PyKolab Developers, PyKolab, Bug Reports
sicherha requested review of D3343: Catch exceptions in `cache_update()`.
Feb 4 2022, 9:07 PM
sicherha assigned T6811: Recipient access denied when inserting into the cache fails to mollekopf.

Do you happen to have a log containing a backtrace for the case where the sender column is too short? After skimming the code, I would assume SQLAlchemy throws an exception which then gets caught in bin/kolab_smtp_access_policy.py:1717. That's obviously too late.

Feb 4 2022, 7:42 AM · PyKolab Developers, PyKolab, Bug Reports

Feb 3 2022

sicherha assigned T6776: wallaced not starting after reboot to mollekopf.

Ooh, this is a subtle bug!

Feb 3 2022, 10:57 PM · Bug Reports
sicherha added a comment to T6610: style.css and files_api.js only http not https.

I guess we can close this?

Feb 3 2022, 10:13 PM · Bug Reports
sicherha assigned T6577: problem with creating user mailbox to mollekopf.

According to the log, the script tries to create a user named '@'. That's, well, weird. Unfortunately, I'm not sufficiently familiar with the pykolab codebase to make a qualified guess where this username may have originated from.

Feb 3 2022, 10:12 PM · Kolab 16, PyKolab, Bug Reports
sicherha closed T6841: Debian : saslauthd no such file or directory after update as Resolved.
Feb 3 2022, 9:35 PM · Bug Reports
sicherha added a comment to T6841: Debian : saslauthd no such file or directory after update.

I have just pushed a new, patched revision of the pykolab package. Please try it out and report back if it fixes the problem for you.

Feb 3 2022, 7:33 PM · Bug Reports
sicherha claimed T6841: Debian : saslauthd no such file or directory after update.

I'll take care of this.

Feb 3 2022, 7:06 PM · Bug Reports

Jan 19 2022

sicherha added a comment to D3217: Add missing parenthesis to filter expression.

Thanks for reviewing this differential! It needs to be landed by someone with Free/Busy Developers group membership.

Jan 19 2022, 7:10 PM

Jan 11 2022

sicherha committed rP16bbda7fa28a: [Python 3] Use new exception syntax, part 2 (authored by sicherha).
[Python 3] Use new exception syntax, part 2
Jan 11 2022, 9:09 PM
sicherha closed D3250: [Python 3] Use new exception syntax, part 2.
Jan 11 2022, 9:09 PM

Jan 10 2022

sicherha requested review of D3250: [Python 3] Use new exception syntax, part 2.
Jan 10 2022, 10:03 PM
sicherha committed rPcfdb3e4f7f15: [Python 3] Use .items() instead of .iteritems() (authored by sicherha).
[Python 3] Use .items() instead of .iteritems()
Jan 10 2022, 8:51 PM
sicherha closed D3244: [Python 3] Use .items() instead of .iteritems().
Jan 10 2022, 8:51 PM
sicherha committed rP9a5f92139d3f: [Python 3] Get rid of .has_key() (authored by sicherha).
[Python 3] Get rid of .has_key()
Jan 10 2022, 8:50 PM
sicherha closed D3241: [Python 3] Get rid of .has_key().
Jan 10 2022, 8:50 PM
sicherha committed rPc3b9d5557161: [Python 3] Remove unnecessary occurrences of .keys() (authored by sicherha).
[Python 3] Remove unnecessary occurrences of .keys()
Jan 10 2022, 8:48 PM
sicherha closed D3235: [Python 3] Remove unnecessary occurrences of .keys().
Jan 10 2022, 8:48 PM
sicherha closed D3232: [Python 3] Use new exception syntax.
Jan 10 2022, 8:46 PM
sicherha committed rP991255eaa314: [Python 3] Use new exception syntax (authored by sicherha).
[Python 3] Use new exception syntax
Jan 10 2022, 8:46 PM
sicherha committed rPd0579b7e5da3: [Python 3] Use print() as function instead of statement (authored by sicherha).
[Python 3] Use print() as function instead of statement
Jan 10 2022, 8:42 PM
sicherha closed D3229: [Python 3] Use print() as function instead of statement.
Jan 10 2022, 8:42 PM
sicherha committed rP7750671314e6: [Python 3] Use 0o prefix for octal numbers (authored by sicherha).
[Python 3] Use 0o prefix for octal numbers
Jan 10 2022, 8:41 PM
sicherha closed D3226: [Python 3] Use 0o prefix for octal numbers.
Jan 10 2022, 8:41 PM
sicherha committed rP25766ccf2710: [Python 3] Avoid use of 0 prefix for decimal literals (authored by sicherha).
[Python 3] Avoid use of 0 prefix for decimal literals
Jan 10 2022, 8:38 PM
sicherha closed D3223: [Python 3] Avoid use of 0 prefix for decimal literals.
Jan 10 2022, 8:38 PM
sicherha added a comment to T6805: Port pykolab to Python 3.

Apparently I need to be added to the PyKolab Developers group to be able to land changes.

Jan 10 2022, 6:18 PM · Architecture & Design
sicherha added a comment to T6805: Port pykolab to Python 3.

Thanks for the review! I tried to arc land the changes but seem to lack permission to do so:

Exception: You do not have permission to push to this repository.
fatal: Could not read from remote repository.
Jan 10 2022, 10:19 AM · Architecture & Design

Jan 8 2022

sicherha added a comment to T6805: Port pykolab to Python 3.

I have abandoned D3190 and submitted the individual commits in D3223, D3226, D3229, D3232, D3235, D3241 and D3244.

Jan 8 2022, 11:45 AM · Architecture & Design
sicherha abandoned D3190: Python 3 compatibility.

Superseded by D3223, D3226, D3229, D3232, D3235, D3241 and D3244.

Jan 8 2022, 11:42 AM
sicherha requested review of D3244: [Python 3] Use .items() instead of .iteritems().
Jan 8 2022, 11:39 AM
sicherha requested review of D3241: [Python 3] Get rid of .has_key().
Jan 8 2022, 11:39 AM
sicherha requested review of D3235: [Python 3] Remove unnecessary occurrences of .keys().
Jan 8 2022, 11:39 AM
sicherha requested review of D3232: [Python 3] Use new exception syntax.
Jan 8 2022, 11:38 AM
sicherha requested review of D3229: [Python 3] Use print() as function instead of statement.
Jan 8 2022, 11:37 AM
sicherha requested review of D3226: [Python 3] Use 0o prefix for octal numbers.
Jan 8 2022, 11:37 AM
sicherha requested review of D3223: [Python 3] Avoid use of 0 prefix for decimal literals.
Jan 8 2022, 11:36 AM
sicherha requested review of D3217: Add missing parenthesis to filter expression.
Jan 8 2022, 10:12 AM
sicherha added a revision to T6770: wrong filter in kolab-freebusy config.ini.sample: D3217: Add missing parenthesis to filter expression.
Jan 8 2022, 10:12 AM · Bug Reports

Jan 6 2022

sicherha closed T6142: freebusy.deb kaput as Resolved.

Fixed - better late than never.

Jan 6 2022, 11:57 AM · Free/Busy
sicherha added a comment to T6805: Port pykolab to Python 3.

Submitted D3190, which has ended up being sort of... bulky. There are several commits in this differential; does Phabricator offer no option to review these commits individually like Git{Hu,La}b do, without the author having to create a separate differential per commit?

Jan 6 2022, 11:43 AM · Architecture & Design
sicherha requested review of D3190: Python 3 compatibility.
Jan 6 2022, 11:37 AM
sicherha added a comment to T6805: Port pykolab to Python 3.

Note that all changes I have made so far should™ be backward-compatible with Python >= 2.6, so they wouldn't necessitate any changes to our existing packaging.

Jan 6 2022, 10:51 AM · Architecture & Design
sicherha raised the priority of T6805: Port pykolab to Python 3 from Wishlist to Normal.
Jan 6 2022, 10:47 AM · Architecture & Design
sicherha updated subscribers of T6805: Port pykolab to Python 3.
Jan 6 2022, 10:46 AM · Architecture & Design
sicherha created T6805: Port pykolab to Python 3.
Jan 6 2022, 10:46 AM · Architecture & Design

Oct 24 2021

sicherha added a reviewer for D2866: Update sabre/vobject to version 4.3.5 Increase php version to 5.5: machniak.
Oct 24 2021, 9:19 PM

Jun 4 2021

sicherha closed T6598: Spam post removed as Invalid.
Jun 4 2021, 1:36 PM

May 24 2021

sicherha added a comment to D2548: Fix memory bugs.

Hmm, does Arcanist offer a way to do fast-forward merges?

May 24 2021, 7:17 PM
sicherha updated the summary of D2548: Fix memory bugs.
May 24 2021, 3:10 PM
sicherha abandoned D2542: Fix memory bugs.

Superseded by D2548. Turns out the first commit is no longer needed (and I messed up the diff during rebase).

May 24 2021, 3:08 PM
sicherha requested review of D2548: Fix memory bugs.
May 24 2021, 3:06 PM
sicherha retitled D2542: Fix memory bugs from Fix use-after-free bug to Fix memory bugs.
May 24 2021, 2:58 PM
sicherha abandoned D2323: Fix use-after-free bug.

Superseded by D2542.

May 24 2021, 2:54 PM