Differential D3884

Space in cyrus imapfolder_path
ClosedPublic
Actions

Authored by ghane on Oct 4 2022, 1:32 PM.

Tags

None

Referenced Files

	F10573501: D3884.diff
	Tue, Nov 28, 6:40 AM

	Unknown Object (File)
	Tue, Nov 7, 4:01 PM

	Unknown Object (File)
	Mon, Nov 6, 7:08 AM

	Unknown Object (File)
	Thu, Nov 2, 1:58 PM

	Unknown Object (File)
	Oct 23 2023, 6:02 AM

	Unknown Object (File)
	Oct 14 2023, 11:50 AM

	Unknown Object (File)
	Oct 10 2023, 6:09 AM

	Unknown Object (File)
	Oct 6 2023, 1:34 PM

View All 16 Files

Subscribers

Details

Reviewers

sicherha
mollekopf

Group Reviewers

PyKolab Developers

Commits

rPc255b3f728cb: Space in cyrus imapfolder_path

Summary

ensure_str needed see cyruslib handling
else string is compared with bytes and the imapfolder won't be verified

Test Plan

tested with dm DELETED* on buster with python 2.7 and 3.x

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ghane requested review of this revision.Oct 4 2022, 1:32 PM

ghane created this revision.

ghane added a parent revision: D3863: [Python 3] def ensure_binary / some ___prepare binary return fix.

sicherha subscribed.Oct 16 2022, 9:32 AM

sicherha added inline comments.

pykolab/imap/cyrus.py
572	In the original code, double quotes are added around the string; your change removes these quotes. Is there a particular reason for this?

sicherha mentioned this in D3863: [Python 3] def ensure_binary / some ___prepare binary return fix.Oct 16 2022, 9:38 AM

ghane added inline comments.Oct 22 2022, 12:11 PM

pykolab/imap/cyrus.py
572	[LIST "" ""b'DELETED/shared/group/Calendar/Personal Calendar/63344406@example.org'""] BAD: bUnexpected extra arguments to List See doubled Quotes, which causes this Error

sicherha accepted this revision.Nov 6 2022, 2:23 PM

This revision is now accepted and ready to land.Nov 6 2022, 2:23 PM

quote is set now in cyruslib.py line 564

new

def decode ... return quote(ensure_str(text))

old

return text

as quotes are now generally set to the mailbox path, so we don't need the if clause

ghane marked an inline comment as done.Jan 2 2023, 12:36 PM

ghane mentioned this in T6805: Port pykolab to Python 3.Jan 30 2023, 1:22 PM

mollekopf accepted this revision.Mar 5 2023, 8:15 PM

Closed by commit rPc255b3f728cb: Space in cyrus imapfolder_path (authored by mollekopf). · Explain WhyMar 7 2023, 9:34 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

pykolab/

imap/

10 lines

Diff 11816

pykolab/imap/cyrus.py

Loading...