Page MenuHomekolab.org

Space in cyrus imapfolder_path
AcceptedPublic

Authored by ghane on Oct 4 2022, 1:32 PM.

Details

Reviewers
sicherha
Group Reviewers
PyKolab Developers
Summary

ensure_str needed see cyruslib handling
else string is compared with bytes and the imapfolder won't be verified

Test Plan

tested with dm DELETED* on buster with python 2.7 and 3.x

Diff Detail

Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

ghane requested review of this revision.Oct 4 2022, 1:32 PM
ghane created this revision.
sicherha added inline comments.
pykolab/imap/cyrus.py
572

In the original code, double quotes are added around the string; your change removes these quotes. Is there a particular reason for this?

ghane added inline comments.Oct 22 2022, 12:11 PM
pykolab/imap/cyrus.py
572
[LIST "" ""b'DELETED/shared/group/Calendar/Personal Calendar/63344406@example.org'""] BAD: bUnexpected extra arguments to List

See doubled Quotes, which causes this Error

sicherha accepted this revision.Sun, Nov 6, 2:23 PM
This revision is now accepted and ready to land.Sun, Nov 6, 2:23 PM