Page MenuHomePhorge

Space in cyrus imapfolder_path
ClosedPublic

Authored by ghane on Oct 4 2022, 1:32 PM.
Tags
None
Referenced Files
F12274845: D3884.id11384.diff
Mon, May 20, 4:46 PM
Unknown Object (File)
Sun, May 19, 3:47 AM
Unknown Object (File)
Sat, May 18, 8:12 AM
Unknown Object (File)
Wed, May 15, 6:55 AM
Unknown Object (File)
Sat, May 4, 3:33 AM
Unknown Object (File)
Sat, May 4, 3:06 AM
Unknown Object (File)
Wed, May 1, 4:48 PM
Unknown Object (File)
Sun, Apr 21, 5:01 PM
Subscribers

Details

Summary

ensure_str needed see cyruslib handling
else string is compared with bytes and the imapfolder won't be verified

Test Plan

tested with dm DELETED* on buster with python 2.7 and 3.x

Diff Detail

Repository
rP pykolab
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

sicherha added inline comments.
pykolab/imap/cyrus.py
572

In the original code, double quotes are added around the string; your change removes these quotes. Is there a particular reason for this?

pykolab/imap/cyrus.py
572
[LIST "" ""b'DELETED/shared/group/Calendar/Personal Calendar/63344406@example.org'""] BAD: bUnexpected extra arguments to List

See doubled Quotes, which causes this Error

This revision is now accepted and ready to land.Nov 6 2022, 2:23 PM

quote is set now in cyruslib.py line 564

new

def decode ... return quote(ensure_str(text))

old

return text

as quotes are now generally set to the mailbox path, so we don't need the if clause

This revision was automatically updated to reflect the committed changes.