Page MenuHomekolab.org

Fix signature of `Logger.debug()`
Needs ReviewPublic

Authored by sicherha on Sun, Nov 6, 6:21 PM.

Details

Reviewers
mollekopf
Summary

The default argument level=1 must not come before any positional
arguments; it must be accepted as a keyword argument.
As signified by the pylint comments, the signature previously did not
conform to the specification given in
https://docs.python.org/3/library/logging.html#logging.Logger.debug.

This commit fixes a longstanding problem with crashes occurring in
certain scenarios when the debug level is set to 9. One such crash could
be observed from within SQLAlchemy, which calls debug() in the
following way:
pool.logger.debug("Created new connection %r", connection)
That call caused pykolab's Logger.debug() method to interpret its
second argument as a numeric level, which resulted in a TypeError
because it was actually an sqlite3.Connection.

By accepting level as a keyword argument, all arguments are now
interpreted in the correct order.

Diff Detail

Repository
rP pykolab
Branch
fix_debug_signature
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 40502
Build 16418: arc lint + arc unit

Event Timeline

sicherha requested review of this revision.Sun, Nov 6, 6:21 PM
sicherha created this revision.