Page MenuHomePhorge

Fix signature of `Logger.debug()`

Authored by sicherha on Nov 6 2022, 6:21 PM.
Referenced Files
Unknown Object (File)
Mon, Jul 1, 3:33 PM
Unknown Object (File)
Sat, Jun 22, 11:07 PM
Unknown Object (File)
Tue, Jun 18, 12:47 PM
Unknown Object (File)
Jun 8 2024, 10:12 PM
Unknown Object (File)
Jun 8 2024, 5:05 PM
Unknown Object (File)
Jun 8 2024, 6:42 AM
Unknown Object (File)
Jun 5 2024, 11:43 PM
Unknown Object (File)
Jun 5 2024, 2:16 AM



The default argument level=1 must not come before any positional
arguments; it must be accepted as a keyword argument.
As signified by the pylint comments, the signature previously did not
conform to the specification given in

This commit fixes a longstanding problem with crashes occurring in
certain scenarios when the debug level is set to 9. One such crash could
be observed from within SQLAlchemy, which calls debug() in the
following way:
pool.logger.debug("Created new connection %r", connection)
That call caused pykolab's Logger.debug() method to interpret its
second argument as a numeric level, which resulted in a TypeError
because it was actually an sqlite3.Connection.

By accepting level as a keyword argument, all arguments are now
interpreted in the correct order.

Diff Detail

rP pykolab
Lint Passed
No Test Coverage
Build Status
Buildable 40502
Build 16418: arc lint + arc unit