Page MenuHomekolab.org

Remove type declaration from property
ClosedPublic

Authored by sicherha on Dec 28 2022, 6:24 PM.

Details

Summary

This syntax is not compatible with PHP < 7.4.0. Fixes T7097.

Diff Detail

Repository
rI iRony
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

sicherha requested review of this revision.Dec 28 2022, 6:24 PM
sicherha created this revision.
sicherha planned changes to this revision.Dec 28 2022, 6:33 PM

Needs revision; doesn't fix the issue yet.

sicherha updated this revision to Diff 11351.Dec 28 2022, 8:57 PM

Typed properties were introduced in PHP 7.4.0. Make sure that Kolab also works
with older PHP instalations.

sicherha retitled this revision from Add missing namespace prefix `Sabre` to Remove type declaration for property.Dec 28 2022, 8:57 PM
sicherha edited the summary of this revision. (Show Details)
sicherha retitled this revision from Remove type declaration for property to Remove type declaration from property.
mollekopf accepted this revision.Dec 30 2022, 2:31 PM
This revision is now accepted and ready to land.Dec 30 2022, 2:31 PM
Closed by commit rId90e149fc0e1: Remove type declaration from property (authored by Christoph Erhardt <christoph.erhardt@sicherha.de>, committed by Christian Mollekopf <mollekopf@apheleia-it.ch>). · Explain WhyDec 30 2022, 2:32 PM
This revision was automatically updated to reflect the committed changes.