Page MenuHomePhorge
Differential D3968

Remove type declaration from property
ClosedPublic
Actions

Authored by sicherha on Dec 28 2022, 6:24 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Apr 18, 2:55 AM
Unknown Object (File)
Wed, Apr 17, 9:57 AM
Unknown Object (File)
Wed, Apr 10, 2:20 PM
Unknown Object (File)
Sun, Apr 7, 10:14 AM
Unknown Object (File)
Wed, Apr 3, 9:32 PM
Unknown Object (File)
Wed, Apr 3, 1:13 PM
Unknown Object (File)
Wed, Apr 3, 1:13 PM
Unknown Object (File)
Wed, Apr 3, 1:13 PM
View All 65 Files
Subscribers
None

Details

Reviewers
mollekopf
Maniphest Tasks
T7097: iRony fails to run after update
Commits
rId90e149fc0e1: Remove type declaration from property
Summary

This syntax is not compatible with PHP < 7.4.0. Fixes T7097.

Diff Detail

Repository
rI iRony
Branch
master
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 40967
Build 16490: arc lint + arc unit

Event Timeline

sicherha requested review of this revision.Dec 28 2022, 6:24 PM
sicherha created this revision.
Harbormaster completed remote builds in B40961: Diff 11345.Dec 28 2022, 6:24 PM
sicherha planned changes to this revision.Dec 28 2022, 6:33 PM

Needs revision; doesn't fix the issue yet.

sicherha updated this revision to Diff 11351.Dec 28 2022, 8:57 PM

Typed properties were introduced in PHP 7.4.0. Make sure that Kolab also works
with older PHP instalations.

Harbormaster completed remote builds in B40967: Diff 11351.Dec 28 2022, 8:57 PM
sicherha retitled this revision from Add missing namespace prefix `Sabre` to Remove type declaration for property.Dec 28 2022, 8:57 PM
sicherha edited the summary of this revision. (Show Details)
sicherha mentioned this in T7097: iRony fails to run after update.Dec 28 2022, 9:02 PM
sicherha retitled this revision from Remove type declaration for property to Remove type declaration from property.
mollekopf accepted this revision.Dec 30 2022, 2:31 PM
This revision is now accepted and ready to land.Dec 30 2022, 2:31 PM
Closed by commit rId90e149fc0e1: Remove type declaration from property (authored by Christoph Erhardt <christoph.erhardt@sicherha.de>, committed by mollekopf). · Explain WhyDec 30 2022, 2:32 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
lib/
Kolab/
CardDAV/
2 lines

Diff 11351

View Options

lib/Kolab/CardDAV/LDAPDirectory.php

Loading...