Page MenuHomekolab.org

refurbish code PEP8 & Co./wap_client
ClosedPublic

Authored by ghane on Aug 15 2022, 7:59 PM.

Details

Summary

PEP8:
E302 expected 2 blank lines
E201 + E202 + E231 Whitespaces

Comparison with None performed with equality operators
+ E714 is not
+ E711

redundant Paranthesis

Diff Detail

Repository
rP pykolab
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

ghane requested review of this revision.Aug 15 2022, 7:59 PM
ghane created this revision.
ghane updated this revision to Diff 10775.Aug 15 2022, 8:34 PM

changed line 285 by a mistake, just split with \ as line to long

Hmm, where can I see in Phabricator for which target branch this diff is intended? It should go into dev/python3, but I can't tell from the web interface.

sicherha accepted this revision.Aug 19 2022, 6:24 PM

On second thought, these changes are in no way specific to Python 3, so let's get them into master right away.

This revision is now accepted and ready to land.Aug 19 2022, 6:24 PM
sicherha updated this revision to Diff 10799.Aug 19 2022, 6:41 PM

Rebase to master

This revision was automatically updated to reflect the committed changes.