Page MenuHomePhorge

refurbish code PEP8 & Co./wap_client
ClosedPublic

Authored by ghane on Aug 15 2022, 7:59 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Oct 28, 9:03 AM
Unknown Object (File)
Sun, Oct 27, 1:59 PM
Unknown Object (File)
Sun, Oct 27, 1:58 PM
Unknown Object (File)
Sun, Oct 27, 1:58 PM
Unknown Object (File)
Sun, Oct 27, 1:58 PM
Unknown Object (File)
Sun, Oct 27, 1:58 PM
Unknown Object (File)
Fri, Oct 25, 10:09 AM
Unknown Object (File)
Thu, Oct 24, 8:10 AM
Subscribers

Details

Summary

PEP8:
E302 expected 2 blank lines
E201 + E202 + E231 Whitespaces

Comparison with None performed with equality operators
+ E714 is not
+ E711

redundant Paranthesis

Diff Detail

Repository
rP pykolab
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ghane requested review of this revision.Aug 15 2022, 7:59 PM
ghane created this revision.

changed line 285 by a mistake, just split with \ as line to long

Hmm, where can I see in Phabricator for which target branch this diff is intended? It should go into dev/python3, but I can't tell from the web interface.

On second thought, these changes are in no way specific to Python 3, so let's get them into master right away.

This revision is now accepted and ready to land.Aug 19 2022, 6:24 PM
This revision was automatically updated to reflect the committed changes.