Page MenuHomePhorge

refurbish code PEP8 & Co./wap_client
ClosedPublic

Authored by ghane on Aug 15 2022, 7:59 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Mar 25, 1:32 AM
Unknown Object (File)
Mon, Mar 18, 1:08 AM
Unknown Object (File)
Feb 19 2024, 11:40 AM
Unknown Object (File)
Jan 31 2024, 1:55 PM
Unknown Object (File)
Jan 29 2024, 5:14 PM
Unknown Object (File)
Jan 28 2024, 2:21 AM
Unknown Object (File)
Jan 27 2024, 10:13 PM
Unknown Object (File)
Jan 19 2024, 4:03 PM
Subscribers

Details

Summary

PEP8:
E302 expected 2 blank lines
E201 + E202 + E231 Whitespaces

Comparison with None performed with equality operators
+ E714 is not
+ E711

redundant Paranthesis

Diff Detail

Repository
rP pykolab
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

ghane requested review of this revision.Aug 15 2022, 7:59 PM
ghane created this revision.

changed line 285 by a mistake, just split with \ as line to long

Hmm, where can I see in Phabricator for which target branch this diff is intended? It should go into dev/python3, but I can't tell from the web interface.

On second thought, these changes are in no way specific to Python 3, so let's get them into master right away.

This revision is now accepted and ready to land.Aug 19 2022, 6:24 PM
This revision was automatically updated to reflect the committed changes.