Paths

Table of Contentst

refurbish code PEP8 & Co./wap_client
ClosedPublic
Actions

Authored by ghane on Aug 15 2022, 7:59 PM.

Tags

None

Referenced Files

	F11805786: D3779.diff
	Fri, Apr 19, 9:23 AM

	Unknown Object (File)
	Wed, Apr 17, 9:37 AM

	Unknown Object (File)
	Sun, Apr 7, 5:18 PM

	Unknown Object (File)
	Sun, Apr 7, 10:04 AM

	Unknown Object (File)
	Sun, Apr 7, 1:30 AM

	Unknown Object (File)
	Thu, Apr 4, 6:07 PM

	Unknown Object (File)
	Wed, Apr 3, 1:10 PM

	Unknown Object (File)
	Wed, Apr 3, 1:10 PM

View All 48 Files

Subscribers

sicherha

Details

Reviewers

sicherha

Group Reviewers

PyKolab Developers

Commits

rP2ffc894af044: refurbish code PEP8 & Co./wap_client

Summary

PEP8:
E302 expected 2 blank lines
E201 + E202 + E231 Whitespaces

Comparison with None performed with equality operators
+ E714 is not
+ E711

redundant Paranthesis

Diff Detail

Repository

rP pykolab

Branch

arcpatch-D3779_1

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 39809
Build 16184: arc lint + arc unit

Event Timeline

ghane requested review of this revision.Aug 15 2022, 7:59 PM

ghane created this revision.

changed line 285 by a mistake, just split with \ as line to long

Hmm, where can I see in Phabricator for which target branch this diff is intended? It should go into dev/python3, but I can't tell from the web interface.

On second thought, these changes are in no way specific to Python 3, so let's get them into master right away.

This revision is now accepted and ready to land.Aug 19 2022, 6:24 PM

Rebase to master

Harbormaster completed remote builds in B39809: Diff 10799.Aug 19 2022, 6:41 PM

Closed by commit rP2ffc894af044: refurbish code PEP8 & Co./wap_client (authored by sicherha). · Explain WhyAug 19 2022, 6:43 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

pykolab/

wap_client/

__init__.py

190 lines

Diff 10799

View Options

pykolab/wap_client/init.py

refurbish code PEP8 & Co./wap_clientClosedPublicActions